morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #4911] Feat/snes rom 65816 #6671

New issue

Open

opened 2026-11-01 21:42:12 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:42:12 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4911
Author: @entzyeung
Created: 10/17/2026
Status: 🔄 Open

Base: main ← Head: feat/snes-rom-65816

📝 Commits (10+)

44d9a48 feat: admit 65816 architecture for raw SNES ROM analysis
0ae5d07 docs: add 65816 / SNES ROM analysis notes
fdf7782 fix: admit 65816 in raw-binary schema and address width
44f8a5c docs: fix 65816 CLI and MCP examples
f54c714 fix: map 65816 to Ghidra language ID for raw binary
c061417 docs: warn about 512-byte SMC header and raw load limitations
620a87d merge: incorporate upstream m68k/hexagon and keep 65816
01cc1a1 merge: include m68k and 65816 in raw-binary admission
0a8670f fix: add m68k case to ghidraRawBinaryLanguage to restore type exhaustiveness
03d2a7a Merge branch 'main' into feat/snes-rom-65816

📊 Changes

8 files changed (+121 additions, -16 deletions)

View changed files

📝 .agents/skills/reverse-engineer-anything/references/native-and-artifacts.md (+2 -2)
➕ docs/ghidra-65816.md (+76 -0)
📝 docs/raw-binary.md (+14 -2)
📝 src/domain/binaryTargetTypes.ts (+5 -0)
📝 src/domain/rawBinary.ts (+10 -6)
📝 src/ghidra/GhidraProvider.ts (+2 -1)
📝 src/ghidra/GhidraProviderClient.ts (+1 -1)
📝 src/ghidra/GhidraRawBinaryLanguage.ts (+11 -4)

📄 Description

Closes #4794

Summary

Adds minimal support for analysing single-file Super Nintendo (SNES) ROM dumps (.sfc / .smc) through REA’s existing raw-binary + Ghidra path.

Admits "65816" in BINARY_ARCHITECTURES and treats it as raw-only (same pattern as 6502).
Documents the requirement for a community 65C816 Ghidra extension and caller-supplied load address.
No automatic LoROM/HiROM detection, no multi-file support, no emulation.

Changes

src/domain/binaryTargetTypes.ts — add 65816 architecture and RAW_ONLY_ARCHITECTURES entry.
docs/ghidra-65816.md — usage notes, limitations, and related links.

Verification

Type-level admission only; actual decompilation requires a Ghidra 65816 extension installed by the user.
Tested conceptually against the existing raw-binary open path used by other raw-only architectures.

Non-goals (as discussed in the issue)

Multi-file / interleaved ROM sets
Automatic mapping detection
Emulation
Shipping any commercial ROM or decompiled code

Happy to adjust based on review.

Author readiness

Human owner: @entzyeung

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4911 **Author:** [@entzyeung](https://github.com/entzyeung) **Created:** 10/17/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `feat/snes-rom-65816` --- ### 📝 Commits (10+) - [`44d9a48`](https://github.com/morluto/rea/commit/44d9a48ab5a18b44844a3435ab9aae0bac0b69db) feat: admit 65816 architecture for raw SNES ROM analysis - [`0ae5d07`](https://github.com/morluto/rea/commit/0ae5d0706c4dbb4da6d6f75d160c51ae7866ea70) docs: add 65816 / SNES ROM analysis notes - [`fdf7782`](https://github.com/morluto/rea/commit/fdf778276f9941945d91bf470e657fd50b3cbf47) fix: admit 65816 in raw-binary schema and address width - [`44f8a5c`](https://github.com/morluto/rea/commit/44f8a5cba15cffaa9394e3b8a558ef5fea81d27f) docs: fix 65816 CLI and MCP examples - [`f54c714`](https://github.com/morluto/rea/commit/f54c71491b8f88f3af5510db4d147a6159880f46) fix: map 65816 to Ghidra language ID for raw binary - [`c061417`](https://github.com/morluto/rea/commit/c06141776b6308aec4b6f3e9e21485399f34b0a9) docs: warn about 512-byte SMC header and raw load limitations - [`620a87d`](https://github.com/morluto/rea/commit/620a87d9a887f97f4812d35b8deb40ff3c2f0722) merge: incorporate upstream m68k/hexagon and keep 65816 - [`01cc1a1`](https://github.com/morluto/rea/commit/01cc1a1c1a0ad6b82dc3690bc02d019f003e9492) merge: include m68k and 65816 in raw-binary admission - [`0a8670f`](https://github.com/morluto/rea/commit/0a8670f0d11d4cc0d598c0b1c07f3dbabad7b92a) fix: add m68k case to ghidraRawBinaryLanguage to restore type exhaustiveness - [`03d2a7a`](https://github.com/morluto/rea/commit/03d2a7acd927ff5a783e48141872d0e3655a6922) Merge branch 'main' into feat/snes-rom-65816 ### 📊 Changes **8 files changed** (+121 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `.agents/skills/reverse-engineer-anything/references/native-and-artifacts.md` (+2 -2) ➕ `docs/ghidra-65816.md` (+76 -0) 📝 `docs/raw-binary.md` (+14 -2) 📝 `src/domain/binaryTargetTypes.ts` (+5 -0) 📝 `src/domain/rawBinary.ts` (+10 -6) 📝 `src/ghidra/GhidraProvider.ts` (+2 -1) 📝 `src/ghidra/GhidraProviderClient.ts` (+1 -1) 📝 `src/ghidra/GhidraRawBinaryLanguage.ts` (+11 -4) </details> ### 📄 Description Closes #4794 ## Summary Adds minimal support for analysing single-file Super Nintendo (SNES) ROM dumps (`.sfc` / `.smc`) through REA’s existing raw-binary + Ghidra path. - Admits `"65816"` in `BINARY_ARCHITECTURES` and treats it as raw-only (same pattern as `6502`). - Documents the requirement for a community 65C816 Ghidra extension and caller-supplied load address. - No automatic LoROM/HiROM detection, no multi-file support, no emulation. ## Changes - `src/domain/binaryTargetTypes.ts` — add `65816` architecture and `RAW_ONLY_ARCHITECTURES` entry. - `docs/ghidra-65816.md` — usage notes, limitations, and related links. ## Verification - Type-level admission only; actual decompilation requires a Ghidra 65816 extension installed by the user. - Tested conceptually against the existing raw-binary open path used by other raw-only architectures. ## Non-goals (as discussed in the issue) - Multi-file / interleaved ROM sets - Automatic mapping detection - Emulation - Shipping any commercial ROM or decompiled code Happy to adjust based on review. ## Author readiness Human owner: @entzyeung - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-11-01 21:42:12 +00:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#6671

No description provided.

Rows
Columns