[PR #1921] [MERGED] fix(javascript): preserve graphs within parent capacity #4911

New issue

Closed

opened 2026-10-31 00:56:42 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented 2026-10-31 00:56:42 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1921
Author: @N0zoM1z0
Created: 10/11/2026
Status: ✅ Merged
Merged: 10/11/2026
Merged by: @morluto

Base: main ← Head: fix/1911-javascript-checkpoint-reserve

---

📝 Commits (1)

• e11aa90 fix(javascript): preserve graphs within parent capacity

📊 Changes

2 files changed (+163 additions, -12 deletions)

View changed files

📝 src/javascript/analysis/JavaScriptAnalysisWorker.ts (+31 -12)
➕ tests/acceptance/applications/javascriptCheckpointReserveCli.test.ts (+132 -0)

📄 Description

Summary

Two JavaScript source files could lose the earlier file's completed semantic graph because the parent reserved 80% of its original result budget while another source remained. Reserve the next sequential static checkpoint using the existing protocol bound and retention accounting, so useful graphs survive within the available capacity. Fixes #1911.

Problem and expected behavior

An inert 400-function ES module followed by a small module returned no semantic functions for the earlier source. A directory with ten later small sources has the same problem. Admission should protect the next checkpoint and enforce actual retained/live-heap capacity rather than an arbitrary fraction of the original budget.

Change and scope

The worker owner reserves one maximum 8-MiB checkpoint at its existing retained expansion of six, matching the sequential producer. Previously retained facts stay charged to the existing ledger. Remove the superseded static-reserve ledger. Genuine parent-side rejections now report effective available capacity and module/graph retention estimates, and point callers to the facts that survived.

Contract and boundary impact

• Semantic owner and earliest changed stage: JavaScriptAnalysisWorker, at parent checkpoint and transfer admission.
• CLI and MCP/tool-catalog contract: unchanged requests and schemas; additive diagnostic limit fields and producer-specific recovery guidance.
• Provider, bridge, target-format, or platform compatibility: existing JavaScript worker protocol and execution limits retained.
• Evidence, artifact, provenance, or reconstruction contract: preserve exact artifact identities, existing static/module facts, explicit partial coverage and semantic unknowns.
• Process execution, authorization, cleanup, or containment impact: existing owned-process, heap, decode, transfer, cancellation and cleanup protections retained.
• Generated metadata, package, or installation impact: none.

Evidence and regression coverage

• Add public CLI cases for one and ten later sources, plus a 600-function source under a 448-MiB parent heap that must reject the graph while preserving static/module facts and accurate recovery guidance. The negative case exceeds even the otherwise-empty parent's available budget, so acceptance cannot depend on GC timing.

• Base replay fails the earlier-source semantic preservation assertion.

• Representative failure now includes parent_available_result_budget_bytes, module_retention_estimate_bytes and graph_retention_estimate_bytes; remediation explains that increasing the worker heap alone does not increase parent capacity.

• Real Linux CLI and fresh stdio MCP checks on two generated modules of 439,680 and 438,705 bytes complete without worker-heap failure or parent-budget rejection. CLI retains 20,000 semantic nodes from each source. Semantic coverage remains explicitly partial.

• Remaining proof gaps: the manual resource-limited workflow was run on Linux/Node, not Bun or other operating systems. The heap-specific CLI cases explicitly skip Bun, whose runtime does not enforce the V8 flags.

• Observed, derived, and inferred claims remain distinguishable.

• Artifact identity, source provenance, and failed attempts remain preserved.

• Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

• Public CLI capacity, worker lifecycle, stdio MCP resource/cancellation and tool-effects wording tests: 21 passed across six files on the refreshed main base.
• Actual generated-module CLI analysis on the final rebased source: completed in 35.35 seconds, process-tree peak 1,002,668,032 bytes, zero OOM events, unchanged input digests.
• Fresh stdio MCP summary, retained module views, Evidence bundle and subsequent ping on the final rebased source: passed in 32.02 seconds with unchanged input digests.
• npm run check — typecheck, lint, formatting, unused-code, metadata and architecture guards passed.
• npm run verify:test-discovery — all 862 test files discovered exactly once; final CLI cases also passed after test typing corrections and deterministic capacity sizing.
• Initial CI identified the main-base static-tool wording failure, independently fixed upstream by #1917. This branch includes that main fix; no tool-effects change is included in this PR.

Compatibility, safety, and release

• Breaking changes or migration steps: none.
• Real Hopper/Ghidra, browser, or OS coverage: Linux Node.js 24.18.0 JavaScript CLI/MCP; native/browser providers are outside this change.
• Package or release metadata impact: none.
• Security, privacy, process, or containment review: inert source analysis; no target execution, new authority, installation, or increased worker heap limits.

Review checklist

• This PR addresses a concrete problem or an agreed enhancement.
• The PR has one focused outcome and the title follows type(scope): outcome.
• Related issue is linked.
• Tests cover changed observable behavior and meaningful failure paths.
• Owning docs, contracts, and generated metadata are updated where needed; no request/schema change requires regenerated documentation.
• User-visible CLI/MCP changes include representative output.
• I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1921 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/11/2026 **Status:** ✅ Merged **Merged:** 10/11/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/1911-javascript-checkpoint-reserve` --- ### 📝 Commits (1) - [`e11aa90`](https://github.com/morluto/rea/commit/e11aa90ff1064db52a0ef6fbca92f9a21edcea02) fix(javascript): preserve graphs within parent capacity ### 📊 Changes **2 files changed** (+163 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/javascript/analysis/JavaScriptAnalysisWorker.ts` (+31 -12) ➕ `tests/acceptance/applications/javascriptCheckpointReserveCli.test.ts` (+132 -0) </details> ### 📄 Description ## Summary Two JavaScript source files could lose the earlier file's completed semantic graph because the parent reserved 80% of its original result budget while another source remained. Reserve the next sequential static checkpoint using the existing protocol bound and retention accounting, so useful graphs survive within the available capacity. Fixes #1911. ## Problem and expected behavior An inert 400-function ES module followed by a small module returned no semantic functions for the earlier source. A directory with ten later small sources has the same problem. Admission should protect the next checkpoint and enforce actual retained/live-heap capacity rather than an arbitrary fraction of the original budget. ## Change and scope The worker owner reserves one maximum 8-MiB checkpoint at its existing retained expansion of six, matching the sequential producer. Previously retained facts stay charged to the existing ledger. Remove the superseded static-reserve ledger. Genuine parent-side rejections now report effective available capacity and module/graph retention estimates, and point callers to the facts that survived. ## Contract and boundary impact - Semantic owner and earliest changed stage: `JavaScriptAnalysisWorker`, at parent checkpoint and transfer admission. - CLI and MCP/tool-catalog contract: unchanged requests and schemas; additive diagnostic limit fields and producer-specific recovery guidance. - Provider, bridge, target-format, or platform compatibility: existing JavaScript worker protocol and execution limits retained. - Evidence, artifact, provenance, or reconstruction contract: preserve exact artifact identities, existing static/module facts, explicit partial coverage and semantic unknowns. - Process execution, authorization, cleanup, or containment impact: existing owned-process, heap, decode, transfer, cancellation and cleanup protections retained. - Generated metadata, package, or installation impact: none. ## Evidence and regression coverage - Add public CLI cases for one and ten later sources, plus a 600-function source under a 448-MiB parent heap that must reject the graph while preserving static/module facts and accurate recovery guidance. The negative case exceeds even the otherwise-empty parent's available budget, so acceptance cannot depend on GC timing. - Base replay fails the earlier-source semantic preservation assertion. - Representative failure now includes `parent_available_result_budget_bytes`, `module_retention_estimate_bytes` and `graph_retention_estimate_bytes`; remediation explains that increasing the worker heap alone does not increase parent capacity. - Real Linux CLI and fresh stdio MCP checks on two generated modules of 439,680 and 438,705 bytes complete without worker-heap failure or parent-budget rejection. CLI retains 20,000 semantic nodes from each source. Semantic coverage remains explicitly partial. - Remaining proof gaps: the manual resource-limited workflow was run on Linux/Node, not Bun or other operating systems. The heap-specific CLI cases explicitly skip Bun, whose runtime does not enforce the V8 flags. - [x] Observed, derived, and inferred claims remain distinguishable. - [x] Artifact identity, source provenance, and failed attempts remain preserved. - [x] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed - Public CLI capacity, worker lifecycle, stdio MCP resource/cancellation and tool-effects wording tests: 21 passed across six files on the refreshed main base. - Actual generated-module CLI analysis on the final rebased source: completed in 35.35 seconds, process-tree peak 1,002,668,032 bytes, zero OOM events, unchanged input digests. - Fresh stdio MCP summary, retained module views, Evidence bundle and subsequent ping on the final rebased source: passed in 32.02 seconds with unchanged input digests. - `npm run check` — typecheck, lint, formatting, unused-code, metadata and architecture guards passed. - `npm run verify:test-discovery` — all 862 test files discovered exactly once; final CLI cases also passed after test typing corrections and deterministic capacity sizing. - Initial CI identified the main-base static-tool wording failure, independently fixed upstream by #1917. This branch includes that main fix; no tool-effects change is included in this PR. ## Compatibility, safety, and release - Breaking changes or migration steps: none. - Real Hopper/Ghidra, browser, or OS coverage: Linux Node.js 24.18.0 JavaScript CLI/MCP; native/browser providers are outside this change. - Package or release metadata impact: none. - Security, privacy, process, or containment review: inert source analysis; no target execution, new authority, installation, or increased worker heap limits. ## Review checklist - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed; no request/schema change requires regenerated documentation. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

bsakaguchi 2026-10-31 00:56:42 +00:00

• closed this issue
• added the
  pull-request
  label

bsakaguchi referenced this issue 2026-11-01 21:10:57 +00:00

[GH-ISSUE #3796] [Tracker] Open feature requests by area (October 2026) #1471

bsakaguchi referenced this issue 2026-11-01 21:11:07 +00:00

[GH-ISSUE #5654] [Tracker] Open PRs that can't merge yet: conflicts and red CI (October 2026) #3425

bsakaguchi referenced this issue 2026-11-01 21:42:12 +00:00

[PR #4911] Feat/snes rom 65816 #6671

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

codex/procedure-reference-stacked

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels   

area: bridge

  

area: bridge

  

area: build

  

area: build

  

area: build

  

area: cli

  

area: domain

  

area: evidence

  

area: mcp

  

area: native

  

area: providers

  

area: runtime

  

area: server

  

area: setup

  

area: tests

  

bug

  

design

  

documentation

  

enhancement

  

enhancement

  

enhancement

  

experiment

  

help wanted

  

i18n

  

invalid

  

P0: critical

  

P1: high

  

P2: medium

  

P2: medium

  

P2: medium

  

P3: low

  

performance

  

provider-request

  

pull-request

Mirrored from GitHub Pull Request

  

question

  

roadmap

  

triage

No labels

area: bridge

area: bridge

area: build

area: build

area: build

area: cli

area: domain

area: evidence

area: mcp

area: native

area: providers

area: runtime

area: server

area: setup

area: tests

bug

design

documentation

enhancement

enhancement

enhancement

experiment

help wanted

i18n

invalid

P0: critical

P1: high

P2: medium

P2: medium

P2: medium

P3: low

performance

provider-request

pull-request

question

roadmap

triage

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#4911

No description provided.