morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 07:47:29 +00:00

[PR #4947] [MERGED] test(setup): use native Windows launcher in layered OpenCode fixture #6685

New issue

Closed

opened 2026-11-01 21:42:18 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:42:18 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4947
Author: @ShuaixinHuang
Created: 10/18/2026
Status: ✅ Merged
Merged: 10/20/2026
Merged by: @morluto

Base: main ← Head: codex/fix-opencode-windows-cli-fixture

📝 Commits (1)

07d1af5 test(setup): use native Windows launcher in layered OpenCode fixture

📊 Changes

1 file changed (+7 additions, -1 deletions)

View changed files

📝 tests/acceptance/setup/registrationRuntimeEnvironmentCli.test.ts (+7 -1)

📄 Description

Problem and outcome

The OpenCode layered JSON/JSONC public CLI test creates a script-only registration on every OS. On Windows, setup correctly expects node.exe plus that script and repairs the command, failing the no-actions assertion before the test reaches its missing-language validation and no-backup checks.

Construct the fixture's launcher using the native Windows command shape. POSIX fixtures keep their script-only command. Production code and every existing assertion remain unchanged.

Scope and boundaries

Test-only correction within existing setup coverage; no linked issue because directly reproduced on main 1f23e977b5. A maintainer capability-scope decision is not applicable. The expected launcher is constructed independently of the production setup helper, so command drift remains detectable. Nearby setup fixtures already use this platform distinction.

No CLI/MCP contract, provider, Evidence, generated metadata, package, or release change. Tests run the compiled REA CLI in isolated configuration homes; no actual OpenCode or analysis provider is launched.

Executed evidence

Windows x64, pinned Node 24.18.0/npm 11.16.0:

Unmodified main, selected OpenCode case: 1 failed / 14 name-filtered cases skipped. Failure is the unexpected configure_client:opencode action caused by the script-only fixture.
npm run test:focused -- tests/acceptance/setup/registrationRuntimeEnvironmentCli.test.ts tests/boundary/filesystem/clientConfigurationLayeredEnvironment.test.ts: 23/23 passed, no skips. This includes the original no-actions, aligned doctor, byte-preservation, missing-dependent-setting refusal, invalid doctor, and no-backup assertions.
npm run check: all six tasks passed; 2,085 resolved module boundaries and 1,506 architecture guards.
git diff --check: passed.

No Linux/macOS runtime execution or native OpenCode session is claimed. Current-head hosted CI required passed.

Author readiness

Human owner: @ShuaixinHuang

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4947 **Author:** [@ShuaixinHuang](https://github.com/ShuaixinHuang) **Created:** 10/18/2026 **Status:** ✅ Merged **Merged:** 10/20/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `codex/fix-opencode-windows-cli-fixture` --- ### 📝 Commits (1) - [`07d1af5`](https://github.com/morluto/rea/commit/07d1af559e49398efab4faac26194d6898428235) test(setup): use native Windows launcher in layered OpenCode fixture ### 📊 Changes **1 file changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `tests/acceptance/setup/registrationRuntimeEnvironmentCli.test.ts` (+7 -1) </details> ### 📄 Description ## Problem and outcome The OpenCode layered JSON/JSONC public CLI test creates a script-only registration on every OS. On Windows, setup correctly expects node.exe plus that script and repairs the command, failing the no-actions assertion before the test reaches its missing-language validation and no-backup checks. Construct the fixture's launcher using the native Windows command shape. POSIX fixtures keep their script-only command. Production code and every existing assertion remain unchanged. ## Scope and boundaries Test-only correction within existing setup coverage; no linked issue because directly reproduced on main 1f23e977b50301e91f02a4a17c9f8d48bb7b60f3. A maintainer capability-scope decision is not applicable. The expected launcher is constructed independently of the production setup helper, so command drift remains detectable. Nearby setup fixtures already use this platform distinction. No CLI/MCP contract, provider, Evidence, generated metadata, package, or release change. Tests run the compiled REA CLI in isolated configuration homes; no actual OpenCode or analysis provider is launched. ## Executed evidence Windows x64, pinned Node 24.18.0/npm 11.16.0: - Unmodified main, selected OpenCode case: 1 failed / 14 name-filtered cases skipped. Failure is the unexpected configure_client:opencode action caused by the script-only fixture. - npm run test:focused -- tests/acceptance/setup/registrationRuntimeEnvironmentCli.test.ts tests/boundary/filesystem/clientConfigurationLayeredEnvironment.test.ts: 23/23 passed, no skips. This includes the original no-actions, aligned doctor, byte-preservation, missing-dependent-setting refusal, invalid doctor, and no-backup assertions. - npm run check: all six tasks passed; 2,085 resolved module boundaries and 1,506 architecture guards. - git diff --check: passed. No Linux/macOS runtime execution or native OpenCode session is claimed. Current-head hosted [CI required](https://github.com/morluto/rea/actions/runs/39092134233/job/117573151265) passed. ## Author readiness Human owner: @ShuaixinHuang - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:42:18 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:47:31 +00:00

[PR #6685] test(search): cover Unicode literal syntax and astral case folding #7392

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#6685

No description provided.

Rows
Columns