[PR #6685] test(search): cover Unicode literal syntax and astral case folding #7392

Open
opened 2026-11-01 21:47:31 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6685
Author: @eco-null
Created: 10/23/2026
Status: 🔄 Open

Base: main ← Head: codex/unicode-literal-search


📝 Commits (10+)

  • d225482 fix(search): fold Unicode literal matches
  • b787af0 test(ida): require Unicode literal case folding
  • a47b37d test(reference): return byte-preserving entry names
  • 946a534 test(search): retain literal edge coverage on main
  • cc3aba8 fix(javascript): coalesce projected source facts
  • 7fe23c8 test: repair isolation and format fixtures
  • da715ad merge: retain upstream CI and doctor fixes
  • 4dd3094 merge: retain upstream fixes and focused regression
  • 8c631f2 fix(evidence): retain rebound snapshot proof
  • d2da6e7 merge: retain upstream Evidence ownership repair

📊 Changes

1 file changed (+34 additions, -0 deletions)

View changed files

📝 src/domain/analysisSearch.test.ts (+34 -0)

📄 Description

Summary

Refs #6634. Adds literal punctuation, backslash, empty-input and astral case-folding regressions, sensitive controls and explicit-regex errors.

The final diff contains one test file relative to pinned main 03ed0c63d9566dbc0d6e805bc62ccd7569bad314. Production corrections are upstream. The shared low-headroom Evidence repair and regressions are retained exactly from @gensokyo-dev's #7036; the competing local repair was removed.

Current-head verification

Head: d2da6e7a0ea024206b1d54ee54bfdee2f954f8f9.

Hosted CI completed successfully: 32,842 passed, 234 skipped, across 2,398 passed/33 skipped test files. Source tests, all eight built-test shards, Portable tests, static checks and CI required all succeeded (12/12 gates). Skipped conditional/platform cases are not claimed as executed; this does not establish every real external-engine or cross-platform workflow.

Local validation

  • Pinned Node24.22.1/npm11.16.0, Windows. 37/37 shared search and recorded IDA protocol tests, 11.09s. Recorded protocol coverage is not real IDA execution.
  • Pinned-upstream Evidence/JSON/error/snapshot/managed-headroom/doctor selection on #6690: 143 passed/1 POSIX skip in seven files, 25.94s. All three heads share identical production code.
  • Full check: six tasks plus architecture guards passed on the pinned tree, 13.561s. Each branch passed its relevant focused tests and normal pre-push typecheck/lint.
  • Merge commits preserve read-only validated index trees; mutating precommit was not applied to upstream-only imports. No assertion, retry, timeout or allowance was weakened.

Readiness

The owner's requested current-head test gate is satisfied. The existing three human declarations below are preserved; no new human attestation or maintainer approval is asserted.

Author readiness

Human owner: @eco-null

  • I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
  • I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
  • I declare this PR ready for initial maintainer review.

Before merge

  • This PR addresses a concrete problem or an agreed enhancement.
  • Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
  • The PR has one focused outcome and the title follows type(scope): outcome.
  • Related issue is linked, or the reason for not linking one is stated above.
  • Tests cover changed observable behavior and meaningful failure paths.
  • Owning docs, contracts, and generated metadata are updated where needed.
  • User-visible CLI/MCP changes include representative output. (No public provider workflow was executed; the shared matcher regression and this limitation are documented above.)
  • I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6685 **Author:** [@eco-null](https://github.com/eco-null) **Created:** 10/23/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `codex/unicode-literal-search` --- ### 📝 Commits (10+) - [`d225482`](https://github.com/morluto/rea/commit/d2254827481ac43b4fe581b7c85a7e73e1d9da46) fix(search): fold Unicode literal matches - [`b787af0`](https://github.com/morluto/rea/commit/b787af0b3d0aee7073c99cc0ab00d6c8c28c54e8) test(ida): require Unicode literal case folding - [`a47b37d`](https://github.com/morluto/rea/commit/a47b37dd0b6345c29a50462bbb94e585de8363b0) test(reference): return byte-preserving entry names - [`946a534`](https://github.com/morluto/rea/commit/946a5347ade725d1e212dcf3808e69b74785d649) test(search): retain literal edge coverage on main - [`cc3aba8`](https://github.com/morluto/rea/commit/cc3aba89c240f71d5a1c5a700bfc55f44e01122b) fix(javascript): coalesce projected source facts - [`7fe23c8`](https://github.com/morluto/rea/commit/7fe23c83d62c1a90c3f104fdaceaa76aa055bf14) test: repair isolation and format fixtures - [`da715ad`](https://github.com/morluto/rea/commit/da715ad92dd08fd1373c10746fcfebed06fb9f3d) merge: retain upstream CI and doctor fixes - [`4dd3094`](https://github.com/morluto/rea/commit/4dd3094b106e22e8ec34fc42f891182ce841725c) merge: retain upstream fixes and focused regression - [`8c631f2`](https://github.com/morluto/rea/commit/8c631f28a5e54e9ebba6cd77ca41344c680b6eca) fix(evidence): retain rebound snapshot proof - [`d2da6e7`](https://github.com/morluto/rea/commit/d2da6e7a0ea024206b1d54ee54bfdee2f954f8f9) merge: retain upstream Evidence ownership repair ### 📊 Changes **1 file changed** (+34 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/analysisSearch.test.ts` (+34 -0) </details> ### 📄 Description ## Summary Refs #6634. Adds literal punctuation, backslash, empty-input and astral case-folding regressions, sensitive controls and explicit-regex errors. The final diff contains **one test file** relative to pinned main `03ed0c63d9566dbc0d6e805bc62ccd7569bad314`. Production corrections are upstream. The shared low-headroom Evidence repair and regressions are retained exactly from @gensokyo-dev's [#7036](https://github.com/morluto/rea/pull/7036); the competing local repair was removed. ## Current-head verification Head: `d2da6e7a0ea024206b1d54ee54bfdee2f954f8f9`. [Hosted CI completed successfully](https://github.com/morluto/rea/actions/runs/40125162029): **32,842 passed, 234 skipped**, across 2,398 passed/33 skipped test files. Source tests, all eight built-test shards, Portable tests, static checks and `CI required` all succeeded (12/12 gates). Skipped conditional/platform cases are not claimed as executed; this does not establish every real external-engine or cross-platform workflow. ## Local validation - Pinned Node24.22.1/npm11.16.0, Windows. 37/37 shared search and recorded IDA protocol tests, 11.09s. Recorded protocol coverage is not real IDA execution. - Pinned-upstream Evidence/JSON/error/snapshot/managed-headroom/doctor selection on #6690: 143 passed/1 POSIX skip in seven files, 25.94s. All three heads share identical production code. - Full check: six tasks plus architecture guards passed on the pinned tree, 13.561s. Each branch passed its relevant focused tests and normal pre-push typecheck/lint. - Merge commits preserve read-only validated index trees; mutating precommit was not applied to upstream-only imports. No assertion, retry, timeout or allowance was weakened. ## Readiness The owner's requested current-head test gate is satisfied. The existing three human declarations below are preserved; no new human attestation or maintainer approval is asserted. ## Author readiness Human owner: @eco-null - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [x] User-visible CLI/MCP changes include representative output. (No public provider workflow was executed; the shared matcher regression and this limitation are documented above.) - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#7392
No description provided.