mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #5352] [MERGED] feat(environment): render more read tools from the state and describe responses #6889
Closed
opened 2026-11-01 21:43:51 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#6889
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/5352
Author: @earakely-scale
Created: 10/20/2026
Status: ✅ Merged
Merged: 10/21/2026
Merged by: @morluto
Base:
main← Head:feat/environment-state-coverage📝 Commits (4)
95c8c9dfeat(environment): render more read tools from the state and describe responses2a926a0fix(environment): keep rendered documents and quoted samples inside their budgets82838a5chore: merge main (d7ca93cc) into environment state coverage87cea71test(environment): pin the replay card this branch serves📊 Changes
26 files changed (+1582 additions, -249 deletions)
View changed files
📝
docs/agent-environments.md(+42 -8)📝
docs/mcp-contracts.md(+1 -1)➕
docs/specs/agent-environments/state-coverage/plan.md(+32 -0)➕
docs/specs/agent-environments/state-coverage/spec.md(+99 -0)➕
docs/specs/agent-environments/state-coverage/tasks.md(+16 -0)➕
docs/specs/agent-environments/state-coverage/verification.md(+123 -0)📝
docs/web-network-captures.md(+35 -17)📝
src/application/environment/environmentBundle.test.ts(+3 -2)📝
src/application/environment/environmentReplay.ts(+19 -29)📝
src/application/environment/environmentSource.ts(+53 -1)📝
src/application/environment/environmentState.test.ts(+3 -3)📝
src/application/environment/environmentState.ts(+11 -9)📝
src/application/environment/environmentStateAnswer.test.ts(+11 -0)📝
src/application/environment/environmentTools.test.ts(+271 -22)📝
src/application/environment/environmentTools.ts(+175 -22)📝
src/contracts/analysisViewToolContracts.ts(+1 -1)📝
src/domain/analysisView/EnvironmentStateAccumulator.ts(+2 -2)📝
src/domain/analysisView/EnvironmentStateExtraction.ts(+78 -47)📝
src/domain/analysisView/environmentStateMerge.ts(+6 -1)📝
src/domain/analysisView/environmentStateRules.ts(+117 -42)...and 6 more files
📄 Description
Summary
Raises how much of an environment the
environment-stateview (#5319) renders from its state, and makes served tools say what they return. Read-only documents hold every non-entityGETread with one initial request line, identity can come from an...Id/..._idfield when no fixed name identifies the items (proved by two distinct items), single entities wrapped in a one-element array ({"posts":[{...}]}) are located, served tool descriptions summarise each tool's recorded response, and served tools carry MCP annotations. On 44 recorded captures, 1,011 of 1,277 read tools render from the state, against 625 without this change.Refs morluto/rea#4933 (design discussion; scope decision requested there).
Builds on #5319, now merged; the diff against main is this change only.
Problem and expected behavior
Half of the read tools still replayed recordings: settings, configuration and other singleton reads had no place in the state unless the capture wrote them, lists keyed by
orgId-style fields had no identity, Ghost-style detail responses wrap their entity in an array, and agents saw only a method and path per tool. The expected outcome is a state that covers those reads and tool descriptions an agent can choose from.Change and scope
EnvironmentStateExtraction.ts: documents for every non-entityGETread with one initial request line, written or not;not-entityis retired andpath-variesnames a read under more than one path. Identity inference still requires listed items, as #5319 does.environmentStateRules.ts: suffix identity candidates afterIDENTITY_NAMES, accepted only when two items in one recording show them distinct; pointers/0and/<member>/0for a one-element array.environmentTools.ts: a response summary per tool from its first JSON-like recorded exchange (fields of an object, an array of objects, or an envelope's list), plus the manifest's statuses, charged to the catalog reservation.serveEnvironment.ts:readOnlyHint,destructiveHint,idempotentHintandopenWorldHint: falseper tool; the card is unchanged.Follow the contribution scope.
Contract and boundary impact
inspect_analysis_viewenvironment-state results gain document views and thepath-variesreason, losenot-entity; served tool descriptions and MCP annotations change; no new tooldocs/public/product-catalog.json), package, or installation impact (CI generates and validates ignored catalogs andskills/; edit authored instructions in.agents/skills/reverse-engineer-anything/and never commit build outputs): the generated catalog picks up the updated view description; no package or installation changeExpected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.
Evidence and regression coverage
no-identity216 to 32,not-entity310 to none.For evidence-bearing changes:
Validation performed
6ad63bcc):npm run check:fast,npm run format:check,npx knip,npm run scan:todos,npm run docs:check: passed.npm run jscpd: 3.39% duplicated lines over 3362 files (gate 3.5%).npx vitest run --project domain --project services: 344 files, 5914 tests passed, 5 pre-existing skips.npm run build:cached, thennpm run test:focused --serve and tool-definition adapters, serve MCP and CLI boundaries, export CLI, analysis-view MCP and CLI boundaries, compact input-schema budget and two contract tests: 10 files, 98 tests passed.npm run check:fastpassed;npx vitest run src/domain/analysisView src/application src/server/environment src/contracts: 137 files, 1801 tests passed, 5 pre-existing skips.ef49dca6, after merging main (a98df6c1; the only conflict was the tool contract text, both sides kept): a document whose value changed between two of its line's reads across any recorded write (e.g.GET /api/mearoundPOST /api/orders) is recorded asfields-differinstead of publishing the post-write value, matching entities; the RFC 9110 safe methods (GET,HEAD,OPTIONS,TRACE) are nowreadOnlyHintandidempotentHint, so a CORS preflight tool no longer falls to the destructive default. Two new tests. tsc, module boundaries, test discovery, knip and docs:check clean; vitest over src/domain, src/application, src/contracts, src/server and src/cli: 7256 passed, 5 skipped; after test:prepare, analysis-view and environment serve/export CLI/MCP and CLI-startup boundary files (55 tests) and tests/conformance (279) passed; mcp-catalog:check passed.b4b7ebc7: Greptile's wide-list finding applied as suggested (list identity candidates intersect through a set after the first recording). A further review ofef49dca6, the/0item pointers and the new tests found nothing else; the branch still merges cleanly with main. vitest over src/domain, src/application, src/contracts, src/server and src/cli: 7256 passed, 5 skipped; module boundaries clean.f6c756aa, after merging main again (dbd0dcee; contract text only): captured field and member names in response summaries are written as JSON strings, so a key such as"x; recorded statuses 500"no longer makes a description claim a status the tool never recorded (new test). The CI failures onb4b7ebc7(tests/boundary/cli/doctorCancellation.test.ts, kuna SIGINT/SIGTERM, arunIdthat is not a UUID) are main's: main's own CI run oneb7acc70fails the same two tests, and this PR touches no doctor or Kuna code. vitest over src/domain, src/application, src/contracts, src/server and src/cli: 7270 passed, 5 skipped; after test:prepare, analysis-view and environment serve/export CLI/MCP and CLI-startup boundary files (55 tests) and tests/conformance (279) passed; mcp-catalog:check and docs:check passed.665112e9, after merging main (19ef5394; contract text only, main's Frida addition kept beside this branch's): an envelope member too long to show whole is now a JSON-quoted prefix before the truncation note, so a newline in it cannot read as more of the description (Greptile). Its test fails onf6c756aa.check:fast, format, knip, todos, docs, test discovery, module boundaries and catalog passed; domain and services 7262 (5 pre-existing skips); focused boundaries 66; conformance;jscpd3.49%.87cea71a, after the squash onto main (95c8c9d1) and morluto's2a926a0a:166fb082. It keeps both sides of every conflict and drops nothing of this branch.2a926a0asettled Greptile's oversized-document finding (rendered-oversize), kept description samples within budget after JSON quoting, and refitted the two tests the squash left failing.d7ca93ccin82838a58, with no conflicts. In87cea71athe replay-only card test pins this branch's 12,818-byte card in place of main's 11,131-byte one, since the descriptions now name each tool's recorded responses.87cea71a:check:fast, format, knip, todos, docs, discovery, module boundaries and catalog, andjscpd(3.49%). The environment, analysis-view and contract tests across the boundary, MCP, CLI, process, acceptance and conformance projects pass: 37 files.npm run test:fastpasses apart from unrelated tests.JavaScriptRuntimeScope.cancellation"stops Inspector target authorization after the current stat settles" fails the same way on main here (macOS). The rest are timeouts in heavy domain, adapter and composition tests, which pass when rerun alone; one worker test fails on alternate runs.Compatibility, safety, and release
path-variesadded,not-entityremoved.Author readiness
Human owner: @earakely-scale
Before merge
type(scope): outcome.🤖 Generated with Claude Code
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.