[PR #6905] [CLOSED] fix(environment)!: keep unsupported HAR body encodings opaque #7437

New issue

Closed

opened 2026-11-01 21:47:51 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:47:51 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6905
Author: @gensokyo-dev
Created: 10/23/2026
Status: ❌ Closed

Base: main ← Head: fix/6889-har-body-encoding-20261023

📝 Commits (1)

a544645 fix(environment)!: keep unsupported HAR body encodings opaque

📊 Changes

7 files changed (+134 additions, -42 deletions)

View changed files

📝 docs/agent-environments.md (+5 -1)
📝 docs/specs/agent-environments/environment-serve/spec.md (+3 -1)
📝 src/application/environment/environmentReplay.test.ts (+109 -33)
📝 src/application/environment/environmentReplay.ts (+6 -2)
📝 src/application/environment/environmentSource.ts (+4 -0)
📝 src/domain/analysisView/EnvironmentStateAccumulator.ts (+1 -1)
📝 src/domain/analysisView/recordedResponseBody.ts (+6 -4)

📄 Description

Superseded by the merged fix

Maintainer commit 254a8e7018e6b984d1cbc607e11dbab0866c9ff7 fixes #6889 and #6890 directly on main. Both issues are closed. This duplicate PR is closed without merging its new output enum.

The review finding on this branch was valid: its new ReplayedBody variant did not reach the comparison consumer. A production-boundary probe reproduced false differences and missing unknown-body accounting. The upstream implementation reuses the existing unavailable-body path and owns HAR interpretation, including empty-body classification and redacted declarations, at the shared boundary.

Verification of main

Pinned revision: 0bbd635ab811b6d6c05cb73188225dbce2d31aa1, Linux x64, Node 24.22.1 / npm 11.16.0.

src/browser/history/HarCapture.test.ts, src/application/environment/environmentSource.test.ts, src/application/environment/environmentStateWriteAnswer.test.ts: 185 passed.
tests/acceptance/tools/harBoundaryFacts.test.ts: unknown-body CLI/MCP case passed in the first run; the malformed-schema case reached its 30-second timeout. An isolated rerun using node node_modules/vitest/vitest.mjs run tests/acceptance/tools/harBoundaryFacts.test.ts --testTimeout=90000 --maxWorkers=1 passed both cases (16.7 and 11.9 seconds). No product or test-source change was made for that retry.
Native HAR → probeRequests → compareAnswers: unsupported/decoded and unsupported/unsupported each report unobserved_bodies: 1, without fabricated body differences. A known status difference survives independently.
Chromium-recorded HAR with actual PROJ metadata, using a controlled unsupported-encoding derivative: compiled CLI/stdin MCP import, state projection, compiled environment serving and HTTP MCP replay completed. The original encoding/text and Evidence linkage remain intact; decoded body is unavailable and state stays recorded with body-unusable.

The branch was not merged; its comparison defect and output enum extension are not part of the upstream fix. The broader maintenance goal continues with current main.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6905 **Author:** [@gensokyo-dev](https://github.com/gensokyo-dev) **Created:** 10/23/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/6889-har-body-encoding-20261023` --- ### 📝 Commits (1) - [`a544645`](https://github.com/morluto/rea/commit/a54464548e67cbcadd6b19f790e5ec848a2ba10e) fix(environment)!: keep unsupported HAR body encodings opaque ### 📊 Changes **7 files changed** (+134 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `docs/agent-environments.md` (+5 -1) 📝 `docs/specs/agent-environments/environment-serve/spec.md` (+3 -1) 📝 `src/application/environment/environmentReplay.test.ts` (+109 -33) 📝 `src/application/environment/environmentReplay.ts` (+6 -2) 📝 `src/application/environment/environmentSource.ts` (+4 -0) 📝 `src/domain/analysisView/EnvironmentStateAccumulator.ts` (+1 -1) 📝 `src/domain/analysisView/recordedResponseBody.ts` (+6 -4) </details> ### 📄 Description ## Superseded by the merged fix Maintainer commit [254a8e7018e6b984d1cbc607e11dbab0866c9ff7](https://github.com/morluto/rea/commit/254a8e7018e6b984d1cbc607e11dbab0866c9ff7) fixes #6889 and #6890 directly on main. Both issues are closed. This duplicate PR is closed without merging its new output enum. The review finding on this branch was valid: its new `ReplayedBody` variant did not reach the comparison consumer. A production-boundary probe reproduced false differences and missing unknown-body accounting. The upstream implementation reuses the existing unavailable-body path and owns HAR interpretation, including empty-body classification and redacted declarations, at the shared boundary. ## Verification of main Pinned revision: `0bbd635ab811b6d6c05cb73188225dbce2d31aa1`, Linux x64, Node 24.22.1 / npm 11.16.0. - `src/browser/history/HarCapture.test.ts`, `src/application/environment/environmentSource.test.ts`, `src/application/environment/environmentStateWriteAnswer.test.ts`: 185 passed. - `tests/acceptance/tools/harBoundaryFacts.test.ts`: unknown-body CLI/MCP case passed in the first run; the malformed-schema case reached its 30-second timeout. An isolated rerun using `node node_modules/vitest/vitest.mjs run tests/acceptance/tools/harBoundaryFacts.test.ts --testTimeout=90000 --maxWorkers=1` passed both cases (16.7 and 11.9 seconds). No product or test-source change was made for that retry. - Native HAR → `probeRequests` → `compareAnswers`: unsupported/decoded and unsupported/unsupported each report `unobserved_bodies: 1`, without fabricated body differences. A known status difference survives independently. - Chromium-recorded HAR with actual PROJ metadata, using a controlled unsupported-encoding derivative: compiled CLI/stdin MCP import, state projection, compiled environment serving and HTTP MCP replay completed. The original encoding/text and Evidence linkage remain intact; decoded body is unavailable and state stays recorded with `body-unusable`. The branch was not merged; its comparison defect and output enum extension are not part of the upstream fix. The broader maintenance goal continues with current main. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:47:51 +00:00