mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #5818] [MERGED] feat(sqlite): make worker deadlines adjustable with recovery guidance #7080
Closed
opened 2026-11-01 21:45:15 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#7080
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/5818
Author: @gensokyo-dev
Created: 10/21/2026
Status: ✅ Merged
Merged: 10/21/2026
Merged by: @gensokyo-dev
Base:
main← Head:feat/20261021-sqlite-timeout-recovery📝 Commits (4)
f1fbd1dfeat(sqlite): make worker deadlines adjustable with recovery guidance200f493fix(sqlite): require known budgets for fresh observationsb58ca53fix(sqlite): retain typed timeout and one output owner through cleanup3e5743btest(sqlite): hand fixture ownership to supervision immediately📊 Changes
15 files changed (+496 additions, -49 deletions)
View changed files
📝
docs/sqlite-databases.md(+23 -2)📝
src/application/sqlite/SqliteDatabaseService.test.ts(+70 -0)📝
src/application/sqlite/SqliteDatabaseService.ts(+5 -1)📝
src/cli/sqliteCommands.ts(+5 -0)📝
src/contracts/sqlite/sqliteToolContracts.ts(+1 -1)📝
src/domain/sqlite/sqliteDatabase.ts(+17 -0)📝
src/sqlite/SqliteDatabaseFailures.ts(+91 -27)📝
src/sqlite/SqliteDatabaseInspection.ts(+1 -1)📝
src/sqlite/SqliteDatabaseLimits.ts(+0 -1)📝
src/sqlite/SqliteDatabaseProvider.ts(+12 -6)📝
src/sqlite/SqliteDatabaseWorkerExecution.ts(+6 -3)📝
tests/acceptance/sqliteDatabaseCli.test.ts(+21 -3)📝
tests/boundary/sqlite/sqliteDatabaseDescriptorCleanup.test.ts(+10 -1)➕
tests/boundary/sqlite/sqliteDatabaseFailures.test.ts(+88 -0)📝
tests/boundary/sqlite/sqliteDatabaseProvider.test.ts(+146 -3)📄 Description
Summary
Fixes #5812. Follow-up to #5808 and the RepoPrompt comparison in #5598.
SQLite's fixed 30-second worker deadline offered no actual public repair. Agents can now select
worker_timeout_ms/--worker-timeout-msand receive precise timeout versus fixed-limit guidance, without changing the database, requested facts or safety bounds.Problem and expected behavior
Raising the MCP client's deadline did not change the SQLite worker budget. Timeout plus cleanup failure also lost the typed primary timeout facts. Expose the real per-call control and retain its actual scope/value in Evidence; do not invent adjustable byte/heap ceilings or repeat deterministic refusals.
Change and scope
The existing parent provider resolves one budget and passes it to the owned supervisor, result and failure mapper. Default remains 30000 ms; accepted timer range is 1..2147483647. Worker wire replies cannot claim parent-owned execution metadata. Historical missing metadata stays unknown; fresh service results must report selected-or-default settings. One shared SQLite cleanup composer preserves typed primaries and delivers captured output once, including after cleanup resolves. Fixed value/reply recovery suggests exact columns/sample/schema selection only when the question permits it. Existing read-only authority and cleanup ownership remain unchanged.
Contract and boundary impact
Expected effects:
Evidence and regression coverage
Service guards for invalid/mismatched budgets, actual owned-worker timeout/corrected retry, typed timeout plus cleanup, max-timer guidance, CLI/MCP custom budget, fixed admission despite larger deadline, cancellation/cleanup partial Evidence.
Six focused guards failed before implementation and pass after; not every test was run fail-before.
Representative output:
provider_timeout,details.timeout_ms: 1, remediation namesworker_timeout_ms/--worker-timeout-ms; retry at 30000 returns the same requested Chinook rows with actual budget and original SHA-256. Oversized input remains non-retryableresource_constrainteven at 60000.Detailed evidence and whole-agent measurements: initial ten-session record, final review fixes and 13-session verification.
Observed, derived, and inferred claims remain distinguishable.
Artifact identity, source provenance, and failed attempts remain preserved.
Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.
Validation performed
npm run test:sqlite— 155 passed, 3 skipped, 12 files (final run 69.39 s). New fail-before guards also reproduce fresh default omission, duplicate output on the actual retained-cleanup path, and missing typed timeout restoration.npm run check— passed; existing lint warnings remain.npm run docs:check,npm run verify:test-discovery— passed after final test additions (5 README checks; all 1900 test files discovered exactly once).gpt-6.1-sol— 13 recorded sessions: nine completed answers, one legitimate fixed-input blocker, three pre-REA host-discovery blockers kept as failures. Four 1 ms timeout recoveries (including final cleanup code), invalid-input correction, fixed-value column selection, oversized honest stop and before/after controls. No unchanged failed retries or surviving sampled owned processes.3e5743ba6has a clean Codex re-review, successful Greptile review and all four threads resolved. None establishes human review.e9cdf873c58bd32e8f43b69f8a9a6d1ceb50d645before SQLite; separately tracked in #5845, not mixed into this PR. Final CI status is reported below, not assumed green.Compatibility, safety, and release
SQLITE_NOMEMclassification remains separate follow-up.Final CI status —
3e5743ba6Build, source tests, static checks, docs, Windows-controls build and all four Linux SQLite runtime jobs (Node 22.x, 24.15.0, 24.x, 26.x) passed. Seven portable test shards passed; shard 4 has only the pre-existing WABT CLI requiredness oracle failure (log, #5845), reproduced before this SQLite change. CI is not all green; dependent rollups inherit that failure. The human-declaration check also fails for the intentionally unfilled attestations below. Merge uses the user's explicit standing override authorization, not fabricated attestations. Main advanced with unrelated Rust #5815; a scoped diff found no changes to the touched SQLite paths.
Author readiness
Human owner: @gensokyo-dev
The user explicitly instructed ready-for-review submission and authorized continuation/merge overrides. The first two human-review attestations remain unchecked because the agent cannot truthfully claim those human acts occurred. Automated checks/source review are not substitutes for them; no all-green readiness claim is made.
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.