mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #6139] [CLOSED] fix(native): inspect an explicit plist path over MCP without an open target #7155
Closed
opened 2026-11-01 21:45:48 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#7155
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/6139
Author: @minjunkim-dev
Created: 10/21/2026
Status: ❌ Closed
Base:
main← Head:fix/inspect-plist-explicit-path-without-target📝 Commits (4)
5726918fix(native): inspect an explicit plist path over MCP without an open targete8fe333fix(native): read standalone plists without opening them as targets0245bd8test(native): cover standalone plist cleanup, cancellation, and routing5c69aa4test(mcp): keep absolute plist selections on a fixed-target server📊 Changes
14 files changed (+594 additions, -11 deletions)
View changed files
📝
src/application/CapabilityInventory.test.ts(+28 -0)📝
src/application/CapabilityInventory.ts(+2 -0)➕
src/application/StandalonePlistRead.test.ts(+148 -0)➕
src/application/StandalonePlistRead.ts(+35 -0)📝
src/application/binary/BinarySessionPort.ts(+1 -0)📝
src/composition/directAnalysis.ts(+28 -0)📝
src/native/NativeMacOSProvider.ts(+23 -7)📝
src/native/NativePlistResourceRoot.test.ts(+70 -0)📝
src/native/NativePlistSource.ts(+18 -0)📝
src/server/BundleResourcesMcp.test.ts(+12 -1)📝
src/server/createServer.ts(+20 -2)📝
src/server/registerNativeTools.ts(+25 -1)📝
tests/boundary/mcp/nativePlistDiagnosticsMcp.test.ts(+59 -0)📝
tests/boundary/mcp/serverIdentity.test.ts(+125 -0)📄 Description
Summary
MCP
inspect_plistdocuments "or pass any local plist path", and its only input example passes justpath. With no target open, that call failed withtarget_unavailable, andbinary_sessionreportedtarget_required. #1176 recorded this under "Remaining gaps". With no target open, an absolutepathis now read directly, and discovery reports the tool available.Fixes #6135
Problem and expected behavior
Trigger: a fresh MCP connection, then
inspect_plist {"path": "/System/Applications/Calculator.app/Contents/Info.plist"}.target_unavailable("No app is open… call open_binary"). Afteropen_binaryon any app, the same call succeeds, even for an unrelated bundle's plist or for suffixless OpenStep text. An absolute selection never uses the target (resolveNativePlistSelectionreturns it unchanged), so the session was only a gate.plutilreads, including OpenStep text without a.plistsuffix (for exampleLocalizable.strings).binary_sessionstill reportsopen: false. A relative selection such asContents/Info.pliststill returnstarget_unavailable, because it has no root without a target.Change and scope
NativeMacOSProvider.createStandalonePlistClient()returns a native client with no target and no app root. It shares construction withcreateBundleResourceClient.NativeMacOSClient#inspectPlistresolves its selection with the newresolveStandalonePlistSelection: an absolute path is selected as is, and a relative or missing path is refused withinvalid_request. The macOS host gate now covers both target-less clients.registerNativeToolsroutesinspect_plistto that client when thepathis absolute and no target or bundle-resource session is selected.inspectStandalonePlist(composition) only builds the client;readStandalonePlist(src/application/StandalonePlistRead.ts) reads and always closes it, mirroringwithSessionCleanup. A close failure is reported through the existingmanagedAnalysisCleanupFailure, and a throw plus a close failure keeps both in anAggregateError. The call runs inside the existing analysis admission.plutilran; that runner is removed.CapabilityInventory.targetAvailabilityno longer reportsinspect_plistastarget_requiredin a closed session. Host availability is still checked first, so a host whose native descriptor isunsupported_hoststill reports it (unit-tested; not run on Linux).BinarySessionPortgains an optionalactiveBundleResourceRoot(), whichBinarySessionalready implements. The server uses it so it never bypasses a resource-only session.CreateServerOptions.standalonePlistInspectionallows injecting the reader, like the other services, so routing can be tested without macOS.Contract and boundary impact
src/native/NativePlistSource.ts,NativeMacOSProvider), MCP native tool admission (src/server/registerNativeTools.ts), and session availability (src/application/CapabilityInventory.ts).tools/listis unchanged.binary_sessionchangesinspect_plistfromtarget_requiredtoavailablein a closed session. CLI is unchanged.unsupported_host.subjectisnull, as for bundle-resource reads.normalized_result.source_pathand the location carry the selected path, and thefile/plutilprovenance is unchanged.docs:checkpasses).Expected effects:
/usr/bin/fileandplutil, as before.)Evidence and regression coverage
Tests added or updated:
src/native/NativePlistResourceRoot.test.ts(simulated native commands, every host): the target-less client reads an absolute suffixless selection, refuses relative and missing selections withinvalid_request, refuses on a non-macOS host withcapability_unavailable, and returnscancelledfor an already aborted signal without running any plist command.src/application/StandalonePlistRead.test.ts(fake clients, every host): the client is closed exactly once after success, cancellation, and an unexpected throw. The success result has anullsubject, and the abort signal is forwarded. A close failure is reported ascleanup_incomplete, keeping the partial observation or the primarycancellederror. A throw plus a close failure keeps both.src/server/BundleResourcesMcp.test.ts: inside a resource-only session, an absolute selection stays on the session's resource client and never reaches the standalone reader. Removing the bundle-resource condition fromtargetSelectedmakes this test fail (executed as a temporary mutation).src/application/CapabilityInventory.test.ts: in a closed sessioninspect_plistis available,inspect_machois stilltarget_required, andunsupported_hoststill wins.tests/boundary/mcp/serverIdentity.test.ts(in-memory MCP, injected reader, every host): with no target, an absolute path goes to the standalone reader and the session stays unopened. A relative path returnstarget_unavailable. Afteropen_binary, the call stays on the session. On a server bound to a fixed analysis target (no session), an absolute selection reaches that analysis and never the standalone reader. Dropping thesession === undefinedcondition fromtargetSelectedmakes this test fail (executed as a temporary mutation).tests/boundary/mcp/nativePlistDiagnosticsMcp.test.ts(built production server over stdio, darwin only): with no target, the real provider reads an XML plist, a suffixless binary plist, a suffixless OpenStep file, and a.stringsOpenStep file, andbinary_sessionreportsopen: false.Base reproduction: in a clean worktree at
01788bawith only these six test files copied in, 5 of the 6 files fail (executed). Every new case fails, andStandalonePlistReaddoes not exist there.BundleResourcesMcp.test.tspasses on the base by design, because without this change nothing is routed away from the session; the mutation above shows it guards the new branch. The suffixless OpenStep cases also fail on this PR's first revision (5726918).User-visible MCP output (executed against this branch's build over stdio, macOS 27.0.1 arm64):
BinarySettingsisplutil -convert binary1of Chess.app's Info.plist;Sample.stringsandSettingscontain{ Name = Example; }.On
rea-agents@6.7.0, the same absolute call returnstarget_unavailable, andbinary_sessionreportstarget_required(see #6135).Remaining proof gaps: the darwin-only real-provider test was run only on macOS 27.0.1. Linux and Windows run the simulated-provider, fake-client, and injected-reader tests only. Cancellation during a running
plutilcommand and during client close use the sharedNativeMacOSClientlifecycle and its existing tests; they are not separately exercised for the target-less client. Token and time costs were not measured; a standalone read creates and closes one target-less native client and removes the extraopen_binaryround trip.For evidence-bearing changes:
Validation performed
All results below are for head commit
5c69aa4on macOS 27.0.1 arm64 unless noted.npm run check— passed (typecheck, built lint with 0 errors, format, knip, metadata, architecture guards).npm run check:fast— passed (also run by the pre-push hook).npm run jscpd— passed (3.48% duplicated lines).npm run docs:check— passed (run on0245bd8; the last commit changes only a test file).npm run verify:test-discovery— passed.npm run test:focused --on the six files with new tests (CapabilityInventory,StandalonePlistRead,NativePlistResourceRoot,BundleResourcesMcp,serverIdentity,nativePlistDiagnosticsMcp) — 55 passed.npm run test:focused --on all 42 test files that mentioninspect_plist,createBundleResourceClient,NativePlistSource,StandalonePlist,inspect_managed_artifactorrunManagedProviderExecution(evaluation suites excluded) — 368 passed, 1 skipped, 1 failed. The failure istests/acceptance/applications/appBundleEncodingCli.test.ts> "resolves real compiled bundles without changing executable names during decoding". It fails identically on01788bawithout this change: this host'splutil(macOS 27.0.1) accepts the "unsupported declaration" fixture, and the CLIinspect-plistpath is not touched here.main(13a8640, 92 commits newer than the base) in a throwaway worktree: the merge is clean,npm run check:fastpassed, and the six new-test files passed (55 tests).Compatibility, safety, and release
Author readiness
Human owner: @minjunkim-dev
Before merge
type(scope): outcome.🤖 Generated with Claude Code
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.