mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #6141] [CLOSED] fix(snapshot): keep mismatch, output-loss, and declaration require diagnostics precise #7157
Closed
opened 2026-11-01 21:45:48 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#7157
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/6141
Author: @agorevski
Created: 10/21/2026
Status: ❌ Closed
Base:
main← Head:fix/misc-snapshot-output-ts📝 Commits (2)
ba46733fix(snapshot): keep target mismatch, output loss, and declaration require exactdead84afix(snapshot): separate omitted-output and completion limitations📊 Changes
6 files changed (+113 additions, -3 deletions)
View changed files
📝
src/application/DirectAnalysis.ts(+2 -2)📝
src/application/javascript/JavaScriptArtifactPathResolution.test.ts(+54 -0)📝
src/application/javascript/JavaScriptArtifactPathResolution.ts(+6 -0)📝
src/application/reverse/ReverseEngineeringService.ts(+6 -1)📝
tests/boundary/filesystem/directAnalysisSnapshotReplay.test.ts(+33 -0)📝
tests/support/ownedRizinCommandEvidenceTests.ts(+12 -0)📄 Description
Summary
Fixes #5945
Fixes #5967
Fixes #6105
Three independent evidence-correctness defects, each fixed at its producing boundary:
EvidenceIntegrityError, so the mismatch-specific presentation never applied. It now constructsAnalysisSnapshotMismatchError, which keeps the sameevidence_integrity_mismatchcode and retryable=false while selecting the target-mismatch message and snapshot recovery advice.diagnosticTruncatedmarker, so Evidence reportedoutput_truncated: falsefor known omitted output. The owned runner now returns the marker on success, and the service assigns it, matching the existing non-zero-exit path.require("./dep.d.ts")was downgraded tounavailableby the generic declaration check, whileimport "./dep.d.ts"resolved. Only the exact requested path is now exempt in module-specifier resolution. The emitted-extension fallback (require("./only.js")findingonly.d.ts) stays unavailable.Problem and expected behavior
analyze B --snapshot A.json. Expected: refuse the snapshot (unchanged) with a target-specific message and the existing snapshot recovery action. Observed: generic integrity text inmessageandremediation.action;details.reasonwas already correct.outputIncompleteproduced a snapshot withdiagnosticTruncated: true, but Evidence hadoutput_truncated: false. Expected: the same partial-output disclosure as the non-zero exit path.require("./dep.d.ts")with the file present returnedunavailablewithcandidate_path: "dep.d.ts"instead of the resolved inventoried declaration. Expected: explicit exact declaration resolves in both loader modes; emitted-extension declaration fallback stays unavailable.Change and scope
DirectAnalysis.ts:prepareSnapshotconstructsAnalysisSnapshotMismatchError(existing subclass ofEvidenceIntegrityError); the now-unused base import is removed.ReverseEngineeringService.ts: the owned-command runner returnsoutputTruncatedfromsnapshot.diagnosticTruncatedon success; the service assigns it instead of leavingfalse.JavaScriptArtifactPathResolution.ts:resolveFileCandidatestakes an optional explicit path.resolveCandidatepasses the declared candidate only formodule-specifiercontext, so that exact path is not downgraded. Directory/package-main and fallback candidates are unchanged.Not included: no change to exit status, completion-status semantics, provider output capture, snapshot file format, or package-main declaration handling (still downgraded). No lifecycle redesign.
Contract and boundary impact
code/category/retryableare unchanged for #5945; message and remediation text change to the existing mismatch wording. #5967 changesoutput_truncatedfrom false to true only for exit-0 captures with omitted output. #6105 changesresolution_statusfromunavailabletoresolvedonly for explicit exact declaration requests.docs/public/product-catalog.json), package, or installation impact (CI generates and validates ignored catalogs andskills/; edit authored instructions in.agents/skills/reverse-engineer-anything/and never commit build outputs): none. Build outputs were produced by the focused test runner and not committed.Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.
Evidence and regression coverage
src/application/javascript/JavaScriptArtifactPathResolution.test.ts: new describe "explicit TypeScript declaration require ownership" (./dep.d.ts,./cfg.d.mts,./legacy.d.ctsresolve to their exact declaration in both loader modes). Existing emitted-fallback test unchanged.tests/support/ownedRizinCommandEvidenceTests.ts: new row "normal exit with omitted output" (exit 0,diagnosticTruncated: true→output_truncated: true); runs throughtests/composition/reverseEngineeringEdgeCases.test.ts.tests/boundary/filesystem/directAnalysisSnapshotReplay.test.ts: new case "names the target mismatch when a snapshot is replayed against other bytes" (asserts code, message, and remediation action).code: "evidence_integrity_mismatch",messageandremediation.actionas in the issue's "Expected behavior"; the CLI/MCP output was not captured from a built binary.tests/acceptance/nativeDispatchSnapshot.test.tsis darwin-only and was not run); no builtdist/CLI run of the #6105 synthetic directory; the full suite (npm run test:run,check:pr) was not run.For evidence-bearing changes:
Validation performed
Review follow-up at
7eb8b5002(the bullets below describe the earlier commit):npm run test:focused -- src/application/javascript/JavaScriptArtifactPathResolution.test.ts tests/composition/reverseEngineeringEdgeCases.test.ts tests/boundary/filesystem/ciChangeScope.test.ts— exit 0, 3 files, 635 tests passed. Covers the new barerequire("dep.d.ts")case and the omitted-output limitation wording.node scripts/run-typescript.mjs --noEmit— exit 0.npx oxfmton the changed files — formatted.Run from the worktree of
fix/misc-snapshot-output-ts(baseorigin/main01788bac8):npm run test:focused -- src/application/javascript/JavaScriptArtifactPathResolution.test.ts tests/composition/reverseEngineeringEdgeCases.test.ts tests/boundary/filesystem/directAnalysisSnapshotReplay.test.ts— exit 0; 3 files passed; 385 tests passed, 2 skipped (pre-existing platform-gated skips).npm run test:local -- <same three paths>— exit 0 but ran no tests: the runner reports that built-project files needtest:focused. Not counted as validation.npm run typecheck— exit 0.npx oxlint <six changed files>— exit 0, no errors. Warnings are complexity/size warnings inJavaScriptArtifactPathResolution.tsthat also appear on the base file; none new.npx oxfmt --check <six changed files>— exit 0.Compatibility, safety, and release
Author readiness
Human owner: @agorevski
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.