morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #6238] [MERGED] docs(javascript): state that duplicate unmapped content stays ambiguous #7215

New issue

Closed

opened 2026-11-01 21:46:13 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:46:13 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6238
Author: @kaoru0822-kitauji
Created: 10/22/2026
Status: ✅ Merged
Merged: 10/22/2026
Merged by: @kaoru0822-kitauji

Base: main ← Head: docs/6061-unmapped-ambiguous-rule

📝 Commits (1)

89a9353 docs(javascript): state that duplicate unmapped content stays ambiguous

📊 Changes

1 file changed (+4 additions, -3 deletions)

View changed files

📝 docs/javascript-runtime-reconciliation.md (+4 -3)

📄 Description

What broke: Rule 6 in docs/javascript-runtime-reconciliation.md (added by #6214) says an unmapped script with "no unique content match" is unknown. But several matching digests give ambiguous (rule 4), so the rule contradicted the matcher.
Fix: Say "no content match", and state that several content matches stay ambiguous. This is the review fix that was pushed to #6214 after it had already been merged at e308f35c4.
Risk: None. Documentation wording only, and it now matches existing behaviour and tests.

Summary

Follow-up to #6214 (Fixes #6061). It addresses Greptile's review finding on #6214 (https://github.com/morluto/rea/pull/6214#discussion_r4344286828). The fix commit was pushed to that branch, but the PR had been merged at its previous head, so the change never reached main.

Problem and expected behavior

The matcher handles content candidates before it reaches the no-mapping rule: one digest gives matched, several give ambiguous, and only zero give unknown / no-authorized-location-mapping. The existing test "keeps unmapped content-only correspondence with 2 digest candidates" expects ambiguous. The docs should say the same.

Change and scope

docs/javascript-runtime-reconciliation.md rule 6: "no unique content match" becomes "no content match", plus a clause saying several content matches remain ambiguous under rule 4.
Contribution scope: not applicable (documentation fix).

Contract and boundary impact

Semantic owner and earliest changed stage: documentation of reconcileCapturedSource matching rules.
Contribution scope fit and linked maintainer decision: not applicable.
CLI and MCP/tool-catalog contract: none.
Provider, bridge, target-format, or platform compatibility: none.
Evidence, artifact, provenance, or reconstruction contract: none (wording now matches behaviour).
Generated metadata, package, or installation impact: none.
Documentation or usability only; no target interaction.

Evidence and regression coverage

Tests added or updated: none. The existing ambiguous-content test in javascriptRuntimeContentPriority.test.ts already covers the behaviour described.
Base reproduction or other evidence: source-derived comparison with the matcher and the existing test (above).
Remaining proof gaps: none.

Validation performed

npm run docs:check: passed on the identical commit c6cda443c (#6214 branch).
oxfmt --check docs/javascript-runtime-reconciliation.md: passed on this branch.

Compatibility, safety, and release

Breaking changes or migration steps: none.
Real Hopper/Ghidra, browser, or OS coverage: not applicable.
Package or release metadata impact: none.
Security, privacy, process, or containment review: none.

Author readiness

Human owner: @kaoru0822-kitauji

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6238 **Author:** [@kaoru0822-kitauji](https://github.com/kaoru0822-kitauji) **Created:** 10/22/2026 **Status:** ✅ Merged **Merged:** 10/22/2026 **Merged by:** [@kaoru0822-kitauji](https://github.com/kaoru0822-kitauji) **Base:** `main` ← **Head:** `docs/6061-unmapped-ambiguous-rule` --- ### 📝 Commits (1) - [`89a9353`](https://github.com/morluto/rea/commit/89a9353216a12d39375c2dc74a2e1f471770c385) docs(javascript): state that duplicate unmapped content stays ambiguous ### 📊 Changes **1 file changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `docs/javascript-runtime-reconciliation.md` (+4 -3) </details> ### 📄 Description **What broke:** Rule 6 in `docs/javascript-runtime-reconciliation.md` (added by #6214) says an unmapped script with "no unique content match" is `unknown`. But several matching digests give `ambiguous` (rule 4), so the rule contradicted the matcher. **Fix:** Say "no content match", and state that several content matches stay `ambiguous`. This is the review fix that was pushed to #6214 after it had already been merged at `e308f35c4`. **Risk:** None. Documentation wording only, and it now matches existing behaviour and tests. ## Summary Follow-up to #6214 (Fixes #6061). It addresses Greptile's review finding on #6214 (https://github.com/morluto/rea/pull/6214#discussion_r4344286828). The fix commit was pushed to that branch, but the PR had been merged at its previous head, so the change never reached main. ## Problem and expected behavior The matcher handles content candidates before it reaches the no-mapping rule: one digest gives `matched`, several give `ambiguous`, and only zero give `unknown` / `no-authorized-location-mapping`. The existing test "keeps unmapped content-only correspondence with 2 digest candidates" expects `ambiguous`. The docs should say the same. ## Change and scope - `docs/javascript-runtime-reconciliation.md` rule 6: "no unique content match" becomes "no content match", plus a clause saying several content matches remain `ambiguous` under rule 4. - Contribution scope: not applicable (documentation fix). ## Contract and boundary impact - Semantic owner and earliest changed stage: documentation of `reconcileCapturedSource` matching rules. - Contribution scope fit and linked maintainer decision: not applicable. - CLI and MCP/tool-catalog contract: none. - Provider, bridge, target-format, or platform compatibility: none. - Evidence, artifact, provenance, or reconstruction contract: none (wording now matches behaviour). - Generated metadata, package, or installation impact: none. - [x] Documentation or usability only; no target interaction. ## Evidence and regression coverage - Tests added or updated: none. The existing ambiguous-content test in `javascriptRuntimeContentPriority.test.ts` already covers the behaviour described. - Base reproduction or other evidence: source-derived comparison with the matcher and the existing test (above). - Remaining proof gaps: none. ## Validation performed - `npm run docs:check`: passed on the identical commit `c6cda443c` (#6214 branch). - `oxfmt --check docs/javascript-runtime-reconciliation.md`: passed on this branch. ## Compatibility, safety, and release - Breaking changes or migration steps: none. - Real Hopper/Ghidra, browser, or OS coverage: not applicable. - Package or release metadata impact: none. - Security, privacy, process, or containment review: none. ## Author readiness Human owner: @kaoru0822-kitauji - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:46:13 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#7215

No description provided.

Rows
Columns