morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #6243] [CLOSED] docs(il2cpp): explain ambiguous universal slice selection #7220

New issue

Closed

opened 2026-11-01 21:46:16 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:46:16 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6243
Author: @ShuaixinHuang
Created: 10/22/2026
Status: ❌ Closed

Base: main ← Head: codex/docs-il2cpp-ambiguous-slice

📝 Commits (2)

6a5b25a docs(il2cpp): explain ambiguous universal slice selection
ece7547 Merge remote-tracking branch 'origin/main' into codex/docs-il2cpp-ambiguous-slice

📊 Changes

1 file changed (+10 additions, -1 deletions)

View changed files

📝 docs/il2cpp-metadata.md (+10 -1)

📄 Description

Summary

Fixes #5752. The IL2CPP guide lists architecture selection requirements but omits the existing refusal when multiple universal Mach-O slices map to the same architecture. Explain unique selection, exact-subtype thinning and its limits, and add ambiguous-slice-selection to the unsupported-reason table.

Change and scope

One documentation file, 10 additions and 1 deletion. No parser, selector, schema, provider, evidence, package or generated-file changes. Scope decision: not applicable; documentation only.

Documentation or usability only; no target interaction.

Validation performed

Synchronized with upstream 2bcd7e6d, head ece75479; Windows x64, pinned Node 24.22.1 and locked dependencies:

npm run check: all six tasks, module boundaries and architecture guards passed.
npm run docs:check: all six tasks and five README consistency tests passed.
npm run test:focused -- tests/boundary/il2cpp/il2cppBinaryFile.test.ts: all 50 tests passed, including ambiguous FAT architecture refusal.
Oxfmt, git diff --check, commit hook and push-hook typecheck/lint passed.
Source inspection confirms ambiguity remains unsupported and thin binaries reject an architecture selector. No new tests were added for this prose-only change.
No local macOS/lipo or real Unity native-linking run. Exact-subtype example and recovery limits are supported by #5752's independent macOS reproduction; the synthetic existing test qualifies only REA's selection behavior.
Conflict resolved while preserving upstream's new invalid-method-token explanation and the original ambiguity/recovery guidance. Fresh online CI is pending; earlier-head results do not qualify this revision.

Author readiness

Human owner: @ShuaixinHuang

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6243 **Author:** [@ShuaixinHuang](https://github.com/ShuaixinHuang) **Created:** 10/22/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `codex/docs-il2cpp-ambiguous-slice` --- ### 📝 Commits (2) - [`6a5b25a`](https://github.com/morluto/rea/commit/6a5b25a767fc1dfd420fe5b445ec970b799946de) docs(il2cpp): explain ambiguous universal slice selection - [`ece7547`](https://github.com/morluto/rea/commit/ece75479da1cce18b6d72cba57bc9a9e2aa9e36c) Merge remote-tracking branch 'origin/main' into codex/docs-il2cpp-ambiguous-slice ### 📊 Changes **1 file changed** (+10 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `docs/il2cpp-metadata.md` (+10 -1) </details> ### 📄 Description ## Summary Fixes #5752. The IL2CPP guide lists architecture selection requirements but omits the existing refusal when multiple universal Mach-O slices map to the same architecture. Explain unique selection, exact-subtype thinning and its limits, and add `ambiguous-slice-selection` to the unsupported-reason table. ## Change and scope One documentation file, 10 additions and 1 deletion. No parser, selector, schema, provider, evidence, package or generated-file changes. Scope decision: not applicable; documentation only. - [x] Documentation or usability only; no target interaction. ## Validation performed Synchronized with upstream `2bcd7e6d`, head `ece75479`; Windows x64, pinned Node 24.22.1 and locked dependencies: - `npm run check`: all six tasks, module boundaries and architecture guards passed. - `npm run docs:check`: all six tasks and five README consistency tests passed. - `npm run test:focused -- tests/boundary/il2cpp/il2cppBinaryFile.test.ts`: all 50 tests passed, including ambiguous FAT architecture refusal. - Oxfmt, `git diff --check`, commit hook and push-hook typecheck/lint passed. - Source inspection confirms ambiguity remains unsupported and thin binaries reject an architecture selector. No new tests were added for this prose-only change. - No local macOS/lipo or real Unity native-linking run. Exact-subtype example and recovery limits are supported by #5752's independent macOS reproduction; the synthetic existing test qualifies only REA's selection behavior. - Conflict resolved while preserving upstream's new invalid-method-token explanation and the original ambiguity/recovery guidance. Fresh online CI is pending; earlier-head results do not qualify this revision. ## Author readiness Human owner: @ShuaixinHuang - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:46:16 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-03 13:39:54 +00:00

[PR #7220] [MERGED] fix(provider-selection): name whether a rejection came from availability or target support #7723

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#7220

No description provided.

Rows
Columns