[PR #7220] [MERGED] fix(provider-selection): name whether a rejection came from availability or target support #7723

New issue

Closed

opened 2026-11-03 13:39:54 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented 2026-11-03 13:39:54 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/7220
Author: @dxqlovestudy
Created: 10/26/2026
Status: ✅ Merged
Merged: 10/26/2026
Merged by: @gensokyo-dev

Base: main ← Head: fix/provider-rejection-origin

---

📝 Commits (3)

• 60b7a5c fix(provider-selection): name whether a rejection came from availability or target support
• 6f88f5b chore: merge current main for provider rejection validation
• 9eb726b fix(provider-selection): describe readiness without configuration assumptions

📊 Changes

6 files changed (+187 additions, -17 deletions)

View changed files

📝 docs/cli.md (+7 -1)
📝 src/application/binary/AnalysisProviderRegistry.test.ts (+125 -0)
📝 src/application/binary/AnalysisProviderRegistry.ts (+38 -15)
📝 src/domain/analysisErrorProjection.ts (+1 -0)
📝 src/domain/providerSelectionError.ts (+15 -1)
📝 src/native/pwntools/PwntoolsFailures.ts (+1 -0)

📄 Description

Summary

Fixes #7214. CLI and MCP provider-selection errors now distinguish local readiness rejections (origin: "availability") from observed target-support refusals (origin: "target"). Original provider IDs, codes, reasons, diagnostics, candidate ordering and explicit provider choices are preserved. The shared error owner makes one defensive diagnostic copy.

An availability-only error describes recorded readiness failures and the absence of a reported target refusal. It does not claim that the host has no configured providers, or infer target support. This includes invalid existing registrations and an explicit unavailable provider alongside a ready alternative. Documentation uses the same distinction.

Validation

Integrated current main b45a83368 and reviewed head 9eb726b1f:

• 116 focused registry, error-projection and pwntools input-limit tests pass. A new configured-but-unavailable/ready-alternative regression first failed on the original PR message, then passed. Mixed rejections retain the existing message.
• npm run check:fast and npm run docs:check pass. One concurrent build attempt was refused by the existing artifact lock; documentation validation completed the required artifacts afterward.
• Actual packaged CLI analyze /usr/bin/true --provider ida --json and stdio MCP open_binary were run with a private HOME in two cases: no IDA registration, and an invalid existing registration. Both adapters retain matching error projections, respectively not_configured/configured:false and open_options_invalid/configured:true; every recorded rejection gains its producer-derived origin. Exact main was run as the control and lacks these origin fields.
• Two cases across both adapters, 2-CPU affinity: control 14.697 s wall / 10.666 s CPU / 323.41 MiB sampled process-family peak; changed final compiled head 11.492 s / 10.765 s / 321.90 MiB. These are single contended samples, not a speedup claim. MCP replies grow from 3226/3242 to 3424/3440 bytes; no report or extra analysis call is added. Agent token usage was not measured. Complete probe responses remain local evidence.

No IDA/Ghidra process was launched, no remote endpoint was contacted, and no native Windows DOS reproduction is claimed. This fixes diagnostic provenance, not DOS admission. Hosted CI 40349759511: source tests, static checks, docs, package build, real binary-layout/recorded-crash/web-network checks, SQLite versions, Linux native baseline, and four portable shards pass. Shard 4 fails four ADB MCP cases; the actual merge-base main d9908fd7a has the identical four assertions and diagnostic in its own CI job. The same four cases pass locally on both original main b45 (59.131 s, 1870 MiB peak) and this PR (54.573 s, 2023 MiB peak). Three fail-fast-canceled shards remain unverified. This is an authorized baseline-failure bypass, not a green-CI claim.

Fresh Codex review reports no findings and Greptile is 5/5 at 9eb726b1f; the previous thread is resolved with root cause, structural fix, validation and limitations.

Author readiness

Human owner: @dxqlovestudy

• I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
• I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
• I declare this PR ready for initial maintainer review.

Before merge

• This PR addresses a concrete problem or an agreed enhancement.
• Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
• The PR has one focused outcome and the title follows type(scope): outcome.
• Related issue is linked, or the reason for not linking one is stated above.
• Tests cover changed observable behavior and meaningful failure paths.
• Owning docs, contracts, and generated metadata are updated where needed.
• User-visible CLI/MCP changes include representative output.
• I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/7220 **Author:** [@dxqlovestudy](https://github.com/dxqlovestudy) **Created:** 10/26/2026 **Status:** ✅ Merged **Merged:** 10/26/2026 **Merged by:** [@gensokyo-dev](https://github.com/gensokyo-dev) **Base:** `main` ← **Head:** `fix/provider-rejection-origin` --- ### 📝 Commits (3) - [`60b7a5c`](https://github.com/morluto/rea/commit/60b7a5ca492dfa27501ee7519597c7ad80e91c9b) fix(provider-selection): name whether a rejection came from availability or target support - [`6f88f5b`](https://github.com/morluto/rea/commit/6f88f5bfd6f012d5aa4b1a1417cecf341b9a777b) chore: merge current main for provider rejection validation - [`9eb726b`](https://github.com/morluto/rea/commit/9eb726b1f96602ce91493d533bc2c9f611dad37b) fix(provider-selection): describe readiness without configuration assumptions ### 📊 Changes **6 files changed** (+187 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `docs/cli.md` (+7 -1) 📝 `src/application/binary/AnalysisProviderRegistry.test.ts` (+125 -0) 📝 `src/application/binary/AnalysisProviderRegistry.ts` (+38 -15) 📝 `src/domain/analysisErrorProjection.ts` (+1 -0) 📝 `src/domain/providerSelectionError.ts` (+15 -1) 📝 `src/native/pwntools/PwntoolsFailures.ts` (+1 -0) </details> ### 📄 Description ## Summary Fixes #7214. CLI and MCP provider-selection errors now distinguish local readiness rejections (`origin: "availability"`) from observed target-support refusals (`origin: "target"`). Original provider IDs, codes, reasons, diagnostics, candidate ordering and explicit provider choices are preserved. The shared error owner makes one defensive diagnostic copy. An availability-only error describes recorded readiness failures and the absence of a reported target refusal. It does not claim that the host has no configured providers, or infer target support. This includes invalid existing registrations and an explicit unavailable provider alongside a ready alternative. Documentation uses the same distinction. ## Validation Integrated current main `b45a83368` and reviewed head `9eb726b1f`: - 116 focused registry, error-projection and pwntools input-limit tests pass. A new configured-but-unavailable/ready-alternative regression first failed on the original PR message, then passed. Mixed rejections retain the existing message. - `npm run check:fast` and `npm run docs:check` pass. One concurrent build attempt was refused by the existing artifact lock; documentation validation completed the required artifacts afterward. - Actual packaged CLI `analyze /usr/bin/true --provider ida --json` and stdio MCP `open_binary` were run with a private HOME in two cases: no IDA registration, and an invalid existing registration. Both adapters retain matching error projections, respectively `not_configured/configured:false` and `open_options_invalid/configured:true`; every recorded rejection gains its producer-derived origin. Exact main was run as the control and lacks these origin fields. - Two cases across both adapters, 2-CPU affinity: control 14.697 s wall / 10.666 s CPU / 323.41 MiB sampled process-family peak; changed final compiled head 11.492 s / 10.765 s / 321.90 MiB. These are single contended samples, not a speedup claim. MCP replies grow from 3226/3242 to 3424/3440 bytes; no report or extra analysis call is added. Agent token usage was not measured. Complete probe responses remain local evidence. No IDA/Ghidra process was launched, no remote endpoint was contacted, and no native Windows DOS reproduction is claimed. This fixes diagnostic provenance, not DOS admission. Hosted CI [40349759511](https://github.com/morluto/rea/actions/runs/40349759511): source tests, static checks, docs, package build, real binary-layout/recorded-crash/web-network checks, SQLite versions, Linux native baseline, and four portable shards pass. Shard 4 fails four ADB MCP cases; the actual merge-base main `d9908fd7a` has the identical four assertions and diagnostic in its own [CI job](https://github.com/morluto/rea/actions/runs/40349559391/job/121666788797). The same four cases pass locally on both original main b45 (59.131 s, 1870 MiB peak) and this PR (54.573 s, 2023 MiB peak). Three fail-fast-canceled shards remain unverified. This is an authorized baseline-failure bypass, not a green-CI claim. Fresh Codex review reports no findings and Greptile is 5/5 at `9eb726b1f`; the previous thread is resolved with root cause, structural fix, validation and limitations. ## Author readiness <!-- The human owner completes these declarations before requesting review. The PR author is the owner by default. A different owner must explicitly accept ownership on this PR. AI agents must leave these declarations to a human to dictate to them or there could be catastrophic consequences for many users of REA. Draft PRs may leave them unchecked. These declarations record initial readiness when opening the PR for review; later pushes do not require a new human sign-off. Keep the description and validation evidence current as the work changes. See CONTRIBUTING.md#pull-request-ownership-and-readiness. --> Human owner: @dxqlovestudy - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge - [ ] This PR addresses a concrete problem or an agreed enhancement. - [ ] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [ ] The PR has one focused outcome and the title follows `type(scope): outcome`. - [ ] Related issue is linked, or the reason for not linking one is stated above. - [ ] Tests cover changed observable behavior and meaningful failure paths. - [ ] Owning docs, contracts, and generated metadata are updated where needed. - [ ] User-visible CLI/MCP changes include representative output. - [ ] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

bsakaguchi 2026-11-03 13:39:54 +00:00

• closed this issue
• added the
  pull-request
  label

bsakaguchi referenced this issue 2026-11-05 01:48:00 +00:00

[PR #7360] fix(cli): admit native data type selectors before opening a target #7834

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

codex/procedure-reference-stacked

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels   

area: bridge

  

area: bridge

  

area: build

  

area: build

  

area: build

  

area: cli

  

area: domain

  

area: evidence

  

area: mcp

  

area: native

  

area: providers

  

area: runtime

  

area: server

  

area: setup

  

area: tests

  

bug

  

design

  

documentation

  

enhancement

  

enhancement

  

enhancement

  

experiment

  

help wanted

  

i18n

  

invalid

  

P0: critical

  

P1: high

  

P2: medium

  

P2: medium

  

P2: medium

  

P3: low

  

performance

  

provider-request

  

pull-request

Mirrored from GitHub Pull Request

  

question

  

roadmap

  

triage

No labels

area: bridge

area: bridge

area: build

area: build

area: build

area: cli

area: domain

area: evidence

area: mcp

area: native

area: providers

area: runtime

area: server

area: setup

area: tests

bug

design

documentation

enhancement

enhancement

enhancement

experiment

help wanted

i18n

invalid

P0: critical

P1: high

P2: medium

P2: medium

P2: medium

P3: low

performance

provider-request

pull-request

question

roadmap

triage

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#7723

No description provided.