mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
Closed
opened 2026-11-01 21:46:21 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#7232
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/6255
Author: @kaoru0822-kitauji
Created: 10/22/2026
Status: ✅ Merged
Merged: 10/22/2026
Merged by: @kaoru0822-kitauji
Base:
main← Head:fix/5541-nib-boolean-values📝 Commits (1)
b0efe92fix(apple): decode NIBArchive booleans with AppKit's polarity📊 Changes
5 files changed (+177 additions, -33 deletions)
View changed files
📝
docs/testing.md(+3 -1)📝
scripts/verify/apple/interface-builder.mjs(+100 -8)📝
src/artifacts/apple/NibArchive.fixture.ts(+2 -1)📝
src/artifacts/apple/NibArchive.test.ts(+31 -0)📝
src/artifacts/apple/NibArchive.ts(+41 -23)📄 Description
What broke:
decode-interface-builderinverted every boolean stored in a compiled NIBArchive: the decoder read type tag 4 astrueand tag 5 asfalse. The test fixture encoder used the same reversed mapping, so round-trip tests could not catch it (#5541).Fix: the value-type tags are now named once (
booleanFalse: 4,booleanTrue: 5) and used by both the read and skip paths. The fixture encoder writes the format's tags, a unit test pins the raw tag bytes, andverify:interface-builderchecks both polarities againstibtool --export.Risk: low. NIB booleans in
nibValuesnow come back with the correct value. No schema change, and no code insrc/interprets these booleans.Summary
Fixes #5541. On main,
NSControlContinuous,NSControlRefusesFirstResponder,NSEnabled,NSWindowIsRestorableand every other boolean in a compiled AppKit NIBArchive decoded to the opposite of its stored value. With this change they match the value AppKit's own nib decoder returns.Problem and expected behavior
The NIBArchive value table stores booleans as payload-free type tags.
readValueinsrc/artifacts/apple/NibArchive.tsmapped4 → true,5 → false. Apple's own decoder reads them the other way round:-[NSCoder decodeBoolForKey:]on the nib decoder returns NO for tag 4 and YES for tag 5, as the evidence below shows. Callers should get the serialized value. The issue's oracle,ibtool --export, reports the same polarity for the source documents.Change and scope
NibArchive.ts: aNibValueTypetable names all 11 value tags.readValueandskipValueboth switch on it instead of on bare numbers, so the boolean polarity is defined in one place. Tag 4 now decodes asfalseand tag 5 astrue. Payload sizes are unchanged.NibArchive.fixture.ts: the encoder writestrueas 5 andfalseas 4. It keeps literal bytes rather than importing the decoder's table, so it does not inherit the decoder's assumption.NibArchive.test.ts: a new test writes raw tags 4 and 5 into a value table and expectsfalseandtrue. It does not depend on how the fixture encodes booleans.scripts/verify/apple/interface-builder.mjs(the macOS CIapple-artifactslane, where Xcode is available): after the existing checks, the script makes a copy ofMain.xibwithcontinuousandrefusesFirstRespondertoggled (viaibtool --import) and compiles both sources. It then requires the public CLI'sNSButtonnibValuesto equalibtool --exportfor each source: false/false and true/true. This replays the restoration check proposed in the issue.docs/testing.md: describes the added verification.Contribution scope: ordinary fix within existing boundaries; maintainer scope decision not applicable.
Contract and boundary impact
Semantic owner and earliest changed stage: NIBArchive value decoding (
src/artifacts/apple/NibArchive.ts).Contribution scope fit and linked maintainer decision: ordinary fix; not applicable.
CLI and MCP/tool-catalog contract: no schema change. Boolean values in
nibValuesfrom NIBArchive documents now have the correct polarity.Provider, bridge, target-format, or platform compatibility: NIBArchive only.
Evidence, artifact, provenance, or reconstruction contract: observed field values are corrected. Identity, digests and coverage are unchanged.
Target selection, authority, upstream behavior, and cleanup details (if applicable): not applicable.
Generated metadata (
docs/public/product-catalog.json), package, or installation impact: none.Read existing files or captured data.
Launch or attach to a process.
Inject instrumentation or run scripts/code.
Change process memory, registers, files, or configuration.
Contact network services.
Recover protected code or work around protections.
Documentation or usability only; no target interaction.
Not sure yet; investigation or maintainer guidance needed.
Evidence and regression coverage
Tests added or updated: raw-tag unit test in
NibArchive.test.ts; corrected fixture encoder;ibtool --exportcomparison of both polarities inverify:interface-builder.Base reproduction (executed, macOS 26 arm64, this host has Command Line Tools but no Xcode
ibtool):NSNiband logs every value that AppKit's nib decoder returns fromdecodeBoolForKey:for keys present in the archive. Each nib is placed alone in an isolatedFixture.app, and the harness compares the per-key true/false counts with the public CLI'snibValuesbooleans.c537c52c9, using real Apple-compiled nibs (TextEditDocumentWindow.nib, Problem ReporterProblemReporterMain.nib, MailExtensionEnablementConfirmation.nib), all 29 compared keys disagree and every count is exactly swapped. Examples:NSControlContinuousAppKit true/false = (0, 7) vs REA (7, 0);NSWindowIsRestorable(1, 0) vs (0, 1)./System/Applicationsand/System/Library/CoreServices, agrees on 502 of 503 key comparisons. The one difference isNSAnimatesin aMainMenu.nib: AppKit returned 1 true while REA reports 1 true and 4 false. AppKit simply did not calldecodeBoolForKey:for 4 archived fields, and the polarity agrees.User-visible CLI/MCP output (executed, TextEdit
DocumentWindow.nib): the CLI'snibValuesfor its 2 controls now reportNSControlContinuous: falseandNSControlRefusesFirstResponder: false, the values AppKit decodes (base reportedtrue). The issue'sMain.xib/ toggled outputs are proposed checks, left to the CI lane.Remaining proof gaps: Xcode
ibtoolis unavailable on this host, so the newverify:interface-buildersteps have not run against realibtoolhere. Theiribtool --import/--exportinvocations copy the issue's executed reproduction. I ran the script end to end with a stand-inibtoolthat emits a NIBArchive with raw tags. Against the base build it fails at the false-polarity assertion; with this change it passes. The macOS CI lane will run it against real Xcode. Storyboard/UIKit NIBArchives were not exercised separately; they share the same value decoder.Observed, derived, and inferred claims remain distinguishable.
Artifact identity, source provenance, and failed attempts remain preserved.
Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.
Validation performed
npm run test:focused -- src/artifacts/apple/NibArchive.test.ts src/artifacts/apple/AppleAssetCatalogAnalysis.test.ts src/domain/apple/interfaceBuilderGraph.test.ts tests/boundary/filesystem/interfaceBuilderBundle.test.ts tests/boundary/filesystem/nibNativeHierarchy.test.ts tests/acceptance/applications/nibFieldIdentity.test.ts tests/acceptance/applications/assetCatalogResourceKeys.test.ts: 7 files passed, 105 tests passed, 7 skipped (Xcode-gated)npm run test:local -- src/artifacts/apple/NibArchive.test.tswith the decoder reverted: 2 failed, 4 passeddecodeBoolForKey:oracle vs public CLI, 3 real nibs: base 0/29 keys agree; this change 29/29node scripts/verify/apple/interface-builder.mjswith a stand-inibtool: fails on the base build at the false-polarity assertion, passes with this changenpm run check:fast: passednpm run format:check: passednpm run docs:check: passedCompatibility, safety, and release
ibtoolcoverage comes from the CIapple-artifactslane.ibtool --import/--exportandplutilon temporary fixture files only.Author readiness
Human owner: @kaoru0822-kitauji
Before merge
type(scope): outcome.🤖 Generated with Claude Code
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.