[PR #6295] [CLOSED] fix(process): retain contradictions in comparison aggregates #7261

New issue

Closed

opened 2026-11-01 21:46:34 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:46:34 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6295
Author: @harshitethic
Created: 10/22/2026
Status: ❌ Closed

Base: main ← Head: fix/process-comparison-contradictions

📝 Commits (1)

6b02eed fix(process): retain contradictions in comparison aggregates

📊 Changes

2 files changed (+24 additions, -0 deletions)

View changed files

📝 src/domain/changedBehavior.test.ts (+23 -0)
📝 src/domain/process/processComparison.ts (+1 -0)

📄 Description

Status: superseded upstream

Closing this duplicate because #6298 was merged as 77c72b96aa01b74f5f1e6dc2e1b737bd0fd1ee0e, resolving #6218. Inspection of current main 80d5c8dc80c65bed9b7409f0bdd059e024a34ac4 confirms the identical aggregate correction is present, with broader domain and MCP regression coverage in the merged change. No merge of this PR is needed.

The validation below records this PR's original branch; it is not a claim that this PR was merged or that we authored the upstream replacement.

Summary

Addresses #6218 (resolved upstream by #6298). A process comparison with a contradictory dimension could validate with an unchanged aggregate. Preserve contradiction in the shared aggregate derivation, after truncation and before ordinary changes, so schema admission and downstream consumers agree.

Evidence and validation

The original regression failed on the base: the inconsistent aggregate was accepted.
Revalidated commit 6b02eed7bdea8cf01c8ca7af604ac0d760a6431e on Linux x64 with pinned Node 24.18.0/npm 11.16.0 and npm ci.
npm run test:focused -- src/domain/changedBehavior.test.ts src/domain/reconstructionVerification.test.ts — 19 passed.
npm run check, npm run verify:test-discovery, and npm run docs:check — passed; docs included 9 README-consistency tests.

Existing unchanged controls remain accepted; a contradictory aggregate is accepted only when its dimensions justify it. No native process capture, browser, or real decompiler lane was exercised for this PR. The full deterministic suite and other platforms were not run locally. This is a domain validation correction with no new target interaction, package changes, or integration scope expansion. Local checks do not establish passing upstream CI.

Author readiness

Human owner: @harshitethic

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

AI-assisted draft pending human review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6295 **Author:** [@harshitethic](https://github.com/harshitethic) **Created:** 10/22/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/process-comparison-contradictions` --- ### 📝 Commits (1) - [`6b02eed`](https://github.com/morluto/rea/commit/6b02eed7bdea8cf01c8ca7af604ac0d760a6431e) fix(process): retain contradictions in comparison aggregates ### 📊 Changes **2 files changed** (+24 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/changedBehavior.test.ts` (+23 -0) 📝 `src/domain/process/processComparison.ts` (+1 -0) </details> ### 📄 Description ## Status: superseded upstream Closing this duplicate because #6298 was merged as `77c72b96aa01b74f5f1e6dc2e1b737bd0fd1ee0e`, resolving #6218. Inspection of current main `80d5c8dc80c65bed9b7409f0bdd059e024a34ac4` confirms the identical aggregate correction is present, with broader domain and MCP regression coverage in the merged change. No merge of this PR is needed. The validation below records this PR's original branch; it is not a claim that this PR was merged or that we authored the upstream replacement. ## Summary Addresses #6218 (resolved upstream by #6298). A process comparison with a contradictory dimension could validate with an `unchanged` aggregate. Preserve `contradiction` in the shared aggregate derivation, after truncation and before ordinary changes, so schema admission and downstream consumers agree. ## Evidence and validation - The original regression failed on the base: the inconsistent aggregate was accepted. - Revalidated commit `6b02eed7bdea8cf01c8ca7af604ac0d760a6431e` on Linux x64 with pinned Node 24.18.0/npm 11.16.0 and `npm ci`. - `npm run test:focused -- src/domain/changedBehavior.test.ts src/domain/reconstructionVerification.test.ts` — 19 passed. - `npm run check`, `npm run verify:test-discovery`, and `npm run docs:check` — passed; docs included 9 README-consistency tests. Existing unchanged controls remain accepted; a contradictory aggregate is accepted only when its dimensions justify it. No native process capture, browser, or real decompiler lane was exercised for this PR. The full deterministic suite and other platforms were not run locally. This is a domain validation correction with no new target interaction, package changes, or integration scope expansion. Local checks do not establish passing upstream CI. ## Author readiness Human owner: @harshitethic - [ ] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [ ] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [ ] I declare this PR ready for initial maintainer review. AI-assisted draft pending human review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:46:34 +00:00