morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #7262] [CLOSED] fix(scripts): format the APK signature verifier import #7757

New issue

Closed

opened 2026-11-03 13:40:11 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-03 13:40:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/7262
Author: @XiaoBinGan
Created: 10/26/2026
Status: ❌ Closed

Base: main ← Head: fix/apk-verifier-format

📝 Commits (1)

81fa99c fix(scripts): format the APK signature verifier import

📊 Changes

1 file changed (+1 additions, -4 deletions)

View changed files

📝 scripts/verify-apk-signature.mjs (+1 -4)

📄 Description

Summary

npm run format:check fails on main at 624ebb2a1, so the Static checks job fails for every pull request opened against it. This restores the formatted state of the one file responsible.

Problem and expected behavior

662ec2e45 (fix(verifiers): preserve source Evidence through shared admission) widened one import in scripts/verify-apk-signature.mjs:

import {
  mcpTextValue,
  requireMcpOutput,
} from "./lib/mcp-verifier-results.mjs";

oxfmt fits that specifier list on one line, so the committed form is unformatted. format:check runs first in Static checks and exits 1, which is why unrelated PRs fail there:

> oxfmt --check .
Checking formatting...

scripts/verify-apk-signature.mjs

Format issues found in above 1 files. Run without `--check` to fix.

Expected: npm run format:check exits 0 on main. Actual: it exits 1.

Change and scope

Ran the repository formatter on that one file. The whole diff is the import returning to one line, 1 insertion and 4 deletions. No behavior changes, no other file touched.

Intentionally not included: any reformatting beyond this file, and any edit to the max-lines warning oxlint already reports for this script (pre-existing, present on main, and not an error).

Contract and boundary impact

Semantic owner and earliest changed stage: none. This is whitespace inside an ES module import list in a verifier script; the parsed module is identical.
Contribution scope fit and linked maintainer decision: not applicable. Ordinary fix within existing boundaries, restoring a repository invariant that a recent commit broke.
CLI and MCP/tool-catalog contract: none.
Provider, bridge, target-format, or platform compatibility: none. The script's imports and behavior are unchanged.
Evidence, artifact, provenance, or reconstruction contract: none.
Target selection, authority, upstream behavior, and cleanup details (if applicable): none.
Generated metadata (docs/public/product-catalog.json), package, or installation impact: none.

Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.

Read existing files or captured data.
Launch or attach to a process.
Inject instrumentation or run scripts/code.
Change process memory, registers, files, or configuration.
Contact network services.
Recover protected code or work around protections.
Documentation or usability only; no target interaction.
Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

Tests added or updated: none. format:check is the regression check, and it is part of Static checks.
Base reproduction or other evidence: on a clean checkout of upstream/main at 624ebb2a1, with no local changes, npm run format:check exits 1 and names only scripts/verify-apk-signature.mjs. After this change it exits 0 over the same 6089 files.
User-visible CLI/MCP output (if applicable): none.
Remaining proof gaps: none for the invariant being restored.

Independent confirmation that this is a main break rather than a per-PR problem: two unrelated open PRs also report Static checks failed on this same base — #7261 (ArjenS-LA, run started 17:30:39Z) and #7258 (BeqaKs, run started 16:50:25Z).

For boundary fixes: not applicable. No boundary or lifecycle behavior changes.

For evidence-bearing changes: not applicable. This change adds or alters no observed, derived, or inferred claim.

Validation performed

npm run format:check (on upstream/main @ 624ebb2a1, unmodified) — exit 1, scripts/verify-apk-signature.mjs reported
npm run format:check (with this change) — exit 0, "All matched files use the correct format.", 6089 files
npx oxfmt --check scripts/verify-apk-signature.mjs — exit 0
npx oxlint scripts/verify-apk-signature.mjs — exit 0, "Found 1 warning and 0 errors." (the max-lines warning is present on main too)

Compatibility, safety, and release

Breaking changes or migration steps: none.
Real Hopper/Ghidra, browser, or OS coverage: not applicable. Unrelated to provider launch.
Package or release metadata impact: none. The file is a repository verifier script, not shipped runtime code.
Security, privacy, process, or containment review: none. Whitespace only.

Author readiness

Human owner: @XiaoBinGan

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

Before merge

This PR addresses a concrete problem or an agreed enhancement.
Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
The PR has one focused outcome and the title follows type(scope): outcome.
Related issue is linked, or the reason for not linking one is stated above.
Tests cover changed observable behavior and meaningful failure paths.
Owning docs, contracts, and generated metadata are updated where needed.
User-visible CLI/MCP changes include representative output.
I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/7262 **Author:** [@XiaoBinGan](https://github.com/XiaoBinGan) **Created:** 10/26/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/apk-verifier-format` --- ### 📝 Commits (1) - [`81fa99c`](https://github.com/morluto/rea/commit/81fa99c545f32cb0d4344c3c917512c9ec96904d) fix(scripts): format the APK signature verifier import ### 📊 Changes **1 file changed** (+1 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `scripts/verify-apk-signature.mjs` (+1 -4) </details> ### 📄 Description ## Summary `npm run format:check` fails on `main` at `624ebb2a1`, so the `Static checks` job fails for every pull request opened against it. This restores the formatted state of the one file responsible. ## Problem and expected behavior `662ec2e45` (*fix(verifiers): preserve source Evidence through shared admission*) widened one import in `scripts/verify-apk-signature.mjs`: ```js import { mcpTextValue, requireMcpOutput, } from "./lib/mcp-verifier-results.mjs"; ``` `oxfmt` fits that specifier list on one line, so the committed form is unformatted. `format:check` runs first in `Static checks` and exits 1, which is why unrelated PRs fail there: ``` > oxfmt --check . Checking formatting... scripts/verify-apk-signature.mjs Format issues found in above 1 files. Run without `--check` to fix. ``` Expected: `npm run format:check` exits 0 on `main`. Actual: it exits 1. ## Change and scope Ran the repository formatter on that one file. The whole diff is the import returning to one line, 1 insertion and 4 deletions. No behavior changes, no other file touched. Intentionally not included: any reformatting beyond this file, and any edit to the `max-lines` warning `oxlint` already reports for this script (pre-existing, present on `main`, and not an error). ## Contract and boundary impact - Semantic owner and earliest changed stage: none. This is whitespace inside an ES module import list in a verifier script; the parsed module is identical. - Contribution scope fit and linked maintainer decision: not applicable. Ordinary fix within existing boundaries, restoring a repository invariant that a recent commit broke. - CLI and MCP/tool-catalog contract: none. - Provider, bridge, target-format, or platform compatibility: none. The script's imports and behavior are unchanged. - Evidence, artifact, provenance, or reconstruction contract: none. - Target selection, authority, upstream behavior, and cleanup details (if applicable): none. - Generated metadata (`docs/public/product-catalog.json`), package, or installation impact: none. Expected effects (check known effects; use documentation-only on its own). Unchecked items do not establish absence; leave uncertainties visible. - [ ] Read existing files or captured data. - [ ] Launch or attach to a process. - [ ] Inject instrumentation or run scripts/code. - [ ] Change process memory, registers, files, or configuration. - [ ] Contact network services. - [ ] Recover protected code or work around protections. - [x] Documentation or usability only; no target interaction. - [ ] Not sure yet; investigation or maintainer guidance needed. ## Evidence and regression coverage - Tests added or updated: none. `format:check` is the regression check, and it is part of `Static checks`. - Base reproduction or other evidence: on a clean checkout of `upstream/main` at `624ebb2a1`, with no local changes, `npm run format:check` exits 1 and names only `scripts/verify-apk-signature.mjs`. After this change it exits 0 over the same 6089 files. - User-visible CLI/MCP output (if applicable): none. - Remaining proof gaps: none for the invariant being restored. Independent confirmation that this is a `main` break rather than a per-PR problem: two unrelated open PRs also report `Static checks` failed on this same base — #7261 (`ArjenS-LA`, run started 17:30:39Z) and #7258 (`BeqaKs`, run started 16:50:25Z). For boundary fixes: not applicable. No boundary or lifecycle behavior changes. For evidence-bearing changes: not applicable. This change adds or alters no observed, derived, or inferred claim. ## Validation performed - `npm run format:check` (on `upstream/main` @ `624ebb2a1`, unmodified) — exit 1, `scripts/verify-apk-signature.mjs` reported - `npm run format:check` (with this change) — exit 0, "All matched files use the correct format.", 6089 files - `npx oxfmt --check scripts/verify-apk-signature.mjs` — exit 0 - `npx oxlint scripts/verify-apk-signature.mjs` — exit 0, "Found 1 warning and 0 errors." (the `max-lines` warning is present on `main` too) ## Compatibility, safety, and release - Breaking changes or migration steps: none. - Real Hopper/Ghidra, browser, or OS coverage: not applicable. Unrelated to provider launch. - Package or release metadata impact: none. The file is a repository verifier script, not shipped runtime code. - Security, privacy, process, or containment review: none. Whitespace only. ## Author readiness Human owner: @XiaoBinGan - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-03 13:40:11 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#7757

No description provided.

Rows
Columns