[PR #6297] [CLOSED] fix(cli): align repeatable inputs with canonical array bounds #7264

New issue

Closed

opened 2026-11-01 21:46:35 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:46:35 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6297
Author: @harshitethic
Created: 10/22/2026
Status: ❌ Closed

Base: main ← Head: fix/cli-path-array-limits

📝 Commits (5)

a09d5c5 fix(cli): expose enforced companion path array limits
ab60902 chore: sync companion path limits with upstream main
073cc53 fix(cli): align repeatable inputs with canonical array bounds
7443435 chore: preserve main imports outside CLI bounds fix
49fb91a chore: incorporate the verified evaluation fixture correction

📊 Changes

5 files changed (+79 additions, -3 deletions)

View changed files

📝 src/cli/adbCommands.ts (+5 -1)
📝 src/domain/adb/adbDeviceAnalysis.ts (+5 -2)
📝 tests/boundary/cli/adbCli.test.ts (+21 -0)
📝 tests/boundary/cli/cliInputSchemaRequired.test.ts (+1 -0)
➕ tests/boundary/cli/pathArrayLimits.test.ts (+47 -0)

📄 Description

Summary

Fixes #6291. The CLI now enforces and advertises the existing 16-item limits for companion paths and ADB activity extras. ADB's serialized --extra field shares the domain maximum; JavaScript and WASM use the canonical contracts already on main.

Validation

Merged main ab720b421 while preserving contributor history.
54 focused tests passed across pathArrayLimits, cliInputSchemaRequired, and adbCli: schemas and parsers admit 16/reject 17; actual CLI calls reject overflow before workflow admission; 16 ADB extras reach the availability check.
Runtime build, check:fast, and test discovery passed with the pinned Node/npm toolchain.
No ADB device, WABT, or Wakaru engine was exercised. Current-head GitHub CI remains a separate gate.

This PR remains a draft for its human owner to review and complete the declarations below.

Shared CI fixture correction: main ab720b421 retains the Notes trace’s partial static coverage. Its 12 known-answer/report-gate tests, fast checks, and docs verification passed. The feature-specific checks above remain applicable.

Author readiness

Human owner: @harshitethic

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

AI-assisted draft pending human review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6297 **Author:** [@harshitethic](https://github.com/harshitethic) **Created:** 10/22/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/cli-path-array-limits` --- ### 📝 Commits (5) - [`a09d5c5`](https://github.com/morluto/rea/commit/a09d5c5b43755e4c24c2bde49387c3b077be54f9) fix(cli): expose enforced companion path array limits - [`ab60902`](https://github.com/morluto/rea/commit/ab60902ed654f316c13096a3908c3f3cff6033d3) chore: sync companion path limits with upstream main - [`073cc53`](https://github.com/morluto/rea/commit/073cc53e7665c5d05e747f46eb760a75a9dd086e) fix(cli): align repeatable inputs with canonical array bounds - [`7443435`](https://github.com/morluto/rea/commit/74434357633fc6cbe1e697b516e461292278435e) chore: preserve main imports outside CLI bounds fix - [`49fb91a`](https://github.com/morluto/rea/commit/49fb91a246f13313571cbe993fafdb9da2f5774f) chore: incorporate the verified evaluation fixture correction ### 📊 Changes **5 files changed** (+79 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/cli/adbCommands.ts` (+5 -1) 📝 `src/domain/adb/adbDeviceAnalysis.ts` (+5 -2) 📝 `tests/boundary/cli/adbCli.test.ts` (+21 -0) 📝 `tests/boundary/cli/cliInputSchemaRequired.test.ts` (+1 -0) ➕ `tests/boundary/cli/pathArrayLimits.test.ts` (+47 -0) </details> ### 📄 Description ## Summary Fixes #6291. The CLI now enforces and advertises the existing 16-item limits for companion paths and ADB activity extras. ADB's serialized `--extra` field shares the domain maximum; JavaScript and WASM use the canonical contracts already on main. ## Validation - Merged main `ab720b421` while preserving contributor history. - 54 focused tests passed across `pathArrayLimits`, `cliInputSchemaRequired`, and `adbCli`: schemas and parsers admit 16/reject 17; actual CLI calls reject overflow before workflow admission; 16 ADB extras reach the availability check. - Runtime build, `check:fast`, and test discovery passed with the pinned Node/npm toolchain. - No ADB device, WABT, or Wakaru engine was exercised. Current-head GitHub CI remains a separate gate. This PR remains a draft for its human owner to review and complete the declarations below. Shared CI fixture correction: main `ab720b421` retains the Notes trace’s partial static coverage. Its 12 known-answer/report-gate tests, fast checks, and docs verification passed. The feature-specific checks above remain applicable. ## Author readiness Human owner: @harshitethic - [ ] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [ ] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [ ] I declare this PR ready for initial maintainer review. AI-assisted draft pending human review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:46:35 +00:00