morluto/rea
1
0
Fork 0
mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00
Code Issues 1.3k Projects Packages Wiki Activity

[PR #7471] fix(apk): validate classic ZIP disk declarations #7858

New issue
Open
opened 2026-11-05 01:48:11 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-11-05 01:48:11 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/7471
Author: @wunianze666-netizen
Created: 10/27/2026
Status: 🔄 Open

Base: main ← Head: codex/apk-classic-zip-disks

📝 Commits (2)

  • 30ae641 fix(apk): validate classic ZIP disk declarations
  • 0369595 merge: integrate upstream CI baseline repairs for APK framing

📊 Changes

5 files changed (+160 additions, -10 deletions)

View changed files

📝 docs/apk-signature.md (+8 -1)
📝 src/apkSignature/apkSignatureFailures.ts (+7 -0)
📝 src/domain/apkSignature/apkSigningBlock.test.ts (+59 -0)
📝 src/domain/apkSignature/apkSigningBlock.ts (+34 -6)
📝 tests/acceptance/apkZip64FramingCli.test.ts (+52 -3)

📄 Description

Summary

Fixes #7433. Refuse classic ZIP disk declarations that the selected file cannot resolve before APK signing inspection reports absent signing schemes.

Problem and expected behavior

A generated two-entry ZIP with only its classic EOCD disk number changed to1 was accepted as observed, unsigned signing Evidence, while the artifact inventory refused the same bytes as split ZIP. A nonzero directory disk and contradictory per-disk entry count were also accepted. Nonlocal disk declarations now return unsupported_target; inconsistent single-disk counts return invalid_request. Valid single-disk and existing Zip64 controls remain supported.

Change and scope

The existing APK tail owner consumes already-parsed EOCD facts and checks classic layout admission before selecting a local directory span. Both ordinary classic and count-saturated/no-Zip64 return paths use that one check. The existing tagged Result and error mapper carry the refusal through CLI/MCP. No new provider or execution authority.

Follow the contribution scope.
Unresolved scope, authority, side effects, or required verification block
integration. Link the required maintainer scope decision for new providers or
capabilities involving target execution, injection, mutation, or protection
recovery; ordinary fixes within existing boundaries may state "not applicable".
Draft PRs may leave the scope decision pending and the readiness and merge checklists
unchecked. Maintainers can help resolve open questions.

Contract and boundary impact

  • Semantic owner and earliest changed stage: APK central-directory resolution in apkSigningBlock.ts, consuming canonical zipEndOfCentralDirectory candidates; both classic return paths share classicDirectory. No binary-field reinterpretation is added downstream.
  • Contribution scope fit and linked maintainer decision: ordinary static-parser correction in the existing APK inspection boundary; separate scope decision not applicable.
  • CLI and MCP/tool-catalog contract: existing inspect-apk-signature / inspect_apk_signature request and result schemas stay unchanged. Previously accepted unsupported/malformed layouts now use existing typed error categories instead of successful signing Evidence.
  • Provider, bridge, target-format, or platform compatibility: builtin dependency-free APK framing; no Android SDK, device, external engine or genuine split-set support added. Existing Zip64 parsing remains on its original path.
  • Evidence, artifact, provenance, or reconstruction contract: successful controls retain selected path, original SHA256/size and no-runtime-execution fact. Refused inputs produce no signing report, so absence is not promoted from an unresolved layout.
  • Target selection, authority, upstream behavior, and cleanup details (if applicable): existing caller-selected local-file reads only; no target execution, mutation, network activity or new cleanup owner.
  • Generated metadata (docs/public/product-catalog.json), package, or installation impact (CI generates and validates ignored catalogs and skills/; edit authored instructions in .agents/skills/reverse-engineer-anything/ and never commit build outputs): no package/lock/schema/install changes; generated outputs remain ignored.

Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.

  • Read existing files or captured data.
  • Launch or attach to a process.
  • Inject instrumentation or run scripts/code.
  • Change process memory, registers, files, or configuration.
  • Contact network services.
  • Recover protected code or work around protections.
  • Documentation or usability only; no target interaction.
  • Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

  • Tests added or updated: the seven domain controls and one CLI/MCP scenario remain intact. On the current ordinary-merge tree, all83 controls in six focused files passed,0skip; the three build tasks passed. Docs9 repeated by docs:check are not added again.
  • Base reproduction or other evidence: ordinary merge 03695956bca23aef59cb8622ae5cd8bf589b7f08 integrates frozen main ad7d4c1f4dd9cbd93229ee330e66c7a522e723e6, including relevant upstream #7349/#7479 baseline repairs. Its parents are30ae6416+ad7d4c1f, tree05f0e21d08c231535ebfe378994175b6741b1cbd. No conflict or manual feature edit was needed; relative to frozen main this remains the original five-file APK fix. Upstream repairs are credited to their authors, not this PR. The original18pass/8fail reproduction and subsequent red CI comparisons remain below as history.
  • User-visible CLI/MCP output (if applicable): disk declarations still refuse unsupported layouts, and contradictory single-disk counts retain invalid_request with the EOCD+8 position. A fresh production probe passed4 compiled CLI and10 full/compact stdio calls over the same four unique353-byte generated inputs, including actual SDK-converted input/output schemas, unchanged SHA/size, no false signing Evidence and successful reuse after refusal.
  • Remaining proof gaps: current-head code CI40639870929 completed success for the selected lanes, as detailed below. Full local repository, skipped providers/deep/Windows capability, Android-device and genuine split/signed APK trust remain unverified. Real-world frequency and first affected release remain unknown.

For boundary fixes, identify the applicable boundary regressions
and lifecycle regressions
covered by the evidence above, and explain relevant gaps.

For evidence-bearing changes:

  • Observed, derived, and inferred claims remain distinguishable.
  • Artifact identity, source provenance, and failed attempts remain preserved.
  • Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

Windows x64, pinned Node24.22.1/npm11.16.0 with the current frozen upstream lock; no feature package/lock change. Local build/check work was serial. The earlier baseline failures are retained in the historical section rather than relabeled as current passes.

  • node scripts/run-development-tests.mjs focused src/domain/apkSignature/apkSigningBlock.test.ts src/domain/apkSignature/apkV1Signature.test.ts src/domain/apkSignature/apkContentDigest.test.ts src/apkSignature/ApkSignatureProvider.test.ts tests/acceptance/apkZip64FramingCli.test.ts tests/conformance/readmeConsistency.test.ts — three build tasks and83 tests passed,0skip:23tail/20v1/5digest/23provider/3CLI-MCP/9docs.
  • npm run check — passed, including full type/lint/module/format/metadata/knip/architecture/production reachability/typed-lint gates. npm run docs:check passed; its repeated9 controls are not added to83.
  • npm run verify:test-discovery — all2690 test files discovered exactly once, not execution of2690 tests.
  • Independent production protocol verifier — four unique generated353-byte ZIP inputs,4 compiled CLI calls and10 stdio calls across full/compact profiles passed. Selected request/result SDK-converted schemas, exact file hashes and positive reuse after refusals are checked; these calls are not another14 Vitest cases.
  • node scripts/verify-windows-native-artifact.mjs — genuine official1173 source6.8 artifact passed current PE/hash/NAPI8/ABI1 admission. Broader Windows capability verification and local Android tools were not run.

Current-head code CI40639870929 completed success, attempt1:37jobs comprise18success/19optional skips. Source tests passed21,071 with15skips. All eight built shards, build/static/docs, Windows native build, selected Linux package, APK toolchain and final gates passed. Optional skips remain unqualified.

Raw primary, all eight shard, native-build, Linux-package and APK-toolchain checkouts are 9d6941a703f25beb3f05b6fcad9752fa845fdefd, parents b594fbc3e739ade1fbb9ce38846ed1c3a991273e + 03695956bca23aef59cb8622ae5cd8bf589b7f08, tree 6989f16ded9f0454d47b36d27bba66395a9dd767. This differs from local 05f0e21d08c231535ebfe378994175b6741b1cbd; local83 is not relabeled as remote execution. Tail23/provider23 were individually observed in source logs; APK CLI/MCP acceptance3 passed in shard5 job122655566157.

Fresh Linux job122655593095 used Android build-tools36.1.0 apksigner/aapt2 through verify:apk-signature --require-tools and passed23 controlled cases on that actual CI tree. This is separate remote toolchain qualification, not part of local83/14protocol calls, Android-device execution or general signature trust. The older30ae result and red CI remain historical below.

Previous-head evidence and failed attempts (historical)
  • Tests added or updated: seven domain cases cover both disk fields, single-disk entry-count mismatch, and the count-saturated classic fallback; one compiled CLI/stdio MCP scenario covers disk/count refusals, no false signing Evidence, preserved input bytes and successful reuse after refusal. Existing Zip64, v1, digest and provider controls are retained.
  • Base reproduction or other evidence: independently reproduced through the production source CLI on frozen main b8cdbdf0. The new two-file regression run on unchanged production code was18pass/8fail; after the fix, six related files passed83 checks,0skip. This is one framing defect with related controls, not eight distinct vulnerabilities.
  • User-visible CLI/MCP output (if applicable): disk1/directory0 now returns unsupported_target with a multi-disk ZIP explanation; unequal single-disk counts return invalid_request at path with the EOCD+8 byte location. The unsigned single-disk control still returns observed Evidence with its exact SHA/size. Independent compiled CLI4 calls and actual full/compact stdio10 calls on four unique generated inputs passed, including real SDK-converted input/output schema validation and positive calls after refusals.
  • Remaining proof gaps: full check fails on the three unrelated knip exports listed below; no complete repository suite or genuine split/signed APK authenticity result is claimed. Real-world occurrence frequency and first affected release are unknown.

Windows x64, pinned Node24.22.1/npm11.16.0; existing locked dependencies admitted without a new install. Genuine official source1173 native6.8 artifact passed current PE/hash/NAPI8/ABI1 checks; no broader Windows capability claim.

  • node scripts/run-development-tests.mjs focused src/domain/apkSignature/apkSigningBlock.test.ts tests/acceptance/apkZip64FramingCli.test.ts on unchanged production baseline — three build tasks passed;18pass/8fail, including the newly authored regressions.
  • node scripts/run-development-tests.mjs focused src/domain/apkSignature/apkSigningBlock.test.ts src/domain/apkSignature/apkV1Signature.test.ts src/domain/apkSignature/apkContentDigest.test.ts src/apkSignature/ApkSignatureProvider.test.ts tests/acceptance/apkZip64FramingCli.test.ts tests/conformance/readmeConsistency.test.ts after fix — three build tasks and83checks passed,0skip:23tail/20v1/5digest/23provider/3CLI-MCP/9docs.
  • npm run check — failed at knip: staticFileUrlPath, AndroidManifestComponentInventory and ObjcClassImportBindingCoverage. The same three findings were independently reproduced on the unmodified actual CI base d6f88bec; no full-main green qualification is inferred. No export or ignore rule was changed.
  • Separate npm run check:fast, verify:architecture-guards, knip:production, lint:typed, docs:check — passed. Formatting/metadata passed. Repeated docs9 are not added to83.
  • npm run verify:test-discovery — all2671 test files discovered exactly once; this is discovery, not execution of2671 tests.
  • External production protocol verifier — four353-byte generated inputs,4compiled CLI calls and10stdio calls across full/compact profiles passed; exact file hashes unchanged. These are generated ZIP controls, not real signed APKs or genuine split volumes.

New-head code CI40481821185 failed:37jobs comprise7success/4failure/7cancellation/19optional skips. Source tests have17 failures; all17 were reproduced on the unmodified actual base d6f88bec (66selected controls:49pass/17fail). Shard7 has19 configuration/packaging/example failures; all19 same test names were reproduced on that base after its own three-task build (37filtered controls not executed). No fixtures, ignores or timeouts were changed. The portable/required gates correctly stayed red.

Primary jobs and all eight shard raw checkouts are 3db370d185a26f7979b8f5a808d176c49c63f170, actual base d6f88becd531cabafca1d968b89cf7fc77a80041, tree 066b281c227ab32e33b3641d4d885f7242102548; this differs from locally validated tree d4ac8faf1290828732f9398d97d362c53b2314e9. The affected tail23/provider23 source files passed. The three APK CLI/MCP acceptance controls completed successfully in shard6 before that shard was cancelled; that is not an entire-shard pass. Build/static/docs/native build and selected Linux packaging passed. The Linux real-apk-signature job122114275873 passed23 existing controlled cases with Android apksigner/aapt2 through the compiled entrypoint. This is separate remote toolchain evidence, not part of local83, Android-device execution, general signature-trust qualification or a green overall CI.

Compatibility, safety, and release

  • Breaking changes or migration steps: no request/schema change; unsupported/malformed classic layouts are refused instead of classified unsigned. Select a complete single-disk archive.
  • Real Hopper/Ghidra, browser, or OS coverage: builtin static parsing through real CLI/MCP on Windows; no real Android engine/device or cryptographic signature-trust validation. Existing supported Zip64 controls passed.
  • Package or release metadata impact: none; no new dependencies, budgets or release changes.
  • Security, privacy, process, or containment review: only selected local generated fixtures were read; no real APK consequences, protection bypass, target execution, capture/replay, paid model, performance or token-savings claim.

Author readiness

Human owner: @wunianze666-netizen

  • I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
  • I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
  • I declare this PR ready for initial maintainer review.

Before merge

  • This PR addresses a concrete problem or an agreed enhancement.
  • Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
  • The PR has one focused outcome and the title follows type(scope): outcome.
  • Related issue is linked, or the reason for not linking one is stated above.
  • Tests cover changed observable behavior and meaningful failure paths.
  • Owning docs, contracts, and generated metadata are updated where needed.
  • User-visible CLI/MCP changes include representative output.
  • I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/7471 **Author:** [@wunianze666-netizen](https://github.com/wunianze666-netizen) **Created:** 10/27/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `codex/apk-classic-zip-disks` --- ### 📝 Commits (2) - [`30ae641`](https://github.com/morluto/rea/commit/30ae6416aae0575b66ba4cbc9936bd14ddd703d4) fix(apk): validate classic ZIP disk declarations - [`0369595`](https://github.com/morluto/rea/commit/03695956bca23aef59cb8622ae5cd8bf589b7f08) merge: integrate upstream CI baseline repairs for APK framing ### 📊 Changes **5 files changed** (+160 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `docs/apk-signature.md` (+8 -1) 📝 `src/apkSignature/apkSignatureFailures.ts` (+7 -0) 📝 `src/domain/apkSignature/apkSigningBlock.test.ts` (+59 -0) 📝 `src/domain/apkSignature/apkSigningBlock.ts` (+34 -6) 📝 `tests/acceptance/apkZip64FramingCli.test.ts` (+52 -3) </details> ### 📄 Description <!-- PR title: type(optional-scope): imperative outcome The title becomes the squash-merge commit subject and generated changelog entry. --> ## Summary Fixes #7433. Refuse classic ZIP disk declarations that the selected file cannot resolve before APK signing inspection reports absent signing schemes. ## Problem and expected behavior A generated two-entry ZIP with only its classic EOCD disk number changed to1 was accepted as observed, unsigned signing Evidence, while the artifact inventory refused the same bytes as split ZIP. A nonzero directory disk and contradictory per-disk entry count were also accepted. Nonlocal disk declarations now return unsupported_target; inconsistent single-disk counts return invalid_request. Valid single-disk and existing Zip64 controls remain supported. ## Change and scope The existing APK tail owner consumes already-parsed EOCD facts and checks classic layout admission before selecting a local directory span. Both ordinary classic and count-saturated/no-Zip64 return paths use that one check. The existing tagged Result and error mapper carry the refusal through CLI/MCP. No new provider or execution authority. Follow the [contribution scope](https://github.com/morluto/rea/blob/main/CONTRIBUTING.md#contribution-scope). Unresolved scope, authority, side effects, or required verification block integration. Link the required maintainer scope decision for new providers or capabilities involving target execution, injection, mutation, or protection recovery; ordinary fixes within existing boundaries may state "not applicable". Draft PRs may leave the scope decision pending and the readiness and merge checklists unchecked. Maintainers can help resolve open questions. ## Contract and boundary impact - Semantic owner and earliest changed stage: APK central-directory resolution in apkSigningBlock.ts, consuming canonical zipEndOfCentralDirectory candidates; both classic return paths share classicDirectory. No binary-field reinterpretation is added downstream. - Contribution scope fit and linked maintainer decision: ordinary static-parser correction in the existing APK inspection boundary; separate scope decision not applicable. - CLI and MCP/tool-catalog contract: existing inspect-apk-signature / inspect_apk_signature request and result schemas stay unchanged. Previously accepted unsupported/malformed layouts now use existing typed error categories instead of successful signing Evidence. - Provider, bridge, target-format, or platform compatibility: builtin dependency-free APK framing; no Android SDK, device, external engine or genuine split-set support added. Existing Zip64 parsing remains on its original path. - Evidence, artifact, provenance, or reconstruction contract: successful controls retain selected path, original SHA256/size and no-runtime-execution fact. Refused inputs produce no signing report, so absence is not promoted from an unresolved layout. - Target selection, authority, upstream behavior, and cleanup details (if applicable): existing caller-selected local-file reads only; no target execution, mutation, network activity or new cleanup owner. - Generated metadata (`docs/public/product-catalog.json`), package, or installation impact (CI generates and validates ignored catalogs and `skills/`; edit authored instructions in `.agents/skills/reverse-engineer-anything/` and never commit build outputs): no package/lock/schema/install changes; generated outputs remain ignored. Expected effects (check known effects; use documentation-only on its own). Unchecked items do not establish absence; leave uncertainties visible. - [x] Read existing files or captured data. - [ ] Launch or attach to a process. - [ ] Inject instrumentation or run scripts/code. - [ ] Change process memory, registers, files, or configuration. - [ ] Contact network services. - [ ] Recover protected code or work around protections. - [ ] Documentation or usability only; no target interaction. - [ ] Not sure yet; investigation or maintainer guidance needed. ## Evidence and regression coverage - Tests added or updated: the seven domain controls and one CLI/MCP scenario remain intact. On the current ordinary-merge tree, all83 controls in six focused files passed,0skip; the three build tasks passed. Docs9 repeated by docs:check are not added again. - Base reproduction or other evidence: ordinary merge `03695956bca23aef59cb8622ae5cd8bf589b7f08` integrates frozen main `ad7d4c1f4dd9cbd93229ee330e66c7a522e723e6`, including relevant upstream #7349/#7479 baseline repairs. Its parents are30ae6416+ad7d4c1f, tree05f0e21d08c231535ebfe378994175b6741b1cbd. No conflict or manual feature edit was needed; relative to frozen main this remains the original five-file APK fix. Upstream repairs are credited to their authors, not this PR. The original18pass/8fail reproduction and subsequent red CI comparisons remain below as history. - User-visible CLI/MCP output (if applicable): disk declarations still refuse unsupported layouts, and contradictory single-disk counts retain invalid_request with the EOCD+8 position. A fresh production probe passed4 compiled CLI and10 full/compact stdio calls over the same four unique353-byte generated inputs, including actual SDK-converted input/output schemas, unchanged SHA/size, no false signing Evidence and successful reuse after refusal. - Remaining proof gaps: current-head code CI40639870929 completed success for the selected lanes, as detailed below. Full local repository, skipped providers/deep/Windows capability, Android-device and genuine split/signed APK trust remain unverified. Real-world frequency and first affected release remain unknown. For boundary fixes, identify the applicable [boundary regressions](https://github.com/morluto/rea/blob/main/docs/testing.md#boundary-regressions) and [lifecycle regressions](https://github.com/morluto/rea/blob/main/docs/testing.md#lifecycle-regressions) covered by the evidence above, and explain relevant gaps. For evidence-bearing changes: - [x] Observed, derived, and inferred claims remain distinguishable. - [x] Artifact identity, source provenance, and failed attempts remain preserved. - [x] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed Windows x64, pinned Node24.22.1/npm11.16.0 with the current frozen upstream lock; no feature package/lock change. Local build/check work was serial. The earlier baseline failures are retained in the historical section rather than relabeled as current passes. - `node scripts/run-development-tests.mjs focused src/domain/apkSignature/apkSigningBlock.test.ts src/domain/apkSignature/apkV1Signature.test.ts src/domain/apkSignature/apkContentDigest.test.ts src/apkSignature/ApkSignatureProvider.test.ts tests/acceptance/apkZip64FramingCli.test.ts tests/conformance/readmeConsistency.test.ts` — three build tasks and83 tests passed,0skip:23tail/20v1/5digest/23provider/3CLI-MCP/9docs. - `npm run check` — passed, including full type/lint/module/format/metadata/knip/architecture/production reachability/typed-lint gates. `npm run docs:check` passed; its repeated9 controls are not added to83. - `npm run verify:test-discovery` — all2690 test files discovered exactly once, not execution of2690 tests. - Independent production protocol verifier — four unique generated353-byte ZIP inputs,4 compiled CLI calls and10 stdio calls across full/compact profiles passed. Selected request/result SDK-converted schemas, exact file hashes and positive reuse after refusals are checked; these calls are not another14 Vitest cases. - `node scripts/verify-windows-native-artifact.mjs` — genuine official1173 source6.8 artifact passed current PE/hash/NAPI8/ABI1 admission. Broader Windows capability verification and local Android tools were not run. Current-head [code CI40639870929](https://github.com/morluto/rea/actions/runs/40639870929) completed **success**, attempt1:37jobs comprise18success/19optional skips. Source tests passed21,071 with15skips. All eight built shards, build/static/docs, Windows native build, selected Linux package, APK toolchain and final gates passed. Optional skips remain unqualified. Raw primary, all eight shard, native-build, Linux-package and APK-toolchain checkouts are `9d6941a703f25beb3f05b6fcad9752fa845fdefd`, parents `b594fbc3e739ade1fbb9ce38846ed1c3a991273e` + `03695956bca23aef59cb8622ae5cd8bf589b7f08`, tree `6989f16ded9f0454d47b36d27bba66395a9dd767`. This differs from local `05f0e21d08c231535ebfe378994175b6741b1cbd`; local83 is not relabeled as remote execution. Tail23/provider23 were individually observed in source logs; APK CLI/MCP acceptance3 passed in shard5 job122655566157. Fresh Linux job122655593095 used Android build-tools36.1.0 apksigner/aapt2 through `verify:apk-signature --require-tools` and passed23 controlled cases on that actual CI tree. This is separate remote toolchain qualification, not part of local83/14protocol calls, Android-device execution or general signature trust. The older30ae result and red CI remain historical below. <details> <summary>Previous-head evidence and failed attempts (historical)</summary> - Tests added or updated: seven domain cases cover both disk fields, single-disk entry-count mismatch, and the count-saturated classic fallback; one compiled CLI/stdio MCP scenario covers disk/count refusals, no false signing Evidence, preserved input bytes and successful reuse after refusal. Existing Zip64, v1, digest and provider controls are retained. - Base reproduction or other evidence: independently reproduced through the production source CLI on frozen main b8cdbdf0. The new two-file regression run on unchanged production code was18pass/8fail; after the fix, six related files passed83 checks,0skip. This is one framing defect with related controls, not eight distinct vulnerabilities. - User-visible CLI/MCP output (if applicable): disk1/directory0 now returns unsupported_target with a multi-disk ZIP explanation; unequal single-disk counts return invalid_request at path with the EOCD+8 byte location. The unsigned single-disk control still returns observed Evidence with its exact SHA/size. Independent compiled CLI4 calls and actual full/compact stdio10 calls on four unique generated inputs passed, including real SDK-converted input/output schema validation and positive calls after refusals. - Remaining proof gaps: full check fails on the three unrelated knip exports listed below; no complete repository suite or genuine split/signed APK authenticity result is claimed. Real-world occurrence frequency and first affected release are unknown. Windows x64, pinned Node24.22.1/npm11.16.0; existing locked dependencies admitted without a new install. Genuine official source1173 native6.8 artifact passed current PE/hash/NAPI8/ABI1 checks; no broader Windows capability claim. - `node scripts/run-development-tests.mjs focused src/domain/apkSignature/apkSigningBlock.test.ts tests/acceptance/apkZip64FramingCli.test.ts` on unchanged production baseline — three build tasks passed;18pass/8fail, including the newly authored regressions. - `node scripts/run-development-tests.mjs focused src/domain/apkSignature/apkSigningBlock.test.ts src/domain/apkSignature/apkV1Signature.test.ts src/domain/apkSignature/apkContentDigest.test.ts src/apkSignature/ApkSignatureProvider.test.ts tests/acceptance/apkZip64FramingCli.test.ts tests/conformance/readmeConsistency.test.ts` after fix — three build tasks and83checks passed,0skip:23tail/20v1/5digest/23provider/3CLI-MCP/9docs. - `npm run check` — failed at knip: staticFileUrlPath, AndroidManifestComponentInventory and ObjcClassImportBindingCoverage. The same three findings were independently reproduced on the unmodified actual CI base d6f88bec; no full-main green qualification is inferred. No export or ignore rule was changed. - Separate `npm run check:fast`, `verify:architecture-guards`, `knip:production`, `lint:typed`, `docs:check` — passed. Formatting/metadata passed. Repeated docs9 are not added to83. - `npm run verify:test-discovery` — all2671 test files discovered exactly once; this is discovery, not execution of2671 tests. - External production protocol verifier — four353-byte generated inputs,4compiled CLI calls and10stdio calls across full/compact profiles passed; exact file hashes unchanged. These are generated ZIP controls, not real signed APKs or genuine split volumes. New-head [code CI40481821185](https://github.com/morluto/rea/actions/runs/40481821185) **failed**:37jobs comprise7success/4failure/7cancellation/19optional skips. Source tests have17 failures; all17 were reproduced on the unmodified actual base d6f88bec (66selected controls:49pass/17fail). Shard7 has19 configuration/packaging/example failures; all19 same test names were reproduced on that base after its own three-task build (37filtered controls not executed). No fixtures, ignores or timeouts were changed. The portable/required gates correctly stayed red. Primary jobs and all eight shard raw checkouts are `3db370d185a26f7979b8f5a808d176c49c63f170`, actual base `d6f88becd531cabafca1d968b89cf7fc77a80041`, tree `066b281c227ab32e33b3641d4d885f7242102548`; this differs from locally validated tree `d4ac8faf1290828732f9398d97d362c53b2314e9`. The affected tail23/provider23 source files passed. The three APK CLI/MCP acceptance controls completed successfully in shard6 before that shard was cancelled; that is not an entire-shard pass. Build/static/docs/native build and selected Linux packaging passed. The Linux `real-apk-signature` job122114275873 passed23 existing controlled cases with Android apksigner/aapt2 through the compiled entrypoint. This is separate remote toolchain evidence, not part of local83, Android-device execution, general signature-trust qualification or a green overall CI. </details> ## Compatibility, safety, and release - Breaking changes or migration steps: no request/schema change; unsupported/malformed classic layouts are refused instead of classified unsigned. Select a complete single-disk archive. - Real Hopper/Ghidra, browser, or OS coverage: builtin static parsing through real CLI/MCP on Windows; no real Android engine/device or cryptographic signature-trust validation. Existing supported Zip64 controls passed. - Package or release metadata impact: none; no new dependencies, budgets or release changes. - Security, privacy, process, or containment review: only selected local generated fixtures were read; no real APK consequences, protection bypass, target execution, capture/replay, paid model, performance or token-savings claim. ## Author readiness <!-- The human owner completes these declarations before requesting review. The PR author is the owner by default. A different owner must explicitly accept ownership on this PR. AI agents must leave these declarations to a human to dictate to them or there could be catastrophic consequences for many users of REA. Draft PRs may leave them unchecked. These declarations record initial readiness when opening the PR for review; later pushes do not require a new human sign-off. Keep the description and validation evidence current as the work changes. See CONTRIBUTING.md#pull-request-ownership-and-readiness. --> Human owner: @wunianze666-netizen - [ ] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [ ] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [ ] I declare this PR ready for initial maintainer review. ## Before merge <!-- Draft PRs may leave pending items unchecked. Resolve material scope and authority questions before integration. --> - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels   
area: bridge

   
area: bridge

   
area: build

   
area: build

   
area: build

   
area: cli

   
area: domain

   
area: evidence

   
area: mcp

   
area: native

   
area: providers

   
area: runtime

   
area: server

   
area: setup

   
area: tests

   
bug

   
design

   
documentation

   
enhancement

   
enhancement

   
enhancement

   
experiment

   
help wanted

   
i18n

   
invalid

   
P0: critical

   
P1: high

   
P2: medium

   
P2: medium

   
P2: medium

   
P3: low

   
performance

   
provider-request

   
pull-request
Mirrored from GitHub Pull Request

  
question

   
roadmap

   
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#7858
No description provided.