morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #6951] [MERGED] test(javascript): execute the registered Webpack export fixture #7471

New issue

Closed

opened 2026-11-01 21:48:05 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:48:05 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6951
Author: @gensokyo-dev
Created: 10/24/2026
Status: ✅ Merged
Merged: 10/24/2026
Merged by: @gensokyo-dev

Base: main ← Head: test/webpack-factory-oracle-20261024

📝 Commits (1)

bb021cb test(javascript): execute the registered Webpack export fixture

📊 Changes

1 file changed (+20 additions, -14 deletions)

View changed files

📝 tests/acceptance/applications/applicationWorkflowCli.test.ts (+20 -14)

📄 Description

Problem and outcome

Main CI on 21a20306b failed the Webpack CLI/MCP export case: from.helper was missing. The fixture redeclared its factory parameter __webpack_require__ with const. Node rejects the complete bundle with SyntaxError: Identifier '__webpack_require__' has already been declared; the old CommonJS oracle ran only the body and missed the invalid factory. Factory-role ownership was deliberately tightened in 5cbcd5855.

Pass the loader into the registered factory and execute the exact analyzed bundle in a fresh Node VM context for the runtime oracle. Remove the superseded body-only oracle file. All runtime/static export keys, computed-key omissions, CLI/MCP Evidence identity assertions and timeouts remain intact. Product analysis and contracts are unchanged. No separate issue was opened for this direct main-health repair.

The prerequisite maintainer PR #6945 fixed four other fixture drifts: bound-target error tags, the launcher's copied environment module, the required package member, and XML plist lint provenance. This PR was rebased onto that merged main b869fa762 before final verification.

Executed evidence and validation

Linux x64, pinned Node 24.22.1 / npm 11.16.0, two CPUs:

Clean 21a20306b: the focused public CLI/MCP case reproduced the missing key (14.25 s wall / 16.40 s CPU / 1625.5 MiB sampled process-family RSS). Node --check independently rejected the original wrapped factory.
Updated focused case passed (13.31 s / 15.25 s / 1690.0 MiB). Restoring the original invalid body under the new oracle failed immediately with the duplicate-declaration syntax error; the reviewed fixture was restored.
All three complete relevant files passed: applicationWorkflowCli, javascriptFactoryExportRoles, javascriptStaticAnalysisModuleIndex — 70 tests, 36.43 s wall / 45.28 s CPU / 2410.0 MiB. This exercises the production CLI, stdio MCP and Node's execution of the complete self-authored bundle.
npm run check and git diff --check passed (27.09 s wall / 49.08 s CPU / 2607.0 MiB).
A broader rebased eight-file local run reached its declared 240 s guard, peak 3238.0 MiB; it is not a full pass, and interrupted CPU accounting is incomplete. The Apple and JavaScript files completed successfully, while compact MCP startup was marked failed at 31.41 s. After stopping that group, the bounded startup, corrupted-catalog and three tar-listing controls all passed: 5 tests, 28.18 s wall / 32.66 s CPU / 1476.1 MiB. No timeout was extended. Complete remote CI subsequently passed all 29 deferred-runtime tests, including that startup case.

Focused comparisons reused build artifacts; each fixture/VM was fresh. The uncached prerequisite build passed (22.25 s wall / 29.12 s CPU / 1087.5 MiB). RSS sums descendants sampled every 100 ms: shared pages may double-count and short-lived/reparented children may be missed. Commands had elapsed guards and an 8 GiB sampled stop; no OOM occurred. These are validation costs, not a speedup claim; agent tokens and remote process-family costs were not measured.

CI and merged main

PR CI 40065098040 passed on bb021cb94: all eight shards, Source tests, static checks, build, Portable aggregation and CI required; its merged report records 31318 passed / 232 skipped. Title/readiness passed and exact-head Codex review completed with no findings or unresolved threads.

Latest main d87e73f2 is green: main CI 40066318409 completed successfully, including CI required. Its merged test report records 31321 passed / 232 skipped. All eight built shards, Source tests, documentation, static checks, build, Portable aggregation, real Apple CLI/MCP, browser, web source-map/network, agentenv, EVM, APK, JavaScript recovery, recorded crashes, reconstruction readiness, reverse-tool quality, all four SQLite Node configurations, Windows capability/package validation and Linux/macOS native package baselines passed. The run finished with 38 successful jobs and 5 existing optional skips. A final branch lookup confirmed that this exact tested commit was still latest main.

The existing selection skipped Deep static checks, nativeaot, web_runtime, Source-built conformance fixtures and ghidra_bridge; no execution claim is made for those lanes. Superseded runs on known-broken intermediate revisions were cancelled to avoid redundant runner work; they are not passes. Final successful runs were not retried. Main also includes #6950's independent entropy optimization, so the main run validates the integrated tree rather than claiming whole-tree equality with the PR's earlier base.

Author readiness

Human owner: @gensokyo-dev

The owner explicitly delegated readiness declarations and agent-managed review. Inspection and execution were performed by Codex; no separate human inspection is claimed.

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6951 **Author:** [@gensokyo-dev](https://github.com/gensokyo-dev) **Created:** 10/24/2026 **Status:** ✅ Merged **Merged:** 10/24/2026 **Merged by:** [@gensokyo-dev](https://github.com/gensokyo-dev) **Base:** `main` ← **Head:** `test/webpack-factory-oracle-20261024` --- ### 📝 Commits (1) - [`bb021cb`](https://github.com/morluto/rea/commit/bb021cb947fb2b85a2ce91df94821ac027d085b1) test(javascript): execute the registered Webpack export fixture ### 📊 Changes **1 file changed** (+20 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `tests/acceptance/applications/applicationWorkflowCli.test.ts` (+20 -14) </details> ### 📄 Description ## Problem and outcome Main CI on `21a20306b` [failed the Webpack CLI/MCP export case](https://github.com/morluto/rea/actions/runs/40062962185/job/120781416854): `from.helper` was missing. The fixture redeclared its factory parameter `__webpack_require__` with `const`. Node rejects the complete bundle with `SyntaxError: Identifier '__webpack_require__' has already been declared`; the old CommonJS oracle ran only the body and missed the invalid factory. Factory-role ownership was deliberately tightened in `5cbcd5855`. Pass the loader into the registered factory and execute the exact analyzed bundle in a fresh Node VM context for the runtime oracle. Remove the superseded body-only oracle file. All runtime/static export keys, computed-key omissions, CLI/MCP Evidence identity assertions and timeouts remain intact. Product analysis and contracts are unchanged. No separate issue was opened for this direct main-health repair. The prerequisite maintainer PR #6945 fixed four other fixture drifts: bound-target error tags, the launcher's copied environment module, the required package member, and XML plist lint provenance. This PR was rebased onto that merged main `b869fa762` before final verification. ## Executed evidence and validation Linux x64, pinned Node 24.22.1 / npm 11.16.0, two CPUs: - Clean `21a20306b`: the focused public CLI/MCP case reproduced the missing key (14.25 s wall / 16.40 s CPU / 1625.5 MiB sampled process-family RSS). Node `--check` independently rejected the original wrapped factory. - Updated focused case passed (13.31 s / 15.25 s / 1690.0 MiB). Restoring the original invalid body under the new oracle failed immediately with the duplicate-declaration syntax error; the reviewed fixture was restored. - All three complete relevant files passed: `applicationWorkflowCli`, `javascriptFactoryExportRoles`, `javascriptStaticAnalysisModuleIndex` — **70 tests**, 36.43 s wall / 45.28 s CPU / 2410.0 MiB. This exercises the production CLI, stdio MCP and Node's execution of the complete self-authored bundle. - `npm run check` and `git diff --check` passed (27.09 s wall / 49.08 s CPU / 2607.0 MiB). - A broader rebased eight-file local run reached its declared **240 s guard**, peak 3238.0 MiB; it is **not a full pass**, and interrupted CPU accounting is incomplete. The Apple and JavaScript files completed successfully, while compact MCP startup was marked failed at 31.41 s. After stopping that group, the bounded startup, corrupted-catalog and three tar-listing controls all passed: **5 tests**, 28.18 s wall / 32.66 s CPU / 1476.1 MiB. No timeout was extended. Complete remote CI subsequently passed all 29 deferred-runtime tests, including that startup case. Focused comparisons reused build artifacts; each fixture/VM was fresh. The uncached prerequisite build passed (22.25 s wall / 29.12 s CPU / 1087.5 MiB). RSS sums descendants sampled every 100 ms: shared pages may double-count and short-lived/reparented children may be missed. Commands had elapsed guards and an 8 GiB sampled stop; no OOM occurred. These are validation costs, not a speedup claim; agent tokens and remote process-family costs were not measured. ## CI and merged main [PR CI 40065098040](https://github.com/morluto/rea/actions/runs/40065098040) passed on `bb021cb94`: all eight shards, Source tests, static checks, build, Portable aggregation and CI required; its merged report records **31318 passed / 232 skipped**. Title/readiness passed and exact-head Codex review completed with no findings or unresolved threads. **Latest main `d87e73f2` is green:** [main CI 40066318409](https://github.com/morluto/rea/actions/runs/40066318409) completed successfully, including CI required. Its merged test report records **31321 passed / 232 skipped**. All eight built shards, Source tests, documentation, static checks, build, Portable aggregation, real Apple CLI/MCP, browser, web source-map/network, agentenv, EVM, APK, JavaScript recovery, recorded crashes, reconstruction readiness, reverse-tool quality, all four SQLite Node configurations, Windows capability/package validation and Linux/macOS native package baselines passed. The run finished with 38 successful jobs and 5 existing optional skips. A final branch lookup confirmed that this exact tested commit was still latest main. The existing selection skipped Deep static checks, nativeaot, web_runtime, Source-built conformance fixtures and ghidra_bridge; no execution claim is made for those lanes. Superseded runs on known-broken intermediate revisions were cancelled to avoid redundant runner work; they are not passes. Final successful runs were not retried. Main also includes #6950's independent entropy optimization, so the main run validates the integrated tree rather than claiming whole-tree equality with the PR's earlier base. ## Author readiness Human owner: @gensokyo-dev The owner explicitly delegated readiness declarations and agent-managed review. Inspection and execution were performed by Codex; no separate human inspection is claimed. - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:48:05 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-05 01:48:11 +00:00

[PR #7471] fix(apk): validate classic ZIP disk declarations #7858

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#7471

No description provided.

Rows
Columns