[GH-ISSUE #87] Please credit me for the Zotero connector (#61) #53

New issue

Closed

opened 2026-10-18 21:13:55 +00:00 by bsakaguchi · 2 comments

bsakaguchi commented

2026-10-18 21:13:55 +00:00

Owner

Originally created by @thiswillbeyourgithub on GitHub (Jul 25, 2026).
Original GitHub issue: https://github.com/open-webui/oikb/issues/87

Hi @tjbck,

Short version: Thanks for oikb and the whole open-webui ecosystem btw! I think code for the Zotero connector in v0.4.0 made its way from my PR #61, and I would like a Co-authored-by trailer for it. I am self-taught with no CS degree, so a visible contribution history is the closest thing I have to a diploma.

I am fairly sure this was an oversight: the same day you merged #34, #35, #36, #37, #50, #69 and #72 all with proper attribution, and 33758a1 sits right on top of one of them.

The ask:

Co-authored-by: thiswillbeyourgithub <26625900+thiswillbeyourgithub@users.noreply.github.com>

The two commits that added src/oikb/connectors/zotero.py (6d3752b and 33758a1) share these with #61:

HIERARCHY_SEP = "%%", same name and same arbitrary separator
parse_zotero_source(), identical in 6d3752b down to the return annotation
"Zotero credentials required. Set ZOTERO_LIBRARY_ID and ZOTERO_API_KEY." and f"Unknown Zotero file: {path}/{filename}", verbatim
the SourceFileUnavailable class and the SyncResult.warnings / _upload_one / _tally refactor in sync.py, which is sync-core work unrelated to Zotero

The WebDAV fallback and _ZoteroFile are clearly yours, and WebDAV is a real improvement over what I had.

Happy to close #61 as superseded afterwards, and glad to help maintain the connector.

Researched and drafted with Claude Code, like the PR itself. Every SHA and string above is checkable.

Originally created by @thiswillbeyourgithub on GitHub (Jul 25, 2026). Original GitHub issue: https://github.com/open-webui/oikb/issues/87 Hi @tjbck, Short version: Thanks for oikb and the whole open-webui ecosystem btw! I think code for the Zotero connector in v0.4.0 made its way from my PR #61, and I would like a `Co-authored-by` trailer for it. I am self-taught with no CS degree, so a visible contribution history is the closest thing I have to a diploma. I am fairly sure this was an oversight: the same day you merged #34, #35, #36, #37, #50, #69 and #72 all with proper attribution, and 33758a1 sits right on top of one of them. The ask: ``` Co-authored-by: thiswillbeyourgithub <26625900+thiswillbeyourgithub@users.noreply.github.com> ``` The two commits that added `src/oikb/connectors/zotero.py` (6d3752b and 33758a1) share these with #61: - `HIERARCHY_SEP = "%%"`, same name and same arbitrary separator - `parse_zotero_source()`, identical in 6d3752b down to the return annotation - `"Zotero credentials required. Set ZOTERO_LIBRARY_ID and ZOTERO_API_KEY."` and `f"Unknown Zotero file: {path}/{filename}"`, verbatim - the `SourceFileUnavailable` class and the `SyncResult.warnings` / `_upload_one` / `_tally` refactor in `sync.py`, which is sync-core work unrelated to Zotero The WebDAV fallback and `_ZoteroFile` are clearly yours, and WebDAV is a real improvement over what I had. Happy to close #61 as superseded afterwards, and glad to help maintain the connector. *Researched and drafted with Claude Code, like the PR itself. Every SHA and string above is checkable.*

bsakaguchi closed this issue

2026-10-18 21:13:55 +00:00

bsakaguchi commented

2026-10-18 21:13:56 +00:00

Author

Owner

@hexsm commented on GitHub (Jul 30, 2026):

The code from my PR #84 was also merged (with slight changes) without credit. It's a bit disappointing, but at least I can now use my changes with the official Docker image.

@hexsm commented on GitHub (Jul 30, 2026): The code from my PR #84 was also merged (with slight changes) without credit. It's a bit disappointing, but at least I can now use my changes with the official Docker image.

bsakaguchi commented

2026-10-18 21:13:56 +00:00

Author

Owner

@tjbck commented on GitHub (Aug 1, 2026):

Addressed for both!

@tjbck commented on GitHub (Aug 1, 2026): Addressed for both!

bsakaguchi referenced this issue

2026-10-18 21:13:57 +00:00

[GH-ISSUE #91] status crashes and ls reports empty against Open WebUI dev: GET /knowledge/{id} no longer inlines files (same root cause as #89) #56