pybind/pybind11
1
0
Fork 0
mirror of https://github.com/pybind/pybind11.git synced 2026-07-15 11:33:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update comments

Browse Source
This commit is contained in:
Xuehai Pan
2025-12-16 16:33:14 +08:00
parent a6754ba40d
commit 1aed3ab1b4
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
include/pybind11/detail/internals.h
View File

@@ -627,19 +627,23 @@ public:
/// Get the pointer-to-pointer for the main interpreter, allocating it if it does not already
/// exist. May acquire the GIL. Will never return nullptr.
std::unique_ptr<InternalsType> *get_pp_for_main_interpreter() {
// This function **assumes** that the current thread is running in the main interpreter.
if (!seen_main_interpreter_) {
// The first call to this function **MUST** be from the main interpreter.
// Here we **ASSUME** that the current thread is running in the main interpreter.
// The caller is responsible for ensuring this.
std::call_once(seen_main_interpreter_flag_, [&] {
gil_scoped_acquire_simple gil;
internals_singleton_pp_ = get_or_create_pp_in_state_dict();
seen_main_interpreter_ = true;
});
}
// This is shared between all threads and all interpreters.
return internals_singleton_pp_;
}
/// Drop all the references we're currently holding.
void unref() {
// See comment in get_pp() above.
#ifdef PYBIND11_HAS_SUBINTERPRETER_SUPPORT
if (get_num_interpreters_seen() > 1) {
last_istate_tls() = nullptr;
@@ -651,6 +655,7 @@ public:
}
void destroy() {
// See comment in get_pp() above.
#ifdef PYBIND11_HAS_SUBINTERPRETER_SUPPORT
if (get_num_interpreters_seen() > 1) {
auto *tstate = get_thread_state_unchecked();
@@ -711,8 +716,8 @@ private:
char const *holder_id_ = nullptr;
on_fetch_function *on_fetch_ = nullptr;
// Pointer to the singleton internals for the main interpreter
std::unique_ptr<InternalsType> *internals_singleton_pp_;
std::once_flag seen_main_interpreter_flag_;
std::atomic_bool seen_main_interpreter_{false};
};

4
include/pybind11/gil_safe_call_once.h
View File

@@ -130,7 +130,7 @@ public:
// CPython API calls in the `fn()` call below may release and reacquire the GIL.
gil_scoped_release gil_rel; // Needed to establish lock ordering.
detail::with_internals([&](detail::internals &internals) {
const void *key = reinterpret_cast<const void *>(this);
const void *const key = reinterpret_cast<const void *>(this);
auto &storage_map = internals.call_once_storage_map;
// There can be multiple threads going through here.
detail::call_once_storage<T> *value = nullptr;
@@ -168,7 +168,7 @@ public:
T *result = last_storage_ptr_;
if (!is_last_storage_valid()) {
detail::with_internals([&](detail::internals &internals) {
const void *key = reinterpret_cast<const void *>(this);
const void *const key = reinterpret_cast<const void *>(this);
auto &storage_map = internals.call_once_storage_map;
auto *value = static_cast<detail::call_once_storage<T> *>(storage_map.at(key));
result = last_storage_ptr_ = reinterpret_cast<T *>(value->storage);