pybind/pybind11
1
0
Fork 0
mirror of https://github.com/pybind/pybind11.git synced 2026-07-12 02:03:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use Py_XINCREF and Py_XDECREF

Browse Source
This commit is contained in:
Xuehai Pan
2026-01-23 01:36:59 +08:00
parent 6d8fa8a29a
commit 1d49006728
1 changed files with 6 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
include/pybind11/detail/class.h
View File

@@ -251,16 +251,12 @@ extern "C" inline void pybind11_meta_dealloc(PyObject *obj) {
}
});
PyType_Type.tp_dealloc(obj);
// Release the references to the internals capsules that were acquired in make_new_python_type.
// See the comment there for details on preventing use-after-free during interpreter shutdown.
if (PyObject *capsule = get_internals_capsule()) {
Py_DECREF(capsule);
}
if (PyObject *capsule = get_local_internals_capsule()) {
Py_DECREF(capsule);
}
PyType_Type.tp_dealloc(obj);
Py_XDECREF(get_internals_capsule());
Py_XDECREF(get_local_internals_capsule());
}
/** This metaclass is assigned by default to all pybind11 types and is required in order
@@ -844,12 +840,8 @@ inline PyObject *make_new_python_type(const type_record &rec) {
// would recreate an empty internals and fail because the type registry is gone. By holding
// references to the capsules, we ensure they outlive all pybind11 types. The decref happens
// in pybind11_meta_dealloc.
if (PyObject *capsule = get_internals_capsule()) {
Py_INCREF(capsule);
}
if (PyObject *capsule = get_local_internals_capsule()) {
Py_INCREF(capsule);
}
Py_XINCREF(get_internals_capsule());
Py_XINCREF(get_local_internals_capsule());
return reinterpret_cast<PyObject *>(type);
}