pybind/pybind11
1
0
Fork 0
mirror of https://github.com/pybind/pybind11.git synced 2026-04-19 14:29:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: provide useful behavior of default py::slice (#5620)

Browse Source 
* Change behavior of default py::slice

* make clang-tidy happy

* Update tests/test_pytypes.py

---------

Co-authored-by: Bryn Lloyd <12702862+dyollb@users.noreply.github.com>
Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
This commit is contained in:
Bryn Lloyd
2025-04-17 00:42:34 +02:00
committed by GitHub
parent 5c498583cc
commit bc4a66dff0
3 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
include/pybind11/pytypes.h
View File

@@ -1942,13 +1942,14 @@ private:
class slice : public object {
public:
PYBIND11_OBJECT_DEFAULT(slice, object, PySlice_Check)
PYBIND11_OBJECT(slice, object, PySlice_Check)
slice(handle start, handle stop, handle step)
: object(PySlice_New(start.ptr(), stop.ptr(), step.ptr()), stolen_t{}) {
if (!m_ptr) {
pybind11_fail("Could not allocate slice object!");
}
}
slice() : slice(none(), none(), none()) {}
#ifdef PYBIND11_HAS_OPTIONAL
slice(std::optional<ssize_t> start, std::optional<ssize_t> stop, std::optional<ssize_t> step)

2
tests/test_pytypes.cpp
View File

@@ -671,6 +671,8 @@ TEST_SUBMODULE(pytypes, m) {
m.def("test_list_slicing", [](const py::list &a) { return a[py::slice(0, -1, 2)]; });
m.def("test_list_slicing_default", [](const py::list &a) { return a[py::slice()]; });
// See #2361
m.def("issue2361_str_implicit_copy_none", []() {
py::str is_this_none = py::none();

3
tests/test_pytypes.py
View File

@@ -603,7 +603,8 @@ def test_number_protocol():
def test_list_slicing():
li = list(range(100))
assert li[::2] == m.test_list_slicing(li)
assert li[0:-1:2] == m.test_list_slicing(li)
assert li[::] == m.test_list_slicing_default(li)
def test_issue2361():