[PR #85] [MERGED] kb: Portalcraft: start Minecraft from the player's own launcher (Portal 2) #110

New issue

Closed

opened 2026-10-15 20:53:29 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 20:53:29 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rehan-remade/universal-modder/pull/85
Author: @Griffdog21
Created: 10/5/2026
Status: ✅ Merged
Merged: 10/5/2026
Merged by: @rehan-remade

Base: main ← Head: kb/portal-2-portalcraft-official-launcher

📝 Commits (2)

d4395e7 kb: Portalcraft: start Minecraft from the player's own launcher
1cf83b0 Merge main into kb/portal-2-portalcraft-official-launcher and regenerate the kb index

📊 Changes

2 files changed (+57 additions, -26 deletions)

View changed files

📝 knowledge/games/portal-2/portalcraft-minecraft-inside-portal-2.md (+55 -25)
📝 knowledge/index.json (+2 -1)

📄 Description

What: Portal 2 + Minecraft Java Edition: the Portalcraft field note now describes starting Minecraft from the player's own official Minecraft Launcher, signed in, instead of an installer that started it offline with a fixed name (the change asked for in the review of #63).

Field note: Portalcraft: real Minecraft inside Portal 2 (passthrough mod)

game: Portal 2
engine / route: source / passthrough
status: working
agents: Claude Code (Opus 5.5)

Changes to the note

Setup, build steps, assets and verification describe the launcher route. Setup adds a "Portalcraft" installation to the player's launcher: Fabric's version JSON plus a launcher_profiles.json entry with its own gameDir and -D options. Offline runs are only for development (Loom runClient). Verified end to end with the Microsoft Store launcher: signed-in Minecraft composited in a campaign level, and launcher_profiles.json was unchanged after uninstalling.
New Gotcha 18: adding a launcher installation the way Fabric's installer does. The launcher splits javaArgs at spaces and has no field for game arguments, and the Xbox app launcher reads %APPDATA%\.minecraft too.
New Gotcha 19: clicking the launcher's Play in automated tests. Its CEF UI has no accessibility tree, and there is a "modified installation" warning.
Gotcha 17 is reworded: Fabric's version JSON has no checksum for the loader itself.
Gotcha 8 is marked as dev runs only.

Checklist

um kb check passes (field notes) / uv run --with pytest pytest -q tests passes (code)
um kb index regenerated (field notes)
no game files, extracted assets, decompiled code dumps or secrets
nothing that cheats other players or bypasses anti-cheat / DRM / ownership checks
versions, verification and what was NOT verified are written down
authored by (agent + model / human): Claude Code (Opus 5.5) with @griffdog21

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rehan-remade/universal-modder/pull/85 **Author:** [@Griffdog21](https://github.com/Griffdog21) **Created:** 10/5/2026 **Status:** ✅ Merged **Merged:** 10/5/2026 **Merged by:** [@rehan-remade](https://github.com/rehan-remade) **Base:** `main` ← **Head:** `kb/portal-2-portalcraft-official-launcher` --- ### 📝 Commits (2) - [`d4395e7`](https://github.com/rehan-remade/universal-modder/commit/d4395e7ea15a56344ace878ff8f9e6706d88e944) kb: Portalcraft: start Minecraft from the player's own launcher - [`1cf83b0`](https://github.com/rehan-remade/universal-modder/commit/1cf83b05bf47ac129ca1cc2f5b1affd221c92719) Merge main into kb/portal-2-portalcraft-official-launcher and regenerate the kb index ### 📊 Changes **2 files changed** (+57 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `knowledge/games/portal-2/portalcraft-minecraft-inside-portal-2.md` (+55 -25) 📝 `knowledge/index.json` (+2 -1) </details> ### 📄 Description **What:** Portal 2 + Minecraft Java Edition: the Portalcraft field note now describes starting Minecraft from the player's own official Minecraft Launcher, signed in, instead of an installer that started it offline with a fixed name (the change asked for in the review of #63). Field note: **Portalcraft: real Minecraft inside Portal 2 (passthrough mod)** - game: Portal 2 - engine / route: source / passthrough - status: working - agents: Claude Code (Opus 5.5) **Changes to the note** - Setup, build steps, assets and verification describe the launcher route. Setup adds a "Portalcraft" installation to the player's launcher: Fabric's version JSON plus a `launcher_profiles.json` entry with its own `gameDir` and `-D` options. Offline runs are only for development (Loom `runClient`). Verified end to end with the Microsoft Store launcher: signed-in Minecraft composited in a campaign level, and `launcher_profiles.json` was unchanged after uninstalling. - New Gotcha 18: adding a launcher installation the way Fabric's installer does. The launcher splits `javaArgs` at spaces and has no field for game arguments, and the Xbox app launcher reads `%APPDATA%\.minecraft` too. - New Gotcha 19: clicking the launcher's Play in automated tests. Its CEF UI has no accessibility tree, and there is a "modified installation" warning. - Gotcha 17 is reworded: Fabric's version JSON has no checksum for the loader itself. - Gotcha 8 is marked as dev runs only. **Checklist** - [x] `um kb check` passes (field notes) / `uv run --with pytest pytest -q tests` passes (code) - [x] `um kb index` regenerated (field notes) - [x] no game files, extracted assets, decompiled code dumps or secrets - [x] nothing that cheats other players or bypasses anti-cheat / DRM / ownership checks - [x] versions, verification and what was NOT verified are written down - [x] authored by (agent + model / human): Claude Code (Opus 5.5) with @griffdog21 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 20:53:29 +00:00