[PR #243] [MERGED] kb search: show the lines that match the most terms first #246

New issue

Closed

opened 2026-10-15 20:54:45 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 20:54:45 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rehan-remade/universal-modder/pull/243
Author: @aetherna1111-glitch
Created: 10/11/2026
Status: ✅ Merged
Merged: 10/12/2026
Merged by: @rehan-remade

Base: main ← Head: feat/kb-search-best-hit-lines

📝 Commits (4)

5112165 kb search: show the lines that match the most terms first
6fb6224 tests: the new kb search test in its own file
2dd6b6b kb search: sort hit lines by count alone (sorted() is stable)
39c5b5f Merge remote-tracking branch 'origin/main' into land/pr-243

📊 Changes

2 files changed (+20 additions, -1 deletions)

View changed files

➕ tests/test_kb_search_hits.py (+16 -0)
📝 um/kb.py (+4 -1)

📄 Description

What: um kb search lists a note's hit lines with the lines matching the most query terms first, then in note order. Test included (in its own file, so it does not collide with other test additions).

Checklist

um kb check passes (field notes) / uv run --with pytest pytest -q tests passes (code)
um kb index regenerated (field notes) — not applicable, no note changed
no game files, extracted assets, decompiled code dumps or secrets
nothing that cheats other players or bypasses anti-cheat / DRM / ownership checks
versions, verification and what was NOT verified are written down
authored by (agent + model / human): Claude Code with @aetherna1111-glitch

🤖 Generated with Claude Code

https://claude.ai/code/session_01KKNUp8RuduYreNsFM6rvZg

Generated by Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rehan-remade/universal-modder/pull/243 **Author:** [@aetherna1111-glitch](https://github.com/aetherna1111-glitch) **Created:** 10/11/2026 **Status:** ✅ Merged **Merged:** 10/12/2026 **Merged by:** [@rehan-remade](https://github.com/rehan-remade) **Base:** `main` ← **Head:** `feat/kb-search-best-hit-lines` --- ### 📝 Commits (4) - [`5112165`](https://github.com/rehan-remade/universal-modder/commit/5112165cfaf041bb7ce37b6139acac0e20d0e5f5) kb search: show the lines that match the most terms first - [`6fb6224`](https://github.com/rehan-remade/universal-modder/commit/6fb622416981f50507cc6772b3dfd627ce97309f) tests: the new kb search test in its own file - [`2dd6b6b`](https://github.com/rehan-remade/universal-modder/commit/2dd6b6bc206ca20c85cd3987b0c0d2cd4446ef79) kb search: sort hit lines by count alone (sorted() is stable) - [`39c5b5f`](https://github.com/rehan-remade/universal-modder/commit/39c5b5fb02c9f16d690b018b9785c90e68bd5276) Merge remote-tracking branch 'origin/main' into land/pr-243 ### 📊 Changes **2 files changed** (+20 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `tests/test_kb_search_hits.py` (+16 -0) 📝 `um/kb.py` (+4 -1) </details> ### 📄 Description **What:** `um kb search` lists a note's hit lines with the lines matching the most query terms first, then in note order. Test included (in its own file, so it does not collide with other test additions). **Checklist** - [x] `um kb check` passes (field notes) / `uv run --with pytest pytest -q tests` passes (code) - [ ] `um kb index` regenerated (field notes) — not applicable, no note changed - [x] no game files, extracted assets, decompiled code dumps or secrets - [x] nothing that cheats other players or bypasses anti-cheat / DRM / ownership checks - [x] versions, verification and what was NOT verified are written down - [x] authored by (agent + model / human): Claude Code with @aetherna1111-glitch 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01KKNUp8RuduYreNsFM6rvZg --- _Generated by [Claude Code](https://claude.ai/code/session_01VfBVHMBywxdbaizz8uKQPN)_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 20:54:45 +00:00