[PR #244] [MERGED] kb search: a quoted multi-word query also matches notes with all of its words #247

New issue

Closed

opened 2026-10-15 20:54:45 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 20:54:45 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rehan-remade/universal-modder/pull/244
Author: @aetherna1111-glitch
Created: 10/11/2026
Status: ✅ Merged
Merged: 10/12/2026
Merged by: @rehan-remade

Base: main ← Head: feat/kb-search-split-quoted-queries

📝 Commits (4)

8df4689 kb search: a quoted multi-word query also matches notes with all of its words
0f9b149 tests: the new kb search test in its own file
1c12548 kb search: say that unquoted arguments stay OR-ed, and test it
4b1ecae Merge remote-tracking branch 'origin/main' into land/pr-244

📊 Changes

3 files changed (+41 additions, -1 deletions)

View changed files

📝 knowledge/README.md (+1 -0)
➕ tests/test_kb_search_quoted.py (+20 -0)
📝 um/kb.py (+20 -1)

📄 Description

What: A quoted multi-word query (um kb search "grand theft auto") also finds notes that contain all of its words apart; the exact phrase still ranks first. Test included (in its own file).

Checklist

um kb check passes (field notes) / uv run --with pytest pytest -q tests passes (code)
um kb index regenerated (field notes) — not applicable, no note changed
no game files, extracted assets, decompiled code dumps or secrets
nothing that cheats other players or bypasses anti-cheat / DRM / ownership checks
versions, verification and what was NOT verified are written down
authored by (agent + model / human): Claude Code with @aetherna1111-glitch

🤖 Generated with Claude Code

https://claude.ai/code/session_01KKNUp8RuduYreNsFM6rvZg

Generated by Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rehan-remade/universal-modder/pull/244 **Author:** [@aetherna1111-glitch](https://github.com/aetherna1111-glitch) **Created:** 10/11/2026 **Status:** ✅ Merged **Merged:** 10/12/2026 **Merged by:** [@rehan-remade](https://github.com/rehan-remade) **Base:** `main` ← **Head:** `feat/kb-search-split-quoted-queries` --- ### 📝 Commits (4) - [`8df4689`](https://github.com/rehan-remade/universal-modder/commit/8df4689e68400df9c620d828f0a66c9d68b82321) kb search: a quoted multi-word query also matches notes with all of its words - [`0f9b149`](https://github.com/rehan-remade/universal-modder/commit/0f9b149a4c83050964567da1fdb6128ce81d6b0f) tests: the new kb search test in its own file - [`1c12548`](https://github.com/rehan-remade/universal-modder/commit/1c12548744887a22c0eb875a7b2d5dbd2b0d3c5a) kb search: say that unquoted arguments stay OR-ed, and test it - [`4b1ecae`](https://github.com/rehan-remade/universal-modder/commit/4b1ecae4a2bb82c31797cfc78ee9c84cebaeca45) Merge remote-tracking branch 'origin/main' into land/pr-244 ### 📊 Changes **3 files changed** (+41 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `knowledge/README.md` (+1 -0) ➕ `tests/test_kb_search_quoted.py` (+20 -0) 📝 `um/kb.py` (+20 -1) </details> ### 📄 Description **What:** A quoted multi-word query (`um kb search "grand theft auto"`) also finds notes that contain all of its words apart; the exact phrase still ranks first. Test included (in its own file). **Checklist** - [x] `um kb check` passes (field notes) / `uv run --with pytest pytest -q tests` passes (code) - [ ] `um kb index` regenerated (field notes) — not applicable, no note changed - [x] no game files, extracted assets, decompiled code dumps or secrets - [x] nothing that cheats other players or bypasses anti-cheat / DRM / ownership checks - [x] versions, verification and what was NOT verified are written down - [x] authored by (agent + model / human): Claude Code with @aetherna1111-glitch 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01KKNUp8RuduYreNsFM6rvZg --- _Generated by [Claude Code](https://claude.ai/code/session_01VfBVHMBywxdbaizz8uKQPN)_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 20:54:45 +00:00