[PR #1] [MERGED] fix(scan): preserve Unicode in Steam game discovery #50

New issue

Closed

opened 2026-10-15 20:53:01 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 20:53:01 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rehan-remade/universal-modder/pull/1
Author: @Bortlesboat
Created: 9/30/2026
Status: ✅ Merged
Merged: 9/30/2026
Merged by: @rehan-remade

Base: main ← Head: fix/steam-manifest-utf8

📝 Commits (1)

0e06552 fix(scan): preserve Unicode in Steam game discovery

📊 Changes

2 files changed (+38 additions, -2 deletions)

View changed files

📝 tests/test_um.py (+36 -0)
📝 um/scan.py (+2 -2)

📄 Description

um scan now preserves non-ASCII Steam game names and finds games in non-ASCII library and install folders on Windows with a non-UTF-8 default encoding. A real scan displayed The Sims™ 4 as The Simsâ„¢ 4; the same decoding issue makes accented paths fail the directory check and disappear from results.

Four real-file regression cases cover ASCII input and non-ASCII display names, install folders, and library folders under a simulated cp1252 default. Before the fix, three cases failed; afterward, all 19 tests pass on Ubuntu/WSL and the real Windows scan displays the correct title.

Native Windows testing: 18 passed, with the existing test_publish_check path-separator failure also reproduced from the unchanged upstream test. Test collection used Git's which.exe on the process PATH because the existing ffmpeg check calls which.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rehan-remade/universal-modder/pull/1 **Author:** [@Bortlesboat](https://github.com/Bortlesboat) **Created:** 9/30/2026 **Status:** ✅ Merged **Merged:** 9/30/2026 **Merged by:** [@rehan-remade](https://github.com/rehan-remade) **Base:** `main` ← **Head:** `fix/steam-manifest-utf8` --- ### 📝 Commits (1) - [`0e06552`](https://github.com/rehan-remade/universal-modder/commit/0e065528fc80c15f49b8fb8281ac86cb00a2b39b) fix(scan): preserve Unicode in Steam game discovery ### 📊 Changes **2 files changed** (+38 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `tests/test_um.py` (+36 -0) 📝 `um/scan.py` (+2 -2) </details> ### 📄 Description `um scan` now preserves non-ASCII Steam game names and finds games in non-ASCII library and install folders on Windows with a non-UTF-8 default encoding. A real scan displayed `The Sims™ 4` as `The Simsâ„¢ 4`; the same decoding issue makes accented paths fail the directory check and disappear from results. Four real-file regression cases cover ASCII input and non-ASCII display names, install folders, and library folders under a simulated cp1252 default. Before the fix, three cases failed; afterward, all 19 tests pass on Ubuntu/WSL and the real Windows scan displays the correct title. Native Windows testing: 18 passed, with the existing `test_publish_check` path-separator failure also reproduced from the unchanged upstream test. Test collection used Git's `which.exe` on the process PATH because the existing ffmpeg check calls `which`. --- [![Compound Engineering](https://img.shields.io/badge/Built_with-Compound_Engineering-6366f1)](https://github.com/EveryInc/compound-engineering-plugin) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 20:53:01 +00:00