[PR #12] [MERGED] fix tests on Windows #58

New issue

Closed

opened 2026-10-15 20:53:04 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 20:53:04 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rehan-remade/universal-modder/pull/12
Author: @kuishou68
Created: 10/3/2026
Status: ✅ Merged
Merged: 10/4/2026
Merged by: @rehan-remade

Base: main ← Head: cocoon-fix-universal-modder

📝 Commits (1)

1db2355 fix tests on Windows

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 tests/test_um.py (+4 -2)

📄 Description

Summary

use shutil.which instead of the Unix-only which command when detecting ffmpeg
normalize path separators in the publish-check assertion

Validation

uv run --with pytest pytest -q tests (21 passed, 1 skipped)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rehan-remade/universal-modder/pull/12 **Author:** [@kuishou68](https://github.com/kuishou68) **Created:** 10/3/2026 **Status:** ✅ Merged **Merged:** 10/4/2026 **Merged by:** [@rehan-remade](https://github.com/rehan-remade) **Base:** `main` ← **Head:** `cocoon-fix-universal-modder` --- ### 📝 Commits (1) - [`1db2355`](https://github.com/rehan-remade/universal-modder/commit/1db235503adcc2b6ac1283236e91260a6b2e88aa) fix tests on Windows ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `tests/test_um.py` (+4 -2) </details> ### 📄 Description ## Summary - use shutil.which instead of the Unix-only which command when detecting ffmpeg - normalize path separators in the publish-check assertion ## Validation - uv run --with pytest pytest -q tests (21 passed, 1 skipped) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 20:53:04 +00:00