[GH-ISSUE #200] Download dir for deluge is retrieved incorrectly #152

New issue

Closed

opened 2026-10-13 19:49:59 +00:00 by bsakaguchi · 3 comments

bsakaguchi commented

2026-10-13 19:49:59 +00:00

Owner

Originally created by @DSilence on GitHub (Feb 21, 2017).
Original GitHub issue: https://github.com/werwolfby/monitorrent/issues/200

Originally assigned to: @DSilence on GitHub.

The correct settings name should be "move_completed_path" instead of "download_location". Download location only represents temp directory for current download

Originally created by @DSilence on GitHub (Feb 21, 2017). Original GitHub issue: https://github.com/werwolfby/monitorrent/issues/200 Originally assigned to: @DSilence on GitHub. The correct settings name should be "move_completed_path" instead of "download_location". Download location only represents temp directory for current download

bsakaguchi

2026-10-13 19:49:59 +00:00

closed this issue
added the
bug
label

bsakaguchi commented

2026-10-13 19:50:00 +00:00

Author

Owner

@werwolfby commented on GitHub (Feb 21, 2017):

And find_torrent for deluge doesn't work as well 😞

@werwolfby commented on GitHub (Feb 21, 2017): And `find_torrent` for deluge doesn't work as well 😞

bsakaguchi commented

2026-10-13 19:50:01 +00:00

Author

Owner

@DSilence commented on GitHub (Feb 22, 2017):

Will take a look at that.

@DSilence commented on GitHub (Feb 22, 2017): Will take a look at that.

bsakaguchi commented

2026-10-13 19:50:02 +00:00

Author

Owner

@werwolfby commented on GitHub (Feb 22, 2017):

Examples from gitter (thanks to @dein0s):

FAILED
Exception while execute
Traceback (most recent call last):
  File "c:\Program Files (x86)\Monitorrent\monitorrent\plugins\trackers\__init__.py", line 245, in execute
    TopicSettings.from_topic(topic))
  File "c:\Program Files (x86)\Monitorrent\monitorrent\engine.py", line 315, in add_torrent
    return self.engine.add_torrent(filename, torrent, old_hash, topic_settings)
  File "c:\Program Files (x86)\Monitorrent\monitorrent\engine.py", line 99, in add_torrent
    existing_torrent = self.clients_manager.find_torrent(torrent.info_hash)
  File "c:\Program Files (x86)\Monitorrent\monitorrent\plugin_managers.py", line 204, in find_torrent
    result = self.default_client.find_torrent(torrent_hash)
  File "c:\Program Files (x86)\Monitorrent\monitorrent\plugins\clients\deluge.py", line 116, in find_torrent
    "name": torrent['name'],
KeyError: 'name'

And result dictionary from Deluge

{b'name': b'Big Little Lies (Season 01)', b'time_added': 1487623424.0}

It is bytes, not a regular string while in tests and in code we are trying access to this dictionary by string keys.

@werwolfby commented on GitHub (Feb 22, 2017): Examples from gitter (thanks to @dein0s): ``` FAILED Exception while execute Traceback (most recent call last): File "c:\Program Files (x86)\Monitorrent\monitorrent\plugins\trackers\__init__.py", line 245, in execute TopicSettings.from_topic(topic)) File "c:\Program Files (x86)\Monitorrent\monitorrent\engine.py", line 315, in add_torrent return self.engine.add_torrent(filename, torrent, old_hash, topic_settings) File "c:\Program Files (x86)\Monitorrent\monitorrent\engine.py", line 99, in add_torrent existing_torrent = self.clients_manager.find_torrent(torrent.info_hash) File "c:\Program Files (x86)\Monitorrent\monitorrent\plugin_managers.py", line 204, in find_torrent result = self.default_client.find_torrent(torrent_hash) File "c:\Program Files (x86)\Monitorrent\monitorrent\plugins\clients\deluge.py", line 116, in find_torrent "name": torrent['name'], KeyError: 'name' ``` And result dictionary from Deluge ``` {b'name': b'Big Little Lies (Season 01)', b'time_added': 1487623424.0} ``` It is bytes, not a regular string while in tests and in code we are trying access to this dictionary by string keys.

bsakaguchi referenced this issue

2026-10-13 19:56:39 +00:00

[PR #152] [MERGED] #137 Fixed several issues with default value for DBEngineRunner.interval #369