[PR #152] [MERGED] #137 Fixed several issues with default value for DBEngineRunner.interval #369

New issue

Closed

opened 2026-10-13 19:56:39 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-13 19:56:39 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/werwolfby/monitorrent/pull/152
Author: @vlad-nikityuk
Created: 11/9/2016
Status: ✅ Merged
Merged: 11/15/2016
Merged by: @werwolfby

Base: develop ← Head: issues/137-fix

📝 Commits (1)

8af1451 Fixed several issues with default value for DBEngineRunner.interval

📊 Changes

4 files changed (+158 additions, -61 deletions)

View changed files

📝 monitorrent/engine.py (+11 -4)
📝 monitorrent/utils/timers.py (+5 -1)
📝 tests/test_engine.py (+127 -55)
📝 tests/utils/test_timers.py (+15 -1)

📄 Description

_create_timer() was not called on interval property setter. Overriding properties interval and last_execute copy behavior from EngineRunner. This solution is simpler comparing to calling overridden properties of base class from child class, tests ensure consistency.
Added daemon=True for EngineRunner and timer threads.
Added maxi-tor.org to list of domain names for rutor.info

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/werwolfby/monitorrent/pull/152 **Author:** [@vlad-nikityuk](https://github.com/vlad-nikityuk) **Created:** 11/9/2016 **Status:** ✅ Merged **Merged:** 11/15/2016 **Merged by:** [@werwolfby](https://github.com/werwolfby) **Base:** `develop` ← **Head:** `issues/137-fix` --- ### 📝 Commits (1) - [`8af1451`](https://github.com/werwolfby/monitorrent/commit/8af1451e703b4e0332f75232de9fbf4673b156dd) Fixed several issues with default value for DBEngineRunner.interval ### 📊 Changes **4 files changed** (+158 additions, -61 deletions) <details> <summary>View changed files</summary> 📝 `monitorrent/engine.py` (+11 -4) 📝 `monitorrent/utils/timers.py` (+5 -1) 📝 `tests/test_engine.py` (+127 -55) 📝 `tests/utils/test_timers.py` (+15 -1) </details> ### 📄 Description - `_create_timer()` was not called on `interval` property setter. Overriding properties `interval` and `last_execute` copy behavior from EngineRunner. This solution is simpler comparing to calling overridden properties of base class from child class, tests ensure consistency. - Added `daemon=True` for EngineRunner and timer threads. - Added maxi-tor.org to list of domain names for rutor.info --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-13 19:56:39 +00:00