Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-04-20 06:20:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: use dispatchEvent to bypass canvas overlay for dialog dismiss

Browse Source 
The dialog's click-outside handler (LGraphCanvas.prompt L7175-7190)
registers via setTimeout(10ms) with a 256ms debounce. The canvas
z-999 overlay blocks normal Playwright click() and force:true
doesn't set e.target to the canvas element. dispatchEvent('click')
bypasses the overlay while correctly targeting the canvas. Custom
toPass intervals [300, 500, 1000] start past the 266ms debounce.
This commit is contained in:
Glary-Bot
2026-04-08 05:53:54 +00:00
parent 78b0ec5efb
commit c205530282
1 changed files with 7 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
browser_tests/tests/interaction.spec.ts
View File

@@ -358,13 +358,13 @@ test.describe('Node Interaction', () => {
})
const legacyPrompt = comfyPage.page.locator('.graphdialog')
await expect(legacyPrompt).toBeVisible()
// The dialog registers its click-outside handler via setTimeout(10ms)
// with a 256ms debounce (see LGraphCanvas.prompt). dispatchEvent
// bypasses the canvas z-999 overlay that blocks normal clicks.
await expect(async () => {
await comfyPage.canvas.click({
position: { x: 10, y: 10 },
force: true
})
await comfyPage.canvas.dispatchEvent('click', { bubbles: true })
await expect(legacyPrompt).toBeHidden()
}).toPass({ timeout: 5_000 })
}).toPass({ intervals: [300, 500, 1000], timeout: 5_000 })
})
test('Can close prompt dialog with canvas click (text widget)', async ({
@@ -381,12 +381,9 @@ test.describe('Node Interaction', () => {
const legacyPrompt = comfyPage.page.locator('.graphdialog')
await expect(legacyPrompt).toBeVisible()
await expect(async () => {
await comfyPage.canvas.click({
position: { x: 10, y: 10 },
force: true
})
await comfyPage.canvas.dispatchEvent('click', { bubbles: true })
await expect(legacyPrompt).toBeHidden()
}).toPass({ timeout: 5_000 })
}).toPass({ intervals: [300, 500, 1000], timeout: 5_000 })
})
test(