Compare commits

..

83 Commits

Author SHA1 Message Date
Nathaniel Parson Koroso
fabf39001c test: address custom-node suite review feedback
- run the backend-touching specs in a dedicated `custom-nodes` Playwright
  project (tagged @custom-nodes in their titles) so the main sharded e2e job
  no longer collects them; their afterEach queue-drain used interrupt(null)
  and could cancel a parallel worker's in-flight prompt
- gating job uses --reporter=list,json,html so playwright-report/ (with the
  on-first-retry traces) is actually produced and uploaded, not discarded
- keep system Chrome for local runs but retain traces on failure; the
  trace:off workaround was stale (verified branded Chrome + trace records
  fine on the current Playwright pin)
- route NodeSlotReference.getPosition through canvasPosToClientPos instead of
  hand-rolled convertOffsetToCanvas + rect math, and drop a debug console.warn
- hoist expectNoVisibleErrors into errorSurfaces.ts (was duplicated across
  three specs and inlined in a fourth)
- delete the unused preValidate validator and its change-detector tests
- collapse expectedNodesPresent to missingExpectedNodes (a filter)
- batchAutoRunnable uses es-toolkit chunk
- log the per-pack registered node count (calibrates a follow-up
  expectedNodeCount guard against silent coverage shrinkage)

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-16 08:18:07 +08:00
Nathaniel Parson Koroso
2a6397e41d Merge branch 'main' into nathaniel/custom-node-e2e-suite
Conflict: src/i18n.ts st() - resolved to main's #13631 (the canonical
version of the same boot fix: rethrow non-SyntaxError, preserve raw
translation on compile errors).
2026-07-16 05:28:30 +08:00
Nathaniel Parson Koroso
d258e9bde2 test(custom-nodes): extension-loaded assert + dynamic-input autogrow tier
What

- manifest: required expectedExtensions per pack (validated: unique
  non-empty names; [] = explicit no-frontend-JS declaration), calibrated
  from each pinned pack's source (WAS ships no frontend JS at its pin)
- T0 load tier: assert every declared extension registered in
  window.app.extensions after boot
- new dynamicInputs.spec.ts: curated autogrow nodes grow one input on
  connecting the last slot and shrink back on disconnect, via BOTH a real
  mouse drag and a programmatic connect, under both renderers, asserted in
  the graph AND as rendered Vue slot rows in both directions
- VueNodeHelpers: output-side slot-row/dot locators (mirrors input side);
  connectivity drag test reuses them
- docs: README/ARCHITECTURE/ADDING_CUSTOM_NODES rows incl. the 6a
  dev-server carve-out (pack JS never loads there; those two surfaces are
  proven in 6b/CI)

Why

- backend nodes can register while a pack's frontend JS silently fails to
  load (wrong web dir, a loadExtensions regression) - nothing red-flagged
  that, and every JS-driven suite behavior would quietly vanish
- dynamic slot growth lives in pack JS (onConnectionsChange), invisible to
  /object_info, so no def-driven tier could see the CombineRegionalPrompts
  class of regression

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-16 05:28:30 +08:00
ShihChi Huang
6d0bbd7d7c perf: shard Chromium E2E across 16 jobs (#13650)
## Summary

> [!NOTE]
> Bumping to [24
shards](https://github.com/Comfy-Org/ComfyUI_frontend/pull/13664)
reduces time from 11m14s to 9m31s, but costs 15% more in GitHub Action
runner time. Keep it 16 for now to be conservative and bump to 24 if it
works well for a week

Split Chromium E2E into 16 shards with two Playwright workers each,
preserving the current per-runner worker density while doubling
effective concurrency.

### 16 shards
| Run | E2E time | Shards |
|---|---:|---:|
|
[1](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/29370163062)
| 11m38s | 16/16 pass |
|
[2](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/29371313957)
| 11m32s | 16/16 pass |
|
[3](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/29372283949)
| 10m50s | 16/16 pass |
|
[4](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/29373163198)
| 11m00s | 16/16 pass |
|
[5](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/29374055787)
| 11m12s | 16/16 pass |

### 24 shards
| Run | E2E time | Shards |
|---|---:|---:|
|
[1](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/29379798083)
| 9m13s | 24/24 pass |
|
[2](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/29380286857)
| 9m33s | 24/24 pass |
|
[3](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/29380761689)
| 9m38s | 24/24 pass |
|
[4](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/29381219308)
| 10m02s | 24/24 pass |
|
[5](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/29381669526)
| 9m07s | 24/24 pass |

## Changes

- **What**: Run Chromium as 16 shards with explicit `--workers=2`.

## Review Focus

- Compare full E2E time, shard skew, runner queue time, and flakiness
with the 8×2 baseline.

## Validation

- YAML parse and oxfmt check
- Pre-commit formatting, linting, and root typecheck
- Pre-push Knip
- Local CodeRabbit review is rate-limited for 24 minutes; server-side
CodeRabbit remains pending.

Created by Codex


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Changes are limited to CI workflow and Playwright config; no
application runtime, auth, or data paths are touched.
> 
> **Overview**
> **Chromium E2E CI** now runs as **16 parallel shards** (up from 8),
with **`workers: 2` on CI** in `playwright.config.ts` so each runner
keeps two Playwright workers while overall concurrency doubles.
> 
> Reporter wiring shifts so **blob output is chosen in config** when
`PLAYWRIGHT_BLOB_OUTPUT_DIR` is set (default reporter is `html`
otherwise); workflow steps drop inline `--reporter=blob` from the
Playwright CLI for both sharded Chromium and the other browser matrix
jobs.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
3707e70611. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: huang47 <157390+huang47@users.noreply.github.com>
2026-07-15 20:08:33 +00:00
imick-io
4341972be3 fix(website): remove opacity-80 washing out footer logo colors (#13648)
## Problem
The animated logo in the site footer (a webp frame sequence drawn to a
`<canvas>`) renders with dull, darkened colors. The brand neon yellow
`rgb(242, 255, 90)` shows up as a muddy olive `≈ rgb(198, 209, 80)`, and
the gray/pastel faces are darkened and purple-tinted.

## Cause
The footer `<canvas>` carried an `opacity-80` Tailwind class. At 80%
opacity the browser composites the animation 20% over the dark purple
footer background (`rgb(33, 25, 39)`), shifting every color. The source
webp frames themselves are correct — the shift only happens at display
time.

## Fix
Remove `opacity-80` from the canvas in `SiteFooter.vue` so it renders
the authored frame colors at full opacity.

## Verify
- Pre-check (no deploy): in DevTools, select the footer `<canvas>` and
untick `opacity: 0.8` — colors pop back immediately.
- After change: sample a yellow cube face in the footer animation with a
color picker — it should read `#F2FF5A` / `rgb(242, 255, 90)`, not
`rgb(198, 209, 80)`.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-15 14:29:55 +00:00
CodeJuggernaut
98700cfcc7 feat: marquee select and Ctrl/Cmd+A in the Media Assets panel (#13323)
## Summary

Adds marquee (rubber-band) multi-select and Ctrl/Cmd+A select-all to the
Media Assets panel, clips the canvas drag-selection rectangle to the
canvas panel, and turns on live (real-time) node-graph rubber-band
selection by default.

## Changes

- **Marquee select** — rubber-band drag from empty grid space selects
the covered cards; hold Ctrl/Cmd to start a marquee from over a card;
Ctrl/Cmd or Shift alone makes the marquee additive to the current
selection, Ctrl/Cmd+Shift subtracts the covered cards from it
(designer-approved), and no modifier replaces it. Cards update their
selected state live during the drag.
- **Ctrl/Cmd+A** — selects all loaded assets when the pointer is over
the panel, otherwise falls through to the canvas (select all nodes). It
`stopImmediatePropagation`s so a panel select-all never also fires the
global node select-all, and it yields while an `aria-modal` dialog is
open or a text input is focused.
- **Select-all recovers after "deselect all"** — the shortcut was gated
only on `useElementHover`, which latched stale when the floating
selection bar under the cursor unmounted on deselect. It now also checks
the live pointer position against the panel rect, so a second Ctrl/Cmd+A
right after deselecting no longer falls through to the browser's native
page select-all.
- **Canvas rectangle clip** — the canvas drag-selection rectangle is
clamped to the canvas panel bounds (`SelectionRectangle.vue`,
display-only).
- **Graph live selection on by default** — flips the existing
`Comfy.Graph.LiveSelection` setting's default to on, so node-graph
rubber-band selection updates in real time during the drag (matching the
assets panel) instead of committing only on mouse-up. The behavior was
already implemented behind the setting; this changes only the default,
and users with an explicit value keep it.
- **Robustness/UX** — the pointer is captured on drag-engage rather than
on press (so a Ctrl/Cmd-click on a card isn't hijacked); no global
`document.body.userSelect` mutation (replaced by a panel-scoped
`selectstart` guard); the marquee overlay uses the semantic
`primary-background` token; post-drag click-suppression auto-resets so a
cancelled drag can't swallow a later click; `setPointerCapture` is
wrapped in try/catch; a Ctrl/Cmd-held card `dragstart` is cancelled so
no native ghost-drag image appears.
- **Breaking**: none — `useAssetSelection` is extended additively (new
`setSelectedIds` helper, nothing removed or altered) and the new
composable exposes only `{ marqueeStyle }`.
- **Dependencies**: none.

## Review Focus

- **`SelectionRectangle.vue`** is shared canvas code; the change is
display-only (clamps the rectangle to the panel; no node-selection
behavior change).
- **`coreSettings.ts`** — a one-line `Comfy.Graph.LiveSelection` default
flip is the only change that affects graph behavior; the live-select
code path itself is pre-existing.
- **`useAssetGridSelection.ts`** — listener lifecycle/teardown, the
panel-scoped `selectstart` guard, the click-suppression timer, the
capture-on-drag-engage logic, the pointer-position select-all fallback,
and the subtractive-mode snapshot at pointerdown.
- **Ctrl/Cmd+A routing** — panel hover (or a live pointer inside the
panel) gates select-all vs. the canvas, and `stopImmediatePropagation`
prevents double-handling.
- Pure geometry/selection logic is extracted into
`marqueeSelectionUtil.ts` and unit-tested in isolation (`RectEdges` is
`Pick<DOMRect, ...>`, the DOM edge subset); `MediaAssetCard.dragStart`
keeps `main`'s `display_name` payload.

Relates to Linear **FE-910**.

## Testing

- **Unit:** `useAssetGridSelection` (39 cases — marquee selection,
additive/replace, subtractive Ctrl/Cmd+Shift (incl. the macOS Cmd
variant and a shrink-restore drag), interactive-element + list-view
guards, `selectstart` scoping, click-suppression auto-reset,
pointer-capture-throw and capture-on-drag-not-press, modal-aware
Ctrl/Cmd+A, non-propagation, and the deselect-recovery pointer-in-panel
path), plus `MediaAssetCard`, `marqueeSelectionUtil` (11 cases incl.
subtractive, and a 5-case fast-check property suite pinning the
additive/subtractive set invariants), `SelectionRectangle`,
`useAssetSelection`, and `mathUtil`.
- **E2E (`assetsSidebarTab.spec.ts`):** 10 Playwright scenarios running
in CI — Ctrl/Cmd+A hover vs. canvas; a marquee from the panel header; a
modifier-held additive marquee; a Ctrl/Cmd+Shift subtractive marquee;
Ctrl/Cmd-drag from a card and within a single card; Ctrl/Cmd+A ignored
in a focused search box and under an aria-modal dialog; and a drag from
the search box not marquee-selecting. The empty-space marquee path is
covered by the panel-header scenario plus the unit suite (a dedicated
empty-space e2e could not run headless without a local backend and was
dropped as redundant).

## Future work

- **Escape key** — not handled by the marquee/select-all flow yet (the
composable handles only Ctrl/Cmd+A). Follow-up: press Escape to cancel
an in-progress marquee drag (abort the rubber-band and restore the
pre-drag selection) and to clear the current selection while the panel
has focus.
- **Ctrl+A across pagination** — select-all covers the loaded assets
only (confirmed as the intended behavior with design); a
load-all-then-select variant can follow if needed.

## Demo


https://github.com/user-attachments/assets/3841bf3c-db75-4229-a5e7-fb363b4882d6
2026-07-15 09:20:31 +00:00
Comfy Org PR Bot
5bf41a41bd 1.48.3 (#13606)
Patch version increment to 1.48.3

**Base branch:** `main`

---------

Co-authored-by: christian-byrne <72887196+christian-byrne@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>
2026-07-15 02:38:12 +00:00
CodeJuggernaut
a7f14a0b3f fix(subscription): size pricing dialogs with Reka props (#13633)
## Summary

Fixes the legacy personal and legacy workspace pricing dialogs so Reka
owns the dialog width and the pricing table no longer overflows the
default 576px frame.

## Changes

- **What**: Replace the shared PrimeVue-only `style` and `pt` dialog
props with Reka `renderer`, `size`, and `contentClass` props for both
legacy pricing paths.
- **What**: Preserve `modal: false` for the legacy workspace path so its
teleported PrimeVue plan-details popover remains interactive.
- **What**: Add unit coverage for both routes and assert that ignored
PrimeVue shell props are no longer passed.

## Review Focus

- **Regression origin**:
[#12593](https://github.com/Comfy-Org/ComfyUI_frontend/pull/12593) made
Reka the default dialog renderer.
[#12666](https://github.com/Comfy-Org/ComfyUI_frontend/pull/12666) then
added shared PrimeVue `style` and `pt` props for these pricing dialogs.
Reka ignored those props and fell back to `size="md"` (`max-w-xl`,
576px).
[#13092](https://github.com/Comfy-Org/ComfyUI_frontend/pull/13092) fixed
the unified pricing path only and explicitly left the two legacy paths
for follow-up.
- **Sizing ownership**: The fix puts width on the Reka dialog frame with
`size: 'full'` and `sm:max-w-7xl`. Pricing content no longer has to
compensate for a narrow shell.
- **Legacy workspace behavior**: `modal: false` remains intentional
because the legacy table opens a PrimeVue popover teleported to `body`.
- **Scope**: This PR contains only global subscription-dialog sizing.
Agent side-panel behavior remains in
[#13472](https://github.com/Comfy-Org/ComfyUI_frontend/pull/13472).
- **Validation**: Focused tests pass (41 tests), `pnpm typecheck`
passes, and targeted ESLint passes. Chrome validation at 1352x705
rendered a 1280px dialog with no horizontal overflow in both the
isolated PR preview and the combined agent-panel preview. The docked
agent panel remained mounted behind the modal.

## Screenshots (if applicable)

- Original report and screenshots: [Slack
thread](https://comfy-organization.slack.com/archives/C0A8Z4U7Y1K/p1783967281397449?thread_ts=1783966866.227439&cid=C0A8Z4U7Y1K)
2026-07-15 00:35:09 +00:00
Christian Byrne
e6d1a9d4a2 fix(release): support manual target-branch override + major versions in resolve-comfyui-release (#13660)
## Problem

`scripts/cicd/resolve-comfyui-release.ts` derived the release target
purely from ComfyUI's `requirements.txt` pin and **hardcoded major
version `1`** (`core/1.${minor}`, `v1.${minor}.*`,
`1.${minor}.${patch}`) even though it parsed `major` and never used it.
Consequences:

- Could not release an out-of-cadence branch (e.g. skip a dead 1.46 to
ship 1.47 directly).
- Could not do a major bump (2.x).

## Changes

1. **Resolver (`resolve-comfyui-release.ts`)** — uses the parsed
`targetMajor` (defaults to the current pin's major) for every
branch/tag/version string instead of literal `1`. `getLatestPatchTag`
now takes a `major` param and globs `v${major}.${minor}.*`.

2. **`TARGET_BRANCH` env override (highest precedence)** — when set,
validates `^core/(\d+)\.(\d+)$`, verifies `origin/<branch>` exists, and
skips the `RELEASE_TYPE`/pin-derived selection entirely. If both
`TARGET_BRANCH` and `RELEASE_TYPE` are set, the override wins.
`current_version` still comes from the pin (for `diff_url` and the
ComfyUI PR "from" version), so the requirements bump jumps straight from
the pin to `target_version` (e.g. 1.45.20 → 1.47.8, skipping 1.46).

3. **Workflow (`release-biweekly-comfyui.yaml`)** — new optional
`target_branch` `workflow_dispatch` input, wired into the resolve step's
`env` as `TARGET_BRANCH`, and surfaced in the run summary. Downstream
jobs consume `target_branch`/`target_version` outputs unchanged.

The output JSON shape is identical. Extracted pure helpers
(`parseTargetBranchOverride`, `computeTargetVersion`) and guarded the
main block so the module is importable by tests.

`release-version-bump.yaml` and `release-branch-create.yaml` were
**already** major-aware and are left untouched.

## Tests

New `scripts/cicd/resolve-comfyui-release.test.ts` (15 cases) covering
`parseRequirementsVersion` (==, >=, missing/absent), `isValidSemver`,
`parseTargetBranchOverride` (valid `core/1.47` and `core/2.0`, malformed
rejected), and `computeTargetVersion` including a non-1 major (`v2.0.3`
+ commits → `2.0.4`).

## Usage

```
gh workflow run release-biweekly-comfyui.yaml --field target_branch=core/1.47
```

releases 1.47.8 directly (skipping a dead 1.46), or `--field
target_branch=core/2.0` for a major bump.

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-14 23:41:35 +00:00
Dante
0b4a960467 feat(billing): derive next-invoice amount, date, and cadence from billing state (FE-1245) (#13599)
## Summary

Adds the data seam for the Settings > Plan & Credits Invoices tab
(FE-1245): derives the next-invoice amount, date, and billing cadence
from billing state already fetched by the billing context, replacing the
prototype's hardcoded mock.

Updated for the 2026-07-13 design decisions (Slack thread + Willie's
Figma updates): the banner surfaces the BE-provided next-invoice date,
and annual subscriptions now show their yearly total and real renewal
date instead of hiding the banner.

## Changes

- **What**: `useNextInvoice` composable + pure `deriveNextInvoice` in
`src/composables/billing/` — returns `{ nextInvoice:
ComputedRef<NextInvoice | null> }`, `NextInvoice = { amountCents,
renewalDate, duration }`
- Monthly: subscribed team credit stop `monthly.price_cents` (status
`team_credit_stop.id` matched against the ladder) with plan
`price_cents` fallback — unchanged precedence
- Annual: stop `yearly.price_cents * 12` (stop yearly prices are
per-month figures, per `useWorkspacePlanPricing`) or the ANNUAL plan's
`price_cents` as-is (already the yearly total, per
`UnifiedPricingTable`)
- `renewalDate`: BE-computed `renewal_date` passed through untouched —
backends own period math including month-end bias. It goes null the
moment a cancellation is scheduled (mutually exclusive with
`end_date`/`cancel_at` on both billing backends)
- null (banner hidden) when inactive, cancelled, the amount is
unresolvable/non-positive (covers legacy billing's empty plan list and
free tier), or the plan resolved by slug disagrees with the
subscription's cadence
- 13 unit tests cover all branches, including x12-regression fixtures
with discriminated list/discount prices

Intentionally excludes usage/overage pending charges until the backend
exposes an authoritative upcoming-invoice amount (see FE-1245).

Follow-ups (not this PR):

- Cancelled-state toast (Figma 4617:29298 month-remaining / 4617:29992
terminal): separate seam UI work. Data is already available —
`subscription.endDate` is populated by both billing backends exactly
during the cancelled-but-paid window, and `useResubscribe()` covers the
Renew plan action
- "/year" amount framing is shown with placeholder copy; no annual
variant exists in the Figma file yet (design follow-up)

## Review Focus

- Annual unit semantics: stop `yearly.price_cents` is a per-month figure
(`useWorkspacePlanPricing.ts` `teamMonthlyCostCents`), while
`Plan.price_cents` for ANNUAL plans is the yearly total
(`UnifiedPricingTable.vue` `getAnnualTotal`) — hence x12 in one branch
and as-is in the other
- Consumed by the `useWorkspaceInvoices` seam once #13591 lands; the
swap now also requires the seam template to render
`renewalDate`/`duration`, so it is no longer a one-line body change
- FE-1245 / DES-497

## Screenshots

Live captures through the real `WorkspaceInvoicesContent` + this
composable with `/api/billing/*` mocked per state (isolated preview
harness). Date format follows the existing billing convention; "/ year"
framing is placeholder pending the annual design variant.

Active monthly subscription, team credit stop `team_320` — $320 USD with
next-invoice date:

![Invoices — team credit stop $320 with
date](https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/9271ad5cfb93dca3fa6d60ed2aa8ebca1dcbec4e/.github/pr-assets/fe-1245-invoices-team-stop.png)

Active monthly subscription without a credit stop — plan-price fallback,
$20 USD:

![Invoices — plan price fallback $20 with
date](https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/9271ad5cfb93dca3fa6d60ed2aa8ebca1dcbec4e/.github/pr-assets/fe-1245-invoices-plan-price.png)

Annual subscription — banner now shown: yearly total from the per-month
stop figure (288 x 12 = $3,456) and the real yearly renewal date:

![Invoices — annual
shown](https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/9271ad5cfb93dca3fa6d60ed2aa8ebca1dcbec4e/.github/pr-assets/fe-1245-invoices-annual.png)

Paused subscription — unchanged: next-invoice banner hidden, the paused
banner hosts the Full invoice history action (capture from the earlier
full-app harness):

![Invoices —
paused](https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/9271ad5cfb93dca3fa6d60ed2aa8ebca1dcbec4e/.github/pr-assets/fe-1245-invoices-paused.png)
2026-07-14 23:21:11 +00:00
Christian Byrne
060957d66c fix: use ComfyUI version for Cloud release notes (#13632)
## Summary

On Cloud, `releaseStore.currentVersion` sourced `cloud_version` (e.g.
`0.160.1`) while the `/releases` feed keys its entries by **ComfyUI**
version (e.g. `0.27.1`). The what's-new popup compares the latest feed
entry against the running version, so `0.27.1 < 0.160.1` read as
"already ahead of the latest release" and the popup never showed.

- Analytics confirmed the regression: `release_note` clicks fell from
**13.4% (90d) → 0% (30d)**; `cloud_release_note` was effectively never
clicked.

## Change

- `currentVersion` always uses `comfyui_version` (drops the `isCloud →
cloud_version` branch). The feed request keeps `project: 'cloud'`.
- Rationale: the changelog page and each note's "learn more" link are
ComfyUI-versioned, and Cloud has no separate versioned feed or changelog
page. The changelog is maintained with ComfyUI versions, updated after
each Cloud deploy lands.

## Tests

- Adds a regression test (`isCloud environment (FE-1237)`) pinning that
Cloud uses `comfyui_version`, not `cloud_version`. Verified via negative
control: reverting the fix fails it with `0.160.1` vs expected `0.27.1`.
- `test:unit` (releaseStore): 49 passed · `typecheck`, `lint`,
`format:check`, `knip`: clean.

## ADR

Adds `docs/adr/0012-cloud-release-notes-use-comfyui-version.md`
(Accepted) recording the rationale and history, and updates the ADR
index.

Fixes FE-1237

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-14 23:03:58 +00:00
Nathaniel Parson Koroso
6783d5ac18 Merge branch 'main' into nathaniel/custom-node-e2e-suite
Bring the custom-node suite branch current with main (37 commits) so the
detection-proof demo can rebase cleanly onto an up-to-date primary.
2026-07-10 15:42:52 -07:00
Nathaniel Parson Koroso
4962589a3e ci(custom-nodes): unpin backend, auto-take latest ComfyUI master
The v0.26.2 pin was a stopgap for a transient master boot regression. The
real cause (an uncaught vue-i18n compile throw on a pack node i18n value with
a literal '@') is now fixed in st() (src/i18n.ts), and current master boots
clean, so the gate tracks latest again. Pack-vs-latest drift remains the
nightly canary's job.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-10 15:08:35 -07:00
Nathaniel Parson Koroso
03f2b6bd89 fix(custom-nodes): boot on newer ComfyUI backends
Two backend-drift failures that took the custom-node e2e suite 100% red on
ComfyUI master (green on v0.26.2):

1. st() (src/i18n.ts) compiled custom-node i18n values via vue-i18n's t().
   A pack node whose translated value contains a literal '@' (vue-i18n
   linked-message syntax) throws SyntaxError: Invalid linked format at
   compile time. st() had no catch and runs on the boot critical path
   (getNodeDefs -> registerNodes -> comfyApp.setup(), before window.app is
   assigned), so one bad pack message aborted app boot and window.app.
   extensionManager never got set -> every test timed out at waitForAppReady.
   Now st() falls back to the raw string when compilation throws.

2. dismissTemplatesDialog hard-waited (no timeout) for the templates dialog,
   which newer ComfyUI no longer auto-opens; now tolerant of its absence.

Verified: pinned to the exact failing backend SHA, the suite goes 86 passed /
0 failed (was 100% red at boot).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-10 12:47:29 -07:00
Nathaniel Parson Koroso
7164b844ff ci(custom-nodes): pin backend to ComfyUI v0.26.2 for a deterministic gate
Unpinned comfyanonymous/ComfyUI master let a core boot regression (0.27.0
hangs frontend app-init before window.app is set) turn the whole custom-node
suite red through no fault of the frontend. Add an optional comfyui_ref input
to setup-comfyui-server (default unchanged = master) and pin only this job.
Pack-vs-latest-ComfyUI drift stays the nightly canary's concern (task #24).
2026-07-09 19:18:38 -07:00
Nathaniel Parson Koroso
f9dbb6b9d8 Merge remote-tracking branch 'origin/main' into nathaniel/custom-node-e2e-suite 2026-07-09 14:26:03 -07:00
Nathaniel Parson Koroso
424e85ebc0 docs(detection-proof): final falsification-pass sync - executed matrix, scoped-break rationale, registry self-heal finding 2026-07-09 11:52:52 -07:00
Nathaniel Parson Koroso
7203fdbb03 docs(detection-proof): sync rows 8-10 to CI-step delivery (not forks) and all-live commit design 2026-07-08 19:15:58 -07:00
Nathaniel Parson Koroso
baa2e046b7 docs(custom-nodes): Detection Proof accuracy pass
Pack-mode breaks are delivered via manifest pin swaps (CI clones packs at
pins, so in-repo pack-file edits cannot reach it); corpus-derived red
messages promise the tier and failure class, not byte-identical offender
text; remaining citations and mechanism descriptions tightened to what the
code and captured runs actually show.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-08 18:19:11 -07:00
Nathaniel Parson Koroso
0cc21040c4 docs(custom-nodes): correct Detection Proof citations after a hallucination audit
Every quoted red message re-verified against its original run log (10/10
match). Seven citation corrections from the audit: the iTools missing-
button tickets are Nodes 2.0 regressions and move to the v2 mount row
(the v1 row is now honestly class-only); the SAM3 hidden-values tickets
are removed (extras-exposed class, which the mount tier tolerates by
design, so citing them overclaimed coverage); the persistence row now
cites the verified defaultInput migration regression (widgets reverting
to socket-only on reload) that open PR #12279 fixes, instead of a live
widget-interaction ticket; the links-type and serialization rows drop
borrowed tickets and state their class plainly; the drag row's tickets
are labeled nearest-symptom family; the two expansion bullets now cite
the committed pure-spec catches instead of an unproven live-sweep catch.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-08 17:46:21 -07:00
Nathaniel Parson Koroso
d65d853227 test(custom-nodes): per-test backend isolation via an afterEach drain to idle
Every test gets a fresh page but all tests share one backend, locally and
on CI alike (the CI job is deliberately unsharded). A test ending while
its prompt still executed left that work running, and the next test's
fresh page connected mid-execution and inherited its async errors or its
busy queue. Drain the backend to idle in an afterEach in all four
backend-running specs, while the finishing test's own page is still open
so late events land there: no test can affect the next.

The drain helper moves to the shared fixture util (drainBackendToIdle,
byte-identical body); the auto-run tier's queue guard and runBatch
post-timeout drain rewire to it with their explicit budgets. The hooks
use a 10s budget: a no-op when already idle, and a backend still busy
past it is wedged, which the auto-run tier's 150s guard surfaces with
the restart diagnostic.

DETECTION_PROOF.md's caveat is rewritten to match, and a false claim
that CI shards one backend per pack is corrected in every location
(code comments and doc): the CI job runs the whole suite against one
fresh backend on an unloaded runner, which is why executions stay
inside their budgets there.

Empirical: a full-suite run with the hook eliminated the cross-test
bleed class entirely (zero mount/save-reload/core-smoke console or
overlay failures, previously 3-5 per run).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-08 17:14:14 -07:00
Nathaniel Parson Koroso
08106db082 test(custom-nodes): make the local full run idempotent (drain, foreign-noise filter, slow-node budgets)
The suite runs all 7 packs' execution tiers against one shared backend
locally (CI shards one backend per pack). Serial execution created three
distinct cross-test contaminations that failed a different set of packs
each run; each is now fixed at its mechanism:

- Foreign execution noise: mount/persistence/wiring/T0/core-smoke tiers
  queue no prompts, yet caught a prior tier's async execution error
  (PromptExecutionError, a 400 on /api/prompt). isForeignExecutionNoise
  filters execution-domain console lines from the non-executing tiers
  only; the executing tiers still assert them. Same "not this test's
  evidence" principle as event attribution (ARCHITECTURE section 9).
- Queue contention: the auto-run queue-busy guard hard-failed when a prior
  pack's slow CPU execution was still draining. drainUntilIdle waits it
  out (interrupt + clear + poll, throw-on-error so a failed read counts as
  busy); only a genuinely wedged backend fails. runBatch's post-timeout
  drain grows from 5s to 90s for the same reason.
- Slow-under-load misread as a regression: the single-node disambiguation
  re-run gets 60s instead of the batch's 20s. A real hang still exceeds it.

Also excludes the CLIPSeg model loaders (essentials, WAS) - model-download
nodes, same non-interruptible class as the listed BLIP/SAM/MiDaS loaders.
Reviewed by four-hat CORE (ship it); the new predicate is unit-pinned.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-08 16:22:11 -07:00
Nathaniel Parson Koroso
10d7769ab5 docs(custom-nodes): neutral phrasing in Detection Proof (drop first-person reference)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-08 14:32:41 -07:00
Nathaniel Parson Koroso
349d82b63e docs(custom-nodes): add Detection Proof plan (falsify every guard, correlate to real regressions)
The correlation matrix + throwaway-PR plan that proves the suite catches
every failure mode ARCHITECTURE.md claims: one deliberate break per
surface, each citing the real historical regression it recreates (Linear
Custom Node Bugs issues + FE PR #12279) and the exact CI red it produces.
Every "exact red" is captured from a real falsification run, not a
prediction. Renames the earlier "kill-test" work to the falsification
pass. States the honest local-full-run idempotency caveat (CI shards
per-pack; a single-backend serial run is not the oracle).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-08 14:32:00 -07:00
Nathaniel Parson Koroso
6be7c18bef test(custom-nodes): sharpen three detection surfaces the break-suite exercise found
- Wiring drop resolution: the curated drag test only targeted first-slot
  inputs, so a slot hit-test regression that falls back to the first
  compatible input went undetected. Add a second-slot anchor
  (EmptyImage.IMAGE -> ImageBatch.image2) that only links if the drop
  resolves the exact slot; proven by breaking getNodeInputOnPos.
- Curated-run failure naming: a backend validation rejection answers
  /prompt with node_errors but app.queuePrompt swallows it, so a
  VALIDATION_FAIL reported {}. Capture and flatten the node_errors
  (summarizePromptError, typed off apiSchema PromptResponse) into the
  result's clientError and surface it in the T1 message, so a red names
  the node and input. Exported with a pure unit test since the happy path
  never runs it.
- Console-error window: document (README + ARCHITECTURE section 10) that
  the ledger collects per-tier, so boot-time pack console noise before the
  first tier action is out of scope by design, backstopped by the startup
  zero-visible-errors check.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-08 14:27:07 -07:00
Nathaniel Parson Koroso
58e0fe7511 docs(custom-nodes): section 6 shows the census feeding three parsers; onboarding mirrors the scoped invariant
Round-3 review follow-ups: the definition-pipeline diagram no longer
implies a centralized normalizer (live census -> wiring slot normalizer /
execution classifier / mount declared-shape parser, matching section 4),
and ADDING_CUSTOM_NODES scopes the zero-visible-errors claim to the tiers
that assert it, same wording as the README.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-08 12:22:05 -07:00
Nathaniel Parson Koroso
72ad08db63 test(custom-nodes): shared console ledger, drift guards, and a doc truth pass from round-2 review
- Extract the pack console-error allowlist into a shared fixture
  (consoleErrorLedger.ts); the curated T1 run now collects console and
  page errors across load+run and asserts them through the ledger. The
  filter is pinned by a discriminating pure spec (pattern match,
  cross-pack ownership, unknown-pack fail-open).
- T1 asserts every expectedNodes type is actually present in the curated
  workflow before running it, killing the vacuous-green path where a
  drifted fixture shrank the executed-set check to an empty id list.
- typePairing records unrecognizable slot specs (unknownSlots on the
  node, unknownShapes on the plan) instead of silently dropping them;
  connectivity logs the list; pure tests pin the input/output drop paths
  and the socketless boundary.
- Add test:custom-nodes:ci, the gate-equivalent run against the
  backend-served built frontend; README re-scopes test:custom-nodes as
  the dev-server loop that is NOT the gate, and scopes the
  zero-visible-errors invariant to the tiers that hold it.
- ARCHITECTURE truth pass: event attribution leads with the positive
  prompt-id capture; section 10 grades ledger guards in three strengths;
  the decentralized parser story (declaredShape, classifyInput,
  normalizer) is stated consistently in section 4, gotcha G5, and the
  legend; ADDING_CUSTOM_NODES points the console ledger at its new home.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-08 11:43:42 -07:00
Nathaniel Parson Koroso
24659c2caf test(custom-nodes): implement 8 external-review hardenings with discriminating self-checks
- positive prompt-id attribution: capture the /prompt response id as the
  primary event filter (seen-set + graph membership stay as depth); a new
  attribution self-check injects a foreign-prompt terminal error mid-run
  and proves it cannot fail the run
- console collection now includes pageerror (uncaught exceptions and
  rejections), with a collector self-check as positive control; surfaces a
  real Custom-Scripts betterCombos typeof-null bug, ledgered with mechanism
- connectivity allowlists are two-way stale-guarded: every entry must be
  observed failing in its recorded way, all stale keys reported per run
- manifest pins are required full 40-hex SHAs (CUSTOM_NODES_ALLOW_UNPINNED=1
  admits only empty pins, reserved for the planned pack-HEAD canary); pack
  must be a plain path segment; contract pinned by pure specs
- CI installs each pack under custom_nodes/<pack> with charset and pin
  gates before cloning (attribution keys on the install dirname)
- allNodes renderer loops honor rendererPassesFor (vueNodesCompatible)
- curated T1 asserts every display sink emitted a ui payload; console
  sinks documented as excluded (no ui payload by design)
- the always()-wrapper suggestion was rejected on sibling evidence:
  ci-tests-unit.yaml gates its required check with a changes job and
  job-level if, and no repo workflow uses a wrapper

Reviewed via ninja pipeline: 4-hat CORE panel (2 passes), senior QA gate
(2 rounds, discrimination proven by falsification), gated review (Primary,
Double Checker, Ultimate Skeptic - 15-entry evidence ledger, all PROVEN).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-07 22:34:08 -07:00
Nathaniel Parson Koroso
e46487f3ed docs(custom-nodes): regression-suite title, tier gating truth, verified stack claims
Implements the cold insider review's full finding set plus pipeline
verification fixes:
- title gains 'regression', matching every sibling doc
- wiring tier renderer coverage told truthfully (breadth sweep one,
  curated drags both); decision 7 enumerates all renderer surfaces
- section 5 gains the manifest tiers vocabulary bridge (run and
  connectivity gate; load and io currently gate nothing)
- renderers named once (LiteGraph / Vue Nodes 2.0); opener deduplicated
  against section 1; implementation map matches the real manifest schema
- section 13 names Playwright, bundled Chromium, GitHub Actions, with a
  caveated runtime ballpark; gotcha receipts carry only verifiable claims
- sections 10 and 13 diagrams conform to the doc's diagram grammar
- ADDING_CUSTOM_NODES tiers gloss and manifest.ts workflow comment
  aligned with the same gating reality

Reviewed via ninja pipeline: 4-hat CORE panel (2 passes), senior QA gate
(2 rounds), gated review (Primary, Double Checker, Ultimate Skeptic).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-07 20:40:13 -07:00
Nathaniel Parson Koroso
3bc40bb148 docs(custom-nodes): legend reads in ascending section order per depth; name the map's ordering principle
Dagre's crossing minimizer ignores edge declaration order, so the fix is
node declaration order. Also states explicitly that the map is ordered by
zoom, not page order.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-07 19:30:14 -07:00
Nathaniel Parson Koroso
cbceaf5dd9 docs(custom-nodes): context + execution + persistence diagrams restructured per review
- context diagram flows one way: driver -> frontend -> verdict synthesis -> team
- execution flow: classification fans out to its three verdicts; runnable paths
  converge on batching, blocked routes straight to reconciliation
- persistence check: sequence diagram replaced with a linear pipeline (one
  actor issuing commands is a procedure, not a message exchange)
- building blocks: tiers fan 2x2 inside the horizontal pipeline
- tripwire step + small recovers? diamond instead of one giant diamond

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-07 18:31:15 -07:00
Nathaniel Parson Koroso
497dd6ede5 docs(custom-nodes): building-blocks view horizontal, raise label wrap width
The building-blocks pipeline rendered as a tall narrow strip for two
mermaid reasons: labels auto-wrap at the ~200px default regardless of
line length, and a subgraph's declared direction is ignored once it has
external edges, so the tier row silently stacked vertically. The view
is now a left-to-right pipeline with the tier group in the middle, and
the wrap-width directive makes boxes wide instead of tall here and in
the definition-pipeline and execution-flow views.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-07 17:15:08 -07:00
Nathaniel Parson Koroso
cec09da789 docs(custom-nodes): close the observation loop in the context view
The frontend box was a dead end: the suite drove it but nothing flowed
back, so the verdicts arrow to the team looked sourceless. Added the
return edge (observations back: what mounted, what persisted, what
executed, every error) and reworded the team edge so verdicts are
visibly the synthesis of those observations.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-07 17:13:16 -07:00
Nathaniel Parson Koroso
9eb035e8a8 docs(custom-nodes): drop the redundant D-diagram labels; de-jargon the batching box
Headings were double-numbered ("2. D1 - system context") with an
internal diagram-numbering scheme that means nothing to a reader.
Sections are already numbered: headings now just name the view, and
every cross-reference points at a section. Also replaced "queue cost
is amortized" with plain English: one submission carries many nodes
instead of paying the round-trip per node.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-07 17:08:53 -07:00
Nathaniel Parson Koroso
3cef258bac docs(custom-nodes): wide diagram boxes - strip forced line breaks from D1-D4
Reader feedback on the rendered views: manual line breaks inside boxes
force Mermaid to render narrow, tall boxes with heavy wrapping, so the
diagrams cost too much scrolling. Mermaid sizes a box to its longest
line, so the fix is one or two long lines per box with elaboration in
the prose below the diagram. Applied to D1 (context), D2 (pipeline),
D3 (definition pipeline), and D4 (execution flow); D7 and D8 stay as
approved.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-07 17:06:01 -07:00
Nathaniel Parson Koroso
34faaa1a1d docs(custom-nodes): redraw D2/D3 for single-flow readability
Reader feedback on the rendered views: D2's service-to-tier arrows
crossed the whole diagram with ambiguous fan-ins (three unattributed
"pass/fail + exceptions" curves), and D3's corpus box mixed the
two-dialects annotation into a flow node right where three arrows fan
out, reading as if the dialects explained the fan-out.

Fixes, using the rules that make the CI view work: one direction of
flow per diagram, no many-to-many edges (the service-to-tier matrix is
now a table, which is what a matrix is), and annotations live in prose
rather than inside flow boxes. D2 is now a straight
manifest -> orchestrator -> tiers -> evidence -> verdict pipeline with
a three-row shared-services table; D3 moves the dialect fact into the
normalize step, labels the fan-out "derives", and adds one sentence
mapping each derived plan to its consuming tier.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-07 17:03:02 -07:00
Nathaniel Parson Koroso
95ced4c6ef docs(custom-nodes): ARCHITECTURE.md - C4-style views, design decisions, gotchas reference
Architecture documentation for the custom-node regression suite,
written as design views rather than an implementation dump:

- eight responsibility-level views: system context, building blocks,
  the node-definition pipeline, the execution flow, the persistence
  check, event attribution, the evidence model, and the CI deployment
  view; every diagram box names a responsibility or concept, arrows
  carry meaning, and decision points read in plain English
- a one-minute What/Why/How opening with the three explicit non-goals
  (output semantics, frontend-virtual nodes, hour-scale soak) and a
  clearly labeled scale snapshot so instance numbers never read as
  properties of the design
- a 12-row design-decisions table with honest trade-offs (why a real
  browser at all, why the backend serves the built frontend, one
  worker, disabled execution cache, pinned pack versions, one-row
  extensibility, per-tier renderer policy, mechanism-carrying
  exceptions, the two-way baseline, batch+bisect, and the scope line),
  plus the curated-workflow fixture named as the deliberate extension
  seam
- a 14-item gotchas reference, each entry in symptom / root cause /
  defense / which-team-concern-it-answers form, with named nodes kept
  only as worked examples of their class
- one implementation map section where architecture names meet code
  symbols, covering every building block including the orchestrator
  and the evidence ledgers
- the workflow's rotted sharding comment fixed (suite duration and
  the real shard trigger)

Grounded on the C4 model's published guidance, reviewed by an
independent architect pass (two view-coherence gaps found and fixed)
after three earlier Opus review passes on content accuracy.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-07 16:33:08 -07:00
Nathaniel Parson Koroso
f9a94d0296 docs(custom-nodes): ARCHITECTURE.md - system design, data flow, and the incident behind every invariant
The suite had run/onboarding docs but nothing describing the SYSTEM:
what the pieces are, how node definitions flow through the planners and
classifiers, how the execution harness attributes outcomes, and why each
non-obvious rule exists. This adds the missing third doc with four
Mermaid box-line diagrams (system overview, def data flow, run pipeline,
CI pipeline), the tier-by-renderer coverage matrix, the full ledger
table with the two-way baseline semantics, and the hard-won invariants
each tied to the incident that forced it (widgetValueStore id bleed,
event cross-attribution, pack JS queue-hook crashes, Vue effect timing,
queue-jam tripwire). Scope contract is stated up front: compatibility
and regression gate, not a behavior certifier.

Every path, symbol, and number cross-checked against the tree before
commit. README and ADDING_CUSTOM_NODES now cross-reference it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-07 15:38:37 -07:00
Nathaniel Parson Koroso
e7681be896 test(custom-nodes): shape-census audit - classify V2-form combos, forceInput beats every form, census-derived fixtures
Systematic audit for siblings of the two combo bug classes (ungrounded
contract, shape blindness), driven by a live shape census of the exact
getNodeDefs object the suite consumes:

- classifyInput now handles the V2 schema form (string 'COMBO' with
  options in the opts object; 495 such inputs exist in the transformed
  defs): options present = widget, empty or remote/lazy = NEEDS_MODELS.
  Real effect measured: 8 KJNodes nodes were silently misclassified
  NEEDS_WIRES and never executed - 5 now run clean, 3 correctly land in
  NEEDS_MODELS (remote combos).
- forceInput now beats every input form, list-form combos included (a
  census-found form the old branch order classified as widget; today's
  4 instances are optional or non-manifest, so this is protection, not
  a behavior change).
- pure-spec fixtures for both parsers now include every census form,
  copied from real census examples (V2 options, V2 empty, V2 remote,
  forceInput-on-combo, cross-form vocabulary pairing) so fixtures can
  no longer self-confirm the parser's assumptions.
- ADDING_CUSTOM_NODES.md gains the evidence rules: independent-oracle
  grounding for semantic claims, shape-census-driven parsing with
  exclude-with-record on unknown shapes, and verify-against-the-source-
  the-code-consumes.

defaultInput checked against frontend source: deprecated and ignored
(nodeDefStore warning only) - deliberately not handled.

Local verification: full customNodes suite 72/72 under CI parity; lint,
format:check, knip, and both typechecks clean.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-07 14:30:51 -07:00
Nathaniel Parson Koroso
70233bbd04 test(custom-nodes): combo vocabulary is a set, not a sequence; never pair combos with unknown options
A wired combo input bypasses its own widget, so menu order and the
options[0] default are not part of the wire contract - membership is
(backend validation checks value-in-options). Vocabulary fingerprints
are now order-insensitive (sorted, element-wise canonicalized). In the
current corpus this changes zero pairs (measured: no same-set,
different-order combos exist across the 7 packs); the rule is now
correct for packs where they do.

Auditing that change surfaced a real hole: the frontend's transformed
defs present some combos as the literal string COMBO with options in
the opts object. The old fingerprint hashed all of those identically,
silently cross-pairing dropdowns with no vocabulary evidence - exactly
the checkpoint-into-scheduler class the combo rule exists to exclude.
Normalization now pulls V2-form options, and a combo with no known
option list is excluded from pairing instead of blind-matched. Plan
moves 5,058 -> 5,030 pairs; the 28 removed were vocabulary-blind.

Also from CI: MiDaS Mask Image excluded (torch.hub download inside
execute hung the Linux runner; runs clean only where the hub cache is
warm) and ImageTransformKJ ledgered (pack JS initializes its
fill-options JSON widget on configure).

Local verification: full customNodes suite 68/68 twice, lint, format,
knip, and both typechecks clean.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-07 14:01:32 -07:00
Nathaniel Parson Koroso
a22acc4f48 test(custom-nodes): save/reload under both renderers; classify client-side queue throws; scope decisions written in-code
Coverage-gap audit after the mount-fidelity miss (assertions silently
narrower than their claim). Fixes:

- save/reload now runs under BOTH renderers with staged evaluates and
  frame yields, so Vue component mount/configure effects actually flush
  before each serialize - the one renderer-dependent value path a
  LiteGraph-only pass could not see. Console errors are now collected
  during the tier too (configure-time pack JS noise was uncovered).
- queuePrompt is wrapped in-page: pack JS that THROWS mid-graphToPrompt
  (VHS applyToGraph crashed CI's whole VHS tier) now classifies as
  VALIDATION_FAIL carrying the exception text, so the offender
  self-identifies instead of aborting the tier. VHS_SelectLatest
  excluded with that mechanism: its applyToGraph assumes downstream
  inputs have widgets and hard-crashes when its output feeds a pure
  socket while the input dir has matching files (upstream-report
  candidate).
- pack-owned-value nodes (ROUNDTRIP_VALUE_ALLOWLIST) no longer receive
  set-and-stick probe writes - writing `_cn` markers into editor JSON
  widgets just made pack JS choke on our own probes.
- deliberate scopes are now stated where the assertion lives: auto-run
  runs single-renderer because execution is a backend contract and
  values flow through the same store in both renderers; it deliberately
  skips the zero-visible-errors check because it provokes expected
  failures; the connectivity breadth sweep is renderer-independent with
  the curated drag test covering both renderers; combo vocabulary
  matching is deliberately order-sensitive (option order defines the
  default).

Local verification: full customNodes suite 67/67 under CI parity, plus
lint, format:check, knip, and both typechecks clean.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-07 13:31:43 -07:00
Nathaniel Parson Koroso
e6ed6120a1 test(custom-nodes): assert def-vs-instance mount fidelity under both renderers; reconcile Linux CI flips
Mount fidelity now has a renderer-independent bar: under BOTH the
LiteGraph and Vue passes, every created instance must materialize
everything its def declares - each non-socketless input exists as a
widget or a socket (autogrow templates count via their dot-qualified
expansion slots, e.g. variables.a/variables.b), and every declared
output exists. The Vue pass keeps its extra layer: the DOM must render
at least the instance's widget and slot counts. Verified against all
823 nodes under both renderers; the only def-shape special case found
was the core autogrow container semantics.

Also reconciles the first Linux CI run of the chain-builder tier:
- environment flips move to AUTO_RUN_EXCLUDE with mechanisms and leave
  the baseline: Image Analyze, Text Parse A1111 Embeddings (fail macOS,
  clean Linux), Image Crop Face (clean macOS, AttributeError Linux),
  ImageReceiver (av decode error macOS, clean Linux)
- run-to-run flip-floppers excluded: ImpactRemoteInt,
  ImpactSchedulerAdapter, ImpactQueueTriggerCountdown (queue-hook JS
  transient refusals), LoadText|pysssss (state-dependent file combo)

Local verification: allNodes 21/21 twice consecutively, plus lint,
format:check, knip, and both typechecks clean.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-07 13:00:17 -07:00
Nathaniel Parson Koroso
5ce414653e test(custom-nodes): chain-run NEEDS_WIRES nodes, assert outputs, mount fidelity, widget round-trip, combo pairing
Executes ~340 more nodes and hardens every tier's assertions:

- CHAINABLE verdict: required sockets with a model-free producer
  (EmptyImage, EmptyLatentImage, SolidMask, Primitive*, EmptyAudio) are
  synthesized and wired automatically; NEEDS_WIRES now means only truly
  unproducible types (MODEL, SEGS, CONDITIONING...)
- auto-run asserts data flow: every PreviewAny sink must emit a ui
  payload (NO_OUTPUT class); OUTPUT_NODE targets stay event-covered
- Vue mount asserts DOM widget/slot counts (missing fails, extras and
  in-row control_after_generate tolerated)
- save/reload is now two passes: pristine (reload must never shrink a
  node or change a value - the "widgets disappear" bug class) and
  set-and-stick (every plain widget holds a programmatic non-default
  write and it survives reload where topology is stable)
- connectivity pairs COMBO slots on exact option-vocabulary match
  (+~120 pairs); mismatched vocabularies stay excluded by design
- harness invariants: node ids never reused within a page (the
  widgetValueStore keys state by node id and survives graph.clear(), so
  a reused id inherits stale widget values - core bug, reported
  separately), and run events are filtered by prompt id + graph node id
  membership so late websocket events or flap-retry double-queues can
  never pin one node's failure on the next
- new mechanism ledgers: WIDGET_SET_ALLOWLIST, ROUNDTRIP_VALUE_ALLOWLIST,
  MOUNT_WIDGET_ALLOWLIST, all stale-guarded; AUTO_RUN_EXCLUDE gains the
  observed offenders (rembg pip-install-at-execute, empty-find infinite
  loop, from_pretrained downloads, minutes-long per-pixel loops)
- manifest baselines reconciled against three observation runs; stale
  entries removed, real failures (missing optional deps, degenerate
  synthesized inputs, CUDA-only recorders) baselined

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-07 12:32:16 -07:00
Nathaniel Parson Koroso
c5de8d421d test: fix ImageGrabPIL pack attribution; exclude WAS ffmpeg path node
ImageGrabPIL is a KJNodes node and was ledgered under WAS, so its
exclusion never applied - moved to the right pack, and the auto-run
test now asserts every exclusion key is actually registered by its
pack so a wrong-pack entry fails loudly instead of silently doing
nothing. WAS Create Video from Path joins the exclusions with CI
evidence (ffmpeg discovery differs per host).
2026-07-07 10:43:57 -07:00
Nathaniel Parson Koroso
9bb0587ec5 Merge remote-tracking branch 'origin/main' into nathaniel/custom-node-e2e-suite 2026-07-07 10:24:36 -07:00
Nathaniel Parson Koroso
de23856742 test: exclude runtime model-downloaders and content-variable nodes from auto-run
The rebuilt environment surfaced the rest of the download class: WAS
BLIP/SAM/MiDaS model loaders all hang the queue in non-interruptible
weight downloads (and would mass-download on a networked runner), the
random.org node needs internet by definition, KJ LoadAndResizeImage and
WAS Create Grid Image follow input-dir contents, and Impact media
widgets preview values via root-relative URLs (console allowlist
widened). Every entry carries its mechanism; all keep mount,
save/reload, and connectivity coverage. 65/65 both environments.
2026-07-07 10:15:11 -07:00
Nathaniel Parson Koroso
650abec3ab test: fix browser typecheck errors; recalibrate exclusions for CI environment
typecheck:browser (which the lint job runs, unlike root typecheck)
caught an unused classifyInput param, a branded-NodeId lookup, and
api.interrupt's required argument. The first serialized CI run then
exposed environment-variable nodes: clean on one host, failing on the
other (screen capture with no X display, PIL screen grabs headless,
torch-stack RuntimeErrors that are macOS-only, state-dependent WAS
history). Those move from the cannotRunAlone baseline to
AUTO_RUN_EXCLUDE with per-node mechanisms so both environments stay
deterministic, and Impact's hardcoded example.png preview 404 joins
the scoped console allowlist.
2026-07-07 09:59:24 -07:00
Nathaniel Parson Koroso
b99100d0b4 test: un-export AutoRunClass (knip: consumers use AutoRunVerdict) 2026-07-06 17:12:24 -07:00
Nathaniel Parson Koroso
6d5bcb9e04 test: suppress deferred-await false positives in turnstile timer tests
vitest/valid-expect flags assertions stored before advancing fake
timers and awaited after - awaiting at creation would deadlock the
timer advance. The file is byte-identical to main; the warnings appear
because the type-aware lint toolchain moved. Suppressed per line with
the reason; also drops a scratch await added while chasing this.
2026-07-06 17:05:39 -07:00
Nathaniel Parson Koroso
0723702791 test: serialize CI workers, prune comment noise, clearer naming
The auto-run tier needs exclusive backend-queue access, so the CI job
now runs with workers=1 - parallel workers were interrupting each
other's executions and cross-attributing errors. Await the async
toHaveLength assertion the type-aware lint flagged, drop the
calibration measurement harness (one-shot scaffolding; the measured
constant keeps a provenance note), rename NO_SINK to
NO_OBSERVABLE_OUTPUT, and cut comments down to load-bearing WHYs.
2026-07-06 17:03:21 -07:00
Nathaniel Parson Koroso
9825047176 ci: pin every manifest pack to its verified commit
An unpinned pack means any upstream push can red the gating check for
every PR in the repo. Each row now pins the exact SHA the suite was
verified against locally (all tiers green, both environments); bumps
are deliberate, re-verified changes. Also records why the job is not
sharded yet: per-shard setup (~4.5 min of pack installs and backend
boot) dominates the ~5.5 min suite, so a prebuilt image comes first.
2026-07-06 16:33:53 -07:00
Nathaniel Parson Koroso
7adfaa9079 test: stabilize every-node auto-run across environments; document the tiers
The cannotRunAlone baseline (per pack, in the manifest) records nodes
that cannot execute standalone on a bare backend, asserted both ways so
entries cannot rot: an unlisted failure is a regression, a listed node
that runs clean must be removed. queuePrompt rejection is retried once
before classifying VALIDATION_FAIL - pack JS hooking the queue path can
refuse transiently, and the backend log proved several apparent rejects
never reached the server. Nodes whose execution depends on their own
pack JS preprocessing widget values (rgthree Power widgets, KJ editors)
are excluded unconditionally with the mechanism recorded, since whether
a page applies pack JS varies by serving setup; ML-session initializers
and unstable executed-set reporters join them. ADDING_PACKS and the
README document the every-node tiers and all five exception ledgers.

Verified 65/65 in both documented environments: dev server and
dist-serving CI parity, twice consecutively on the latter.
2026-07-06 16:16:51 -07:00
Nathaniel Parson Koroso
1e36107109 test: every-node coverage - mount, save/reload, connect, and auto-run for all pack nodes
All-nodes tiers discover each pack's full node list from the live
backend: chunked mount checks in both renderers (batch size 24, chosen
by the committed calibration tool), chunked save/reload round-trips,
a connectivity corpus widened from the curated sentinels to every
registered node, and an auto-run tier that classifies every node
(AUTO_RUNNABLE / NEEDS_WIRES / NEEDS_MODELS / NO_SINK) and executes the
runnable ones in batches with per-node bisection on failure.

Hard-won harness rules baked in: queuePrompt rejects classify instantly
as VALIDATION_FAIL instead of burning the timeout; a timed-out batch
interrupts and verifies the queue drained so one hung node cannot jam
every later run; a pre-flight queue check fails fast with the real
cause; and three reviewable exception ledgers carry reasons inline
(AUTO_RUN_EXCLUDE for runtime-downloaders like RemBGSession+, a scoped
console-noise allowlist for KJNodes' undefined-filename previews,
connectivity CONNECT_REJECTED/ROUNDTRIP_LOST entries for pack JS that
vetoes or drops links).
2026-07-06 16:16:23 -07:00
Nathaniel Parson Koroso
1d5514c90e docs: rename ADDING_PACKS to ADDING_CUSTOM_NODES
The doc onboards custom nodes; name it what it is.
2026-07-06 16:16:09 -07:00
Nathaniel Parson Koroso
61d1cbfdb0 docs: fix ADDING_PACKS extensions probe and misattributed CI triage
grep -c on the single-line /extensions JSON could only say 0 or 1; count
entries properly with the same python one-liner style the doc already
uses. The Step 7 triage claimed our CI failure was upstream drift; it was
the dev-server blindspot - reorder the advice to reproduce under 6b
before diagnosing.
2026-07-02 18:49:20 -07:00
Nathaniel Parson Koroso
14666b09c4 docs: fold 5-pack onboarding lessons into ADDING_PACKS
Detect frontend-JS packs at install time, split local verification into
the fast dev-server loop and the CI-parity dist run (required when the
pack ships frontend JS), spell out that workflow media paths resolve
against the backend's working directory, and add upstream-drift triage
for unpinned packs. Checklist updated to match.
2026-07-02 18:46:05 -07:00
Nathaniel Parson Koroso
efb0365bc3 test: make connectivity instance-aware; slot drags survive pack page chrome
Two CI failures with the 7-pack backend, both from pack frontend JS that
never loads under the Vite dev server (its /extensions list is core-only):

- rgthree's Seed rebuilds its declared seed input as a widget-only
  control, so the planned BatchCount+.INT -> Seed.seed pair has no socket
  on the instance. The sweep now classifies that as
  WIDGET_ONLY_ON_INSTANCE, logged and excluded like wildcards; a name
  missing from both slots and widgets still fails hard, and the drag test
  picks the first in-pack pair that materializes on real instances.

- rgthree's progress bar shifts the canvas element 16px down, and
  NodeSlotReference.getPosition returned canvas-relative coordinates, so
  every slot drag grabbed the node title instead of the slot dot. Slot
  positions now include the canvas element's page offset (a no-op when
  the canvas sits at 0,0).

Documents the dev-server blindspot and the CI-parity loop (build dist,
--front-end-root) in the suite README and ADDING_PACKS. Verified 36/36
green against both the dev server and a dist-serving 7-pack backend.
2026-07-02 18:42:48 -07:00
Nathaniel Parson Koroso
065bc0c336 test: fail manifest load when a run tier has no workflow
A run row with an empty workflow would skip locally and rely on CI's
skip gate to notice the lost coverage; enforce the documented contract
at load time instead.
2026-07-02 18:13:26 -07:00
Nathaniel Parson Koroso
1248c4628a test: onboard 5 packs (rgthree, essentials, KJNodes, Custom-Scripts, WAS) with vueNodesCompatible flag and ADDING_PACKS guide
Five new manifest rows, each covering load, connectivity, and run tiers
with hand-authored model-free workflows verified against a live backend.
New optional vueNodesCompatible manifest field: a pack proven unable to
mount under Vue Nodes 2.0 runs its LiteGraph assertions only - never a
test.skip, so the zero-skip CI gate stays honest. All five packs mount
under Vue Nodes 2.0 empirically, so no row sets the flag; the decision
helper is unit-tested instead. ADDING_PACKS.md is the authoritative
step-by-step onboarding process, validated against live /object_info.
Manifest rows now also fail fast on an empty repo field.
2026-07-02 18:05:20 -07:00
Nathaniel Parson Koroso
ee83d67834 test: single tier source of truth; fix skip diagnostic to find nested skips
Derive CustomNodeTier from the VALID_TIERS array (as const) so adding a tier
is one edit and the type/runtime lists can't drift. The forbid-skips
diagnostic now recurses the report and prints only specs that actually
skipped - the old dump printed every title and a single-level filter would
miss specs nested under describe() blocks (which the regression spec uses).
2026-07-02 16:07:04 -07:00
Nathaniel Parson Koroso
f63b7d866e ci: gate custom-node job with changes-filter, not trigger paths
A required check gated by a trigger-level paths filter never creates a check
run on a PR that touches none of those paths, leaving branch protection stuck
Pending. Move the gating to a job-level if via the changes-filter action (a
skipped job counts as passing), mirroring ci-tests-unit.yaml, so this can be
marked required without stalling docs-only PRs. Keeps the same-repo fork guard
in the same if.
2026-07-02 16:03:37 -07:00
Nathaniel Parson Koroso
068191ea47 test: harden custom-node CI and manifest per review
Security: the pack-install job now runs only for same-repo PRs and pushes, so
a fork PR can't point the manifest's repo URLs at attacker-controlled code
that the job would clone and pip-install. Fork PRs keep the env-agnostic
coverage via the main e2e shards.

Stability: pack requirements install under a pip constraint pinning the CPU
torch stack, so no pack can swap torch for a GPU/incompatible build on the
--cpu runner.

Correctness: manifest validation rejects unknown tier values (a 'connectivty'
typo would otherwise silently drop that tier's coverage). Connectivity's
'pack installed' predicate is extracted to one isEntryInstalled helper used by
both the breadth and drag tests.
2026-07-02 15:56:17 -07:00
Nathaniel Parson Koroso
07c4b230b2 ci: make the custom-node job gating - fail on pack-install error or any skip
A regression gate that lets a broken pack through as a skip is theater. Pack
clone/dependency failures now fail the job (array+loop instead of a
failure-swallowing jq|while pipe), and a post-run check fails the job if any
test was skipped - on this backend every tier is meant to run, so a skip
means a pack or devtools did not load. Drops the informational framing;
mark custom-nodes-e2e required in branch protection to block merges.
2026-07-02 15:36:19 -07:00
Nathaniel Parson Koroso
9ed51f1e4b ci: run the custom-node suite against a backend with the packs installed
Phase 5. A new informational (non-gating) workflow that reuses the repo's
setup-frontend/setup-playwright/setup-comfyui-server actions, then installs
every pack the manifest declares (jq loop over customNodeManifest.json, so a
new pack row installs itself with no workflow change) and boots ComfyUI with
--multi-user --cache-none before running browser_tests/tests/customNodes.

This makes the load and run tiers actually execute in CI instead of skipping
for want of the packs - the whole point of the suite. A pack whose deps fail
degrades to an honest skip rather than reddening the job.
2026-07-02 15:25:31 -07:00
Nathaniel Parson Koroso
4a91fa4849 test: name connectivity tests in plain language
T-conn was planning-doc shorthand for the connectivity tier; test titles and
logs now say connectivity outright so CI output reads without tribal
knowledge.
2026-07-02 14:11:56 -07:00
Nathaniel Parson Koroso
0991905a89 test: exclude COMBO literals from connectivity auto-pairing
CI caught what a pack-rich local backend masked: isValidConnection compares
only the string COMBO while every combo slot carries its own option set, so
the planner would wire a checkpoint dropdown into a scheduler dropdown and
call it proof, and combo outputs declare a non-string output_name whose
instance slot name never matches (DevToolsNodeWithOutputCombo failed 5
pairs on CI as SLOT_CONTRACT_MISMATCH). Combo slots are now recorded and
counted like wildcards instead of paired, the normalizer coerces slot names
to strings, and a pure spec locks both behaviors. Targeted fixtures remain
the way to cover combo semantics.
2026-07-02 14:10:37 -07:00
Nathaniel Parson Koroso
df6764762b test: make the custom-node suite work on multi-user backends
The Comfy.userId=default settings override broke every test on multi-user
backends (the repo's stated browser-test prerequisite): devtools
set_settings wrote to a user no session reads, so Comfy.TutorialCompleted
never landed, the templates dialog never opened, and the beforeEach wait
timed out - CI sessions even inherited leftover settings (a zh locale) from
earlier tests on the same worker user. Dropping the override lets the
fixture target the real per-worker user everywhere; the harness backend now
runs --multi-user like CI. Connectivity's per-pack guards and drag
derivation apply only to installed packs, so a backend without the manifest
packs reports the absence instead of hard-failing while the core sweep,
native drag, and self-checks still run.
2026-07-02 13:45:34 -07:00
Nathaniel Parson Koroso
2d2b318450 test: drop exports from internal-only custom-node types
knip flags exported types with no external consumers; CustomNodeTier,
ObjectInfoNode, NormalizedSlot, and SlotRef are referenced only within
their own modules.
2026-07-02 13:15:58 -07:00
GitHub Action
0f94da8746 [automated] Apply ESLint and Oxfmt fixes 2026-07-02 19:32:18 +00:00
Nathaniel Parson Koroso
d80427d014 test: assert breadth-sweep console errors and tighten manifest shape checks
The breadth sweep now fails on any console error captured during the
connect/serialize/prompt loop, matching the fidelity test. The wildcard
predicate is exported from typePairing and reused instead of re-derived.
assertEntry validates real shapes (non-empty pack/expectedNodes/tiers,
arrays, boolean requiresGpu, finite positive timeoutMs); workflow stays
allowed as an empty string until a pack gains a run-tier fixture.
2026-07-02 12:28:23 -07:00
Nathaniel Parson Koroso
d02e665290 test: address review feedback on the custom-node suite
Resolve the manifest path from import.meta.url so tests are cwd-independent,
and validate requiresGpu at manifest load. Reuse the centralized TestIds for
the error overlay, error dialog, and templates dialog selectors. Extract the
shared suite settings and templates-dialog dismissal into
fixtures/utils/customNodeSuite so the three specs cannot drift. Rename
spikeDesktop.spec.ts to coreSmoke.spec.ts to match its maintained purpose,
document the full manifest schema in the README, and describe the gate
outcome without a hardcoded test count.
2026-07-02 12:24:33 -07:00
Nathaniel Parson Koroso
dc83cc4df6 test: prove the connectivity executor can reject, and drag every pack
A permanent self-check feeds the shared pair executor a type-incompatible
pair and a fabricated slot name and requires CONNECT_REJECTED and
SLOT_CONTRACT_MISMATCH back, so a green sweep can never come from a
classifier that lost the ability to fail. The breadth test asserts every
connectivity-tier pack contributes pairs, guarding pack attribution. The
drag tier's widget-primitive exclusion is removed: widget-backed inputs
render real slot dots under Vue Nodes (verified empirically), so every pack
now gets an in-pack drag in both renderers, asserted present.
2026-07-02 12:19:40 -07:00
Nathaniel Parson Koroso
8b81a4f359 test: add connectivity tier proving the slot/type contract
A type-pairing generator indexes /object_info producers and consumers and
plans one representative typed edge per slot, excluding wildcard slots
(isValidConnection short-circuits on * before the real type compare, so a
wildcard link proves reachability, not interop). The breadth sweep connects
every planned edge through the real validator in-page and requires each link
to survive serialize/configure and appear in graphToPrompt output; verified
up front that graphToPrompt emits links even when other required inputs
dangle. A curated subset is dragged slot-dot to slot-dot under both
renderers, addressed by data-slot-key so shared labels cannot misfire.
Orphan types are reported, never failed; connect vetoes must match a
committed allow-list. Manifest packs opt in via a connectivity tier that
needs no extra assets.
2026-07-02 12:14:39 -07:00
GitHub Action
8f567e8ef0 [automated] Apply ESLint and Oxfmt fixes 2026-07-02 18:44:36 +00:00
Nathaniel Parson Koroso
4fb282f853 docs: link custom-node suite README from browser_tests README 2026-07-02 11:39:53 -07:00
Nathaniel Parson Koroso
d17a387ddb test: name each custom-node check as a pnpm script and document the suite
One script per pack tier (impact-render/impact-run/vhs-render/vhs-run) plus
the self-check, all opening the Playwright Inspector so anyone can step
through what the robot does. README covers prerequisites, every script, a
worked example, the zero-visible-errors contract, and how to add a pack.
2026-07-02 11:39:53 -07:00
Nathaniel Parson Koroso
68ba0aa613 test: add pnpm scripts for the custom-node suite
test:custom-nodes runs the whole suite headless (the gate); :watch opens a
headed slow-motion run of the browser tiers; :debug steps through them in the
Playwright Inspector. All target the local dev server on :5173 and use the
committed system-Chrome config (no bundled-chromium download). Pass -g to
:watch / :debug to run a single test, e.g. -g 'VideoHelperSuite.*T1'.
2026-07-02 11:39:53 -07:00
Nathaniel Parson Koroso
675140c164 test: drop io tier scaffold until assertion-node pack exists
T2a gated on the ComfyUI-test-framework 'Assert Executed' nodes, which are
not published for any backend yet, so the tier could only ever skip. A test
that cannot run anywhere is reporting noise; restore it from history when
the assertion pack lands. Suite is now 16 passed, zero skips, zero failures.
2026-07-02 11:39:53 -07:00
Nathaniel Parson Koroso
64706c53c3 test: enforce zero visible errors across custom-node suite
Every browser tier now asserts the app's user-facing error surfaces (error
overlay, error dialog, node render errors, error toasts) are absent at test
start and after each pass, so a run is green only if a human watching the
screen sees zero errors. The harness self-check asserts the overlay IS
visible after a forced execution error, keeping the selectors provably live.

Sessions boot with a blank graph (Comfy.TutorialCompleted=false) because the
bundled default template references models absent on a scoped backend; the
tutorial path's auto-opened template browser is dismissed per test. Settings
now reach the session on single-user server-storage backends by routing
devtools set_settings to the default user, and the errors tab stays enabled
so error indicators are never suppressed in this suite. The smoke test loads
a core-only model-free workflow instead of the SD1.5 default asset.
2026-07-02 11:39:53 -07:00
Nathaniel Parson Koroso
bfa94d4118 test: enable run tier for Impact and VHS with model-free workflows
Impact runs ImpactInt and ImpactFloat into PreviewAny as a group; VHS decodes
the existing plain_video.mp4 asset through VHS_LoadVideoPath into
VHS_VideoInfo. The executed-set check asserts each expected node individually
executed, so group workflows still verify per-node execution. Requires a
cache-disabled backend (--cache-none) with the video staged in its input dir;
documented on the manifest workflow field.
2026-07-02 11:39:53 -07:00
Nathaniel Parson Koroso
b7708d5ad0 test: validate timeoutMs and requiresModels at manifest load 2026-07-02 11:39:53 -07:00
Nathaniel Parson Koroso
564de12d46 test: harden custom-node suite per review findings
Normalize the executing event tap: its CustomEvent detail is a bare node-id
string, so the previous object-spread left the executed-set permanently empty.
The self-check now asserts a non-empty executed-set to keep that path live.

T0 now clears the graph per renderer pass, asserts exact node counts, and
verifies each added pack node's own data-node-id mounts in the Vue pass
(default-workflow nodes can no longer satisfy the assertions). Console capture
starts before the renderer toggle. Added an object_info sanity floor so a
depleted getNodeDefs fails loudly instead of skipping everything.

Run/io tiers gain test.setTimeout, requiresModels gating, and an empty-workflow
guard. Interrupted runs get pure-spec coverage; the shared console collector
moves to fixtures/utils.
2026-07-02 11:39:53 -07:00
Nathaniel Parson Koroso
5a1f788230 test: custom-node E2E regression suite (load/render, both renderers)
Data-driven Playwright harness verifying custom-node packs load and render
under both LiteGraph 1.0 and Vue Nodes 2.0 against a real ComfyUI backend.
Pure classifier/validator/manifest logic is unit-tested; the regression spec
renders each pack's nodes in both renderers (Vue via data-node-id DOM) and a
self-check runs a workflow to confirm execution-error capture. Proven against
Impact Pack + VideoHelperSuite.

Makes ComfyPage.createUser idempotent so the suite runs against a persistent
backend (Desktop server user storage).
2026-07-02 11:39:53 -07:00
215 changed files with 12387 additions and 5833 deletions

View File

@@ -9,6 +9,10 @@ inputs:
description: 'Whether to launch the server after setup'
required: false
default: 'false'
comfyui_ref:
description: 'ComfyUI git ref to check out (tag/branch/SHA). Empty = default branch (master).'
required: false
default: ''
runs:
using: 'composite'
steps:
@@ -19,6 +23,7 @@ runs:
uses: actions/checkout@v6
with:
repository: 'comfyanonymous/ComfyUI'
ref: ${{ inputs.comfyui_ref }}
path: 'ComfyUI'
- name: Install ComfyUI_devtools from frontend repo

View File

@@ -0,0 +1,180 @@
# Runs the custom-node regression suite against a backend that has the manifest
# packs actually installed, so the load/run tiers execute for real. This is a
# GATING check: if a pack fails to install or any tier is skipped, the job goes
# red - a regression gate that let a broken pack through as a "skip" would be
# pointless. Mark `custom-nodes-e2e` as a required status check in branch
# protection to block merges on failure.
name: 'CI: Tests Custom Nodes'
on:
pull_request:
branches-ignore: [wip/*, draft/*, temp/*]
push:
branches: [main, master]
merge_group:
workflow_dispatch:
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
jobs:
# Path gating lives here, not in a trigger-level `paths:` filter: a required
# check gated by trigger paths never creates a check run on an unrelated PR
# and leaves branch protection stuck Pending. A job-level `if:` still creates
# the check and marks it Skipped (= passing). Mirrors ci-tests-unit.yaml.
changes:
runs-on: ubuntu-latest
permissions:
contents: read
outputs:
should-run: ${{ steps.changes.outputs.should-run }}
steps:
- uses: actions/checkout@v6
- id: changes
uses: ./.github/actions/changes-filter
# Deliberately NOT sharded yet: the suite is ~8 min but every shard would
# pay the full ~4.5 min setup (clone + pip-install every pack + boot the
# backend), so 2 shards buy ~4 min of wall time for double the runner cost,
# with diminishing returns beyond that. Sharding pays once test time dwarfs
# setup time -
# first cut setup with a prebuilt image of the pinned packs, then shard if
# the job exceeds ~12 minutes.
custom-nodes-e2e:
needs: changes
# Run only when non-docs code changed AND the PR is same-repo. Fork PRs can
# edit the manifest's repo/pin URLs, and this job clones and pip-installs
# whatever they point at (setup.py runs at install time), so an untrusted
# fork must not be able to aim the clone at an attacker-controlled repo.
# Fork PRs still get the environment-agnostic coverage via the main e2e
# shards. A skipped job counts as passing, so this stays required-safe.
if: >-
needs.changes.outputs.should-run == 'true' &&
(github.event_name != 'pull_request' ||
github.event.pull_request.head.repo.full_name == github.repository)
runs-on: ubuntu-latest
timeout-minutes: 30
permissions:
contents: read
steps:
- name: Checkout repository
uses: actions/checkout@v6
- name: Setup frontend
uses: ./.github/actions/setup-frontend
with:
include_build_step: true
- name: Setup Playwright
uses: ./.github/actions/setup-playwright
# Checks out ComfyUI, installs Python/torch/requirements and ComfyUI_devtools.
# launch_server:false so we can add the manifest packs before booting.
- name: Setup ComfyUI server
uses: ./.github/actions/setup-comfyui-server
with:
launch_server: 'false'
# Install every pack the manifest declares (DRY: a new pack row installs
# itself here, no workflow change). A clone or dependency failure fails the
# job - if a pack can't be installed, its coverage can't run, and that is a
# gate failure, not something to paper over. The `jq | while` pipe hides
# failures in a subshell, so read into an array and loop with `set -e`.
- name: Install manifest custom nodes
shell: bash
run: |
set -euo pipefail
# Pin the CPU torch stack that setup-comfyui-server installed so no
# pack's requirements.txt can pull a GPU/incompatible torch onto this
# --cpu runner. A pack that genuinely needs a different torch fails
# the constrained install loudly rather than silently swapping it.
pip freeze | grep -iE '^(torch|torchvision|torchaudio)==' \
> /tmp/torch-constraints.txt || true
manifest=browser_tests/fixtures/data/customNodeManifest.json
mapfile -t entries < <(jq -c '.[]' "$manifest")
for entry in "${entries[@]}"; do
repo=$(jq -r '.repo' <<<"$entry")
pin=$(jq -r '.pin' <<<"$entry")
# Install under the manifest `pack` key, not basename(repo): node
# attribution keys on the install dirname via python_module, and
# the two only coincide by luck. Same charset the manifest loader
# enforces - belt for anything that bypasses it.
pack=$(jq -r '.pack' <<<"$entry")
if ! [[ "$pack" =~ ^[A-Za-z0-9][A-Za-z0-9._-]*$ ]]; then
echo "::error::unsafe pack name: '$pack'"; exit 1
fi
# The gate tests exactly what was verified: a full SHA pin is
# mandatory here, before anything installs. The planned canary
# (pack HEADs) is the only intended unpinned consumer and runs
# with CUSTOM_NODES_ALLOW_UNPINNED=1 through the loader instead.
if ! [[ "$pin" =~ ^[0-9a-f]{40}$ ]]; then
echo "::error::$pack: pin must be a full commit SHA (got '$pin')"; exit 1
fi
dir="ComfyUI/custom_nodes/$pack"
echo "::group::install $pack"
git clone --depth 1 "$repo" "$dir"
git -C "$dir" fetch --depth 1 origin "$pin"
git -C "$dir" checkout "$pin"
if [ -f "$dir/requirements.txt" ]; then
pip install -r "$dir/requirements.txt" -c /tmp/torch-constraints.txt
fi
echo "::endgroup::"
done
# The VHS run-tier workflow reads input/plain_video.mp4.
- name: Stage run-tier assets
shell: bash
run: cp browser_tests/assets/plain_video.mp4 ComfyUI/input/plain_video.mp4
# --cache-none so retried run-tier tests re-execute every node (a cached
# node emits no `executing` event and would false-fail PARTIAL).
- name: Start ComfyUI server
shell: bash
working-directory: ComfyUI
run: |
python main.py --cpu --multi-user --cache-none --front-end-root ../dist &
wait-for-it --service 127.0.0.1:8188 -t 600
- name: Run custom-node suite
env:
PLAYWRIGHT_JSON_OUTPUT_NAME: custom-nodes-results.json
run: |
# workers=1: the auto-run tier needs exclusive backend-queue access;
# parallel workers interrupt each other's executions.
# --project=custom-nodes: the `@custom-nodes`-tagged specs, which the
# main e2e job's `chromium` project excludes (see playwright.config).
# list,json,html: json feeds the skip gate below; html writes
# playwright-report/ (the upload step's target) and folds in the
# on-first-retry traces, which a bare list,json would discard.
pnpm exec playwright test browser_tests/tests/customNodes/ \
--project=custom-nodes --reporter=list,json,html --workers=1
# A skip here means a pack or devtools did not load: on this backend every
# tier is meant to run, so a skip is a gate failure, not an honest pass.
- name: Forbid skipped tests
if: always()
shell: bash
run: |
set -euo pipefail
skipped=$(jq '.stats.skipped' custom-nodes-results.json)
echo "skipped tests: $skipped"
if [ "$skipped" != "0" ]; then
echo "::error::$skipped test(s) skipped - a manifest pack or devtools failed to load; skips are not acceptable in the gating job"
# Recurse so specs nested under describe() blocks are found, and
# print only the specs that actually skipped.
jq -r '.. | objects
| select(has("title") and has("tests"))
| select(any(.tests[]?; .status == "skipped"))
| .title' custom-nodes-results.json | sort -u | head -40
exit 1
fi
- name: Upload Playwright report
if: always()
uses: actions/upload-artifact@v6
with:
name: playwright-report-custom-nodes
path: playwright-report/
retention-days: 7
if-no-files-found: warn

View File

@@ -73,8 +73,8 @@ jobs:
strategy:
fail-fast: false
matrix:
shardIndex: [1, 2, 3, 4, 5, 6, 7, 8]
shardTotal: [8]
shardIndex: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16]
shardTotal: [16]
steps:
- name: Checkout repository
uses: actions/checkout@v6
@@ -93,7 +93,7 @@ jobs:
# Run sharded tests (browsers pre-installed in container)
- name: Run Playwright tests (Shard ${{ matrix.shardIndex }}/${{ matrix.shardTotal }})
id: playwright
run: pnpm exec playwright test --project=chromium --shard=${{ matrix.shardIndex }}/${{ matrix.shardTotal }} --reporter=blob
run: pnpm exec playwright test --project=chromium --shard=${{ matrix.shardIndex }}/${{ matrix.shardTotal }}
env:
PLAYWRIGHT_BLOB_OUTPUT_DIR: ./blob-report
COLLECT_COVERAGE: 'true'
@@ -150,7 +150,7 @@ jobs:
# Run tests (browsers pre-installed in container)
- name: Run Playwright tests (${{ matrix.browser }})
id: playwright
run: pnpm exec playwright test --project=${{ matrix.browser }} --reporter=blob
run: pnpm exec playwright test --project=${{ matrix.browser }}
env:
PLAYWRIGHT_BLOB_OUTPUT_DIR: ./blob-report

View File

@@ -23,6 +23,10 @@ on:
required: false
default: 'Comfy-Org/ComfyUI'
type: string
target_branch:
description: 'Optional: force a specific release branch, e.g. core/1.47 or core/2.0. Overrides the pin-derived target — use to skip a dead minor or do an out-of-cadence / major release.'
required: false
type: string
jobs:
check-release-week:
@@ -49,12 +53,15 @@ jobs:
fi
- name: Summary
env:
TARGET_BRANCH_OVERRIDE: ${{ inputs.target_branch }}
run: |
echo "## Release Check" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo "- Is release week: ${{ steps.check.outputs.is_release_week }}" >> $GITHUB_STEP_SUMMARY
echo "- Manual trigger: ${{ github.event_name == 'workflow_dispatch' }}" >> $GITHUB_STEP_SUMMARY
echo "- Release type: ${{ inputs.release_type || 'minor (scheduled)' }}" >> $GITHUB_STEP_SUMMARY
echo "- Target branch override: ${TARGET_BRANCH_OVERRIDE:-(none — pin-derived)}" >> $GITHUB_STEP_SUMMARY
resolve-version:
needs: check-release-week
@@ -103,6 +110,7 @@ jobs:
working-directory: frontend
env:
RELEASE_TYPE: ${{ inputs.release_type || 'minor' }}
TARGET_BRANCH: ${{ inputs.target_branch }}
run: |
set -euo pipefail

View File

@@ -175,10 +175,7 @@ const contactColumn: { title: string; links: FooterLink[] } = {
</div>
<!-- Logo -->
<canvas
ref="canvasRef"
class="pointer-events-none size-52 opacity-80 lg:mt-28"
/>
<canvas ref="canvasRef" class="pointer-events-none size-52 lg:mt-28" />
</div>
</footer>
</template>

View File

@@ -123,6 +123,15 @@ Browser tests in this project follow a specific organization pattern:
- **Utilities**: Located in `utils/` - Common utility functions
- `litegraphUtils.ts` - Utilities for working with LiteGraph nodes
### Custom-node regression suite
`tests/customNodes/` holds the manifest-driven suite that proves community
custom-node packs load, render in both renderers (LiteGraph canvas and Vue
Nodes 2.0), and execute real workflows. It has its own prerequisites, pnpm
scripts (`pnpm test:custom-nodes` and per-pack variants), and a
one-JSON-row process for adding packs - see
[tests/customNodes/README.md](tests/customNodes/README.md).
## Writing Effective Tests
When writing new tests, follow these patterns:

View File

@@ -0,0 +1,53 @@
{
"last_node_id": 2,
"last_link_id": 1,
"nodes": [
{
"id": 1,
"type": "PrimitiveInt",
"pos": { "0": 20, "1": 60 },
"size": { "0": 250, "1": 100 },
"flags": {},
"order": 0,
"mode": 0,
"inputs": [],
"outputs": [
{
"name": "INT",
"type": "INT",
"links": [1],
"slot_index": 0
}
],
"properties": {
"Node name for S&R": "PrimitiveInt"
},
"widgets_values": [5, "fixed"]
},
{
"id": 2,
"type": "PreviewAny",
"pos": { "0": 340, "1": 60 },
"size": { "0": 220, "1": 60 },
"flags": {},
"order": 1,
"mode": 0,
"inputs": [
{
"name": "source",
"type": "*",
"link": 1
}
],
"outputs": [],
"properties": {
"Node name for S&R": "PreviewAny"
}
}
],
"links": [[1, 1, 0, 2, 0, "INT"]],
"groups": [],
"config": {},
"extra": {},
"version": 0.4
}

View File

@@ -0,0 +1,53 @@
{
"last_node_id": 2,
"last_link_id": 1,
"nodes": [
{
"id": 1,
"type": "PrimitiveInt",
"pos": { "0": 20, "1": 60 },
"size": { "0": 250, "1": 80 },
"flags": {},
"order": 0,
"mode": 0,
"inputs": [],
"outputs": [
{
"name": "INT",
"type": "INT",
"links": [1],
"slot_index": 0
}
],
"properties": {
"Node name for S&R": "PrimitiveInt"
},
"widgets_values": [42, "fixed"]
},
{
"id": 2,
"type": "PreviewAny",
"pos": { "0": 340, "1": 60 },
"size": { "0": 220, "1": 60 },
"flags": {},
"order": 1,
"mode": 0,
"inputs": [
{
"name": "source",
"type": "*",
"link": 1
}
],
"outputs": [],
"properties": {
"Node name for S&R": "PreviewAny"
}
}
],
"links": [[1, 1, 0, 2, 0, "INT"]],
"groups": [],
"config": {},
"extra": {},
"version": 0.4
}

View File

@@ -0,0 +1,60 @@
{
"last_node_id": 2,
"last_link_id": 1,
"nodes": [
{
"id": 1,
"type": "StringFunction|pysssss",
"pos": { "0": 20, "1": 60 },
"size": { "0": 300, "1": 240 },
"flags": {},
"order": 0,
"mode": 0,
"inputs": [],
"outputs": [
{
"name": "STRING",
"type": "STRING",
"links": [1],
"slot_index": 0
}
],
"properties": {
"Node name for S&R": "StringFunction|pysssss"
},
"widgets_values": ["append", "yes", "hello", " world", ""]
},
{
"id": 2,
"type": "ShowText|pysssss",
"pos": { "0": 380, "1": 60 },
"size": { "0": 220, "1": 80 },
"flags": {},
"order": 1,
"mode": 0,
"inputs": [
{
"name": "text",
"type": "STRING",
"link": 1
}
],
"outputs": [
{
"name": "STRING",
"type": "STRING",
"links": null,
"slot_index": 0
}
],
"properties": {
"Node name for S&R": "ShowText|pysssss"
}
}
],
"links": [[1, 1, 0, 2, 0, "STRING"]],
"groups": [],
"config": {},
"extra": {},
"version": 0.4
}

View File

@@ -0,0 +1,61 @@
{
"last_node_id": 2,
"last_link_id": 1,
"nodes": [
{
"id": 1,
"type": "SimpleMathInt+",
"pos": { "0": 20, "1": 60 },
"size": { "0": 250, "1": 60 },
"flags": {},
"order": 0,
"mode": 0,
"inputs": [],
"outputs": [
{
"name": "INT",
"type": "INT",
"links": [1],
"slot_index": 0
}
],
"properties": {
"Node name for S&R": "SimpleMathInt+"
},
"widgets_values": [5]
},
{
"id": 2,
"type": "DisplayAny",
"pos": { "0": 340, "1": 60 },
"size": { "0": 220, "1": 80 },
"flags": {},
"order": 1,
"mode": 0,
"inputs": [
{
"name": "input",
"type": "*",
"link": 1
}
],
"outputs": [
{
"name": "STRING",
"type": "STRING",
"links": null,
"slot_index": 0
}
],
"properties": {
"Node name for S&R": "DisplayAny"
},
"widgets_values": ["raw value"]
}
],
"links": [[1, 1, 0, 2, 0, "INT"]],
"groups": [],
"config": {},
"extra": {},
"version": 0.4
}

View File

@@ -0,0 +1,98 @@
{
"last_node_id": 4,
"last_link_id": 2,
"nodes": [
{
"id": 1,
"type": "ImpactInt",
"pos": { "0": 20, "1": 60 },
"size": { "0": 250, "1": 60 },
"flags": {},
"order": 0,
"mode": 0,
"inputs": [],
"outputs": [
{
"name": "INT",
"type": "INT",
"links": [1],
"slot_index": 0
}
],
"properties": {
"Node name for S&R": "ImpactInt"
},
"widgets_values": [42]
},
{
"id": 2,
"type": "PreviewAny",
"pos": { "0": 340, "1": 60 },
"size": { "0": 220, "1": 60 },
"flags": {},
"order": 2,
"mode": 0,
"inputs": [
{
"name": "source",
"type": "*",
"link": 1
}
],
"outputs": [],
"properties": {
"Node name for S&R": "PreviewAny"
}
},
{
"id": 3,
"type": "ImpactFloat",
"pos": { "0": 20, "1": 220 },
"size": { "0": 250, "1": 60 },
"flags": {},
"order": 1,
"mode": 0,
"inputs": [],
"outputs": [
{
"name": "FLOAT",
"type": "FLOAT",
"links": [2],
"slot_index": 0
}
],
"properties": {
"Node name for S&R": "ImpactFloat"
},
"widgets_values": [3.14]
},
{
"id": 4,
"type": "PreviewAny",
"pos": { "0": 340, "1": 220 },
"size": { "0": 220, "1": 60 },
"flags": {},
"order": 3,
"mode": 0,
"inputs": [
{
"name": "source",
"type": "*",
"link": 2
}
],
"outputs": [],
"properties": {
"Node name for S&R": "PreviewAny"
}
}
],
"links": [
[1, 1, 0, 2, 0, "INT"],
[2, 3, 0, 4, 0, "FLOAT"]
],
"groups": [],
"config": {},
"extra": {},
"version": 0.4
}

View File

@@ -0,0 +1,98 @@
{
"last_node_id": 4,
"last_link_id": 2,
"nodes": [
{
"id": 1,
"type": "INTConstant",
"pos": { "0": 20, "1": 60 },
"size": { "0": 250, "1": 60 },
"flags": {},
"order": 0,
"mode": 0,
"inputs": [],
"outputs": [
{
"name": "value",
"type": "INT",
"links": [1],
"slot_index": 0
}
],
"properties": {
"Node name for S&R": "INTConstant"
},
"widgets_values": [42]
},
{
"id": 2,
"type": "PreviewAny",
"pos": { "0": 340, "1": 60 },
"size": { "0": 220, "1": 60 },
"flags": {},
"order": 2,
"mode": 0,
"inputs": [
{
"name": "source",
"type": "*",
"link": 1
}
],
"outputs": [],
"properties": {
"Node name for S&R": "PreviewAny"
}
},
{
"id": 3,
"type": "FloatConstant",
"pos": { "0": 20, "1": 220 },
"size": { "0": 250, "1": 60 },
"flags": {},
"order": 1,
"mode": 0,
"inputs": [],
"outputs": [
{
"name": "value",
"type": "FLOAT",
"links": [2],
"slot_index": 0
}
],
"properties": {
"Node name for S&R": "FloatConstant"
},
"widgets_values": [3.14]
},
{
"id": 4,
"type": "PreviewAny",
"pos": { "0": 340, "1": 220 },
"size": { "0": 220, "1": 60 },
"flags": {},
"order": 3,
"mode": 0,
"inputs": [
{
"name": "source",
"type": "*",
"link": 2
}
],
"outputs": [],
"properties": {
"Node name for S&R": "PreviewAny"
}
}
],
"links": [
[1, 1, 0, 2, 0, "INT"],
[2, 3, 0, 4, 0, "FLOAT"]
],
"groups": [],
"config": {},
"extra": {},
"version": 0.4
}

View File

@@ -0,0 +1,53 @@
{
"last_node_id": 2,
"last_link_id": 1,
"nodes": [
{
"id": 1,
"type": "Seed (rgthree)",
"pos": { "0": 20, "1": 60 },
"size": { "0": 250, "1": 130 },
"flags": {},
"order": 0,
"mode": 0,
"inputs": [],
"outputs": [
{
"name": "SEED",
"type": "INT",
"links": [1],
"slot_index": 0
}
],
"properties": {
"Node name for S&R": "Seed (rgthree)"
},
"widgets_values": [12345]
},
{
"id": 2,
"type": "Display Any (rgthree)",
"pos": { "0": 340, "1": 60 },
"size": { "0": 220, "1": 60 },
"flags": {},
"order": 1,
"mode": 0,
"inputs": [
{
"name": "source",
"type": "*",
"link": 1
}
],
"outputs": [],
"properties": {
"Node name for S&R": "Display Any (rgthree)"
}
}
],
"links": [[1, 1, 0, 2, 0, "INT"]],
"groups": [],
"config": {},
"extra": {},
"version": 0.4
}

View File

@@ -0,0 +1,107 @@
{
"last_node_id": 3,
"last_link_id": 2,
"nodes": [
{
"id": 1,
"type": "VHS_LoadVideoPath",
"pos": { "0": 20, "1": 60 },
"size": { "0": 320, "1": 260 },
"flags": {},
"order": 0,
"mode": 0,
"inputs": [],
"outputs": [
{
"name": "IMAGE",
"type": "IMAGE",
"links": null
},
{
"name": "frame_count",
"type": "INT",
"links": null
},
{
"name": "audio",
"type": "AUDIO",
"links": null
},
{
"name": "video_info",
"type": "VHS_VIDEOINFO",
"links": [1],
"slot_index": 3
}
],
"properties": {
"Node name for S&R": "VHS_LoadVideoPath"
},
"widgets_values": ["input/plain_video.mp4", 0, 0, 0, 0, 0, 1]
},
{
"id": 2,
"type": "VHS_VideoInfo",
"pos": { "0": 400, "1": 60 },
"size": { "0": 240, "1": 260 },
"flags": {},
"order": 1,
"mode": 0,
"inputs": [
{
"name": "video_info",
"type": "VHS_VIDEOINFO",
"link": 1
}
],
"outputs": [
{
"name": "source_fps🟨",
"type": "FLOAT",
"links": [2],
"slot_index": 0
},
{ "name": "source_frame_count🟨", "type": "INT", "links": null },
{ "name": "source_duration🟨", "type": "FLOAT", "links": null },
{ "name": "source_width🟨", "type": "INT", "links": null },
{ "name": "source_height🟨", "type": "INT", "links": null },
{ "name": "loaded_fps🟦", "type": "FLOAT", "links": null },
{ "name": "loaded_frame_count🟦", "type": "INT", "links": null },
{ "name": "loaded_duration🟦", "type": "FLOAT", "links": null },
{ "name": "loaded_width🟦", "type": "INT", "links": null },
{ "name": "loaded_height🟦", "type": "INT", "links": null }
],
"properties": {
"Node name for S&R": "VHS_VideoInfo"
}
},
{
"id": 3,
"type": "PreviewAny",
"pos": { "0": 700, "1": 60 },
"size": { "0": 220, "1": 60 },
"flags": {},
"order": 2,
"mode": 0,
"inputs": [
{
"name": "source",
"type": "*",
"link": 2
}
],
"outputs": [],
"properties": {
"Node name for S&R": "PreviewAny"
}
}
],
"links": [
[1, 1, 3, 2, 0, "VHS_VIDEOINFO"],
[2, 2, 0, 3, 0, "FLOAT"]
],
"groups": [],
"config": {},
"extra": {},
"version": 0.4
}

View File

@@ -0,0 +1,103 @@
{
"last_node_id": 3,
"last_link_id": 2,
"nodes": [
{
"id": 1,
"type": "Constant Number",
"pos": { "0": 20, "1": 60 },
"size": { "0": 250, "1": 100 },
"flags": {},
"order": 0,
"mode": 0,
"inputs": [],
"outputs": [
{
"name": "NUMBER",
"type": "NUMBER",
"links": [1],
"slot_index": 0
},
{
"name": "FLOAT",
"type": "FLOAT",
"links": null,
"slot_index": 1
},
{
"name": "INT",
"type": "INT",
"links": null,
"slot_index": 2
}
],
"properties": {
"Node name for S&R": "Constant Number"
},
"widgets_values": ["integer", 7]
},
{
"id": 2,
"type": "Number to Text",
"pos": { "0": 340, "1": 60 },
"size": { "0": 220, "1": 60 },
"flags": {},
"order": 1,
"mode": 0,
"inputs": [
{
"name": "number",
"type": "NUMBER",
"link": 1
}
],
"outputs": [
{
"name": "STRING",
"type": "STRING",
"links": [2],
"slot_index": 0
}
],
"properties": {
"Node name for S&R": "Number to Text"
}
},
{
"id": 3,
"type": "Text to Console",
"pos": { "0": 640, "1": 60 },
"size": { "0": 250, "1": 80 },
"flags": {},
"order": 2,
"mode": 0,
"inputs": [
{
"name": "text",
"type": "STRING",
"link": 2
}
],
"outputs": [
{
"name": "STRING",
"type": "STRING",
"links": null,
"slot_index": 0
}
],
"properties": {
"Node name for S&R": "Text to Console"
},
"widgets_values": ["Text Output"]
}
],
"links": [
[1, 1, 0, 2, 0, "NUMBER"],
[2, 2, 0, 3, 0, "STRING"]
],
"groups": [],
"config": {},
"extra": {},
"version": 0.4
}

View File

@@ -275,8 +275,16 @@ export class ComfyPage {
data: { username }
})
if (resp.status() !== 200)
throw new Error(`Failed to create user: ${await resp.text()}`)
if (resp.status() !== 200) {
const body = await resp.text()
// Persistent backends (Comfy Desktop server user storage) keep the user
// across runs and do not list it via GET /api/users, so a duplicate means
// it already exists. Returns the username since the generated id is not
// retrievable here; only reached on single-user / default-resolving backends.
if (resp.status() === 400 && body.includes('Duplicate username.'))
return username
throw new Error(`Failed to create user: ${body}`)
}
return await resp.json()
}

View File

@@ -55,6 +55,22 @@ export class VueNodeHelpers {
)
}
getOutputSlotRow(nodeId: string, slotIndex: number): Locator {
return this.getNodeLocator(nodeId)
.locator('.lg-slot--output')
.filter({
has: this.page.locator(
`[data-slot-key="${getSlotKey(toNodeId(nodeId), slotIndex, false)}"]`
)
})
}
getOutputSlotConnectionDot(nodeId: string, slotIndex: number): Locator {
return this.getOutputSlotRow(nodeId, slotIndex).getByTestId(
TestIds.node.slotConnectionDot
)
}
/**
* Get locator for Vue nodes by the node's title (displayed name in the header).
* Matches against the actual title element, not the full node body.

View File

@@ -322,6 +322,9 @@ export class AssetsSidebarTab extends SidebarTab {
// --- Folder view ---
public readonly backToAssetsButton: Locator
// --- Panel chrome ---
public readonly panelHeader: Locator
// --- Loading ---
public readonly skeletonLoaders: Locator
@@ -354,12 +357,11 @@ export class AssetsSidebarTab extends SidebarTab {
)
this.selectionFooter = page.getByTestId('assets-selection-bar')
this.selectionCountButton = page.getByText(/\d+ selected/)
this.deselectAllButton = page.getByRole('button', {
name: 'Deselect all'
})
this.deselectAllButton = page.getByTestId('assets-deselect-selected')
this.deleteSelectedButton = page.getByTestId('assets-delete-selected')
this.downloadSelectedButton = page.getByTestId('assets-download-selected')
this.backToAssetsButton = page.getByText('Back to all assets')
this.panelHeader = page.locator('.comfy-vue-side-bar-header')
this.skeletonLoaders = page.locator(
'.sidebar-content-container .animate-pulse'
)

View File

@@ -0,0 +1,287 @@
import type { Page, Response } from '@playwright/test'
import type { PromptResponse } from '@/schemas/apiSchema'
import type { ObjectInfo } from '@e2e/fixtures/customNode/objectInfoValidator'
import type {
ExecutionError,
PromptEvent,
RunResult
} from '@e2e/fixtures/customNode/runResult'
import { classifyRun } from '@e2e/fixtures/customNode/runResult'
interface RawEvent {
type: string
node?: string | null
prompt_id?: string
output?: unknown
exception_type?: string
node_id?: string
node_type?: string
traceback?: string[]
}
const TERMINAL = [
'execution_success',
'execution_error',
'execution_interrupted'
]
// The /prompt rejection body is the apiSchema PromptResponse shape
// ({ error: string | {message}, node_errors: { <nodeId>: { class_type,
// errors: [{ details, message }] } } }). Flatten it to a single line naming
// the node class and the failing input so a VALIDATION_FAIL result is
// actionable instead of an empty object. Exported for a pure unit test: the
// happy path never runs it, so without a test a regression here would rot the
// diagnostic back to `{}` silently.
export function summarizePromptError(body: unknown): string | undefined {
const payload = body as Partial<PromptResponse> | null
if (!payload || typeof payload !== 'object') return undefined
const parts: string[] = []
const topError = payload.error
if (typeof topError === 'string') {
if (topError) parts.push(topError)
} else if (topError?.message) parts.push(topError.message)
for (const [nodeId, nodeError] of Object.entries(payload.node_errors ?? {})) {
const cls = nodeError.class_type || nodeId
for (const err of nodeError.errors ?? []) {
const detail = err.details || err.message
if (detail) parts.push(`${cls}: ${detail}`)
}
}
return parts.length > 0 ? parts.join('; ') : undefined
}
function toPromptEvent(raw: RawEvent): PromptEvent {
if (raw.type === 'executing')
return { type: 'executing', node: raw.node ?? null }
if (raw.type === 'executed')
return { type: 'executed', node: raw.node ?? null, output: raw.output }
if (raw.type === 'execution_error' || raw.type === 'execution_interrupted') {
const error: ExecutionError = {
exceptionType: raw.exception_type,
nodeId: raw.node_id,
nodeType: raw.node_type,
traceback: raw.traceback
}
return { type: raw.type, error }
}
return { type: raw.type as 'execution_start' | 'execution_success' }
}
/**
* Drives a real ComfyUI backend through the running frontend. The verdict logic
* lives in the pure `classifyRun`; this class is only the in-page IO plumbing.
*/
export class LocalDesktopTarget {
async getObjectInfo(page: Page): Promise<ObjectInfo> {
return await page.evaluate(async () => {
const defs = await window.app!.api.getNodeDefs()
const out: Record<
string,
{ input?: { required?: Record<string, unknown> } }
> = {}
for (const [name, def] of Object.entries(defs)) {
const required = (
def as { input?: { required?: Record<string, unknown> } }
).input?.required
out[name] = { input: { required } }
}
return out
})
}
async runWorkflow(
page: Page,
opts: {
expectedNodeIds: string[]
graphNodeIds?: string[]
timeoutMs: number
}
): Promise<RunResult> {
// A prior run's terminal event can arrive after its sink was read (late
// websocket delivery, or a timed-out prompt finishing during this run).
// Remember every prompt id already observed and ignore its events here,
// so one node's failure is never attributed to the next node tested.
const seenPromptIds = await page.evaluate(
(types) => {
const sink = window as unknown as {
__cnEvents: RawEvent[]
__cnSeenPromptIds?: string[]
__cnTapInstalled?: boolean
}
const seen = new Set(sink.__cnSeenPromptIds ?? [])
for (const event of sink.__cnEvents ?? [])
if (event.prompt_id) seen.add(event.prompt_id)
sink.__cnSeenPromptIds = [...seen]
sink.__cnEvents = []
if (sink.__cnTapInstalled) return sink.__cnSeenPromptIds
sink.__cnTapInstalled = true
for (const type of types)
(window.app!.api as EventTarget).addEventListener(
type,
(event: Event) => {
const detail: unknown = (event as CustomEvent).detail
// `executing` dispatches a bare node-id string (api.ts
// dispatchCustomEvent('executing', msg.data.node)); the other
// events dispatch object payloads.
sink.__cnEvents.push(
detail !== null && typeof detail === 'object'
? { type, ...(detail as Record<string, unknown>) }
: { type, node: (detail as string | undefined) ?? null }
)
}
)
return sink.__cnSeenPromptIds
},
['execution_start', ...TERMINAL, 'executing', 'executed']
)
// Positively identify THIS attempt: the /prompt POST response body
// carries the prompt_id the backend assigned. When captured it becomes
// the primary event filter; the seen-set above and the graph-membership
// check below stay as defense in depth (capture can lose a race with a
// transient refusal, and `executing` events carry no prompt id at all).
let capturedPromptId: string | undefined
// A backend validation rejection answers /prompt with a non-2xx body
// carrying { error, node_errors }. app.queuePrompt swallows it and just
// returns false, so without capturing it here a VALIDATION_FAIL result
// names nothing. Snapshot the failing node/input so the outcome is
// actionable instead of an empty object.
let capturedValidationError: string | undefined
const onPromptResponse = (response: Response) => {
if (response.request().method() !== 'POST') return
if (!new URL(response.url()).pathname.endsWith('/prompt')) return
response
.json()
.then((body: unknown) => {
const id = (body as { prompt_id?: unknown } | null)?.prompt_id
if (typeof id === 'string') capturedPromptId = id
if (response.status() >= 400)
capturedValidationError = summarizePromptError(body)
})
.catch(() => {
// a refused submission answers with a non-JSON or error body;
// the refusal path below already handles it
})
}
page.on('response', onPromptResponse)
const stopCapture = () => page.off('response', onPromptResponse)
// app.queuePrompt (NOT api.queuePrompt: that submits an empty prompt).
// false = validation reject (emits no events), but pack JS hooking the
// queue can refuse transiently - retry once; real rejects fail twice.
// Pack JS can also THROW mid-graphToPrompt on a graph shape it does not
// expect; catch in-page so one bad node classifies as VALIDATION_FAIL
// (with the exception text) instead of aborting the whole tier.
const queueOnce = () =>
page.evaluate(async () => {
try {
return await window.app!.queuePrompt(0)
} catch (error) {
// Never an empty string: an empty __cnThrew would nullish-coalesce
// wrong downstream and blank the VALIDATION_FAIL message.
return { __cnThrew: String(error) || 'pack threw an empty error' }
}
})
const refused = (
result: unknown
): result is false | { __cnThrew: string } =>
result === false ||
(typeof result === 'object' && result !== null && '__cnThrew' in result)
let queued = await queueOnce()
if (refused(queued)) {
await page.evaluate(
() => new Promise((resolve) => setTimeout(resolve, 250))
)
queued = await queueOnce()
if (refused(queued)) {
stopCapture()
return {
outcome: 'VALIDATION_FAIL',
executedNodes: [],
outputsByNode: {},
// A throw carries its own text; a bare `false` reject leaves only
// the backend's node_errors captured off the /prompt response.
clientError:
(typeof queued === 'object' ? queued.__cnThrew : undefined) ??
capturedValidationError
}
}
}
// The submission resolved, so the /prompt response is in flight or done;
// give its body-parse a bounded beat before snapshotting the id.
const captureDeadline = Date.now() + 2_000
while (capturedPromptId === undefined && Date.now() < captureDeadline)
await new Promise((resolve) => setTimeout(resolve, 50))
// A silent permanent miss would degrade every run to the legacy filters
// with no signal - make the fallback observable in the runner output.
if (capturedPromptId === undefined)
console.warn(
'[customNodes] /prompt response id capture missed; falling back to seen-set filtering'
)
await page
.waitForFunction(
([terminal, seen, graphIds, promptId]) => {
const events =
(
window as unknown as {
__cnEvents?: {
type: string
prompt_id?: string
node_id?: string
}[]
}
).__cnEvents ?? []
return events.some(
(event) =>
terminal.includes(event.type) &&
(promptId !== null
? event.prompt_id === promptId
: !(event.prompt_id && seen.includes(event.prompt_id)) &&
(graphIds === null ||
event.node_id === undefined ||
graphIds.includes(event.node_id)))
)
},
[
TERMINAL,
seenPromptIds ?? [],
opts.graphNodeIds ?? null,
capturedPromptId ?? null
] as const,
{ timeout: opts.timeoutMs }
)
.catch((error: unknown) => {
// Only a Playwright wait timeout means "no terminal event"; surface any
// other fault instead of masquerading it as a run TIMEOUT.
if (error instanceof Error && error.name === 'TimeoutError') return
stopCapture()
throw error
})
stopCapture()
const raw = (
await page.evaluate(
() =>
(window as unknown as { __cnEvents?: RawEvent[] }).__cnEvents ?? []
)
).filter((event) =>
// Positive id match when captured (events without a prompt_id - bare
// `executing` strings - stay, and graph membership still vets them);
// otherwise the legacy seen-set exclusion.
capturedPromptId !== undefined
? event.prompt_id === undefined || event.prompt_id === capturedPromptId
: !(event.prompt_id && (seenPromptIds ?? []).includes(event.prompt_id))
)
const timedOut = !raw.some((event) => TERMINAL.includes(event.type))
return classifyRun({
events: raw.map(toPromptEvent),
expectedNodeIds: opts.expectedNodeIds,
graphNodeIds: opts.graphNodeIds,
timedOut
})
}
}

View File

@@ -0,0 +1,164 @@
// Classifies which nodes can execute with no hand-authored fixture; the
// rest are recorded with the reason, never silently dropped.
import { chunk } from 'es-toolkit'
import type { RawNodeDef } from '@e2e/fixtures/customNode/typePairing'
type AutoRunClass =
// Widgets cover every required input and a terminus exists.
| 'AUTO_RUNNABLE'
// Every required socket is synthesizable from a model-free producer.
| 'CHAINABLE'
// A required socket type has no model-free producer (MODEL, CLIP, SEGS...).
| 'NEEDS_WIRES'
// A required combo has zero options (empty model/file scan).
| 'NEEDS_MODELS'
// No outputs and not an OUTPUT_NODE - nothing the executor could watch.
| 'NO_OBSERVABLE_OUTPUT'
export interface RequiredSocket {
name: string
type: string
}
export interface AutoRunVerdict {
key: string
verdict: AutoRunClass
// Wire output 0 to PreviewAny (false = the node is its own terminus).
needsPreviewSink?: boolean
// CHAINABLE: sockets to satisfy from SYNTH_PRODUCERS, in declaration order.
requiredSockets?: RequiredSocket[]
reason: string
}
// Model-free producers for each synthesizable socket type. NUMBER is a WAS
// type with a WAS producer, so each entry is validated against the live defs
// before it counts as synthesizable.
export const SYNTH_PRODUCERS: Record<
string,
{ nodeType: string; outputIndex: number }
> = {
IMAGE: { nodeType: 'EmptyImage', outputIndex: 0 },
LATENT: { nodeType: 'EmptyLatentImage', outputIndex: 0 },
MASK: { nodeType: 'SolidMask', outputIndex: 0 },
INT: { nodeType: 'PrimitiveInt', outputIndex: 0 },
FLOAT: { nodeType: 'PrimitiveFloat', outputIndex: 0 },
STRING: { nodeType: 'PrimitiveString', outputIndex: 0 },
BOOLEAN: { nodeType: 'PrimitiveBoolean', outputIndex: 0 },
AUDIO: { nodeType: 'EmptyAudio', outputIndex: 0 },
NUMBER: { nodeType: 'Constant Number', outputIndex: 0 },
'*': { nodeType: 'PrimitiveInt', outputIndex: 0 }
}
const WIDGET_TYPES = new Set(['INT', 'FLOAT', 'STRING', 'BOOLEAN'])
type InputSpec = [unknown, Record<string, unknown>?] | unknown
function classifyInput(spec: InputSpec): 'widget' | 'socket' | 'empty-combo' {
const specArray = Array.isArray(spec) ? spec : [spec]
const rawType = specArray[0]
const options = specArray[1] as
| { forceInput?: boolean; options?: unknown }
| undefined
// forceInput beats every form, combos included: no widget materializes,
// so no default exists to run on - the input must be wired.
if (options?.forceInput) return 'socket'
if (Array.isArray(rawType))
return rawType.length > 0 ? 'widget' : 'empty-combo'
if (typeof rawType !== 'string') return 'socket'
if (rawType === 'COMBO') {
// Transformed (V2-schema) defs carry combos as the literal 'COMBO' with
// the option list in the opts object. No static list (empty, or a
// `remote` lazy combo) means the default value cannot be verified
// runnable at plan time - same bucket as an empty model scan.
return Array.isArray(options?.options) && options.options.length > 0
? 'widget'
: 'empty-combo'
}
return WIDGET_TYPES.has(rawType) ? 'widget' : 'socket'
}
function socketType(spec: InputSpec): string {
const specArray = Array.isArray(spec) ? spec : [spec]
return String(specArray[0])
}
export function classifyAutoRunnable(
key: string,
def: RawNodeDef & { output_node?: boolean },
synthTypes: ReadonlySet<string>
): AutoRunVerdict {
const sockets: RequiredSocket[] = []
for (const [name, spec] of Object.entries(def.input?.required ?? {})) {
const kind = classifyInput(spec)
if (kind === 'empty-combo')
return {
key,
verdict: 'NEEDS_MODELS',
reason: `required combo "${name}" has no options on this backend`
}
if (kind === 'socket') {
const type = socketType(spec)
if (!synthTypes.has(type))
return {
key,
verdict: 'NEEDS_WIRES',
reason: `required input "${name}" (${type}) has no model-free producer`
}
sockets.push({ name, type })
}
}
const terminus =
def.output_node === true
? { needsPreviewSink: false, note: 'node is its own terminus' }
: (def.output ?? []).length > 0
? { needsPreviewSink: true, note: 'output 0 -> PreviewAny' }
: null
if (!terminus)
return {
key,
verdict: 'NO_OBSERVABLE_OUTPUT',
reason: 'no outputs and not an OUTPUT_NODE - nothing observable to queue'
}
if (sockets.length === 0)
return {
key,
verdict: 'AUTO_RUNNABLE',
needsPreviewSink: terminus.needsPreviewSink,
reason: `widgets satisfy all required inputs; ${terminus.note}`
}
return {
key,
verdict: 'CHAINABLE',
needsPreviewSink: terminus.needsPreviewSink,
requiredSockets: sockets,
reason: `${sockets.length} required socket(s) synthesized from model-free producers; ${terminus.note}`
}
}
export function planAutoRuns(
defs: Record<string, RawNodeDef & { output_node?: boolean }>,
packNodeKeys: string[]
): AutoRunVerdict[] {
// A producer only counts if the backend actually registers it.
const synthTypes = new Set(
Object.entries(SYNTH_PRODUCERS)
.filter(([, producer]) => producer.nodeType in defs)
.map(([type]) => type)
)
return packNodeKeys.map((key) =>
classifyAutoRunnable(key, defs[key], synthTypes)
)
}
// Independent chains per prompt so one bad node fails a batch, not the tier.
export function batchAutoRunnable(
verdicts: AutoRunVerdict[],
batchSize: number
): AutoRunVerdict[][] {
const runnable = verdicts.filter(
(verdict) =>
verdict.verdict === 'AUTO_RUNNABLE' || verdict.verdict === 'CHAINABLE'
)
return chunk(runnable, batchSize)
}

View File

@@ -0,0 +1,82 @@
// Pack-attributed console noise with no visible error surface. Shared by
// the all-nodes tiers and the curated run tier so one ledger covers every
// surface a pack's script can emit on. Filter-guarded: a pattern suppresses
// matching errors for its pack only; stale entries are caught by review,
// not observation (several patterns are environment-conditional, so
// observed-firing guards would false-fail - see ARCHITECTURE.md section 10).
export const CONSOLE_ERROR_ALLOWLIST: Record<
string,
Array<{ pattern: RegExp; reason: string }>
> = {
'ComfyUI-Impact-Pack': [
{
// Media/text widgets preview their value via root-relative URLs at
// creation; 404s on a backend whose root does not serve the file.
pattern:
/Failed to load resource.*404.*(example\.png|plain_video\.mp4|file\.txt)/,
reason: 'media widget previews its value via a root-relative URL'
},
{
// PreviewBridge widgets fetch their internal preview id on configure;
// a bare backend has no image behind it.
pattern: /Failed to load resource.*400.*api\/impact\/get\/pb_id_image/,
reason: 'PreviewBridge fetches its preview id on configure'
},
{
// The save/reload tier writes `<value>_cn` probe values; media widgets
// preview them as URLs and 404.
pattern: /Failed to load resource.*404.*_cn/,
reason: 'set-and-stick probe value previewed by a media widget'
}
],
'ComfyUI-KJNodes': [
{
// Image/video loader previews fetch their combo value at creation;
// on a backend with an empty input dir the value is undefined and the
// preview 404s (and retries with a fresh rand). Console-only noise,
// no visible error; upstream-report candidate.
pattern:
/Failed to load resource.*\/api\/view\?type=input&filename=undefined/,
reason: 'loader preview fetches undefined filename on empty input dir'
}
],
'ComfyUI-Custom-Scripts': [
{
// betterCombos.js:473 checks `typeof ret === "object" && "content" in
// ret`; typeof null is "object", so a null ret during save/reload
// throws `Cannot use 'in' operator to search for 'content' in null`
// as an uncaught page error - invisible until pageerror collection
// landed. Pack-owned and deterministic; upstream-report candidate.
pattern: /Cannot use 'in' operator to search for 'content' in null/,
reason: 'betterCombos.js missing null check throws during save/reload'
}
]
}
export function unallowlistedErrors(pack: string, errors: string[]): string[] {
const allowlist = CONSOLE_ERROR_ALLOWLIST[pack] ?? []
return errors.filter(
(error) => !allowlist.some((rule) => rule.pattern.test(error))
)
}
// Execution errors surface on the tiers that actually queue prompts (the
// curated run and the auto-run tier). The mount, persistence, and wiring
// tiers queue nothing, so a prompt-execution error arriving in their console
// collector is an async stray from a prior tier's still-draining execution -
// the same "not this test" principle the event-attribution filter uses
// (ARCHITECTURE section 9). It is filtered from the non-executing tiers only;
// the executing tiers still assert on it. This is not error suppression: the
// visible error SURFACES (overlay/dialog/toast) are still asserted separately
// by expectNoVisibleErrors.
const FOREIGN_EXECUTION_NOISE: RegExp[] = [
/PromptExecutionError/,
/Prompt execution failed/,
// The browser logs a rejected prompt submission as a failed resource load
// on /api/prompt. Only the executing tiers POST there, so this line in a
// mount/persistence/wiring collector is a prior tier's async submission.
/Failed to load resource.*\/api\/prompt/
]
export function isForeignExecutionNoise(error: string): boolean {
return FOREIGN_EXECUTION_NOISE.some((pattern) => pattern.test(error))
}

View File

@@ -0,0 +1,156 @@
import { readFileSync } from 'node:fs'
import { fileURLToPath } from 'node:url'
const MANIFEST_PATH = fileURLToPath(
new URL('../data/customNodeManifest.json', import.meta.url)
)
const VALID_TIERS = ['load', 'run', 'connectivity', 'io'] as const
type CustomNodeTier = (typeof VALID_TIERS)[number]
export interface CustomNodeManifestEntry {
pack: string
repo: string
pin: string
tiers: CustomNodeTier[]
// Frontend-format workflow (path relative to browser_tests/) loaded and queued
// by the run tier; empty or absent file = tier skips. Run the backend with
// --cache-none, or repeat runs classify PARTIAL when cached nodes skip executing.
workflow: string
// Runtime class_type / object_info keys, NOT Python class names (e.g. rgthree
// registers "Power Primitive (rgthree)", not RgthreePowerPrimitive).
expectedNodes: string[]
// Frontend extension names the pack's JS registers at boot (via
// app.registerExtension), calibrated from the pinned source. Asserted
// against window.app.extensions in the load tier: backend nodes can
// register while the pack's frontend JS silently fails to load (wrong
// web dir, a loadExtensions regression), and every JS-dependent
// assertion in this suite would then quietly test vanilla nodes.
// Empty array = the pinned pack ships no boot-registered extension.
expectedExtensions: string[]
requiresGpu: boolean
requiresModels: string[]
timeoutMs: number
// Optional; absent means true. Set false ONLY with evidence that the pack's
// nodes fail to mount under Vue Nodes 2.0 (probe it - a README grumble is
// not evidence). When false, renderer-specific Vue assertions are not
// applied to this pack: its tests still run and pass their LiteGraph-canvas
// assertions, so the zero-skip gate is preserved.
vueNodesCompatible?: boolean
// Node key -> evidenced reason it cannot mount under Vue Nodes 2.0; only
// the Vue mount assertion is withheld. Stale keys fail the suite.
vueIncompatibleNodes?: Record<string, string>
// Nodes that cannot execute on pure defaults. Asserted both ways: an
// unlisted failure is a regression, a listed clean run is a stale entry.
cannotRunAlone?: string[]
}
// Exported for the pure spec's validation cases; production callers go
// through loadManifest.
export function assertEntry(
entry: CustomNodeManifestEntry,
index: number
): void {
const missing: string[] = []
// CI installs the pack into custom_nodes/<pack>, and node attribution keys
// on that directory name via python_module - so pack must be a safe,
// plain path segment, not just non-empty.
if (
typeof entry.pack !== 'string' ||
!/^[A-Za-z0-9][A-Za-z0-9._-]*$/.test(entry.pack)
)
missing.push('pack (must be a plain path segment)')
// CI clones from repo, so an empty value must fail here, not mid-clone.
if (typeof entry.repo !== 'string' || entry.repo.length === 0)
missing.push('repo')
// The gate tests exactly what was verified, so pin is a required full
// commit SHA. CUSTOM_NODES_ALLOW_UNPINNED=1 is the one escape hatch,
// reserved for the planned pack-HEAD canary - never for the PR gate.
if (
!/^[0-9a-f]{40}$/.test(entry.pin ?? '') &&
!(
process.env.CUSTOM_NODES_ALLOW_UNPINNED === '1' &&
(entry.pin ?? '') === ''
)
)
missing.push('pin (full 40-char commit SHA required)')
// workflow may be an empty string until the pack gains a run-tier fixture.
if (typeof entry.workflow !== 'string') missing.push('workflow')
// A run-tier row with no workflow would otherwise skip locally, leaving
// only CI's skip gate to notice the lost coverage. Fail at load instead.
else if (
entry.workflow === '' &&
Array.isArray(entry.tiers) &&
entry.tiers.includes('run')
)
missing.push('workflow (required when tiers includes "run")')
if (!Array.isArray(entry.expectedNodes) || entry.expectedNodes.length === 0)
missing.push('expectedNodes')
// Explicitly required (an empty array is a deliberate "no frontend JS"
// declaration) so a new pack row cannot silently opt out of the
// extension-loaded assert by omission.
if (
!Array.isArray(entry.expectedExtensions) ||
entry.expectedExtensions.some(
(name) => typeof name !== 'string' || name.length === 0
) ||
new Set(entry.expectedExtensions).size !== entry.expectedExtensions.length
)
missing.push('expectedExtensions (unique non-empty extension names)')
if (!Array.isArray(entry.tiers) || entry.tiers.length === 0)
missing.push('tiers')
// A typo like "connectivty" would otherwise pass and silently drop that
// tier's coverage - the exact drift this manifest exists to catch.
else if (entry.tiers.some((tier) => !VALID_TIERS.includes(tier)))
missing.push(`tiers (unknown value; allowed: ${VALID_TIERS.join(', ')})`)
if (!Array.isArray(entry.requiresModels)) missing.push('requiresModels')
if (typeof entry.requiresGpu !== 'boolean') missing.push('requiresGpu')
if (!Number.isFinite(entry.timeoutMs) || entry.timeoutMs <= 0)
missing.push('timeoutMs')
if (
entry.vueNodesCompatible !== undefined &&
typeof entry.vueNodesCompatible !== 'boolean'
)
missing.push('vueNodesCompatible')
if (
entry.vueIncompatibleNodes !== undefined &&
(typeof entry.vueIncompatibleNodes !== 'object' ||
entry.vueIncompatibleNodes === null ||
Array.isArray(entry.vueIncompatibleNodes) ||
Object.values(entry.vueIncompatibleNodes).some(
(reason) => typeof reason !== 'string' || reason.length === 0
))
)
missing.push('vueIncompatibleNodes (node key -> non-empty reason string)')
if (
entry.cannotRunAlone !== undefined &&
(!Array.isArray(entry.cannotRunAlone) ||
entry.cannotRunAlone.some(
(key) => typeof key !== 'string' || key.length === 0
) ||
new Set(entry.cannotRunAlone).size !== entry.cannotRunAlone.length)
)
missing.push('cannotRunAlone (unique non-empty node keys)')
if (missing.length > 0)
throw new Error(
`custom-node manifest entry ${index} (${entry.pack ?? '?'}) missing: ${missing.join(', ')}`
)
}
// Renderer passes for the load tier: LiteGraph canvas always, Vue Nodes 2.0
// unless the pack declares itself incompatible. Conditional coverage, never a
// test.skip - the caller still runs and gates on the returned passes.
export function rendererPassesFor(
entry: Pick<CustomNodeManifestEntry, 'vueNodesCompatible'>
): boolean[] {
return entry.vueNodesCompatible === false ? [false] : [false, true]
}
export function loadManifest(): CustomNodeManifestEntry[] {
const entries = JSON.parse(
readFileSync(MANIFEST_PATH, 'utf-8')
) as CustomNodeManifestEntry[]
entries.forEach(assertEntry)
return entries
}

View File

@@ -0,0 +1,13 @@
interface ObjectInfoNode {
input?: { required?: Record<string, unknown> }
}
export type ObjectInfo = Record<string, ObjectInfoNode>
// Names from `expectedNodes` absent from the backend's object_info. Empty
// result = every expected node is registered on this backend.
export function missingExpectedNodes(
objectInfo: ObjectInfo,
expectedNodes: string[]
): string[] {
return expectedNodes.filter((name) => !(name in objectInfo))
}

View File

@@ -0,0 +1,107 @@
export type CustomNodeOutcome =
| 'NOT_INSTALLED'
| 'IMPORT_ERROR'
| 'MISSING_NODE'
| 'VALIDATION_FAIL'
| 'EXECUTION_ERROR'
| 'PARTIAL'
| 'TIMEOUT'
| 'PASS'
export interface ExecutionError {
exceptionType?: string
nodeId?: string
nodeType?: string
traceback?: string[]
}
export type PromptEvent =
| { type: 'execution_start' }
| { type: 'executing'; node: string | null }
| { type: 'executed'; node: string | null; output?: unknown }
| { type: 'execution_success' }
| { type: 'execution_error'; error: ExecutionError }
| { type: 'execution_interrupted'; error?: ExecutionError }
export interface RunResult {
outcome: CustomNodeOutcome
executedNodes: string[]
// ui payloads from `executed` events, keyed by node id - proof that data
// reached each output node, not just that execution finished.
outputsByNode: Record<string, unknown>
error?: ExecutionError
// Set when queuePrompt THREW client-side (pack JS hooking the queue can
// crash on a graph shape it does not expect); carries the exception text
// so the failing node self-identifies in the report.
clientError?: string
}
// `executing` with a non-null node is the only cache-safe "this node actually ran"
// signal: ComfyUI emits it solely for non-cached nodes (execution.py:493), while the
// `executed` message and /history outputs are replayed for cached nodes too.
function executedNodesFrom(events: PromptEvent[]): string[] {
const executed = new Set<string>()
for (const event of events) {
if (event.type === 'executing' && event.node !== null)
executed.add(event.node)
}
return [...executed]
}
function outputsFrom(events: PromptEvent[]): Record<string, unknown> {
const outputs: Record<string, unknown> = {}
for (const event of events) {
if (event.type === 'executed' && event.node !== null)
outputs[event.node] = event.output
}
return outputs
}
export function classifyRun(input: {
events: PromptEvent[]
expectedNodeIds: string[]
// All node ids in the queued graph. An error naming a node outside it is a
// stray from another prompt (late websocket delivery, or a duplicate queue
// from the client-flap retry) and must not be pinned on this run.
graphNodeIds?: string[]
timedOut?: boolean
}): RunResult {
const { events, expectedNodeIds, graphNodeIds, timedOut = false } = input
const executedNodes = executedNodesFrom(events)
const outputsByNode = outputsFrom(events)
if (timedOut) return { outcome: 'TIMEOUT', executedNodes, outputsByNode }
const failure = events.find(
(
event
): event is Extract<
PromptEvent,
{ type: 'execution_error' | 'execution_interrupted' }
> =>
(event.type === 'execution_error' ||
event.type === 'execution_interrupted') &&
(graphNodeIds === undefined ||
event.error?.nodeId === undefined ||
graphNodeIds.includes(event.error.nodeId))
)
if (failure)
return {
outcome: 'EXECUTION_ERROR',
executedNodes,
outputsByNode,
error: failure.error
}
if (!events.some((event) => event.type === 'execution_success'))
return { outcome: 'TIMEOUT', executedNodes, outputsByNode }
const ranEveryExpected = expectedNodeIds.every((node) =>
executedNodes.includes(node)
)
return {
outcome: ranEveryExpected ? 'PASS' : 'PARTIAL',
executedNodes,
outputsByNode
}
}

View File

@@ -0,0 +1,293 @@
// Type-driven pairing generator for the connectivity (contract) tier.
// Wildcard `*` slots are excluded from pairing: LiteGraph.isValidConnection
// short-circuits on `*` before the real type compare, so a wildcard link
// proves reachability, not type interop.
export interface RawNodeDef {
input?: {
required?: Record<string, unknown>
optional?: Record<string, unknown>
}
output?: unknown[]
output_name?: string[]
python_module?: string
}
interface NormalizedSlot {
name: string
type: string
// COMBO slots: the literal option list, for same-vocabulary pairing.
comboOptions?: unknown[]
}
export interface NormalizedNode {
type: string
pack: string
inputs: NormalizedSlot[]
outputs: NormalizedSlot[]
// Slots whose raw spec carried no recognizable type (slotTypeOf null):
// recorded so a schema change can never silently shrink the corpus.
unknownSlots?: string[]
}
interface SlotRef {
nodeType: string
pack: string
slotName: string
slotType: string
}
export interface PlannedPair {
producer: SlotRef
consumer: SlotRef
}
export interface PairingPlan {
pairs: PlannedPair[]
// No compatible partner in the loaded corpus: a health signal, not a failure.
orphans: Array<SlotRef & { dir: 'in' | 'out' }>
// `*` / empty-typed slots, excluded by design (false confidence).
wildcards: Array<SlotRef & { dir: 'in' | 'out' }>
// COMBO slots with no same-vocabulary partner in the corpus, excluded:
// isValidConnection only compares the string COMBO while each slot carries
// its own option set, so pairing across different vocabularies proves
// nothing (a checkpoint dropdown would "connect" to a scheduler dropdown).
// Combos whose option lists match exactly ARE paired like any other type.
combos: Array<SlotRef & { dir: 'in' | 'out' }>
// Slots dropped at normalize time because their raw spec had no
// recognizable type - surfaced here (and logged by the sweep) so a
// backend or pack schema change cannot silently shrink the corpus.
unknownShapes: string[]
}
// Extends the shared outcome taxonomy (runResult.ts); ORPHAN_TYPE is a
// plan-time skip so it never reaches the executor.
// WIDGET_ONLY_ON_INSTANCE: the pack's own frontend JS rebuilt a declared
// input as a widget-only control, so there is no socket to wire - excluded
// like wildcards, never a failure and never a silent pass.
export type ConnectivityOutcome =
| 'PASS'
| 'CONNECT_REJECTED'
| 'ROUNDTRIP_LOST'
| 'SLOT_CONTRACT_MISMATCH'
| 'WIDGET_ONLY_ON_INSTANCE'
export function packOf(pythonModule: string | undefined): string {
if (pythonModule?.startsWith('custom_nodes.'))
return pythonModule.slice('custom_nodes.'.length)
return 'core'
}
export function isWildcard(type: string): boolean {
return type === '' || type === '*'
}
// COMBO list literals are arrays; their connectable socket type is COMBO.
function slotTypeOf(rawType: unknown): string | null {
if (Array.isArray(rawType)) return 'COMBO'
return typeof rawType === 'string' ? rawType : null
}
function inputSlots(
entries: Record<string, unknown> | undefined,
unknown: string[]
): NormalizedSlot[] {
if (!entries) return []
const slots: NormalizedSlot[] = []
for (const [name, spec] of Object.entries(entries)) {
const specArray = Array.isArray(spec) ? spec : [spec]
const type = slotTypeOf(specArray[0])
if (type === null) {
unknown.push(name)
continue
}
const opts = specArray[1] as
| { socketless?: boolean; options?: unknown }
| undefined
// socketless = widget only, no slot: not connectable, out of the matrix.
if (opts?.socketless) continue
if (type === 'COMBO') {
// Raw defs carry the option list as the type literal; the frontend's
// transformed defs use the string 'COMBO' with options in the opts.
const options = Array.isArray(specArray[0])
? (specArray[0] as unknown[])
: Array.isArray(opts?.options)
? opts.options
: undefined
slots.push({ name, type, comboOptions: options })
continue
}
slots.push({ name, type })
}
return slots
}
export function normalizeNodeDefs(
defs: Record<string, RawNodeDef>
): NormalizedNode[] {
return Object.entries(defs).map(([type, def]) => {
const unknown: string[] = []
const node: NormalizedNode = {
type,
pack: packOf(def.python_module),
inputs: [
...inputSlots(def.input?.required, unknown),
...inputSlots(def.input?.optional, unknown)
],
outputs: (def.output ?? []).flatMap((rawType, index) => {
const slotType = slotTypeOf(rawType)
if (slotType === null) {
unknown.push(`output[${index}]`)
return []
}
// output_name entries can be non-strings (COMBO literals repeat the
// option array); the slot name must stay a string.
const rawName = def.output_name?.[index]
const slot: NormalizedSlot = {
name: typeof rawName === 'string' ? rawName : slotType,
type: slotType
}
if (slotType === 'COMBO') slot.comboOptions = rawType as unknown[]
return [slot]
})
}
if (unknown.length > 0) node.unknownSlots = unknown
return node
})
}
// Faithful mirror of LiteGraph.isValidConnection (LiteGraphGlobal.ts):
// wildcard/empty always match, comparison is case-insensitive, comma-unions
// match if any member pair matches. The live sweep still connects through the
// REAL validator, so any drift here surfaces as CONNECT_REJECTED, not a
// silent false green.
export function isTypeCompatible(a: string, b: string): boolean {
if (isWildcard(a) || isWildcard(b)) return true
const typeA = a.toLowerCase()
const typeB = b.toLowerCase()
if (typeA === typeB) return true
if (!typeA.includes(',') && !typeB.includes(',')) return false
return typeA
.split(',')
.some((memberA) =>
typeB.split(',').some((memberB) => isTypeCompatible(memberA, memberB))
)
}
function slotRef(node: NormalizedNode, slot: NormalizedSlot): SlotRef {
return {
nodeType: node.type,
pack: node.pack,
slotName: slot.name,
slotType: slot.type
}
}
// One representative compatible edge per slot, deterministically the first
// partner in (nodeType, slotName) order. This bounds cost to O(slots) but
// does NOT prove every pair; a full cross-product is an opt-in deep mode.
export function planPairs(
all: NormalizedNode[],
corpusTypes: string[]
): PairingPlan {
const sorted = [...all].sort((a, b) => a.type.localeCompare(b.type))
const pairable = (slot: NormalizedSlot) =>
!isWildcard(slot.type) && slot.type !== 'COMBO'
const producers: Array<SlotRef> = sorted.flatMap((node) =>
node.outputs.filter(pairable).map((slot) => slotRef(node, slot))
)
const consumers: Array<SlotRef> = sorted.flatMap((node) =>
node.inputs.filter(pairable).map((slot) => slotRef(node, slot))
)
// COMBO slots pair only on an identical option vocabulary; the string type
// alone would let a checkpoint dropdown "connect" to a scheduler dropdown.
// Vocabulary equality is a SET comparison: a wired input bypasses its own
// widget, so menu order and the options[0] default do not participate in
// the wire contract - only membership does (backend validation checks
// "value in options"). Values still compare as exact strings.
const vocabOf = (slot: NormalizedSlot) =>
JSON.stringify(
(slot.comboOptions ?? []).map((option) => JSON.stringify(option)).sort()
)
// A combo whose option list is unknown (transformed defs without an
// options array) must never pair - a blind match would wire dropdowns
// with no vocabulary evidence at all.
const comboProducers = sorted.flatMap((node) =>
node.outputs
.filter(
(slot) => slot.type === 'COMBO' && Array.isArray(slot.comboOptions)
)
.map((slot) => ({ ref: slotRef(node, slot), vocab: vocabOf(slot) }))
)
const comboConsumers = sorted.flatMap((node) =>
node.inputs
.filter(
(slot) => slot.type === 'COMBO' && Array.isArray(slot.comboOptions)
)
.map((slot) => ({ ref: slotRef(node, slot), vocab: vocabOf(slot) }))
)
const plan: PairingPlan = {
pairs: [],
orphans: [],
wildcards: [],
combos: [],
unknownShapes: all.flatMap((node) =>
(node.unknownSlots ?? []).map((slot) => `${node.type}.${slot}`)
)
}
const seen = new Set<string>()
const addPair = (producer: SlotRef, consumer: SlotRef) => {
const key = `${producer.nodeType}.${producer.slotName}->${consumer.nodeType}.${consumer.slotName}`
if (seen.has(key)) return
seen.add(key)
plan.pairs.push({ producer, consumer })
}
const corpus = all.filter((node) => corpusTypes.includes(node.type))
for (const node of corpus) {
for (const slot of node.inputs) {
if (isWildcard(slot.type)) {
plan.wildcards.push({ ...slotRef(node, slot), dir: 'in' })
continue
}
if (slot.type === 'COMBO') {
const producer = Array.isArray(slot.comboOptions)
? comboProducers.find(
(candidate) => candidate.vocab === vocabOf(slot)
)
: undefined
if (producer) addPair(producer.ref, slotRef(node, slot))
else plan.combos.push({ ...slotRef(node, slot), dir: 'in' })
continue
}
const producer = producers.find((candidate) =>
isTypeCompatible(candidate.slotType, slot.type)
)
if (producer) addPair(producer, slotRef(node, slot))
else plan.orphans.push({ ...slotRef(node, slot), dir: 'in' })
}
for (const slot of node.outputs) {
if (isWildcard(slot.type)) {
plan.wildcards.push({ ...slotRef(node, slot), dir: 'out' })
continue
}
if (slot.type === 'COMBO') {
const consumer = Array.isArray(slot.comboOptions)
? comboConsumers.find(
(candidate) => candidate.vocab === vocabOf(slot)
)
: undefined
if (consumer) addPair(slotRef(node, slot), consumer.ref)
else plan.combos.push({ ...slotRef(node, slot), dir: 'out' })
continue
}
const consumer = consumers.find((candidate) =>
isTypeCompatible(slot.type, candidate.slotType)
)
if (consumer) addPair(slotRef(node, slot), consumer)
else plan.orphans.push({ ...slotRef(node, slot), dir: 'out' })
}
}
return plan
}

View File

@@ -0,0 +1,158 @@
[
{
"pack": "ComfyUI-Impact-Pack",
"repo": "https://github.com/ltdrdata/ComfyUI-Impact-Pack",
"pin": "429d0159ad429e64d2b3916e6e7be9c22d025c3c",
"tiers": ["load", "connectivity", "run"],
"workflow": "assets/customNodes/impact_primitives_run.json",
"expectedNodes": ["ImpactInt", "ImpactFloat"],
"expectedExtensions": ["Comfy.Impack"],
"requiresGpu": false,
"requiresModels": [],
"timeoutMs": 30000,
"cannotRunAlone": [
"AnyPipeToBasic",
"CLIPSegDetectorProvider",
"ImpactMakeImageBatch",
"ImpactMakeMaskBatch",
"LatentSender",
"MasksToMaskList",
"PreviewBridgeLatent"
]
},
{
"pack": "ComfyUI-VideoHelperSuite",
"repo": "https://github.com/Kosinkadink/ComfyUI-VideoHelperSuite",
"pin": "4ee72c065db22c9d96c2427954dc69e7b908444b",
"tiers": ["load", "connectivity", "run"],
"workflow": "assets/customNodes/vhs_video_pipeline_run.json",
"expectedNodes": ["VHS_LoadVideoPath", "VHS_VideoInfo"],
"expectedExtensions": ["VideoHelperSuite.Core"],
"requiresGpu": false,
"requiresModels": [],
"timeoutMs": 90000,
"cannotRunAlone": [
"VHS_LoadAudio",
"VHS_LoadImagePath",
"VHS_LoadImages",
"VHS_LoadImagesPath",
"VHS_LoadVideoFFmpegPath",
"VHS_LoadVideoPath"
]
},
{
"pack": "rgthree-comfy",
"repo": "https://github.com/rgthree/rgthree-comfy",
"pin": "27b4f4cdcf3b127c29d5d8135ac1536ecbd4c383",
"tiers": ["load", "connectivity", "run"],
"workflow": "assets/customNodes/rgthree_seed_display_run.json",
"expectedNodes": ["Seed (rgthree)", "Display Any (rgthree)"],
"expectedExtensions": ["rgthree.AnySwitch"],
"requiresGpu": false,
"requiresModels": [],
"timeoutMs": 30000,
"cannotRunAlone": ["Image or Latent Size (rgthree)"]
},
{
"pack": "ComfyUI_essentials",
"repo": "https://github.com/cubiq/ComfyUI_essentials",
"pin": "9d9f4bedfc9f0321c19faf71855e228c93bd0dc9",
"tiers": ["load", "connectivity", "run"],
"workflow": "assets/customNodes/essentials_math_display_run.json",
"expectedNodes": ["SimpleMathInt+", "DisplayAny"],
"expectedExtensions": ["essentials.DisplayAny"],
"requiresGpu": false,
"requiresModels": [],
"timeoutMs": 30000,
"cannotRunAlone": [
"ImageApplyLUT+",
"ImageUntile+",
"MaskFromList+",
"PixelOEPixelize+",
"SimpleCondition+",
"SimpleMath+",
"SimpleMathCondition+",
"SimpleMathDual+"
]
},
{
"pack": "ComfyUI-KJNodes",
"repo": "https://github.com/kijai/ComfyUI-KJNodes",
"pin": "e27a505b3ba6ce42687fe00500deda103d9d6071",
"tiers": ["load", "connectivity", "run"],
"workflow": "assets/customNodes/kjnodes_constants_run.json",
"expectedNodes": ["INTConstant", "FloatConstant"],
"expectedExtensions": ["KJNodes.appearance"],
"requiresGpu": false,
"requiresModels": [],
"timeoutMs": 30000,
"cannotRunAlone": [
"CameraPoseVisualizer",
"CreateAudioMask",
"CreateGradientFromCoords",
"CreateInstanceDiffusionTracking",
"CreateShapeImageOnPath",
"CreateShapeMaskOnPath",
"CreateTextOnPath",
"CrossFadeImages",
"CrossFadeImagesMulti",
"CustomControlNetWeightsFluxFromList",
"CutAndDragOnPath",
"EndRecordCUDAMemoryHistory",
"FloatToMask",
"GetImagesFromBatchIndexed",
"GetLatentsFromBatchIndexed",
"ImageAndMaskPreview",
"ImageGridtoBatch",
"ImagePadForOutpaintTargetSize",
"InterpolateCoords",
"LoadImagesFromFolderKJ",
"LoadVideosFromFolder",
"PlotCoordinates",
"StartRecordCUDAMemoryHistory",
"Superprompt",
"VisualizeCUDAMemoryHistory",
"WebcamCaptureCV2",
"WeightScheduleConvert",
"WeightScheduleExtend",
"WidgetToString"
]
},
{
"pack": "ComfyUI-Custom-Scripts",
"repo": "https://github.com/pythongosssss/ComfyUI-Custom-Scripts",
"pin": "609f3afaa74b2f88ef9ce8d939626065e3247469",
"tiers": ["load", "connectivity", "run"],
"workflow": "assets/customNodes/customscripts_string_show_run.json",
"expectedNodes": ["StringFunction|pysssss", "ShowText|pysssss"],
"expectedExtensions": ["pysssss.ShowText"],
"requiresGpu": false,
"requiresModels": [],
"timeoutMs": 30000,
"cannotRunAlone": ["MathExpression|pysssss"]
},
{
"pack": "was-node-suite-comfyui",
"repo": "https://github.com/WASasquatch/was-node-suite-comfyui",
"pin": "ea935d1044ae5a26efa54ebeb18fe9020af49a45",
"tiers": ["load", "connectivity", "run"],
"workflow": "assets/customNodes/was_number_text_run.json",
"expectedNodes": ["Constant Number", "Number to Text", "Text to Console"],
"expectedExtensions": [],
"requiresGpu": false,
"requiresModels": [],
"timeoutMs": 30000,
"cannotRunAlone": [
"Bus Node",
"Diffusers Hub Model Down-Loader",
"Image Aspect Ratio",
"Image Batch",
"Image Send HTTP",
"Latent Batch",
"Mask Batch",
"Samples Passthrough (Stat System)",
"Text Dictionary Convert",
"Text to Number"
]
}
]

View File

@@ -0,0 +1,28 @@
import type { ConsoleMessage, Page } from '@playwright/test'
export function collectConsoleErrors(page: Page): {
errors: string[]
stop: () => void
} {
const errors: string[] = []
const listener = (message: ConsoleMessage) => {
if (message.type() !== 'error') return
const url = message.location().url
errors.push(url ? `${message.text()} [${url}]` : message.text())
}
// Uncaught page exceptions and unhandled promise rejections never reach
// console.error; Chromium surfaces both through pageerror. Without this
// listener a pack script crashing outside a console call passes silently.
const pageErrorListener = (error: Error) => {
errors.push(`Uncaught page error: ${error.message}`)
}
page.on('console', listener)
page.on('pageerror', pageErrorListener)
return {
errors,
stop: () => {
page.off('console', listener)
page.off('pageerror', pageErrorListener)
}
}
}

View File

@@ -0,0 +1,80 @@
import type { Page } from '@playwright/test'
import type { ComfyPage } from '@e2e/fixtures/ComfyPage'
import { TestIds } from '@e2e/fixtures/selectors'
// Boot every session with a blank graph (loadBlankWorkflow) instead of the
// bundled default template, whose model references error on a model-less
// harness backend and would trip the zero-visible-errors invariant. The
// backend must run --multi-user (the repo-wide prerequisite for browser
// tests): the fixture then writes these settings to the same per-worker
// user the session reads, on CI and locally alike.
// The shared fixture disables the errors tab to hide missing-model
// indicators in unrelated suites; this suite exists to SEE errors, so every
// error surface stays live.
export const customNodeSuiteSettings = {
'Comfy.TutorialCompleted': false,
'Comfy.RightSidePanel.ShowErrorsTab': true
}
// The tutorial path (Comfy.TutorialCompleted:false) auto-opens the templates
// browser over the blank graph on some ComfyUI backends, but WHETHER it opens
// has drifted across backend versions - newer ComfyUI no longer auto-opens it.
// Dismiss it if it appears; if it never shows within a short window there is
// nothing to dismiss and the blank graph is already ready. Hard-waiting for
// 'visible' (no timeout) hung every beforeEach for the full 15s test budget on
// backends where it stopped auto-opening, failing the whole suite.
export async function dismissTemplatesDialog(
comfyPage: ComfyPage
): Promise<void> {
const templates = comfyPage.page.getByTestId(TestIds.templates.content)
try {
await templates.waitFor({ state: 'visible', timeout: 5000 })
} catch {
return
}
await comfyPage.page.keyboard.press('Escape')
await templates.waitFor({ state: 'hidden' })
}
// Every test gets a fresh page, but they share ONE backend. An execution
// tier that ends while a prompt is still draining leaves that work running
// on the shared backend; the next test's fresh page connects mid-execution
// and catches its async error events (console noise, a popped error dialog)
// or its still-running prompt (queue-busy). Draining to idle in an afterEach
// - while the finishing test's own page is still open, so any late events
// land there - is what makes each test unable to affect the next. getQueue
// swallows a failed fetch and returns an empty queue, so throw-on-error and
// treat a failed read as still-busy; the wait is free when already idle
// (one getQueue round-trip), so a healthy suite pays ~nothing for it.
// Returns 0 when the backend reached idle, 1 when it was still busy after the
// budget (a genuinely wedged, non-interruptible execution). The afterEach hook
// ignores the result; the auto-run tier asserts on it.
export async function drainBackendToIdle(
page: Page,
budgetMs = 150_000
): Promise<number> {
const depth = () =>
page.evaluate(async () => {
try {
const queue = await window.app!.api.getQueue({ throwOnError: true })
return queue.Running.length + queue.Pending.length
} catch {
return Number.POSITIVE_INFINITY
}
})
if ((await depth()) === 0) return 0
await page.evaluate(async () => {
await window.app!.api.interrupt(null)
await window.app!.api.clearItems('queue')
})
const deadline = Date.now() + budgetMs
let remaining = await depth()
while (remaining !== 0 && Date.now() < deadline) {
await page.evaluate(
() => new Promise((resolve) => setTimeout(resolve, 500))
)
remaining = await depth()
}
return remaining === 0 ? 0 : 1
}

View File

@@ -0,0 +1,28 @@
import type { Locator, Page } from '@playwright/test'
import { expect } from '@playwright/test'
import { TestIds } from '@e2e/fixtures/selectors'
// The app's user-visible error surfaces. A regression run is green only if a
// human looking at the screen would see zero errors - not merely a clean
// console. The harness self-check asserts the overlay IS visible after a
// forced execution error, so these selectors are permanently proven live.
export function errorSurfaces(page: Page): Record<string, Locator> {
return {
errorOverlay: page.getByTestId(TestIds.dialogs.errorOverlay),
errorDialog: page.getByTestId(TestIds.dialogs.errorDialog),
nodeRenderErrors: page.locator('.node-error'),
errorToasts: page.locator('.p-toast-message-error')
}
}
// The suite's central invariant: a regression run is green only if every
// user-visible error surface is empty. Kept here (single source) so a new
// surface added above is enforced everywhere at once.
export async function expectNoVisibleErrors(
page: Page,
context: string
): Promise<void> {
for (const [surface, locator] of Object.entries(errorSurfaces(page)))
await expect(locator, `${context}: ${surface}`).toHaveCount(0)
}

View File

@@ -117,23 +117,11 @@ class NodeSlotReference {
if (!node) throw new Error(`Node ${id} not found.`)
const rawPos = node.getConnectionPos(type === 'input', index)
const convertedPos =
window.app!.canvas.ds!.convertOffsetToCanvas(rawPos)
// Debug logging - convert Float64Arrays to regular arrays for visibility
console.warn(
`NodeSlotReference debug for ${type} slot ${index} on node ${id}:`,
{
nodePos: [node.pos[0], node.pos[1]],
nodeSize: [node.size[0], node.size[1]],
rawConnectionPos: [rawPos[0], rawPos[1]],
convertedPos: [convertedPos[0], convertedPos[1]],
currentGraphType:
'inputNode' in window.app!.canvas.graph! ? 'Subgraph' : 'LGraph'
}
)
return convertedPos
// page.mouse needs page coords. canvasPosToClientPos applies the
// canvas transform AND the canvas element's client offset, so it
// survives pack JS injecting chrome above the canvas (e.g. rgthree's
// progress bar shifting it off (0,0)).
return window.app!.canvasPosToClientPos([rawPos[0], rawPos[1]])
},
[this.type, this.node.id, this.index] as const
)

View File

@@ -0,0 +1,408 @@
# Adding a custom-node pack to the regression suite
The authoritative, step-by-step process for onboarding a new pack. Written to
be followable by a human or an agent with no prior context. The suite itself
(what it asserts, how to run it) is documented in [README.md](README.md),
and its system design in [ARCHITECTURE.md](ARCHITECTURE.md); this file is
only about adding coverage for a new pack.
The short version: install the pack on a local test backend, read the pack's
real node keys out of `/object_info`, author one small model-free workflow,
add one row to the manifest, prove it green locally, push. No new test code
is ever needed - the specs iterate the manifest. (One exception: a pack
whose JS grows/shrinks input slots dynamically also adds one case row to
`AUTOGROW_CASES` in `dynamicInputs.spec.ts` to enroll that behavior.)
## What a manifest row buys you (the tiers)
Adding the one row enrolls the pack in two kinds of coverage:
- **Every-node tiers (automatic, zero configuration).** The suite reads the
pack's FULL node list from the live backend and, for every registered
node: mounts it in both renderers and asserts under EACH renderer that the
instance materializes everything its def declares - every non-socketless
input exists as a widget or a socket (autogrow templates count via their
expansion slots) and every declared output exists; the Vue pass
additionally asserts the DOM renders at least the instance's widget and
slot counts - a mount with missing controls fails. It then round-trips
every node through save/reload (every widget
is first written with a non-default value that must stick, and the
serialized `widgets_values` must survive configure unchanged), plans typed
connections for all its concrete slots (COMBO slots pair when they offer
the same option SET - order-insensitive, since a wired input bypasses its
own widget and only membership matters), and executes it for real when it
can run:
either self-sufficient (every required input is a widget with a valid
default) or `CHAINABLE` - every required socket type has a model-free
producer (`EmptyImage`, `EmptyLatentImage`, `SolidMask`, `Primitive*`,
`EmptyAudio`, ...) that the runner synthesizes and wires automatically.
Executed nodes must observably produce: the `PreviewAny` sink wired to the
node's first output must emit a ui payload, or the node is its own
terminus (`OUTPUT_NODE`). Nodes that cannot run are classified and
logged, never silently dropped: `NEEDS_WIRES` (a required socket type has
no model-free producer - MODEL, SEGS, CONDITIONING...), `NEEDS_MODELS`
(empty model/file combo on the bare backend), `NO_OBSERVABLE_OUTPUT`
(nothing observable to queue), or "rejected at validation on defaults"
(needs a curated fixture).
- **Curated tiers (the row's fields).** `expectedNodes` + `workflow` drive
the hand-authored run-tier chain (Step 4) proving a real multi-node
wiring executes end to end, and serve as must-exist sentinels.
Every-node coverage means a pack update is tested the moment CI installs
it - including nodes you never listed.
## Step 0 - prerequisites
- A local test backend and dev server set up exactly per the
[README prerequisites](README.md#prerequisites). Do not skip `--multi-user`
or `--cache-none`.
- The pack's GitHub URL. The CI job clones and pip-installs it, so the repo
must be public and its `requirements.txt` must install on a CPU-only
runner. Packs that hard-require CUDA at import time cannot be onboarded
until they guard that import.
## Step 1 - install the pack on the test backend
```bash
cd <test-backend>/custom_nodes
git clone https://github.com/<owner>/<pack>
pip install -r <pack>/requirements.txt # if the pack has one
```
The clone directory name must equal the manifest `pack` key: node
attribution keys on that directory via `python_module`, and CI installs
into `custom_nodes/<pack>` for the same reason.
If you run a CPU-only backend, constrain pip so the pack cannot swap in a
different torch (CI does the same):
```bash
pip freeze | grep -iE '^(torch|torchvision|torchaudio)==' > /tmp/torch-constraints.txt
pip install -r <pack>/requirements.txt -c /tmp/torch-constraints.txt
```
Restart the backend and check its log: the `Import times for custom nodes`
block must list the pack with no `IMPORT FAILED` marker. An import failure is
a pack bug or a missing dependency - fix that first; nothing downstream can
work without a clean import.
While you are here, note whether the pack ships frontend JS:
```bash
curl -s http://127.0.0.1:8288/extensions | python3 -c '
import json, sys
print(sum(1 for p in json.load(sys.stdin) if p.startswith("/extensions/<pack-dir-name>/")))
'
```
Non-zero means the pack patches the frontend at runtime (restyled nodes,
rebuilt widgets, injected page chrome). Write that down - it decides whether
Step 6 needs the CI-parity run. Both "green locally, red on CI" failures in
the first 5-pack onboarding came from exactly this.
## Step 2 - read the pack's real node keys
The manifest's `expectedNodes` are the pack's `object_info` keys (the same
strings the API uses as `class_type`). They are NOT Python class names and
NOT display names. Get them from the running backend:
```bash
curl -s http://127.0.0.1:8288/object_info | python3 -c '
import json, sys
d = json.load(sys.stdin)
for key, node in sorted(d.items()):
if node.get("python_module") == "custom_nodes.<pack-dir-name>":
print(key)
'
```
Real traps this step catches (each one shipped in a real pack):
| Pack | Correct key | Wrong guesses that look right |
| ---------------------- | ------------------- | ------------------------------------------------------------------------------- |
| ComfyUI_essentials | `SimpleMathInt+` | `SimpleMathInt` (keys carry a trailing `+`, except `DisplayAny` which has none) |
| ComfyUI-KJNodes | `INTConstant` | `INT Constant` (that is the display name) |
| ComfyUI-Custom-Scripts | `ShowText\|pysssss` | `ShowText` (keys carry a `\|pysssss` suffix) |
| rgthree-comfy | `Seed (rgthree)` | `RgthreeSeed` (the Python class name) |
## Step 3 - pick the expected nodes
Choose 2-3 nodes that are:
- **Model-free**: no checkpoint / VAE / CLIP inputs, no file downloads. The
gate runs on CPU with no models installed. Constants, math, text, and
display nodes are ideal.
- **Wireable into a chain**: at least one producer (has a typed output) and
one terminal node. A terminal node either has `output_node: true` in
`/object_info` (it terminates a workflow by itself) or you end the chain in
the core `PreviewAny` node, which accepts any type.
Check a candidate's inputs, outputs, and `output_node` flag:
```bash
curl -s http://127.0.0.1:8288/object_info | python3 -c '
import json, sys
node = json.load(sys.stdin)["<exact key>"]
print(json.dumps({k: node[k] for k in ("input", "output", "output_name", "output_node")}, indent=1))
'
```
Every node you list in `expectedNodes` must appear in the run workflow: the
run tier asserts each one actually executes on the backend.
## Step 4 - author the run-tier workflow
Add one JSON file under `browser_tests/assets/customNodes/`, named
`<pack>_<what it does>_run.json`. Copy an existing asset as the template
(`rgthree_seed_display_run.json` is the simplest two-node example;
`was_number_text_run.json` shows a 3-node chain). It is the frontend
workflow format, hand-authorable:
- `nodes[].type` is the exact `object_info` key from Step 2.
- `widgets_values` is an array in the node's widget order: the `input`
entries from `/object_info` in declaration order (`required` first, then
`optional`), keeping only widget-type inputs (INT, FLOAT, STRING, BOOLEAN,
and combo lists) and skipping any input whose options say
`"forceInput": true` (those are sockets, never widgets). A required input
that is neither a widget type nor `forceInput` (a custom type like
`NUMBER`) is also a socket: wire a link into it or the run fails on a
missing required input.
- A link is one row in `links`: `[link_id, from_node_id, from_slot,
to_node_id, to_slot, "TYPE"]`, plus the matching `link`/`links` ids on the
two nodes' `inputs`/`outputs` entries.
- To wire INTO an input that would normally be a widget (no `forceInput`),
the input entry also needs a `"widget": { "name": "<input name>" }` key -
see `browser_tests/assets/vueNodes/linked-int-widget.json`.
- Keep it tiny. Two to four nodes proving "this pack executes" is the whole
job; feature-depth testing belongs to the pack's own repo.
- If the workflow needs a media file, reuse something already under
`browser_tests/assets/` (e.g. `plain_video.mp4`) - never commit new binary
assets. CI stages `plain_video.mp4` into the backend's `input/` dir; if
your workflow needs a different existing asset staged, extend the
`Stage run-tier assets` step in
`.github/workflows/ci-tests-custom-nodes.yaml`.
- A media path in the workflow (e.g. `input/plain_video.mp4`) resolves
against the backend process's working directory, not the repo. Locally,
copy the file into the `input/` dir of the directory you launched
`main.py` from, or the run tier fails validation with
`Invalid file path` and the test reports `TIMEOUT`.
## Step 5 - add the manifest row
Append one object to `browser_tests/fixtures/data/customNodeManifest.json`:
| Field | Meaning |
| -------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
| `pack` | The pack's directory name under `custom_nodes/` (what `git clone` creates). |
| `repo` | The GitHub URL CI clones. Required non-empty. |
| `pin` | Required: the full 40-char commit SHA you verified locally. The manifest loader rejects anything else at load and CI fails before install (empty is accepted only under `CUSTOM_NODES_ALLOW_UNPINNED=1`, reserved for the planned pack-HEAD canary). CI checks it out after cloning, so the gate tests exactly what you tested. Bump deliberately, re-verifying per this doc. |
| `tiers` | Tier gates: `connectivity` (typed links + slot drags) and `run` (executes the workflow) enable their tiers; `load` is descriptive only - the register+render pass runs for every row regardless. Keep all three unless a tier is impossible for the pack. |
| `workflow` | Path relative to `browser_tests/` of the Step 4 file. `""` only while the pack has no `run` tier. |
| `expectedNodes` | The Step 2/3 keys. The load tier mounts each in both renderers; the run tier asserts each executes. |
| `expectedExtensions` | Required. Frontend extension names the pack's JS registers at boot (`app.registerExtension({ name })` in the pinned source - grep its web/js dir). The load tier asserts each is present in `window.app.extensions`, catching a pack whose frontend JS silently fails to load while its backend nodes still register. One boot-registered sentinel name per pack is enough for the pack-level failure modes this assert targets (wrong web dir, a loadExtensions regression); extension files load per-file, so a single-file failure inside a multi-file pack is out of scope for this tier. Do not enumerate every extension. `[]` only when the pinned pack ships no frontend JS. |
| `requiresGpu` | `true` only if execution genuinely needs CUDA. Such packs cannot use the `run` tier on the CPU gate. |
| `requiresModels` | Model files the workflow needs (`[]` for the packs onboarded so far - keep it that way whenever possible). |
| `timeoutMs` | Per-test budget. `30000` unless the workflow does real work (video decode uses `90000`). |
| `vueNodesCompatible` | Optional, default `true`. See the policy below. Only ever set `false`, and only with evidence. |
`loadManifest()` (`browser_tests/fixtures/customNode/manifest.ts`) validates
every row and fails loudly on a missing field, an empty `repo`, a misspelled
tier, or a `run` tier with an empty `workflow`.
## Step 6 - prove it green locally, in both environments
### 6a - fast loop (dev server)
```bash
pnpm test:custom-nodes
```
Green means: every tier for every pack passes, zero skips, and the
zero-visible-errors invariant held for the tiers that assert it (mount,
persistence, connectivity, core smoke, curated workflows): no error
overlay, dialog, node error, or error toast. Two deliberate exceptions,
same as the README: the auto-run execution tier provokes expected
failures, and the self-check inverts the invariant. Iterate here - it is
the fastest loop.
Two surfaces fail under 6a BY DESIGN and are proven in 6b/CI instead: the
T0 `expectedExtensions` assert and the dynamic-inputs tier. Both depend on
pack frontend JS, which the dev server never loads (see 6b) - so their 6a
red is the assert working, not a setup problem. Everything else must be
green here.
### 6b - CI-parity run (required if the pack ships frontend JS)
The dev server never loads pack frontend JS (its `/extensions` list is
core-only), so 6a exercises vanilla nodes. If Step 1 found frontend JS, a
6a green proves nothing about the pack's real runtime behavior. CI serves
the built frontend from the backend, so reproduce that exactly:
```bash
pnpm build
# relaunch the test backend with the same flags plus:
# --front-end-root <repo>/dist
# and make sure any run-tier media is in that process's input/ dir
PLAYWRIGHT_TEST_URL=http://127.0.0.1:8288 pnpm exec playwright test \
browser_tests/tests/customNodes/ --config playwright.chrome.config.ts --workers=1
```
Both real failures during the first 5-pack onboarding only existed here:
rgthree's progress bar shifted the canvas and broke slot-drag coordinates,
and rgthree's Seed rebuilt a declared input as widget-only. Skipping 6b
means discovering that class of problem one CI round at a time.
### Failure classes and what they mean
- **T0 fails only in the Vue Nodes pass** (the LiteGraph pass is green):
suspected Vue Nodes 2.0 incompatibility. Follow the policy below - do not
delete the pack, do not skip the test.
- **Run tier fails with `PARTIAL`** (some expected nodes never executed):
either the backend is missing `--cache-none` (cached nodes emit no
`executing` event) or an expected node is not actually in the workflow.
- **Run tier fails with an execution error**: the workflow JSON is wrong
(bad key, wrong `widgets_values` order, type-mismatched link) or the pack
cannot execute model-free. Fix the workflow or drop the node for a
simpler one.
- **Connectivity reports zero planned pairs**: the pack's slots are all
wildcard typed, or combo typed with no same-vocabulary partner (wildcards
bypass the real type compare; combos pair only when their option lists
match exactly). The pack still gets load/run coverage.
- **Connectivity logs `widget-only on instance` exclusions**: the pack's own
frontend JS rebuilt a declared input as a widget-only control (rgthree's
Seed does this to `seed`), so there is no socket to wire. Recorded and
excluded, like wildcards - pack design, not a regression.
- **Auto-run reports a node "not in cannotRunAlone"**: the node failed to
execute on pure defaults or synthesized chain inputs (validation reject,
or a real exception from degenerate inputs - empty expression, empty
coordinate JSON, single-frame batch, missing optional python dep). If the
node USED to run clean this is a regression; otherwise add it to the
row's `cannotRunAlone` baseline with the run log in the PR. The check is
two-way: a listed node that starts running clean fails the suite until
the stale entry is removed. Confidence note: a chain failure proves the
node cannot run on synthesized inputs, not that it is broken - the inputs
may be semantically insufficient (e.g. a coordinates STRING fed an empty
string).
- **Auto-run reports `NO_OUTPUT`**: the node executed but its `PreviewAny`
sink emitted no ui payload - data never actually flowed out of the node.
Treat like any other cannot-run failure: regression or baseline entry.
- **Auto-run fails with `HUNG_BACKEND`**: a node blocked forever during
execution. Observed mechanism classes so far: model downloads at execute
(BLIP/SAM/MiDaS/rembg/CLIPSeg `from_pretrained`), runtime
`pip install` inside execute (WAS lazy-install), minutes-long pure-Python
per-pixel loops, and an infinite `while` on empty-string defaults. The
failure names the suspects and the remedy: add the offender to
`AUTO_RUN_EXCLUDE` in `allNodes.spec.ts` with its mechanism, and restart
the test backend (the hang is non-interruptible). Everything queued
behind the offender reports `HUNG_BACKEND` too - identify the true
offender (backend log, `/queue`) before excluding victims.
- **Mount test fails on console errors**: a pack's JS logged real errors
while its nodes mounted. If it is pack-attributed noise with no visible
error surface (KJNodes' loader previews fetching `filename=undefined`),
add a scoped `CONSOLE_ERROR_ALLOWLIST` entry (in
`fixtures/customNode/consoleErrorLedger.ts`, shared by the all-nodes
tiers and the curated run) with the mechanism; otherwise it is a
finding.
### The exception ledgers (all reasons on the record)
Every escape hatch is a reviewed list whose entries carry the mechanism, so
the gate stays honest and none can grow silently:
| Ledger | Lives in | Covers |
| ---------------------------- | ------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| `vueIncompatibleNodes` | manifest row | node cannot mount under Vue Nodes 2.0 (evidence rule below) |
| `cannotRunAlone` | manifest row | node cannot execute standalone on a bare backend; asserted both ways so entries cannot rot |
| `AUTO_RUN_EXCLUDE` | `allNodes.spec.ts` | executing the node is unsafe or unstable (runtime downloads/pip installs, infinite loops, non-interruptible hangs, environment/state-variable results, flip-flopping executed signals) |
| `WIDGET_SET_ALLOWLIST` | `allNodes.spec.ts` | plain-typed widget whose value is owned by pack JS (menu-action combos, canonicalized refs) - set-and-stick does not apply |
| `ROUNDTRIP_VALUE_ALLOWLIST` | `allNodes.spec.ts` | node whose serialized widgets_values legitimately change on reload (pack JS initializes or rebuilds them); the widget-shrink check still applies |
| `MOUNT_WIDGET_ALLOWLIST` | `allNodes.spec.ts` | node whose pack JS renders custom editor/preview widgets outside the node-widget rows; slot fidelity still applies |
| `CONSOLE_ERROR_ALLOWLIST` | `fixtures/customNode/consoleErrorLedger.ts` | pack-attributed console noise with no visible error surface; shared by the all-nodes tiers and the curated run |
| `CONNECT_REJECTED_ALLOWLIST` | `connectivity.spec.ts` | pack JS legitimately vetoes a planned wiring |
| `ROUNDTRIP_LOST_ALLOWLIST` | `connectivity.spec.ts` | pack's own serialize/configure drops links it manages itself |
### Evidence rules for changing the harness itself
Two bug classes shipped past green tests once, so these are now policy:
- **Ground assertions in an oracle you did not write.** A semantic claim
about how ComfyUI behaves (what a wire accepts, what an event means, when
a widget exists) must cite a live probe, the backend/frontend source, or
a CI observation - never plausibility. If every layer agreeing with you
was authored from your own mental model (code, fixtures, measurement
script), their agreement is not evidence.
- **Parse live data against a shape census, not memory.** Node defs reach
the suite through `getNodeDefs`, which emits BOTH schema forms (combo as
an option-list literal AND as the string `COMBO` with `options`/`remote`
in the opts; `forceInput` on any form; autogrow `template` inputs;
`socketless`). Any parser of def shapes must handle every form the census
shows, its pure-spec fixtures must include each form (copied from real
census examples, not invented), and an unrecognized shape must be
excluded WITH a record - never silently matched or silently skipped.
- **Verify against the source the code consumes.** Measuring raw
`/object_info` proves nothing about code that reads the transformed
`getNodeDefs` object.
## Step 7 - push and watch CI
The `CI: Tests Custom Nodes` job (gating) re-does Steps 1-6 from scratch on
every PR: clones every manifest `repo` at its `pin`, pip-installs under CPU
torch constraints, boots the backend, runs the suite, and fails on any
install error, any test failure, or any skipped test. A new pack row is
automatically picked up; no workflow edit is needed unless you must stage an
extra asset (Step 4).
If CI goes red where local was green, reproduce under the Step 6b
environment before changing anything - the first such failure looked like
upstream drift but was actually pack frontend JS that never loads under
the dev server. Only after 6b reproduces it, decide: adjust the suite's
expectation honestly (the way widget-only instance slots became a recorded
exclusion) or, for genuine upstream drift after a pin bump, re-pin the
pack to its last good commit. Never paper
over it with a skip.
## Vue Nodes 2.0 compatibility policy
Some packs only work under the LiteGraph canvas renderer and fail to mount
under Vue Nodes 2.0. The suite must state that fact without producing false
failures and without skipping tests:
1. **Default**: every pack is assumed compatible. New rows omit
`vueNodesCompatible`.
2. **Evidence rule**: set `"vueNodesCompatible": false` ONLY after the T0
Vue pass fails for the pack locally while the LiteGraph pass is green,
and the failure reproduces on a retry. A README grumble, a hunch, or an
old forum thread is not evidence. Record the evidence (the failing
assertion and the pack version) in the PR description of the change that
sets the flag. When only SOME of a pack's nodes fail to mount, use the
per-node `vueIncompatibleNodes` ledger in the manifest row instead of
flagging the whole pack - compatibility is per-node, not per-pack (all
823 nodes across the first 7 packs mount clean, so both mechanisms ship
unused; the every-node mount tier is what earns an entry).
3. **Effect of `false`**: the load tier runs its LiteGraph pass only, and
the connectivity drag test does not drag that pack's edges under Vue
Nodes. The tests still run and pass their canvas assertions - nothing is
`test.skip`ped, so the CI skip gate stays honest. The run tier and the
connectivity contract sweep are renderer-independent (they never toggle
the Vue Nodes setting) and run for the pack regardless of the flag - a
flagged pack must still execute and wire cleanly there.
4. **Un-flagging**: if a pack ships Vue Nodes support later, delete the flag
and prove T0 green in both passes locally.
## Checklist
- [ ] Pack installs clean on the test backend (no `IMPORT FAILED`)
- [ ] Checked whether the pack ships frontend JS (Step 1 `/extensions` probe)
- [ ] `expectedNodes` copied exactly from `/object_info` (Step 2 traps checked)
- [ ] All expected nodes are model-free and present in the run workflow
- [ ] Workflow JSON under `browser_tests/assets/customNodes/`, no new binaries
- [ ] Any media staged into the backend's own `input/` dir locally (Step 4)
- [ ] Manifest row appended with every field (Step 5 table)
- [ ] `vueNodesCompatible` omitted, or set `false` with recorded evidence
- [ ] 6a green: `pnpm test:custom-nodes` against the dev server, zero skips
(except the T0 `expectedExtensions` assert and the dynamic-inputs
tier, red by design under the dev server - 6b proves those)
- [ ] 6b green when the pack ships frontend JS: built dist + backend-served run
- [ ] Every-node tiers green: no unexplained mount/save-reload/auto-run
failures; any new ledger entry carries its mechanism
- [ ] Pushed; `CI: Tests Custom Nodes` green on the PR

View File

@@ -0,0 +1,728 @@
# Custom-node regression suite architecture
The design of the custom-node regression suite: what it is made of, how the
pieces cooperate, the decisions behind them, and the gotchas that shaped
them. Companion docs: [README.md](README.md) (how to run it),
[ADDING_CUSTOM_NODES.md](ADDING_CUSTOM_NODES.md) (how to onboard a pack).
The document is organized as eight architecture views; the diagram map
under "Reading paths" shows what question each answers and how they nest.
Implementation symbols live in one place: the implementation map at the
end (section 14).
## What / Why / How, in one minute
**What it proves.** On every PR, for every node that the manifest's
community packs register on a real backend, the suite proves four concrete
things: the node mounts completely in both renderers (the canvas renderer,
LiteGraph, and the DOM renderer, Vue Nodes 2.0), it survives save/reload,
its slots wire type-correctly, and it executes when its inputs allow.
Section 1 states each proof precisely.
> **Scale snapshot (example, at the time of writing):** 7 packs, 823
> registered nodes, about 5,000 planned wiring checks, about 440 nodes
> executing clean per run. These are observations printed by the run, not
> properties of the design; they move whenever the manifest or a pin moves.
**What it does NOT prove.** Output semantics, frontend-only nodes, and
hour-scale soak behavior are out of scope; section 1 states the non-goals
precisely. Green means "every registered node still mounts, saves, wires,
and runs," and nothing wider: a compatibility and regression gate, not a
behavior certifier.
**Why it exists.** Regressions against real community packs used to be
invisible: the frontend could break widely installed packs and no test
would fail, because nothing exercised those packs at all. Claims about
which packs worked were anecdotes with no receipts. The suite turns "most
packs are broken" or "this one is fine" from an opinion into a per-node,
reproducible result attached to a PR.
**How it works, in one paragraph.** One manifest row per pack (source,
pinned version, tiers, a tiny curated workflow) drives everything; there is
no per-pack test code. The suite reads each pack's real node list live from
the backend, derives what every node should be able to do, and verifies it
in a real browser against a real backend with the pack's own frontend
scripts active. Every exception is a reviewed record that carries its
causal mechanism, every exception list is guarded against going stale
(section 10 grades the strength of each guard), and execution results are
reconciled in both directions against a known-failure baseline, so the
gate can neither hide a regression nor accumulate dead exemptions.
Nothing is ever skipped; a skip fails the job.
## Reading paths
- **Skeptical about what green actually covers?** Section 1 (what it proves
and the non-goals) and section 12 (the gotchas: every real incident, its
root cause, and the defense).
- **Deciding pack strategy** (which packs to keep, which renderers to
support): section 11 (design decisions and their trade-offs) and the Vue
Nodes compatibility policy in ADDING_CUSTOM_NODES.md. A pack is one
manifest row to add or remove.
- **Onboarding a pack:** ADDING_CUSTOM_NODES.md, not this doc. This doc is
the why; that doc is the step-by-step.
- **Debugging a red run:** the failure-class list in ADDING_CUSTOM_NODES.md
maps each red message to a cause; sections 7 and 10 show where in the pipeline it
happened; section 12 gives symptom-first triage.
How to read the diagrams: a rectangle is one step, named by its purpose; a
diamond is a short question, drawn only where the flow genuinely forks; a
check that cannot fork is a "Check:" step, not a diamond; a titled group
is a thing with internal structure; mechanism detail lives in the prose
under each diagram, not stacked inside boxes.
The eight views are zoom levels of one mental model, not eight parallel
pictures. Every arrow below names the element of the parent view that the
child expands. The map is ordered by zoom, not by page order: arrows say
what contains what, section numbers say where to read.
```mermaid
%%{init: {"flowchart": {"wrappingWidth": 240}}}%%
flowchart LR
L1["System context (section 2): who and what the suite touches"]
L2["Building blocks (section 4): what the suite is made of"]
L3["Definition pipeline (section 6): where every check's expectations come from"]
L4["Execution flow (section 7): how a foreign node gets run safely"]
L5["Persistence check (section 8): how save and reload are proven"]
L6["Event attribution (section 9): when an arriving event may be believed"]
L7["Evidence model (section 10): how exceptions stay honest"]
L8["CI deployment view (section 13): the order the test world is built in"]
L1 -->|"opens the suite boxes"| L2
L1 -->|"expands the CI arrow"| L8
L2 -->|"the definition parsers"| L3
L2 -->|"the Execution tier"| L4
L2 -->|"the Persistence tier"| L5
L2 -->|"the Evidence Ledgers box"| L7
L4 -->|"the collect-events step"| L6
```
The mount and wiring tiers have no diagram on purpose: each is a
single-shot comparison with nothing to sequence, so they live as prose and
tables in section 5.
## 1. What this suite proves, and deliberately does not
For every node that the manifest's packs register on the backend,
re-discovered live on every run:
- the node **mounts completely** in both renderers: the instance
materializes every input and output its definition declares, and under
the DOM renderer the page renders at least the instance's widget and
slot counts
- the node **survives save/reload**: no widget silently disappears and no
serialized value silently changes across a save/reload round-trip, and a
user-like non-default write sticks and survives a second reload, under
both renderers (dynamic widgets the application itself adds on reload are
expected and allowed, see section 8)
- the node's concrete slots **wire type-correctly** through the real
connection validator, and the wires survive save, reload, and prompt
serialization
- the node **executes on a real backend** when its inputs allow it, and its
output observably arrives at an observation sink
- the pack's **frontend extensions actually load**: every extension name the
manifest declares (`expectedExtensions`) is registered in the browser.
Backend nodes can register while the pack's JS silently fails to load
(wrong web dir, a loadExtensions regression), which would strip every
JS-driven behavior and quietly downgrade this suite to testing vanilla
nodes
- **dynamic input slots grow and shrink** for the curated autogrow nodes:
connecting the last input adds a slot (via both a real drag and a
programmatic connect, under both renderers, in the graph AND, in the Vue
renderer, as a rendered row), disconnecting removes the trailing empty. This behavior lives in
pack JS (`onConnectionsChange` overrides), invisible to `/object_info`, so
the def-driven tiers above cannot see it
Every tier also asserts the app shows **zero visible errors** while doing
this, except the execution tier, which deliberately provokes expected
failures (section 7).
Deliberately out of scope: output semantics (does a blur actually blur),
frontend-virtual nodes that never register on the backend, and hour-scale
soak behavior. A rare intermittent glitch that only surfaces after long
interactive use (a widget that occasionally shrinks on its own) is soak
behavior: this per-PR gate will not catch it, and does not claim to.
## 2. System context
Who and what the suite touches.
```mermaid
%%{init: {"flowchart": {"wrappingWidth": 220}}}%%
flowchart LR
CIP["CI platform: runs the gate on every PR"]
PACKS["Community node packs: external code, installed at pinned versions"]
DRIVER["Suite test driver: puts every pack node through its create, wire, save, and submit checks"]
FE["ComfyUI frontend: the system under test, running in a real browser"]
BE["ComfyUI backend: real graph execution engine"]
SYN["Suite verdict synthesis: turns observations into per-node verdicts + exceptions"]
TEAM["Engineering team: consumes verdicts and the evidence ledgers"]
CIP -->|"builds the environment, triggers"| DRIVER
DRIVER -->|"drives a real browser session"| FE
FE <-->|"definitions, prompts, execution events"| BE
FE -->|"observations: mounts, persistence, execution, errors"| SYN
SYN --> TEAM
PACKS -->|"frontend scripts load into"| FE
PACKS -->|"python side installs into"| BE
```
The two "Suite" boxes are the same system, split so the flow reads one way:
the driver puts the frontend through its paces, and verdict synthesis turns
what came back into the per-node verdicts and mechanism-carrying exceptions
the team consumes. Nothing flows backwards.
The load-bearing property: the suite tests the same stack a user runs. The
pack's own frontend scripts are active, the backend actually executes
graphs, and nothing is mocked.
## 3. The verification environment
The environment must have these properties, or the suite reports green
while testing the wrong thing:
| Requirement | Why |
| ------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| The backend serves the **built** frontend, and tests point at the backend | The dev server loads core extension scripts only, so pack frontend scripts never run under it. Packs that restyle nodes, rebuild widgets, or hook the submission path behave completely differently. Both early "green locally, red on CI" incidents were this. |
| Execution caching disabled | Per-node "it actually ran" signals are only emitted for non-cached executions; with caching on, a node can pass without running. |
| Isolated test users | Test state must not leak between runs or into a developer's real workspace. |
| One test worker | The backend's execution queue is a shared, exclusive resource. Two workers interrupt each other's work and misattribute events. |
## 4. Building blocks
What the suite is made of. The main flow is a straight pipeline; the shared
services that support the tiers are listed in the table below it.
```mermaid
%%{init: {"flowchart": {"wrappingWidth": 240}}}%%
flowchart LR
MAN["Pack Manifest: source, pin, tiers, known-failure baseline per pack"]
ORCH["Test Orchestrator: runs every row through the tiers, honoring the row's tier gates (section 5)"]
subgraph TIERS ["Verification tiers (section 5)"]
TM["Mount Completeness"]
TP["Persistence"]
TW["Wiring Compatibility"]
TX["Execution"]
TM ~~~ TW
TP ~~~ TX
end
EVID["Evidence Ledgers + Reconciler: every result collected, every exception carries its mechanism, lists cannot go stale"]
GATE["Gate verdict + evidence for the team"]
MAN -->|"drives"| ORCH
ORCH -->|"runs, per pack"| TIERS
TIERS -->|"all results and exceptions"| EVID
EVID -->|"green only if everything is accounted for"| GATE
```
The shared services behind the tiers:
| Service | Used by | Responsibility |
| --------------------- | ----------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| Definition Normalizer | Wiring (slot model); every all-nodes tier (pack attribution, node keys) | one canonical connectable-slot model out of the multiple definition dialects (section 6), feeding the pairing planner |
| Capability Classifier | Execution | decides, per node, what it can do without hand-written fixtures: run on its own defaults, run with synthesized inputs, or blocked, with the reason recorded (section 7) |
| Execution Harness | Execution | runs nodes for real and attributes every outcome to the right node despite an asynchronous, noisy event stream (sections 7 and 9) |
Two further tiers (curated workflows, core smoke) sit alongside these four
but are fixture-driven rather than derived from the node corpus; section 5
lists all six.
Dialect handling is deliberately not centralized. Mount and the Capability
Classifier read the raw definitions through their own purpose-built
parsers (`declaredShape`, `classifyInput`), because each needs a different
slice of a definition (declared parts vs. runnability); the normalizer's
slot model feeds the wiring planner alone, though the all-nodes tiers
also call it for pack attribution and node-key derivation. What keeps the
three parsers from drifting is shared evidence, not shared code: each is
pinned by fixtures copied from a live census of both definition dialects
(section 6).
- **Pack Manifest**: the single extension point. Adding a pack is one row;
no tier knows pack names.
- **Evidence Ledgers**: the honesty mechanism. An exception without a
recorded mechanism is not allowed to exist (section 10).
## 5. The verification tiers
| Tier | Verifies | Renderers | Notes |
| -------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------- | --------------------------------------------------------------------------------------- |
| Mount Completeness | every declared input and output actually materializes on the created node; the DOM renderer additionally shows at least the instance's widget/slot counts | both; a pack declared Vue-incompatible runs canvas only | missing parts fail; extras are tolerated |
| Persistence | save/reload loses nothing and changes nothing; user-like writes stick and survive reload | both; a pack declared Vue-incompatible runs canvas only | application-added dynamic widgets are legal; see section 8 |
| Wiring Compatibility | one representative typed wire per slot connects through the real validator and survives save, reload, and prompt serialization | breadth sweep: one, by decision 7; curated drags: both | dropdown slots pair only on identical option sets; see section 10 for exception routing |
| Execution | the node runs on a real backend and its output arrives at an observation sink | one, by decision 7 | the full flow is section 7 |
| Curated workflows | a small hand-authored graph per pack executes end to end; its named must-exist nodes are asserted present (a missing one fails the tier, catching a pack that renamed or dropped a node) | both (render pass) | plus a forced-error self-check proving the harness detects real failures |
| Core smoke | the core app loads a workflow cleanly with packs installed | both | guards against packs breaking the base app |
One vocabulary bridge, because the manifest predates these tier names: the
manifest row's `tiers` field takes `load`, `run`, `connectivity`, and
`io`. Today `run` gates the curated workflow execution, `connectivity`
gates the wiring tier, and everything else ignores the field: mount,
persistence, execution, and the curated render pass run for every row
unconditionally, and core smoke is pack-independent. `load` and `io` are
accepted by the schema but currently gate nothing.
## 6. The node-definition pipeline
Where the suite's knowledge of every node comes from: definitions flow left
to right, and three independent parsers derive three plans from one live
census.
```mermaid
%%{init: {"flowchart": {"wrappingWidth": 380}}}%%
flowchart LR
PUB["Backend publishes node definitions"] --> CORPUS["Live definition census: every node the packs register, re-discovered each run, in two dialects"]
CORPUS -->|"wiring slot normalizer"| W["Wiring plan: which slots can pair, and why"]
CORPUS -->|"execution classifier"| X["Execution plan: which nodes can run, and why the rest cannot"]
CORPUS -->|"mount declared-shape parser"| M["Mount expectations: what each created node must materialize"]
```
The three plans are independent consumers of the same census, each through
its own dialect-aware parser (section 4 names the symbols): the wiring
plan feeds the Wiring Compatibility tier, the execution plan feeds the
Execution tier, and the mount expectations feed Mount Completeness.
Design rule that came from a real bug: every consumer must handle **both
definition dialects** (legacy list-form and V2 object-form), and anything
with an unknown shape is excluded with a record, never silently matched or
skipped. The dialects differ in where dropdown options live, how "must be
wired" is flagged, and how growable input groups are declared; details and
evidence rules are in ADDING_CUSTOM_NODES.md.
## 7. The execution flow
How the suite runs hundreds of foreign nodes safely, with no fixtures, and
still attributes every failure to the right node.
```mermaid
%%{init: {"flowchart": {"wrappingWidth": 700}}}%%
flowchart TD
CLASS["Classify each node: what can it do with no hand-written fixtures?"]
CLASS --> RUND["runnable on its own defaults"]
CLASS --> RUNS["runnable with synthesized inputs"]
CLASS --> BLOCK["blocked: the reason is recorded"]
RUND --> BATCH["Group runnable nodes into small batches: a failure stays isolated, and one submission carries many nodes instead of paying the round-trip per node"]
RUNS --> BATCH
BLOCK --> REC
BLOCK ~~~ BATCH
BATCH --> TG
subgraph TG ["Build the batch's disposable test graph: one isolated chain per node"]
PROD["synthetic producers for each required input"] --> NUT["the node under test"]
NUT --> SINK["an observation sink on its output"]
end
TG --> SUBQ["Submit the assembled batch graph for real execution"]
SUBQ --> GUARD{"submission outcome?"}
GUARD -->|"crashed inside a pack's own script"| ERR
GUARD -->|"accepted"| OBSERVE["Collect the execution events as the graph runs, keeping only events that belong to this submission and name a node in this test graph (section 9)"]
OBSERVE --> V{"outcome?"}
V -->|"ran, output observed at the sink"| CLEAN["clean"]
V -->|"ran, nothing arrived at the sink"| NOOUT["failure: data never flowed"]
V -->|"error attributed to this graph"| ERR["failure: named node, named cause"]
V -->|"no response in time"| TRIP["tripwire: interrupt the engine, then watch whether the queue drains"]
TRIP --> INT{"recovers?"}
INT -->|"yes"| ERR
INT -->|"no"| HUNG["engine wedged: stop the tier and name the batch as suspects; queued nodes are victims, not findings"]
ERR --> BIS["re-run each batch member alone, so the offender names itself"]
NOOUT --> BIS
CLEAN --> REC
BIS --> REC["Reconcile with the known-failure baseline, in BOTH directions: an unlisted failure fails the gate; a listed entry that now passes, or can no longer run at all, also fails it. Exclusion ledgers are stale-guarded separately"]
```
Synthesized inputs are produced by a small set of self-sufficient producer
nodes (an empty image, an empty latent, a solid mask, primitive values), so
"runnable with synthesized inputs" needs no per-node authoring. The
observation sink is what upgrades "it finished" to "its output actually
arrived somewhere."
The submission guard is why a crash inside a pack's own script can never
abort the tier: the throw is caught in the page, recorded as that node's
failure with the client error text, and the run moves on.
## 8. The persistence check
Why it is staged: the DOM renderer's widget components react to creation
and reload on their own schedule, and a check that snapshots synchronously
would compare state those reactions never touched. The whole pass runs once
per renderer.
```mermaid
%%{init: {"flowchart": {"wrappingWidth": 240}}}%%
flowchart LR
P1["Stand up: create every node of the pack, let the UI settle"]
P2["Round-trip: snapshot, reload from the snapshot, snapshot again"]
P3["Check: nothing lost, nothing changed; additions the application itself makes are legal"]
P4["Probe: write a user-like non-default value into every plain widget, verify every write sticks"]
P5["Round-trip again: snapshot, reload from the snapshot, snapshot again"]
P6["Check: written values survive wherever the node's shape stayed stable (a changed dropdown can legally rebuild a dynamic node's widgets)"]
P1 --> P2 --> P3 --> P4 --> P5 --> P6
```
Between phases the rig yields to the UI so renderer effects flush before
the next snapshot; those settle points are what makes the staging real.
Widgets whose values the pack's own script owns (canonicalized references,
embedded editors) are exempt from probe writes, each with a recorded
mechanism: writing probe markers into them only makes the pack's script
choke on the probe.
## 9. Event attribution
Real execution reports back over an asynchronous event stream, and the
stream can mislead in two specific ways. Both produced real misattributed
failures before the filters existed. The primary defense is positive: when
the harness submits a graph, it captures the id the backend assigns to
that submission from the submission response itself, so an event's
ownership is checked against a known id, never inferred from history.
Every arriving event passes the same two questions before it may count as
evidence:
```mermaid
%%{init: {"flowchart": {"wrappingWidth": 280}}}%%
flowchart TD
EV["an event arrives on the execution stream, while this attempt runs"]
EV --> Q1{"from THIS attempt?"}
Q1 -->|"no: it does not carry the id this submission was assigned"| DROP["dropped: a stray cannot blame any node in this run"]
Q1 -->|"yes"| Q2{"names a node in THIS test graph?"}
Q2 -->|"no: it names another graph's nodes"| DROP
Q2 -->|"yes"| KEEP["kept: evidence for exactly that node"]
```
Both no-answers are checkable, not hopeful. The first is a comparison
against the captured submission id: an event either carries it or it does
not. If that capture ever misses, the harness says so on the console and
falls back to identity bookkeeping, recording every attempt identity it
has ever seen so a late event from an observed attempt still identifies
itself. The second question defeats the one stray the first cannot: a
retried duplicate arriving under a never-seen identity. Node identities
are never reused within a session, so such an event can only name an
earlier graph's nodes. Membership is decisive.
## 10. The evidence model
The suite's honesty mechanism. Every exception is a reviewed record that
names its causal mechanism, and every list is guarded: an entry naming a
node the pack no longer registers fails the suite. Full per-record
semantics live in the ledger table in
[ADDING_CUSTOM_NODES.md](ADDING_CUSTOM_NODES.md).
```mermaid
%%{init: {"flowchart": {"wrappingWidth": 300}}}%%
flowchart TD
F["a node fails a tier"] --> Q1{"is EXECUTING it unsafe or environment-dependent?"}
Q1 -- yes --> L1["execution exclusion: never run; mechanism on record; every other tier still applies"]
Q1 -- no --> Q2{"does it fail deterministically on synthesized inputs?"}
Q2 -- yes --> L2["known-failure baseline: still runs every time; reconciled in both directions"]
Q2 -- no --> Q3{"does the pack's own script own the failing surface?"}
Q3 -- yes --> L3["scoped exception record naming the mechanism"]
Q3 -- no --> L4["no exception applies: it is a finding. Fix it or file it"]
```
What the first question means in practice: runtime downloads or installs,
infinite loops, host-specific results, mutable-content dropdowns,
unreliable completion signals. What a pack script owning the failing
surface looks like: rewritten values, custom widgets, vetoed wires,
console noise.
The two-way baseline is what stops the whole evidence model from rotting: a
failure that is not listed fails the gate, and a listed node that starts
passing ALSO fails the gate until its stale entry is removed. Exemptions
cannot silently accumulate.
Not every ledger can earn that two-way strength; the guards come in three
grades. Ledgers whose nodes still execute (the known-failure baseline) are
two-way behavioral: a new failure and a stale entry both flip the gate.
Ledgers that stop a path from running at all (execution exclusions,
probe-write exemptions) are registration guarded: the suite proves the
named node still exists, but the excluded path never runs, so an entry
that stopped being necessary cannot be observed; staleness there is
caught by review, not observation. Weakest are the pattern allowlists
(the console-error ledger): an entry that no longer matches anything
simply filters nothing, and usage tracking cannot be naively bolted on,
because some patterns are environment conditional (a missing-model 404
fires only on hosts without the model), so an entry can be legitimately
idle in one environment and load-bearing in the next.
The console-error ledger also has a bounded window, not just bounded
strength. Collection starts inside each tier, so it covers that tier's
own actions (load, run, wire, save); console noise a pack logs at app
boot, before the first tier action, is outside it - the shared app
fixture navigates once at setup, so boot output predates any per-pack
collector. This is deliberate: boot breakage that reaches a visible
surface is still caught by the startup zero-visible-errors check, and
invisible boot console noise is exactly what the ledger exists to
tolerate rather than gate on.
## 11. Design decisions
The decisions that define the suite, with their trade-offs. Each is
deliberate, and each is cheap to reverse or narrow later. The suite's one
deliberate extension seam is the curated-workflow fixture: anything the
manifest cannot derive from the live node corpus (pack-specific semantics,
multi-node behavior) is expressed there (decisions 6 and 11).
| # | Decision | Why | Trade-off accepted |
| --- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------- |
| 0 | Drive a real browser, not just the backend API | Pack frontend scripts (widget rebuilds, restyles, submission hooks) are half of what breaks; only a browser running the built frontend exercises them | Browser e2e is the slowest, most race-prone tier; mitigated by the attribution filters (section 9) and the staged settle points (section 8) |
| 1 | Real environment only: real browser, real backend, pack scripts active, nothing mocked | The failures worth catching live in the integration, not in units | Slower than unit tests; needs a backend in CI |
| 2 | The backend serves the built frontend | The dev server never loads pack scripts, so it tests a different product | Local iteration needs a build + restart for pack-script changes |
| 3 | One test worker | The execution queue is exclusive; parallel workers corrupt each other's evidence | Wall-clock time grows with the manifest |
| 4 | Execution caching disabled | The per-node "actually ran" signal only exists for uncached executions | Every run pays full execution cost |
| 5 | Packs installed at pinned, verified versions | An upstream push must not change what the gate tests mid-flight | Pins need deliberate bumps; a nightly canary against pack HEADs is the planned complement |
| 6 | One manifest row per pack, zero per-pack test code | Extension cost stays constant as coverage grows | The generic tiers cannot assert pack-specific semantics; curated workflows exist for that |
| 7 | Both renderers only where the renderer can change the outcome: mount, persistence, the curated render pass, the curated pointer drags, core smoke; one renderer elsewhere (breadth wiring sweep, execution) | Widget values flow through the same store under both renderers (verified by probe), so doubling execution buys no new failure surface | If that store unification ever changes, revisit this decision |
| 8 | Every exception carries its mechanism and is stale-guarded | An unexplained exemption is indistinguishable from a hidden bug | Onboarding a flaky pack takes more effort than a blanket skip |
| 9 | Known-failure baseline reconciled in both directions | One-way baselines rot into permanent blind spots | A node that gets fixed upstream turns the gate red until its entry is removed (by design) |
| 10 | Small batches with single-node bisection | Batching amortizes queue latency; bisection restores per-node attribution on failure | A failing batch costs one extra pass over its members |
| 11 | Scope excludes output semantics and frontend-virtual nodes | Both need per-node knowledge a manifest cannot derive; curated workflows and future behavior tests are the extension point | "Green" is narrower than "the pack fully works," and says so |
## 12. Gotchas: every incident, its root cause, and the defense
These failure modes shaped the suite. Each was real: something passed that
should have failed, or failed for a reason that had nothing to do with the
node under test. Named nodes below are worked examples of their class,
kept because specifics are what make a mechanism checkable. Do not remove
a defense without re-reading its incident. The two recurring team concerns
these answer: "green but broken" and "tests can never catch random bugs."
### G1. Dev-server pack-script blindspot
- **You hit it when**: a node behaves perfectly in local dev but breaks on
CI, or vice versa, on any pack that restyles nodes, rebuilds widgets, or
hooks the submission path.
- **Root cause**: the dev server loads core extension scripts only; pack
frontend scripts never run under it. The node tested there is a
different node than the one users get.
- **Defense**: the environment contract (section 3): the backend serves the
built frontend and tests point at the backend. CI does exactly this (section 13).
- **Answers**: green but broken.
### G2. Widget-state bleed through recycled node identities
- **You hit it when**: a node fails validation with a value it was never
given, specifically a dropdown carrying an option that belongs to some
OTHER node created earlier in the same session.
- **Root cause**: the frontend keeps widget state keyed by node identity,
and that state survives clearing the graph. A new node that reuses a
cleared node's identity inherits its same-named widget values. Core
frontend bug, distinct from this suite; the defense below stands
regardless of when it is fixed.
- **Defense**: the suite never reuses a node identity within a browser
session: every builder hands out monotonically increasing identities
across graph clears.
- **Answers**: green but broken (a neighbor's leftover value produces a
false failure and hides the real store bug).
### G3. Event misattribution races
- **You hit it when**: node A is reported failing, but the error belongs to
node B tested just before it, or to a duplicate submission of an earlier
graph.
- **Root cause**: two races over the asynchronous event stream: late
arrivals from a previous attempt, and duplicate attempts created by a
submission retry erroring under a fresh identity.
- **Defense**: the positive submission-id match plus the graph-membership
filter of section 9, made decisive by G2's never-reuse-identities rule.
- **Answers**: tests can never catch random bugs (a misattributed error is
noise that erodes trust in every verdict).
### G4. Pack scripts crashing the submission path
- **You hit it when**: an entire pack's execution tier aborts, not just one
node.
- **Root cause**: pack scripts can hook workflow submission and throw on a
graph shape they do not expect. Observed example: a video pack's
"apply to graph" hook copies its latest file into downstream widget
inputs and throws when its output feeds a plain socket while matching
files exist; the trigger is content-dependent.
- **Defense**: submission runs guarded; a throw records as that node's
failure, carrying the exception text, so the node names itself instead
of aborting the tier. The proven case is also excluded with its
mechanism in the exclusion ledger, and remains an upstream-report
candidate.
- **Answers**: tests can never catch random bugs (uncaught, one crash masks
every node queued behind it).
### G5. Two definition dialects
- **You hit it when**: a set of nodes silently never executes: they are
classified as needing wires they do not need, so the planner skips them
and nothing goes red.
- **Root cause**: node definitions reach the suite in two dialects (legacy
list-form and V2 object-form), and a parser written against one dialect
misreads the other. Measured example: 8 nodes of one pack were invisibly
unexecuted until the classifier learned the second dialect.
- **Defense**: each consumer's parser handles both dialects
(`declaredShape` for mount, `classifyInput` for execution, the
normalizer for wiring; section 4); parser fixtures are copied from a
live census of the real corpus so tests cannot self-confirm a parser's
assumptions; unknown shapes are excluded with a record, never silently
matched (section 6).
- **Answers**: green but broken (a whole class of nodes was uncovered while
the tier stayed green).
### G6. "Must be wired" beats every dialect
- **You hit it when**: an input the pack marked as wire-only is treated as
a widget, so the node runs without the wire it requires.
- **Root cause**: the wire-only flag can appear on any input form; a
classifier that checks the form before the flag misreads it.
- **Defense**: the classifier checks the wire-only flag first, before any
form-specific branch; fixtures pin the ordering.
- **Answers**: green but broken.
### G7. Dropdown pairing semantics
- **You hit it when**: the wiring tier pairs two unrelated dropdowns (a
checkpoint list into a scheduler list), a pass that proves nothing, or
refuses to pair two dropdowns that differ only in menu order.
- **Root cause**: a wired dropdown input bypasses its own menu, so the wire
contract is set membership of options, not their order. And dropdowns
whose options are not statically known cannot prove anything by pairing.
- **Defense**: dropdowns pair only on identical option SETS
(order-insensitive); dropdowns with unknown option lists are excluded
from pairing with a record instead of blind-matched.
- **Answers**: green but broken.
### G8. Environment flips
- **You hit it when**: a node fails on one OS but is clean on another, run
to run, with no code change. A subtle variant is the warm-cache
illusion: a node that downloads model weights inside execution runs
clean only where the cache is already warm.
- **Root cause**: execution depends on the host, not on the node's
frontend contract: numeric-stack differences, codec differences, cached
downloads, directory-handling differences.
- **Defense**: the environment-variable class of execution exclusions,
each entry naming its per-host mechanism, reconciled against observation
runs on both hosts. The node keeps every non-execution tier.
- **Answers**: tests can never catch random bugs (host-dependent flips are
flake that trains people to ignore red).
### G9. Queue jams from non-interruptible execution
- **You hit it when**: the execution tier hangs and every node queued
BEHIND one offender reports failure.
- **Root cause**: some execution paths never respond to interrupt:
installing packages at runtime, pure-Python infinite loops (observed
example: a text-replace node spinning forever on an empty search
string), minutes-long per-pixel loops, non-interruptible weight
downloads.
- **Defense**: a timeout interrupts and checks that the queue recovers; a
queue that will not drain stops the tier immediately and names the batch
as suspects. Triage is explicitly offender-versus-victims, and a
preflight asserts the queue is idle before the tier starts. Proven
offenders are excluded with their mechanism.
- **Answers**: tests can never catch random bugs (a jam failing a whole
batch is pure noise; the tripwire converts it into one named offender).
### G10. Renderer effect timing
- **You hit it when**: the persistence tier passes under the canvas
renderer but silently tests nothing under the DOM renderer.
- **Root cause**: DOM-renderer widget components react to creation and
reload asynchronously, writing back into the value store on frame
boundaries; a synchronous snapshot compares state those reactions never
touched.
- **Defense**: the persistence check is staged with explicit settle points
between build, snapshot, reload, and write phases (section 8), and runs once
per renderer.
- **Answers**: green but broken (a synchronous pass certifies a value path
it never observed).
### G11. Growable input groups materialize under expanded names
- **You hit it when**: mount completeness reports a declared input missing
on a node that uses growable input groups, when the renderer actually
materialized it under expanded per-slot names.
- **Root cause**: growable input groups do not materialize under their
declared group name; they expand into per-slot names derived from it.
- **Defense**: mount expectations accept either the group name or its
required expansion; this was the only definition-shape special case
found across the full corpus.
- **Answers**: keeps mount fidelity strict without false-failing
group-typed nodes.
### G12. Legal dynamic growth on reload
- **You hit it when**: a node legitimately gains a widget on reload (the
application attaches a seed-control widget; a pack appends a
value-driven widget) and a naive equality check flags it as a
regression.
- **Root cause**: reload is allowed to APPEND; what must never happen is
the inverse: a widget disappearing or a saved value changing.
- **Defense**: the persistence comparison is asymmetric by design: growth
passes, loss or mutation fails; after probe writes, values are compared
only where the node's shape stayed stable, because a changed dropdown
can legally rebuild a dynamic node.
- **Answers**: green but broken, from the other side: a check that
rejected legal growth would get relaxed into uselessness.
### G13. Mutable-content dropdowns
- **You hit it when**: a file-list node flips between clean and failing
across runs, tracking whatever content the backend happens to hold.
- **Root cause**: some dropdowns populate from mutable backend content
(file listings, run history), so their default value and validity change
as content changes.
- **Defense**: the state-dependent class of execution exclusions, with the
mechanism on record; where the same dropdown also re-resolves on reload,
a scoped persistence exception skips the value comparison while the
no-shrink rule still applies. All other tiers are retained.
- **Answers**: tests can never catch random bugs.
### G14. Unreliable completion signals
- **You hit it when**: a node reports clean on one run and incomplete on
the next with no change to anything.
- **Root cause**: the per-node "actually ran" signal is reliable for
ordinary nodes with caching disabled, but list-expanded and
remote-control nodes do not emit it on every run.
- **Defense**: only nodes with a PROVEN signal flip are excluded from
execution, each recorded with the shared mechanism, so an incomplete
result stays meaningful everywhere else.
- **Answers**: tests can never catch random bugs.
## 13. The CI deployment view
In today's implementation, the suite is Playwright driving bundled
Chromium, and the CI platform is GitHub Actions.
```mermaid
%%{init: {"flowchart": {"wrappingWidth": 260}}}%%
flowchart LR
CH["change gate: skip only when nothing relevant changed, without wedging the required check"] --> BUILD["build the frontend"]
BUILD --> ENV["provision a CPU backend"]
ENV --> INST["clone every manifest pack at its pinned version; install with dependency constraints so packs cannot swap the numeric stack"]
INST --> ASSET["stage the curated workflows' media"]
ASSET --> RUN["boot the backend serving the built frontend; run the suite, one worker"]
RUN --> SKIP{"anything skipped?"}
SKIP -- yes --> RED["fail: a pack or a fixture failed to load"]
SKIP -- no --> ART["publish the report artifact"]
```
Fork PRs skip the job (the install loop is a code-execution surface) and
keep coverage via the main test shards. Sharding is deliberately deferred:
every shard would pay the full environment setup, which is a large share of
the job; the workflow states the threshold at which sharding starts paying.
Ballpark at the time of writing, moving like the scale snapshot: about
eight minutes of suite on top of about four and a half minutes of
environment setup, with sharding starting to pay once the whole job
passes roughly twelve minutes.
## 14. Implementation map
The one place where architecture names meet code symbols.
| Building block | File | Key symbols |
| ------------------------------------- | -------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| Pack Manifest | `browser_tests/fixtures/data/customNodeManifest.json` | one row per pack: `pack`, `repo`, `pin`, `tiers`, `workflow`, `expectedNodes`, `expectedExtensions`, `requiresGpu`, `requiresModels`, `timeoutMs`, plus optional `vueNodesCompatible`, `vueIncompatibleNodes`, `cannotRunAlone` |
| Manifest loader | `browser_tests/fixtures/customNode/manifest.ts` | `loadManifest`, `rendererPassesFor` |
| Test Orchestrator | each spec file | the `for (const entry of loadManifest())` loop heading allNodes.spec.ts, connectivity.spec.ts, customNode.regression.spec.ts |
| Evidence Ledgers + Reconciler | `browser_tests/tests/customNodes/allNodes.spec.ts`, `connectivity.spec.ts` | the `*_ALLOWLIST` maps, `AUTO_RUN_EXCLUDE`, the `cannotRunAlone` two-way reconciliation, stale-entry guards |
| Definition Normalizer | `browser_tests/fixtures/customNode/typePairing.ts` | `normalizeNodeDefs`, `packOf` |
| Wiring planner | `browser_tests/fixtures/customNode/typePairing.ts` | `planPairs`, `isTypeCompatible`, `vocabOf` |
| Capability Classifier | `browser_tests/fixtures/customNode/autoRun.ts` | `classifyAutoRunnable`, `classifyInput`, `planAutoRuns`, `batchAutoRunnable`, `SYNTH_PRODUCERS` |
| Execution Harness | `browser_tests/fixtures/customNode/ComfyTarget.ts` | `LocalDesktopTarget.runWorkflow`: event tap, attempt + graph-membership filters, guarded submission |
| Outcome classification | `browser_tests/fixtures/customNode/runResult.ts` | `classifyRun`, `CustomNodeOutcome` |
| Mount / Persistence / Execution tiers | `browser_tests/tests/customNodes/allNodes.spec.ts` | `addChunk`, `declaredShape`, the staged rig on `window.__cnRt`, `runBatch`, monotonic identities via `window.__cnIdBase`, five in-spec exception ledgers |
| Wiring tier | `browser_tests/tests/customNodes/connectivity.spec.ts` | breadth sweep, executor self-check, curated drags, two allowlists |
| Curated workflows + self-check | `browser_tests/tests/customNodes/customNode.regression.spec.ts` | T0/T1 per pack, forced-error positive control |
| Core smoke | `browser_tests/tests/customNodes/coreSmoke.spec.ts` | |
| Dynamic-input (autogrow) tier | `browser_tests/tests/customNodes/dynamicInputs.spec.ts` | `AUTOGROW_CASES` (curated cases), `consumerShape` (graph + DOM census), per-path connect/disconnect loop |
| Parser/classifier fixtures | `browser_tests/tests/customNodes/*.pure.spec.ts` | census-derived cases for both definition dialects |
| CI job | `.github/workflows/ci-tests-custom-nodes.yaml` | gating check `custom-nodes-e2e` |

View File

@@ -0,0 +1,214 @@
# Detection Proof
How we prove the custom-node regression suite actually catches every failure
mode it claims to in [ARCHITECTURE.md](ARCHITECTURE.md). The proof is a
separate, deliberately-red pull request branched off the suite branch: each
commit breaks one surface on purpose, cites the real regression class it
recreates, and turns the custom-nodes CI check red at exactly the named tier
with the named message. (A frontend break may also trip other layers, e.g.
unit tests - that is layered coverage, not noise.) A green custom-nodes check
anywhere in that PR would mean the gate failed to catch a regression.
This replaces the earlier ad-hoc "kill-test" name. The verb is **falsify**: we
falsify each guard by breaking the thing it watches and confirming it fires.
## Why this exists
The suite's value claim is that a frontend PR can no longer silently break a
widely-installed custom-node pack. That claim is only worth as much as its
ability to go red on a real break. A green suite proves nothing on its own -
it could be green because everything works, or green because it checks nothing.
The Detection Proof PR removes that doubt: it shows, break by break, that every
tier in ARCHITECTURE.md turns red on the exact class of regression it was built
to catch, and names the offender in the failure message.
## How to read the proof PR
- **It must never merge.** Every commit is a deliberate break. A reviewer reads
it, they do not ship it.
- **One commit per surface.** Each commit is a single-file change plus a comment
naming the historical regression it recreates and the red it should produce.
Check out a commit, watch the named CI check go red, read the message, move on.
- **CI is the source of truth, not a local full run.** The CI job runs the
suite against one fresh backend on an unloaded runner, which keeps every
execution inside its budget. A local run of the whole
suite against a single CPU backend is not reliable for this (see
[Honest caveat](#honest-caveat-local-full-runs-and-machine-load)); run CI, or
run one pack locally at a time.
## Two protection modes
The gate protects against two distinct things, and the proof covers both:
- **FE-regression** - a change to _this frontend_ breaks installed packs. This
is the primary thing the gate guards on every frontend PR. These breaks live
in `src/`.
- **Pack-bug** - a pack itself ships a bug (or a pinned pack is bumped to a
broken version). The gate catches these too. CI clones every pack fresh at
its pin, so editing pack files in the frontend repo does nothing - the clone
overwrites them. Two ways deliver a pack break on CI: (a) point the manifest
(`browser_tests/fixtures/data/customNodeManifest.json`) `repo`/`pin` at a
broken fork, which is exactly the pinned-bump scenario and the most
production-faithful; or (b) a self-contained CI step that patches each cloned
pack in place right after install. The proof PR uses (b) - no external repos,
and each patch asserts it landed (`grep`, fails the job otherwise) so a silent
no-op cannot fake a pass. Both reproduce the same edits captured against a
local backend (which is how the exact reds below were captured).
Each row below is labelled with its mode.
## The correlation matrix
Every "Exact red" below is the real message captured when the break was applied
and the tier was run against a real backend - not a prediction. One scope note:
for the corpus-derived tiers (rows 4, 6, 9) the named offender and pair list
are re-derived from `/object_info` each run, so a pin bump can legitimately
change WHICH pair or node the message names without weakening the catch - the
promise is the tier and the failure class, not byte-identical offender text
across pin changes. Sections refer to [ARCHITECTURE.md](ARCHITECTURE.md).
| # | Surface (ARCH section) | Mode | Real regression it recreates | The one-file break | CI check that catches it | Exact red |
| --- | ------------------------------------------------ | ---- | ------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------ | ------------------------------------------ | --------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| 1 | Mount completeness, canvas / v1 (s1, s5) | FE | A change dropping declared parts on the canvas renderer (class; no single ticket - the v2 wave below shows how this family presents) | `src/services/litegraphService.ts` `addInputs`: stop materializing the last declared input (Impact-scoped in the stacked PR, step 7) | Tests Custom Nodes / mount tier | `ImpactBoolean: instance is missing declared input "value" (litegraph)` |
| 2 | Mount completeness, DOM / v2 (s1, s5) | FE | Widgets missing under Nodes 2.0 (FE-627/FE-634 iTools buttons; FE-841 is the adjacent wrong-style class, present but unproven caught) | `src/renderer/extensions/vueNodes/composables/useProcessedWidgets.ts`: skip numeric widgets in the Vue processing pipeline (see the registry self-heal note below) | Tests Custom Nodes / mount tier (Vue pass) | `Image Inset Crop (rgthree): Vue mounts 1 of 5 widgets` |
| 3 | Persistence, save/reload (s1, s8) | FE | Widgets reverting to socket-only on reload: the defaultInput migration regression that PR #12279 (open) exists to fix | `src/lib/litegraph/src/LGraphNode.ts` `configure`: off-by-one drops the last `widgets_values` entry | Tests Custom Nodes / persistence tier | `Image Inset Crop (rgthree): widgets_values ["Percentage",8,8,8,8] -> ["Percentage",8,8,8,0] on set-values reload` |
| 4 | Wiring - type compatibility (s5, s6) | FE | A frontend change narrowing connectable types (class; no single verified ticket) | `src/lib/litegraph/src/LiteGraphGlobal.ts` `isValidConnection`: reject IMAGE links | Tests Custom Nodes / connectivity sweep | `AddLabel.IMAGE -> FastPreviewBatch.input: CONNECT_REJECTED` (full pair list) |
| 5 | Wiring - drop resolution (s5) | FE | Drag/slot resolution family (nearest reported symptoms: FE-625/FE-632 EditUtils connections shift after drag) | `src/lib/litegraph/src/canvas/measureSlots.ts` `getNodeInputOnPos`: return undefined | Tests Custom Nodes / connectivity drag | `EmptyImage.IMAGE -> ImageBatch.image2 with VueNodes=false` |
| 6 | Execution - frontend prompt serialization (s7) | FE | A prompt-serialization change corrupting inputs (class; no single verified ticket) | `src/utils/executionUtil.ts`: drop numeric widget values from the API prompt (Impact-scoped in the stacked PR, step 7) | Tests Custom Nodes / curated run (T1) | `Prompt outputs failed validation; ImpactInt: value; ImpactFloat: value` (in the stacked PR, row 10's rename makes `ImpactInt` read `ImpactIntDETECTIONPROOF: value`) |
| 7 | Zero-visible-errors / load hook (s1) | FE | An extension hook crashing on graph load, the mechanism packs hook (FE-751 class; the break is in a core extension, hence FE mode) | `src/composables/node/useNodeBadge.ts` `afterConfigureGraph`: throw | Tests Custom Nodes / curated run (T1) | `Error calling extension 'Comfy.NodeBadge' method 'afterConfigureGraph' ...` |
| 8 | Console / pageerror ledger (s10) | Pack | An uncaught pack-JS error during save/reload (the betterCombos.js `typeof null` bug this suite found) | CI step patches the cloned ComfyUI-Custom-Scripts `showText.js` to log a `console.error` in `onExecuted` (captured locally by editing the installed pack directly) | Tests Custom Nodes / curated run (T1) | `console errors during curated run` + the exact text + script URL |
| 9 | Execution - runtime (s7) | Pack | A pack node raising at execution (WAS Text Find/Replace infinite loop; KJ ImageGridtoBatch min violation) | CI step patches the cloned was-node-suite `return_constant_number` to raise on entry (captured locally by editing the installed pack directly) | Tests Custom Nodes / auto-run tier | `Constant Number: EXECUTION_ERROR (Constant Number: ValueError) - not in cannotRunAlone; a regression, ...` |
| 10 | Registration / expectedNodes sentinels (s5, s10) | Pack | A pinned pack bump renaming a node key | CI step patches the cloned ComfyUI-Impact-Pack `__init__.py` to rename the `ImpactInt` mapping key (captured locally by editing the installed pack directly) | Tests Custom Nodes / zero-skip gate | job goes red on `skipped != 0` (T0 + T1 skip; the workflow's "Forbid skipped tests" step fails) |
### Links of various types (surface 4/5 expanded)
"Links of various types" is covered breadth-first: the connectivity tier
plans one representative typed edge per slot across the whole installed corpus,
so a single break in the validator (#4) fails a broad, named list of concrete
pairs - not one hand-picked wire. The drag break (#5) additionally proves the
_pointer_ path resolves the exact slot. To show breadth explicitly, the proof PR
can add two more validator mutations, each turning a different link class red:
- Break the COMBO option-vocabulary compare (`vocabOf`) - the committed pure
specs (typePairing.pure.spec.ts, same-vocabulary pairing tests) go red;
dropdown slots are checked, not just primitive types.
- Break the wildcard exclusion (`isWildcard`) - the committed pure specs
("wildcard slots are excluded" test) go red; the exclusion is pinned as a
design decision, not an accident. Both catches are at the pure-spec layer;
whether the live corpus also exercises them per run is not asserted here.
### Execution of various types (surface 6/7/9 expanded)
Three distinct execution break-points, each caught by a different tier:
- **Frontend serialization** (#6) - the value never leaves the browser correctly;
caught at submit as a named `VALIDATION_FAIL`.
- **Load-time hook** (#7) - an extension hook crashes the graph load (the same
hook mechanism pack scripts use); caught by the console/pageerror ledger.
- **Backend runtime** (#9) - the node runs and raises; caught by the auto-run
tier's two-way baseline, which isolates each node (single-node re-run) so
the failing node names itself; a chain that fails because its synthesized
producer raised still carries that producer's name in the backend's error
event.
## What is already proven (the falsification pass)
Before writing this plan, every break in the matrix was applied one at a time
against a real backend and the tier was confirmed to catch and name it. That is
where the "Exact red" column comes from. Two of those runs also corrected the
suite itself, and those fixes are already committed on the suite branch:
- **Drag drop-resolution (#5)** was originally a _miss_: the curated drag test
only targeted first-slot inputs, and a broken drop resolver falls back to the
first compatible input (LinkConnector's drop-on-node path), so such a
regression could not fail a first-slot-only pair. Fixed by adding the
second-slot anchor (`EmptyImage.IMAGE -> ImageBatch.image2`); the matrix red
above is from the fixed test.
- **Curated-run failure naming (#6)** originally reported `{}` for a backend
validation rejection. Fixed by capturing and flattening the backend
`node_errors`; the matrix now shows the named nodes and input.
- **Boot-time console noise** was confirmed out of the ledger's window by
design (documented in ARCHITECTURE.md section 10 and README), backstopped by
the startup zero-visible-errors check.
## Honest caveat: local full runs and machine load
All tests share ONE backend, locally and on CI alike (the CI job is
deliberately unsharded), and the suite enforces per-test backend isolation
itself: every test's
afterEach drains the backend to idle (`drainBackendToIdle`), the auto-run tier
waits out a still-draining prior execution instead of hard-failing, and the
non-executing tiers filter a foreign execution's async console lines
(`isForeignExecutionNoise`). This fixed the cross-test bleed class outright: a
test can no longer leave work running for the next test to inherit, and the
mount/persistence/wiring tiers no longer catch a neighbor's execution errors.
What remains genuinely load-sensitive is execution TIMING, not isolation: on a
machine that is busy with other work, slow CPU nodes can exceed even the raised
budgets (20s batch, 60s single re-run), which flips their classification and
trips the two-way cannotRunAlone baseline. That is the baseline doing its job
against an environment that changed under it, not a suite defect. Therefore:
- Use **CI** as the pass/fail oracle for the Detection Proof (a fresh backend
on an unloaded runner, every run).
- A local full run is meaningful on an otherwise-idle machine; do not run it
concurrently with heavy local work and expect baseline-exact results.
## Building the proof PR
1. Branch off the suite branch: `git checkout -b nathaniel/detection-proof nathaniel/custom-node-e2e-suite`.
2. One commit per matrix row, each breaking one surface, stacked so all breaks
are live at HEAD at once (not reverted between commits - the goal is to see
every surface broken together, and the `Tests Custom Nodes` job reds across
every tier in one run). FE-mode rows (1-7) are a direct `src/` edit carrying
an inline comment in the changed file:
`// DETECTION PROOF (row N, surface): recreates <FE-xxx / PR #12279>. Expected: <tier> red <message>.`
3. Pack-mode rows (8-10) are delivered by one CI step
(`DETECTION PROOF - break packs`, on this branch only) that patches each
cloned pack in place right after install. Each patch asserts it landed
(`grep`, fails the job otherwise) so a silent no-op cannot fake a pass. The
step is fenced to this never-merge branch and must never be ported to a real
suite branch.
4. Commit message names the surface, e.g.
`detection-proof: break mount (v2 Vue renderer) - drops the int widget mapping`.
5. Open the PR against the suite branch (not main) with the correlation matrix as
the description and a bold header: **This PR must never merge. Every commit is
a deliberate break; green would mean the gate missed a regression.**
6. Let CI run on HEAD. With every break live, the `Tests Custom Nodes` job reds
across every tier in one run. Attribute a red to its cause via the labelled
comment on the matching `src/` file (rows 1-7) or in the CI break step
(rows 8-10); checking out commit N (which contains breaks 1..N) narrows it
further.
7. Iterate until every row's own signature is visible in one run. Stacked
breaks mask each other along assert order (the mount test asserts the
litegraph pass before the Vue pass; the wiring sweep asserts its console
ledger before its pair verdicts; a globally-corrupted prompt fails
validation before any node can raise at runtime), so narrow blast radii
instead of weakening breaks: rows 1 and 6 are scoped to Impact-prefixed
nodes, and row 8 fires in `onExecuted` rather than `onConfigure` (the sweep
configures nodes but queues no prompts). A scoped break is still a real
bug class - real regressions routinely hit only a subset of nodes. Also
budget the job for the broken run: every red retries (3x on CI), so the
all-broken run does roughly double a green run's work (the demo branch
raises `timeout-minutes` to 90).
### Registry self-heal: why row 2 targets the pipeline, not the registry
The first row 2 variant deleted the `int` entry from `widgetRegistry.ts`, and
the suite rightly stayed green: `useProcessedWidgets` falls back to
`WidgetLegacy` when a registry lookup misses, so the widget row still renders
and the mount count matches (INT/FLOAT widgets are runtime type `number`,
served by the `float` entry's aliases, so the `int` entry is not even on the
standard path). The falsification falsified the break, not the suite, and
documented a real resilience property of the Vue renderer. To make a widget
row genuinely disappear (the FE-627/FE-634 class), skip it in the
`useProcessedWidgets` pipeline - the suite catches that immediately.
## References
- Linear "Custom Node Bugs" project issues (symptoms): FE-841, FE-627, FE-634,
FE-630, FE-637, FE-629, FE-625, FE-632, FE-751, FE-489, FE-491, FE-492.
- The defaultInput migration regression (widgets revert to socket-only on reload) and its open fix: Comfy-Org/ComfyUI_frontend #12279.
- Suite-discovered bugs with no upstream ticket yet (betterCombos `typeof null`,
WAS infinite-loop, WAS pip-install-in-execute, KJ ImageGridtoBatch min) are
pending upstream filing.

View File

@@ -0,0 +1,141 @@
# Custom-node regression suite
Proves community custom-node packs work against this frontend across both
renderers: nodes register, render under LiteGraph (canvas) AND Vue Nodes 2.0
(DOM), and execute real workflows end to end. Manifest-driven: adding a pack
is one JSON row, no new test code.
System design, data flow, and the reasoning behind every invariant:
[ARCHITECTURE.md](ARCHITECTURE.md). Onboarding a new pack:
[ADDING_CUSTOM_NODES.md](ADDING_CUSTOM_NODES.md).
## Prerequisites
1. A ComfyUI backend on `127.0.0.1:8288` with every manifest pack (the
`pack` entries in `browser_tests/fixtures/data/customNodeManifest.json`)
and ComfyUI_devtools
installed. Launch it with `--multi-user` (the repo-wide browser-test
prerequisite; the fixture writes per-worker user settings and the suite
depends on them landing), `--cache-none` (repeat runs must re-execute
every node or the executed-set check fails honestly with `PARTIAL`), and
with `browser_tests/assets/plain_video.mp4` copied into its `input/` dir.
2. The dev server proxying that backend:
`DEV_SERVER_COMFYUI_URL=http://127.0.0.1:8288 pnpm dev`
## Running
| Script | What it does |
| -------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
| `pnpm test:custom-nodes` | whole suite headless against the Vite dev server - the fast local loop for suite-code iteration. NOT the gate: the dev server never loads pack frontend JS (see Gotchas) |
| `pnpm test:custom-nodes:ci` | whole suite headless against the backend-served BUILT frontend - the gate-equivalent run (every tier passes, zero skips). Requires a backend serving the built dist on :8188 (a separate endpoint from the :8288 dev-proxy backend in Prerequisites); set `PLAYWRIGHT_TEST_URL` if yours differs |
| `pnpm test:custom-nodes:watch` | headed slow-motion run of the browser tiers, hands-off watching |
| `pnpm test:custom-nodes:debug` | step through the browser tiers in the Playwright Inspector (F10 step, F8 resume) |
| `pnpm test:custom-nodes:impact-render` | Impact nodes render in both renderers (Inspector) |
| `pnpm test:custom-nodes:impact-run` | Impact group workflow executes on the backend (Inspector) |
| `pnpm test:custom-nodes:vhs-render` | VHS nodes render in both renderers (Inspector) |
| `pnpm test:custom-nodes:vhs-run` | VHS decodes a real video through its node chain (Inspector) |
| `pnpm test:custom-nodes:connectivity` | slot/type contract: type-paired links + real slot drags in both renderers (Inspector) |
| `pnpm test:custom-nodes:self-check` | watches the harness catch a deliberate execution error |
Example - watch the VHS video-decode run step by step:
```bash
pnpm test:custom-nodes:vhs-run
```
Two windows open: the app under test and the Playwright Inspector. Press F10
to execute one robot action at a time (workflow loads, queue fires, backend
decodes the video), F8 to run to the end. While paused, look but do not click
inside the app window - your clicks change the state the next assertion
checks.
Any `-g` pattern works against the generic scripts, e.g.
`pnpm test:custom-nodes:debug -g "Impact-Pack.*T0"`.
## What the tests assert
- **T0 load**: pack nodes are registered in `/object_info`, added to a
cleared graph, counted exactly, and each added node's own `[data-node-id]`
element mounts under Vue Nodes 2.0. Both renderer passes - unless the pack
declares `vueNodesCompatible: false` in the manifest (evidence required;
see [ADDING_CUSTOM_NODES.md](ADDING_CUSTOM_NODES.md)), in which case its tests run their
LiteGraph-canvas assertions only. Never a skip. T0 also asserts each
pack's declared frontend extensions registered (`expectedExtensions`):
backend nodes can appear while the pack's JS silently failed to load.
- **T1 run**: the manifest workflow is loaded and queued; the backend's
`executing` event stream must contain every expected node id, and the run
must end in `execution_success`.
- **Dynamic inputs** (`dynamicInputs.spec.ts`): autogrow nodes (pack JS adds
an input when the last one is connected, removes trailing empties on
disconnect) grow and shrink correctly, via BOTH a real mouse drag and a
programmatic connect, under both renderers, asserted in the graph AND (in
the Vue renderer) as a rendered slot row, both directions. This behavior
lives in pack JS, not `/object_info`, so no def-driven tier can see it.
Curated cases live in the spec's `AUTOGROW_CASES` table.
- **Every-node tiers** (`allNodes.spec.ts`): the pack's FULL node list,
discovered live from `/object_info`, is exercised with zero
configuration - every registered node mounts in both renderers (chunked
at an empirically measured batch size), survives a serialize/configure
save-reload round-trip, and executes for real on the backend when
self-sufficient (all required inputs are widgets with valid defaults).
Nodes that cannot run alone are classified and logged
(`NEEDS_WIRES` / `NEEDS_MODELS` / `NO_OBSERVABLE_OUTPUT` / rejected-at-validation),
never silently dropped; the documented exception ledgers (see
[ADDING_CUSTOM_NODES.md](ADDING_CUSTOM_NODES.md)) carry a written mechanism for every
escape hatch.
- **connectivity (contract)**: wiring-only, no execution. A
type-pairing generator (`fixtures/customNode/typePairing.ts`) indexes
`/object_info` producers/consumers and plans one representative typed edge
per slot (wildcard `*` slots excluded - they bypass the real type compare
and prove nothing). Each planned edge must connect through the real
`isValidConnection` veto, then survive `serialize()` -> `configure()` and
appear in `graphToPrompt()` output. A curated subset is additionally
dragged for real - slot dot to slot dot - under both renderers. Orphan
types (no partner in the corpus) are reported, never fake-failed. One
representative edge per slot bounds cost; it does not prove all pairs.
- **Zero visible errors**: the mount, persistence, connectivity, core
smoke, and curated workflow tests assert the app's error surfaces (error
overlay, error dialog, node render errors, error toasts) are absent at
start and after every pass - green means a human watching those runs sees
no errors. Two deliberate exceptions: the auto-run execution tier
provokes expected failures (baselined cannotRunAlone nodes surface as
real error UI by design), and the self-check inverts the invariant - it
forces a real execution error and asserts the overlay IS visible, proving
the selectors stay live.
- **Console-error window**: the console/page-error ledger (curated run,
save/reload) starts collecting inside each tier, so it covers the tier's
own actions - load, run, wire, save. Pure console noise a pack logs at
app boot, before the first tier action, is out of that window by design:
the shared app fixture navigates once at setup, so boot output predates
any per-pack collector. Boot breakage that MATTERS still fails the gate -
the zero-visible-errors check runs at startup and catches any boot error
that reaches a visible surface; only invisible, functionally-inert boot
console noise (the ledger's whole reason to exist) is out of scope.
## Adding a pack
One manifest row plus one small workflow JSON - no new test code. The
authoritative step-by-step process (verifying the pack's real node keys,
authoring the run workflow, the `vueNodesCompatible` evidence rule, what CI
does with the row) lives in [ADDING_CUSTOM_NODES.md](ADDING_CUSTOM_NODES.md). Follow it
exactly; the traps it lists all shipped in real packs.
## Gotchas
- **Pack frontend JS does not load under the Vite dev server.** The dev
server's `/extensions` endpoint lists core extensions only, so nodes render
vanilla locally even when the backend has the packs installed. CI serves
the built frontend from the backend, where every pack's JS loads and can
restyle nodes, rebuild widgets, or inject page chrome. Before pushing
changes that could interact with pack JS, reproduce CI locally:
`pnpm build`, relaunch the backend with `--front-end-root <repo>/dist`,
and run the suite with `PLAYWRIGHT_TEST_URL` pointed at the backend.
- Do not run with `--trace on` against system Chrome
(`playwright.chrome.config.ts` pins trace off): the trace recorder crashes
pages under the branded Chrome channel and every test reports a bogus 15s
timeout.
- In a git worktree whose `node_modules` is symlinked from another checkout,
prefix scripts with `pnpm --config.verify-deps-before-run=false ...` to
skip pnpm's auto-install check.
- First run against a cold dev server can exceed the 15s per-test setup
budget while Vite compiles; just run again.

File diff suppressed because it is too large Load Diff

View File

@@ -0,0 +1,238 @@
import {
comfyExpect as expect,
comfyPageFixture as test
} from '@e2e/fixtures/ComfyPage'
import {
batchAutoRunnable,
classifyAutoRunnable,
planAutoRuns
} from '@e2e/fixtures/customNode/autoRun'
const SYNTH = new Set([
'IMAGE',
'LATENT',
'MASK',
'INT',
'FLOAT',
'STRING',
'BOOLEAN',
'*'
])
test.describe('autoRun classifier', () => {
test('widget-only node with outputs is runnable via a PreviewAny sink', () => {
const verdict = classifyAutoRunnable(
'IntConstant',
{
input: { required: { value: ['INT', { default: 0 }] } },
output: ['INT'],
output_node: false
},
SYNTH
)
expect(verdict.verdict).toBe('AUTO_RUNNABLE')
expect(verdict.needsPreviewSink).toBe(true)
})
test('widget-only OUTPUT_NODE runs standalone', () => {
const verdict = classifyAutoRunnable(
'ShowValue',
{
input: {
required: {
text: ['STRING', {}],
mode: [['raw value', 'tensor shape']]
}
},
output: [],
output_node: true
},
SYNTH
)
expect(verdict.verdict).toBe('AUTO_RUNNABLE')
expect(verdict.needsPreviewSink).toBe(false)
})
test('synthesizable sockets make a node CHAINABLE with its socket list', () => {
const verdict = classifyAutoRunnable(
'MaskComposite',
{
input: {
required: {
destination: ['MASK'],
source: ['MASK'],
x: ['INT', { default: 0 }],
operation: [['multiply', 'add']]
}
},
output: ['MASK'],
output_node: false
},
SYNTH
)
expect(verdict.verdict).toBe('CHAINABLE')
expect(verdict.requiredSockets).toEqual([
{ name: 'destination', type: 'MASK' },
{ name: 'source', type: 'MASK' }
])
expect(verdict.needsPreviewSink).toBe(true)
})
test('a socket with no model-free producer means NEEDS_WIRES', () => {
const verdict = classifyAutoRunnable(
'VaeDecode',
{
input: { required: { samples: ['LATENT'], vae: ['VAE'] } },
output: ['IMAGE'],
output_node: false
},
SYNTH
)
expect(verdict.verdict).toBe('NEEDS_WIRES')
expect(verdict.reason).toContain('vae')
})
test('forceInput STRING is a socket but STRING is synthesizable', () => {
const verdict = classifyAutoRunnable(
'TextSink',
{
input: { required: { text: ['STRING', { forceInput: true }] } },
output: ['STRING'],
output_node: true
},
SYNTH
)
expect(verdict.verdict).toBe('CHAINABLE')
expect(verdict.requiredSockets).toEqual([{ name: 'text', type: 'STRING' }])
})
test('an empty required combo means NEEDS_MODELS', () => {
const verdict = classifyAutoRunnable(
'CheckpointLoader',
{
input: { required: { ckpt_name: [[]] } },
output: ['MODEL'],
output_node: false
},
SYNTH
)
expect(verdict.verdict).toBe('NEEDS_MODELS')
expect(verdict.reason).toContain('ckpt_name')
})
// Census-derived: transformed (V2-schema) defs carry combos as the string
// 'COMBO' with options in the opts object - the classifier must not read
// that as an unproducible socket type.
test('a V2-form combo with options is a widget', () => {
const verdict = classifyAutoRunnable(
'LatentConcatLike',
{
input: {
required: {
dim: ['COMBO', { multiselect: false, options: ['x', '-x', 'y'] }]
}
},
output: ['LATENT'],
output_node: false
},
SYNTH
)
expect(verdict.verdict).toBe('AUTO_RUNNABLE')
})
// Census-derived (DevToolsNodeWithOutputCombo.subset_options): a combo
// carrying forceInput is a socket in ANY form - no widget materializes,
// so its option list cannot satisfy the input.
test('forceInput on a list-form combo is a socket, not a widget', () => {
const verdict = classifyAutoRunnable(
'OutputComboLike',
{
input: {
required: { subset_options: [['A', 'B'], { forceInput: true }] }
},
output: ['COMBO'],
output_node: false
},
SYNTH
)
expect(verdict.verdict).toBe('NEEDS_WIRES')
expect(verdict.reason).toContain('subset_options')
})
test('a V2-form combo with no static options means NEEDS_MODELS', () => {
for (const spec of [
['COMBO', { multiselect: false, options: [] }],
['COMBO', { remote: { route: '/internal/files/output' } }]
]) {
const verdict = classifyAutoRunnable(
'LoadImageOutputLike',
{
input: { required: { image: spec } },
output: ['IMAGE'],
output_node: false
},
SYNTH
)
expect(verdict.verdict).toBe('NEEDS_MODELS')
expect(verdict.reason).toContain('image')
}
})
test('no outputs and not an OUTPUT_NODE means NO_OBSERVABLE_OUTPUT', () => {
const verdict = classifyAutoRunnable(
'SideEffectOnly',
{
input: { required: { value: ['INT', {}] } },
output: [],
output_node: false
},
SYNTH
)
expect(verdict.verdict).toBe('NO_OBSERVABLE_OUTPUT')
})
test('optional socket inputs do not block auto-running', () => {
const verdict = classifyAutoRunnable(
'MathWithOptionalAny',
{
input: {
required: { expression: ['STRING', {}] },
optional: { a: ['*'] }
},
output: ['INT', 'FLOAT'],
output_node: true
},
SYNTH
)
expect(verdict.verdict).toBe('AUTO_RUNNABLE')
})
test('planAutoRuns validates producers against defs and batches runnables', () => {
const defs = {
A: {
input: { required: { v: ['INT', {}] } },
output: ['INT'],
output_node: false
},
B: {
input: { required: { x: ['SEGS'] } },
output: ['SEGS'],
output_node: false
},
C: {
input: { required: { img: ['IMAGE'] } },
output: ['IMAGE'],
output_node: false
},
EmptyImage: { input: { required: {} }, output: ['IMAGE'] }
}
const verdicts = planAutoRuns(defs, ['A', 'B', 'C'])
expect(verdicts.map((verdict) => verdict.verdict)).toEqual([
'AUTO_RUNNABLE',
'NEEDS_WIRES',
'CHAINABLE'
])
const batches = batchAutoRunnable(verdicts, 1)
expect(batches.map((batch) => batch[0].key)).toEqual(['A', 'C'])
})
})

View File

@@ -0,0 +1,533 @@
import type { Page } from '@playwright/test'
import {
comfyExpect as expect,
comfyPageFixture as test
} from '@e2e/fixtures/ComfyPage'
import {
customNodeSuiteSettings,
dismissTemplatesDialog,
drainBackendToIdle
} from '@e2e/fixtures/utils/customNodeSuite'
import { isForeignExecutionNoise } from '@e2e/fixtures/customNode/consoleErrorLedger'
import { loadManifest } from '@e2e/fixtures/customNode/manifest'
import type {
ConnectivityOutcome,
PlannedPair,
RawNodeDef
} from '@e2e/fixtures/customNode/typePairing'
import {
isWildcard,
normalizeNodeDefs,
planPairs
} from '@e2e/fixtures/customNode/typePairing'
import { collectConsoleErrors } from '@e2e/fixtures/utils/consoleErrorCollector'
import { expectNoVisibleErrors } from '@e2e/fixtures/utils/errorSurfaces'
const CORE_PROOF_NODE_COUNT = 16
// A node may legitimately veto a wiring via onConnectInput; committed
// entries here must name the veto. Green means actual rejections are a
// subset of this list.
const CONNECT_REJECTED_ALLOWLIST: string[] = [
// pysssss MathExpression only accepts INT/FLOAT-producing links into its
// expression variables; its JS vetoes text-list producers.
'AddTextPrefix.texts -> MathExpression|pysssss.expression'
]
// A pack's own serialize/configure hooks may drop links it manages itself
// (reproducible manually: wire, save, reload - link gone). Pack behavior on
// record, not frontend regressions.
const ROUNDTRIP_LOST_ALLOWLIST: string[] = [
// rgthree SDXL Power Prompt rebuilds its dimension widget-inputs during
// configure and drops inbound links to them.
'BatchCount+.INT -> SDXL Power Prompt - Positive (rgthree).target_width',
'BatchCount+.INT -> SDXL Power Prompt - Positive (rgthree).target_height',
'BatchCount+.INT -> SDXL Power Prompt - Positive (rgthree).crop_width',
'BatchCount+.INT -> SDXL Power Prompt - Positive (rgthree).crop_height',
'BatchCount+.INT -> SDXL Power Prompt - Simple / Negative (rgthree).target_width',
'BatchCount+.INT -> SDXL Power Prompt - Simple / Negative (rgthree).target_height',
'BatchCount+.INT -> SDXL Power Prompt - Simple / Negative (rgthree).crop_width',
'BatchCount+.INT -> SDXL Power Prompt - Simple / Negative (rgthree).crop_height',
// VHS_SelectLatest rebuilds its dynamic slots on configure, detaching
// links on both its inputs and outputs.
'AddTextPrefix.texts -> VHS_SelectLatest.filename_prefix',
'AddTextPrefix.texts -> VHS_SelectLatest.filename_postfix',
'VHS_SelectLatest.Filename -> AddLabel.font_color'
]
test.use({ initialSettings: customNodeSuiteSettings })
test.beforeEach(async ({ comfyPage }) => {
await dismissTemplatesDialog(comfyPage)
})
// Leave the shared backend idle so the next test starts clean (drainBackendToIdle).
test.afterEach(async ({ comfyPage }) => {
// The drain is a no-op when the queue is already idle, so it costs
// ~nothing in the common path; the 10s ceiling only bounds a genuinely
// busy backend. A backend still busy past it is wedged, and the auto-run
// tier's 150s guard surfaces that with the restart diagnostic.
await drainBackendToIdle(comfyPage.page, 10_000)
})
function concrete(slot: { type: string }): boolean {
return !isWildcard(slot.type)
}
function isEntryInstalled(
nodeTypes: Set<string>,
entry: { expectedNodes: string[] }
): boolean {
return entry.expectedNodes.every((type) => nodeTypes.has(type))
}
const connectivityEntries = loadManifest().filter((entry) =>
entry.tiers.includes('connectivity')
)
test('connectivity: every type-paired link survives model, serialize, and prompt round-trips @custom-nodes', async ({
comfyPage
}) => {
test.setTimeout(120_000)
const defs = (await comfyPage.page.evaluate(() =>
window.app!.api.getNodeDefs()
)) as unknown as Record<string, RawNodeDef>
const nodes = normalizeNodeDefs(defs)
// Pack-specific expectations apply only where the pack is installed; on a
// backend without it (e.g. a generic CI runner) the core sweep still runs
// and the absence is reported, never fake-failed or fake-passed.
const nodeTypes = new Set(nodes.map((node) => node.type))
const installedEntries = connectivityEntries.filter((entry) =>
isEntryInstalled(nodeTypes, entry)
)
for (const entry of connectivityEntries)
if (!installedEntries.includes(entry))
console.log(`connectivity: ${entry.pack} not installed on this backend`)
// Corpus = every node the installed packs register, from the live backend.
const installedPacks = new Set(installedEntries.map((entry) => entry.pack))
const packTypes = nodes
.filter((node) => installedPacks.has(node.pack))
.map((node) => node.type)
const coreProof = nodes
.filter(
(node) =>
node.pack === 'core' &&
node.inputs.some(concrete) &&
node.outputs.some(concrete)
)
.map((node) => node.type)
.sort()
.slice(0, CORE_PROOF_NODE_COUNT)
const plan = planPairs(nodes, [...packTypes, ...coreProof])
expect(plan.pairs.length, 'pairing produced no edges').toBeGreaterThan(0)
console.log(
`connectivity plan: ${plan.pairs.length} pairs, ${plan.orphans.length} orphan slots, ${plan.wildcards.length} wildcard + ${plan.combos.length} combo slots (excluded by design), ${plan.unknownShapes.length} unknown-shape slots (recorded: ${plan.unknownShapes.join('; ') || 'none'})`
)
for (const entry of installedEntries) {
expect(
plan.pairs.some(
(pair) =>
pair.producer.pack === entry.pack || pair.consumer.pack === entry.pack
),
`${entry.pack} contributes no pairs - corpus or pack attribution broke`
).toBe(true)
}
// The breadth sweep runs under one renderer by design: it exercises
// graph-API link creation, the real isValidConnection veto, and
// serialize/configure survival - all renderer-independent paths (widget
// values and links flow through the same stores in both renderers). The
// curated drag test below covers real pointer wiring under BOTH renderers.
const consoleErrors = collectConsoleErrors(comfyPage.page)
const results = await runPairsInPage(comfyPage.page, plan.pairs)
consoleErrors.stop()
// Deliberately raw, not routed through the pack console ledger
// (consoleErrorLedger.ts): the sweep holds zero console errors without
// exceptions today, and the stricter contract catches noise the moment
// wiring provokes it. If a ledgered pattern ever fires here, filter
// through unallowlistedErrors with the pack taken from the offending
// pair's nodes (the sweep is cross-pack), instead of silently
// loosening this assert. The wiring sweep queues no prompts, so a
// prompt-execution error here is a prior tier's async stray, not this
// test's (isForeignExecutionNoise; ARCHITECTURE section 9 principle).
expect(
consoleErrors.errors.filter((error) => !isForeignExecutionNoise(error)),
'console errors during breadth sweep'
).toEqual([])
const widgetOnly = results.filter(
(result) =>
result.outcome ===
('WIDGET_ONLY_ON_INSTANCE' satisfies ConnectivityOutcome)
)
if (widgetOnly.length > 0)
console.log(
`connectivity sweep: ${widgetOnly.length} pair(s) excluded - pack JS made the declared input widget-only: ${widgetOnly.map((result) => result.key).join('; ')}`
)
const failures = results.filter(
(result) =>
result.outcome !== ('PASS' satisfies ConnectivityOutcome) &&
result.outcome !==
('WIDGET_ONLY_ON_INSTANCE' satisfies ConnectivityOutcome) &&
!(
result.outcome === ('CONNECT_REJECTED' satisfies ConnectivityOutcome) &&
CONNECT_REJECTED_ALLOWLIST.includes(result.key)
) &&
!(
result.outcome === ('ROUNDTRIP_LOST' satisfies ConnectivityOutcome) &&
ROUNDTRIP_LOST_ALLOWLIST.includes(result.key)
)
)
const passed = results.filter((result) => result.outcome === 'PASS').length
console.log(`connectivity sweep: ${passed}/${results.length} pairs PASS`)
expect(failures, JSON.stringify(failures, null, 1)).toEqual([])
expect(passed).toBeGreaterThan(0)
// Two-way guard, same discipline as cannotRunAlone: every allowlisted key
// must still be OBSERVED failing in its recorded way. An entry whose pair
// now passes (or is no longer even planned) is stale and would silently
// hide the fixed bug behind it. On a partially-installed local backend an
// absent key only logs; CI installs every pack, so it always enforces.
const outcomeByKey = new Map(
results.map((result) => [result.key, result.outcome])
)
const allPacksInstalled =
installedEntries.length === connectivityEntries.length
const staleEntries: string[] = []
for (const [allowlist, expected] of [
[CONNECT_REJECTED_ALLOWLIST, 'CONNECT_REJECTED'],
[ROUNDTRIP_LOST_ALLOWLIST, 'ROUNDTRIP_LOST']
] as const)
for (const key of allowlist) {
const observed = outcomeByKey.get(key)
if (observed === undefined && !allPacksInstalled) {
console.log(
`allowlist entry not observed (pack not installed here): ${key}`
)
continue
}
if (observed !== expected)
staleEntries.push(
`${key}: expected ${expected}, observed ${observed ?? 'nothing'} - remove the stale entry`
)
}
expect(staleEntries, 'stale allowlist entries').toEqual([])
await expectNoVisibleErrors(comfyPage.page, 'after breadth sweep')
})
// First planned pair whose slots both exist on real instances (pack JS can
// rebuild declared inputs as widget-only controls).
function firstMaterializedPair(
page: Page,
pairs: PlannedPair[]
): Promise<PlannedPair | null> {
return page.evaluate((pairsInPage) => {
for (const pair of pairsInPage) {
const producer = window.LiteGraph!.createNode(pair.producer.nodeType)
const consumer = window.LiteGraph!.createNode(pair.consumer.nodeType)
const outFound = producer?.outputs.some(
(slot) => slot.name === pair.producer.slotName
)
const inFound = consumer?.inputs.some(
(slot) => slot.name === pair.consumer.slotName
)
if (outFound && inFound) return pair
}
return null
}, pairs)
}
// The self-check below runs THIS SAME executor on poisoned pairs; if it stops
// being able to reject, every green sweep above is meaningless.
function runPairsInPage(
page: Page,
pairs: PlannedPair[]
): Promise<Array<{ key: string; outcome: string; detail?: string }>> {
return page.evaluate(async (pairsInPage) => {
const graph = window.app!.graph
const report: Array<{
key: string
outcome: string
detail?: string
}> = []
for (const pair of pairsInPage) {
const key = `${pair.producer.nodeType}.${pair.producer.slotName} -> ${pair.consumer.nodeType}.${pair.consumer.slotName}`
try {
graph.clear()
const producer = window.LiteGraph!.createNode(pair.producer.nodeType)
const consumer = window.LiteGraph!.createNode(pair.consumer.nodeType)
if (!producer || !consumer) {
report.push({
key,
outcome: 'SLOT_CONTRACT_MISMATCH',
detail: 'createNode returned null for a registered type'
})
continue
}
graph.add(producer)
graph.add(consumer)
const outIndex = producer.outputs.findIndex(
(slot) => slot.name === pair.producer.slotName
)
const inIndex = consumer.inputs.findIndex(
(slot) => slot.name === pair.consumer.slotName
)
if (outIndex < 0 || inIndex < 0) {
// Pack JS may rebuild a declared input as widget-only (rgthree
// Seed.seed) - excluded; missing as slot AND widget stays a fail.
const widgetOnly =
outIndex >= 0 &&
(consumer.widgets ?? []).some(
(widget) => widget.name === pair.consumer.slotName
)
report.push({
key,
outcome: widgetOnly
? 'WIDGET_ONLY_ON_INSTANCE'
: 'SLOT_CONTRACT_MISMATCH',
detail: `declared slot missing on instance (out=${outIndex}, in=${inIndex})`
})
continue
}
const link = producer.connect(outIndex, consumer, inIndex)
if (!link || consumer.inputs[inIndex]?.link == null) {
report.push({ key, outcome: 'CONNECT_REJECTED' })
continue
}
const serialized = graph.serialize()
graph.configure(serialized)
const restored = graph.getNodeById(consumer.id)
if (restored?.inputs?.[inIndex]?.link == null) {
report.push({
key,
outcome: 'ROUNDTRIP_LOST',
detail: 'serialize/configure dropped the link'
})
continue
}
const prompt = (await window.app!.graphToPrompt()) as {
output?: Record<string, { inputs?: Record<string, unknown> }>
}
const promptInput =
prompt.output?.[String(consumer.id)]?.inputs?.[pair.consumer.slotName]
if (!Array.isArray(promptInput)) {
report.push({
key,
outcome: 'ROUNDTRIP_LOST',
detail: 'link missing from graphToPrompt output'
})
continue
}
report.push({ key, outcome: 'PASS' })
} catch (error) {
report.push({
key,
outcome: 'SLOT_CONTRACT_MISMATCH',
detail: `threw: ${String(error)}`
})
}
}
graph.clear()
return report
}, pairs)
}
test('connectivity self-check: the executor rejects broken pairs @custom-nodes', async ({
comfyPage
}) => {
const slot = (nodeType: string, slotName: string, slotType: string) => ({
nodeType,
pack: 'core',
slotName,
slotType
})
const results = await runPairsInPage(comfyPage.page, [
{
producer: slot('CheckpointLoaderSimple', 'MODEL', 'MODEL'),
consumer: slot('KSampler', 'latent_image', 'LATENT')
},
{
producer: slot('EmptyLatentImage', 'LATENT', 'LATENT'),
consumer: slot('KSampler', 'does_not_exist', 'LATENT')
}
])
expect(results.map((result) => result.outcome)).toEqual([
'CONNECT_REJECTED',
'SLOT_CONTRACT_MISMATCH'
])
})
test('connectivity drags: curated slot-to-slot wires connect under both renderers @custom-nodes', async ({
comfyPage
}) => {
test.setTimeout(120_000)
const defs = (await comfyPage.page.evaluate(() =>
window.app!.api.getNodeDefs()
)) as unknown as Record<string, RawNodeDef>
const nodes = normalizeNodeDefs(defs)
// Native anchor pair plus one in-pack, link-typed pair per connectivity
// pack (derived from the same generator the breadth sweep uses).
const dragEdges: PlannedPair[] = [
{
producer: {
nodeType: 'EmptyLatentImage',
pack: 'core',
slotName: 'LATENT',
slotType: 'LATENT'
},
consumer: {
nodeType: 'KSampler',
pack: 'core',
slotName: 'latent_image',
slotType: 'LATENT'
}
},
// Second-slot anchor: ImageBatch has two IMAGE inputs (image1, image2)
// and we target the SECOND. A slot hit-test regression that falls back
// to the first compatible input would land on image1, leaving image2
// (the asserted index) unlinked - so this pair, unlike a first-slot
// pair, actually discriminates a broken drop-to-slot resolution.
{
producer: {
nodeType: 'EmptyImage',
pack: 'core',
slotName: 'IMAGE',
slotType: 'IMAGE'
},
consumer: {
nodeType: 'ImageBatch',
pack: 'core',
slotName: 'image2',
slotType: 'IMAGE'
}
}
]
const nodeTypes = new Set(nodes.map((node) => node.type))
for (const entry of connectivityEntries) {
if (!isEntryInstalled(nodeTypes, entry)) {
console.log(
`connectivity drag: ${entry.pack} not installed on this backend`
)
continue
}
// Restrict the partner pool to the pack itself so the drag proves an
// in-pack wiring; widget-backed primitive inputs render real slot dots
// in Vue (verified empirically), so no slot type is excluded at plan time.
const packPlan = planPairs(
nodes.filter((node) => node.pack === entry.pack),
entry.expectedNodes
)
expect(
packPlan.pairs.length,
`${entry.pack} has no in-pack draggable pair - drag coverage lost`
).toBeGreaterThan(0)
// The plan comes from object_info, but a pack's own JS can rebuild a
// declared input as widget-only on the instance (rgthree's Seed does).
// Drag the first pair whose slots actually materialize; a pack whose
// every planned pair is customized away has no socket contract to drag.
const inPack = await firstMaterializedPair(comfyPage.page, packPlan.pairs)
if (!inPack) {
console.log(
`connectivity drag: ${entry.pack} planned pairs are widget-only on instances; drag not applicable`
)
continue
}
dragEdges.push(inPack)
}
const vueIncompatiblePacks = new Set(
connectivityEntries
.filter((entry) => entry.vueNodesCompatible === false)
.map((entry) => entry.pack)
)
for (const vueNodesEnabled of [false, true]) {
const consoleErrors = collectConsoleErrors(comfyPage.page)
await comfyPage.settings.setSetting(
'Comfy.VueNodes.Enabled',
vueNodesEnabled
)
for (const edge of dragEdges) {
if (vueNodesEnabled && vueIncompatiblePacks.has(edge.producer.pack)) {
console.log(
`connectivity drag: ${edge.producer.pack} declares vueNodesCompatible=false; Vue drag not applicable`
)
continue
}
await comfyPage.nodeOps.clearGraph()
const producer = await comfyPage.nodeOps.addNode(
edge.producer.nodeType,
undefined,
{ x: 150, y: 200 }
)
const consumer = await comfyPage.nodeOps.addNode(
edge.consumer.nodeType,
undefined,
{ x: 700, y: 200 }
)
await comfyPage.nextFrame()
const [outIndex, inIndex] = await comfyPage.page.evaluate(
([producerId, consumerId, outName, inName]) => {
const byId = (id: string) =>
window.app!.graph.nodes.find((node) => String(node.id) === id)!
const src = byId(producerId)
const dst = byId(consumerId)
return [
src.outputs.findIndex((slot) => slot.name === outName),
dst.inputs.findIndex((slot) => slot.name === inName)
]
},
[
String(producer.id),
String(consumer.id),
edge.producer.slotName,
edge.consumer.slotName
] as const
)
const key = `${edge.producer.nodeType}.${edge.producer.slotName} -> ${edge.consumer.nodeType}.${edge.consumer.slotName}`
expect(outIndex, `${key}: producer slot on instance`).toBeGreaterThan(-1)
expect(inIndex, `${key}: consumer slot on instance`).toBeGreaterThan(-1)
if (vueNodesEnabled) {
await comfyPage.vueNodes.waitForNodes(2)
// Slot-key-addressed dots so shared-label ambiguity cannot misfire
// the drag.
const outDot = comfyPage.vueNodes.getOutputSlotConnectionDot(
String(producer.id),
outIndex
)
const inDot = comfyPage.vueNodes.getInputSlotConnectionDot(
String(consumer.id),
inIndex
)
await outDot.dragTo(inDot)
} else {
await producer.connectOutput(outIndex, consumer, inIndex)
}
const linked = await comfyPage.page.evaluate(
([consumerId, index]) => {
const node = window.app!.graph.nodes.find(
(candidate) => String(candidate.id) === consumerId
)
return node?.inputs?.[Number(index)]?.link != null
},
[String(consumer.id), String(inIndex)] as const
)
expect(linked, `${key} with VueNodes=${vueNodesEnabled}`).toBe(true)
}
consoleErrors.stop()
expect(
consoleErrors.errors.filter((error) => !isForeignExecutionNoise(error)),
`console errors with VueNodes=${vueNodesEnabled}`
).toEqual([])
await expectNoVisibleErrors(
comfyPage.page,
`after drag pass VueNodes=${vueNodesEnabled}`
)
}
})

View File

@@ -0,0 +1,69 @@
import {
comfyExpect as expect,
comfyPageFixture as test
} from '@e2e/fixtures/ComfyPage'
import {
isForeignExecutionNoise,
unallowlistedErrors
} from '@e2e/fixtures/customNode/consoleErrorLedger'
// unallowlistedErrors is the sole enforcement point of the curated-run
// console gate (customNode.regression.spec.ts T1): a degradation to
// "always empty" would turn that gate vacuously green, so the filter's
// three behaviors are pinned here directly.
test.describe('consoleErrorLedger', () => {
test('filters only errors matching the pack own patterns', () => {
const errors = [
'Failed to load resource: the server responded with a status of 404 () http://host/example.png',
'TypeError: something real broke'
]
expect(unallowlistedErrors('ComfyUI-Impact-Pack', errors)).toEqual([
'TypeError: something real broke'
])
})
test('a pattern never filters for a pack that does not own it', () => {
const error = "Cannot use 'in' operator to search for 'content' in null"
expect(unallowlistedErrors('ComfyUI-Impact-Pack', [error])).toEqual([error])
expect(unallowlistedErrors('ComfyUI-Custom-Scripts', [error])).toEqual([])
})
test('unknown pack fails open: every error surfaces', () => {
// The first error would match an Impact pattern; with no ledger for the
// pack, nothing may be filtered.
const errors = [
'Failed to load resource: the server responded with a status of 404 () http://host/example.png',
'boom'
]
expect(unallowlistedErrors('Some-Future-Pack', errors)).toEqual(errors)
})
})
// Filters a prior tier's async execution error out of the non-executing
// tiers; must match execution-domain lines and nothing a mount/wiring tier
// should legitimately catch.
test.describe('isForeignExecutionNoise', () => {
test('matches the execution-domain console surfaces', () => {
expect(isForeignExecutionNoise('PromptExecutionError: boom')).toBe(true)
expect(isForeignExecutionNoise('Prompt execution failed')).toBe(true)
expect(
isForeignExecutionNoise(
'Failed to load resource: the server responded with a status of 400 (Bad Request) http://127.0.0.1:8288/api/prompt'
)
).toBe(true)
})
test('does not match render or unrelated resource errors a tier must catch', () => {
expect(
isForeignExecutionNoise('TypeError: cannot read x of undefined')
).toBe(false)
expect(
isForeignExecutionNoise(
'Failed to load resource: 404 http://127.0.0.1:8288/api/view?filename=x.png'
)
).toBe(false)
expect(
isForeignExecutionNoise('Uncaught page error: something rendered wrong')
).toBe(false)
})
})

View File

@@ -0,0 +1,65 @@
import { readFileSync } from 'node:fs'
import { resolve } from 'node:path'
import type { ComfyWorkflowJSON } from '@/platform/workflow/validation/schemas/workflowSchema'
import {
comfyExpect as expect,
comfyPageFixture as test
} from '@e2e/fixtures/ComfyPage'
import { isForeignExecutionNoise } from '@e2e/fixtures/customNode/consoleErrorLedger'
import {
customNodeSuiteSettings,
dismissTemplatesDialog,
drainBackendToIdle
} from '@e2e/fixtures/utils/customNodeSuite'
import { collectConsoleErrors } from '@e2e/fixtures/utils/consoleErrorCollector'
import { expectNoVisibleErrors } from '@e2e/fixtures/utils/errorSurfaces'
import { assetPath } from '@e2e/fixtures/utils/paths'
// Core-only, model-free workflow: the bundled default template references
// model files a scoped test backend does not have, which rightly trips the
// error surfaces this suite asserts are clean.
const smokeWorkflow = JSON.parse(
readFileSync(resolve(assetPath('customNodes/core_smoke.json')), 'utf-8')
) as ComfyWorkflowJSON
test.use({ initialSettings: customNodeSuiteSettings })
test.beforeEach(async ({ comfyPage }) => {
await dismissTemplatesDialog(comfyPage)
})
// Leave the shared backend idle so the next test starts clean (drainBackendToIdle).
test.afterEach(async ({ comfyPage }) => {
// The drain is a no-op when the queue is already idle, so it costs
// ~nothing in the common path; the 10s ceiling only bounds a genuinely
// busy backend. A backend still busy past it is wedged, and the auto-run
// tier's 150s guard surfaces that with the restart diagnostic.
await drainBackendToIdle(comfyPage.page, 10_000)
})
test.describe('smoke: core workflow @custom-nodes', () => {
test('loads without console errors in both renderers', async ({
comfyPage
}) => {
for (const vueNodesEnabled of [false, true]) {
const consoleErrors = collectConsoleErrors(comfyPage.page)
await comfyPage.settings.setSetting(
'Comfy.VueNodes.Enabled',
vueNodesEnabled
)
await comfyPage.workflow.loadGraphData(smokeWorkflow)
await comfyPage.nextFrame()
consoleErrors.stop()
expect(await comfyPage.nodeOps.getGraphNodesCount()).toBeGreaterThan(0)
// Core smoke loads a graph but queues no prompt; a prompt-execution
// error here is a prior tier's async stray (isForeignExecutionNoise).
expect(
consoleErrors.errors.filter((error) => !isForeignExecutionNoise(error)),
`console errors (VueNodes=${vueNodesEnabled})`
).toEqual([])
await expectNoVisibleErrors(comfyPage.page, `VueNodes=${vueNodesEnabled}`)
}
})
})

View File

@@ -0,0 +1,351 @@
/* oxlint-disable playwright/no-skipped-test -- tiers conditionally skip when the target backend lacks the required packs (installed custom nodes or devtools); this is the framework's designed environment gating, not a disabled test */
import { existsSync, readFileSync } from 'node:fs'
import { resolve } from 'node:path'
import type { Page } from '@playwright/test'
import type { ComfyWorkflowJSON } from '@/platform/workflow/validation/schemas/workflowSchema'
import {
comfyExpect as expect,
comfyPageFixture as test
} from '@e2e/fixtures/ComfyPage'
import {
customNodeSuiteSettings,
dismissTemplatesDialog,
drainBackendToIdle
} from '@e2e/fixtures/utils/customNodeSuite'
import { LocalDesktopTarget } from '@e2e/fixtures/customNode/ComfyTarget'
import {
isForeignExecutionNoise,
unallowlistedErrors
} from '@e2e/fixtures/customNode/consoleErrorLedger'
import {
loadManifest,
rendererPassesFor
} from '@e2e/fixtures/customNode/manifest'
import { missingExpectedNodes } from '@e2e/fixtures/customNode/objectInfoValidator'
import { collectConsoleErrors } from '@e2e/fixtures/utils/consoleErrorCollector'
import {
errorSurfaces,
expectNoVisibleErrors
} from '@e2e/fixtures/utils/errorSurfaces'
import { assetPath } from '@e2e/fixtures/utils/paths'
const target = new LocalDesktopTarget()
const OBJECT_INFO_SANITY_FLOOR = 50
// Display sinks used by the curated workflows; each is an output node whose
// `executed` event carries a ui payload, so "the workflow ran" can be
// upgraded to "data actually arrived at the sink". Console-style sinks
// (WAS `Text to Console`) emit NO ui payload and stay off this list, so a
// pack whose only sink prints to console gets execution-completed proof
// only.
const CURATED_SINK_TYPES = [
'PreviewAny',
'DisplayAny',
'Display Any (rgthree)',
'ShowText|pysssss'
]
test.use({ initialSettings: customNodeSuiteSettings })
test.beforeEach(async ({ comfyPage }) => {
await dismissTemplatesDialog(comfyPage)
})
// Leave the shared backend idle so the next test starts clean (drainBackendToIdle).
test.afterEach(async ({ comfyPage }) => {
// The drain is a no-op when the queue is already idle, so it costs
// ~nothing in the common path; the 10s ceiling only bounds a genuinely
// busy backend. A backend still busy past it is wedged, and the auto-run
// tier's 150s guard surfaces that with the restart diagnostic.
await drainBackendToIdle(comfyPage.page, 10_000)
})
function readWorkflow(relativePath: string): ComfyWorkflowJSON {
return JSON.parse(
readFileSync(resolve(relativePath), 'utf-8')
) as ComfyWorkflowJSON
}
async function nodeIdsByType(
page: Page,
classTypes: string[]
): Promise<string[]> {
return await page.evaluate((types) => {
const nodes = window.app!.graph.nodes ?? []
return nodes
.filter((node) => {
const n = node as { comfyClass?: string; type?: string }
return types.includes(n.comfyClass ?? n.type ?? '')
})
.map((node) => String(node.id))
}, classTypes)
}
for (const entry of loadManifest()) {
const workflowRelative = `browser_tests/${entry.workflow}`
test.describe(`custom node: ${entry.pack} @custom-nodes`, () => {
test('T0 load: expected nodes register, render in both renderers, and frontend extensions load', async ({
comfyPage
}) => {
test.setTimeout(entry.timeoutMs)
const objectInfo = await target.getObjectInfo(comfyPage.page)
expect(
Object.keys(objectInfo).length,
'object_info sanity floor'
).toBeGreaterThan(OBJECT_INFO_SANITY_FLOOR)
const missing = missingExpectedNodes(objectInfo, entry.expectedNodes)
test.skip(
missing.length > 0,
`${entry.pack} not installed on this backend (missing: ${missing.join(', ')})`
)
await expectNoVisibleErrors(comfyPage.page, 'at startup')
// Backend registration alone does not prove the pack's FRONTEND JS
// loaded: a wrong web dir or a loadExtensions regression leaves nodes
// in object_info while every JS-driven behavior silently vanishes
// (and this suite would then be testing vanilla nodes). Assert the
// pack's boot-registered extensions actually arrived in the browser.
if (entry.expectedExtensions.length > 0) {
const registered = await comfyPage.page.evaluate(() =>
window.app!.extensions.map((extension) => extension.name)
)
for (const name of entry.expectedExtensions)
expect(
registered,
`${entry.pack}: frontend extension "${name}" not registered - pack JS did not load`
).toContain(name)
}
// vueNodesCompatible: false = canvas-only assertions; still runs, no skip.
const rendererPasses = rendererPassesFor(entry)
if (entry.vueNodesCompatible === false)
console.log(
`${entry.pack} declares vueNodesCompatible=false; Vue Nodes pass not applicable`
)
for (const vueNodesEnabled of rendererPasses) {
const consoleErrors = collectConsoleErrors(comfyPage.page)
await comfyPage.settings.setSetting(
'Comfy.VueNodes.Enabled',
vueNodesEnabled
)
await comfyPage.nodeOps.clearGraph()
const addedIds: string[] = []
for (const classType of entry.expectedNodes) {
const node = await comfyPage.nodeOps.addNode(classType)
addedIds.push(String(node.id))
}
await comfyPage.nextFrame()
expect(await comfyPage.nodeOps.getGraphNodesCount()).toBe(
entry.expectedNodes.length
)
// Vue Nodes 2.0 mounts each node as a [data-node-id] element; assert
// the pack's own nodes rendered, not just any node count.
if (vueNodesEnabled)
for (const id of addedIds)
await expect(comfyPage.vueNodes.getNodeLocator(id)).toBeVisible()
consoleErrors.stop()
// T0 loads and renders nodes but queues no prompt; a prompt-execution
// error here is a prior tier's async stray (isForeignExecutionNoise).
expect(
consoleErrors.errors.filter(
(error) => !isForeignExecutionNoise(error)
),
`console errors with VueNodes=${vueNodesEnabled}`
).toEqual([])
await expectNoVisibleErrors(
comfyPage.page,
`after VueNodes=${vueNodesEnabled} pass`
)
}
})
test('T1 run: workflow executes without error', async ({ comfyPage }) => {
test.setTimeout(entry.timeoutMs + 15_000)
const objectInfo = await target.getObjectInfo(comfyPage.page)
const missing = missingExpectedNodes(objectInfo, entry.expectedNodes)
test.skip(
!entry.tiers.includes('run') ||
missing.length > 0 ||
entry.requiresGpu ||
entry.requiresModels.length > 0 ||
!entry.workflow ||
!existsSync(resolve(workflowRelative)),
`run tier unavailable for ${entry.pack}`
)
await expectNoVisibleErrors(comfyPage.page, 'at startup')
// Pack scripts can throw during workflow load or execution without
// any visible error surface; collect console + uncaught page errors
// across the whole run, filtered through the shared pack ledger.
const consoleErrors = collectConsoleErrors(comfyPage.page)
await comfyPage.workflow.loadGraphData(readWorkflow(workflowRelative))
// A drifted fixture that dropped an expected node would silently
// shrink the executed-set assertion (an empty id list PASSes on
// execution_success alone): require every expected type to actually
// be present in the loaded workflow before running it.
const expectedNodeIds: string[] = []
for (const type of entry.expectedNodes) {
const ids = await nodeIdsByType(comfyPage.page, [type])
expect(
ids.length,
`expectedNodes drift: ${type} is not in the curated workflow ${entry.workflow}`
).toBeGreaterThan(0)
expectedNodeIds.push(...ids)
}
const result = await target.runWorkflow(comfyPage.page, {
expectedNodeIds,
timeoutMs: entry.timeoutMs
})
// A run that executed and errored carries an ExecutionError; a run the
// backend rejected before executing (VALIDATION_FAIL) carries only the
// captured node_errors text in clientError - surface whichever exists so
// a red names the cause instead of printing an empty object.
expect(
result.outcome,
result.clientError ?? JSON.stringify(result.error ?? {})
).toBe('PASS')
// PASS proves execution completed; the sinks prove data ARRIVED.
// Every display sink in the curated workflow must have emitted a ui
// payload through its executed event.
const sinkIds = await nodeIdsByType(comfyPage.page, CURATED_SINK_TYPES)
for (const sinkId of sinkIds)
expect(
result.outputsByNode[sinkId],
`sink node ${sinkId} produced no ui payload`
).toBeTruthy()
await expectNoVisibleErrors(comfyPage.page, 'after run')
consoleErrors.stop()
expect(
unallowlistedErrors(entry.pack, consoleErrors.errors),
'console errors during curated run'
).toEqual([])
})
})
}
test('harness self-check: captures a real execution error @custom-nodes', async ({
comfyPage
}) => {
test.setTimeout(30_000)
const objectInfo = await target.getObjectInfo(comfyPage.page)
expect(
Object.keys(objectInfo).length,
'object_info sanity floor'
).toBeGreaterThan(OBJECT_INFO_SANITY_FLOOR)
test.skip(
!('DevToolsErrorRaiseNode' in objectInfo),
'ComfyUI_devtools not installed on this backend'
)
await comfyPage.workflow.loadGraphData(
readWorkflow(assetPath('nodes/execution_error.json'))
)
const result = await target.runWorkflow(comfyPage.page, {
expectedNodeIds: [],
timeoutMs: 15000
})
expect(result.outcome).toBe('EXECUTION_ERROR')
expect(result.error?.exceptionType).toBeTruthy()
// Proves the event tap captures node ids from the live `executing` stream
// (its detail is a bare string): the failing node starts before it raises.
expect(result.executedNodes.length).toBeGreaterThan(0)
// Positive control for the zero-visible-errors invariant: a real execution
// error MUST surface in the app's error overlay. If this fails, the
// expectNoVisibleErrors selectors have rotted and every clean assertion in
// this suite is meaningless.
await expect(errorSurfaces(comfyPage.page).errorOverlay).toBeVisible()
})
test('collector self-check: captures uncaught page exceptions @custom-nodes', async ({
comfyPage
}) => {
// Positive control for the console collector: an uncaught async throw
// never reaches console.error, so this proves the pageerror listener
// works. If this fails, every zero-console-errors assertion in the suite
// is blind to the whole uncaught-exception class.
const collected = collectConsoleErrors(comfyPage.page)
await comfyPage.page.evaluate(() => {
setTimeout(() => {
throw new Error('cn-collector-self-check')
}, 0)
})
await expect
.poll(() =>
collected.errors.some((error) =>
error.includes('cn-collector-self-check')
)
)
.toBe(true)
collected.stop()
})
test('attribution self-check: a foreign-prompt terminal event cannot fail this run @custom-nodes', async ({
comfyPage
}) => {
test.setTimeout(30_000)
const objectInfo = await target.getObjectInfo(comfyPage.page)
test.skip(
!('PrimitiveInt' in objectInfo) || !('PreviewAny' in objectInfo),
'core Primitive/PreviewAny nodes unavailable on this backend'
)
await comfyPage.workflow.loadGraphData(
readWorkflow(assetPath('customNodes/core_primitive_preview_run.json'))
)
// Once the run's event tap starts filling, inject ONE terminal error under
// a prompt id this page never queued. The positive prompt-id filter must
// discard it; the pre-capture harness let the never-seen id through the
// seen-set and misclassified the run as EXECUTION_ERROR. This is the
// discriminating guard for the foreign-attribution bug class.
await comfyPage.page.evaluate(() => {
const w = window as unknown as {
__cnEvents?: object[]
__cnSelfCheckTimer?: ReturnType<typeof setInterval>
}
w.__cnSelfCheckTimer = setInterval(() => {
const sink = w.__cnEvents
if (!sink || sink.length === 0) return
sink.push({
type: 'execution_error',
prompt_id: 'cn-foreign-self-check',
exception_type: 'ForeignError',
node_id: '424242'
})
clearInterval(w.__cnSelfCheckTimer)
}, 25)
})
const result = await target.runWorkflow(comfyPage.page, {
expectedNodeIds: await nodeIdsByType(comfyPage.page, [
'PrimitiveInt',
'PreviewAny'
]),
timeoutMs: 15000
})
// Prove the stimulus actually landed before trusting the PASS: without
// this, a run that finishes before the injector's next tick never injects
// the foreign event, and PASS then holds for the wrong reason (it would
// hold identically against a harness with the prompt-id filter removed).
// Clearing a not-yet-fired timer stops a post-run push from faking it.
const injectionLanded = await comfyPage.page.evaluate(() => {
const w = window as unknown as {
__cnEvents?: { prompt_id?: string }[]
__cnSelfCheckTimer?: ReturnType<typeof setInterval>
}
clearInterval(w.__cnSelfCheckTimer)
return (w.__cnEvents ?? []).some(
(event) => event.prompt_id === 'cn-foreign-self-check'
)
})
expect(
injectionLanded,
'positive control: the foreign terminal event was injected during the run'
).toBe(true)
expect(result.outcome, JSON.stringify(result.error ?? {})).toBe('PASS')
expect(result.error).toBeUndefined()
})

View File

@@ -0,0 +1,295 @@
/* oxlint-disable playwright/no-skipped-test -- skips only when the target backend lacks the pack; environment gating, not a disabled test */
import type { Page } from '@playwright/test'
import {
comfyExpect as expect,
comfyPageFixture as test
} from '@e2e/fixtures/ComfyPage'
import { LocalDesktopTarget } from '@e2e/fixtures/customNode/ComfyTarget'
import { isForeignExecutionNoise } from '@e2e/fixtures/customNode/consoleErrorLedger'
import { missingExpectedNodes } from '@e2e/fixtures/customNode/objectInfoValidator'
import { collectConsoleErrors } from '@e2e/fixtures/utils/consoleErrorCollector'
import {
loadManifest,
rendererPassesFor
} from '@e2e/fixtures/customNode/manifest'
import {
customNodeSuiteSettings,
dismissTemplatesDialog
} from '@e2e/fixtures/utils/customNodeSuite'
import { errorSurfaces } from '@e2e/fixtures/utils/errorSurfaces'
// Dynamic-input (autogrow) tier: packs whose JS adds an input slot when the
// last one is connected and removes trailing empties on disconnect. That
// behavior lives in pack JS (onConnectionsChange overrides), NOT in
// /object_info - the def declares only the initial slot, so the mount and
// connectivity tiers are structurally blind to it. This tier asserts the
// BEHAVIOR: connect -> the node grows; disconnect -> it shrinks back.
//
// Both connect paths run on purpose: the drag path and the programmatic
// path go through different frontend pipelines (pointer -> hit-test ->
// LinkConnector vs a direct node.connect), and Impact's handler inspects
// `new Error().stack` (on its disconnect/removal branch), so the two paths
// can break independently. Both renderers run because a Vue reactivity gap
// can grow the graph-side array without rendering the new slot row.
//
// One curated node per mechanism: every Impact autogrow node shares one
// onConnectionsChange block, so a second node of the same mechanism adds
// runtime, not detection. ImpactMakeImageList is the IMAGE-typed member,
// wireable from the model-free EmptyImage.
//
// Disconnect runs single-path (programmatic disconnectInput) on purpose: the
// pack contract under test fires on the disconnect EVENT regardless of how
// the link was severed, and the suite has no generic drag-detach vocabulary
// (drag-detach pointer mechanics are core-interaction territory).
const AUTOGROW_CASES = [
{
pack: 'ComfyUI-Impact-Pack',
consumerType: 'ImpactMakeImageList',
producerType: 'EmptyImage',
producerSlot: 'IMAGE'
}
]
const target = new LocalDesktopTarget()
test.use({ initialSettings: customNodeSuiteSettings })
test.beforeEach(async ({ comfyPage }) => {
await dismissTemplatesDialog(comfyPage)
})
async function consumerShape(
page: Page,
consumerId: string
): Promise<{ inputCount: number; domSlotDots: number }> {
return await page.evaluate((id) => {
const node = window.app!.graph.nodes.find(
(candidate) => String(candidate.id) === id
)
const root = document.querySelector(`[data-node-id="${id}"]`)
return {
inputCount: node?.inputs?.length ?? -1,
domSlotDots:
root?.querySelectorAll('[data-testid="slot-connection-dot"]').length ??
-1
}
}, consumerId)
}
for (const autogrowCase of AUTOGROW_CASES) {
test.describe(`dynamic inputs: ${autogrowCase.pack} @custom-nodes`, () => {
test(`${autogrowCase.consumerType} grows on connect and shrinks on disconnect (drag + programmatic, both renderers)`, async ({
comfyPage
}) => {
test.setTimeout(120_000)
const objectInfo = await target.getObjectInfo(comfyPage.page)
expect(
Object.keys(objectInfo).length,
'object_info sanity floor'
).toBeGreaterThan(50)
const missing = missingExpectedNodes(objectInfo, [
autogrowCase.consumerType,
autogrowCase.producerType
])
test.skip(
missing.length > 0,
`${autogrowCase.pack} not installed on this backend (missing: ${missing.join(', ')})`
)
// The pack row owns renderer compatibility (vueNodesCompatible), so a
// pack that ever declares itself Vue-incompatible keeps its canvas
// coverage here instead of failing the Vue pass. Also validates the
// curated pack label against the manifest.
const manifestEntry = loadManifest().find(
(entry) => entry.pack === autogrowCase.pack
)
expect(
manifestEntry,
`${autogrowCase.pack} is not a manifest pack - fix AUTOGROW_CASES`
).toBeDefined()
for (const vueNodesEnabled of rendererPassesFor(manifestEntry!)) {
const consoleErrors = collectConsoleErrors(comfyPage.page)
await comfyPage.settings.setSetting(
'Comfy.VueNodes.Enabled',
vueNodesEnabled
)
for (const connectPath of ['drag', 'programmatic'] as const) {
const context = `${autogrowCase.consumerType} via ${connectPath} with VueNodes=${vueNodesEnabled}`
await comfyPage.nodeOps.clearGraph()
const producer = await comfyPage.nodeOps.addNode(
autogrowCase.producerType,
undefined,
{ x: 150, y: 200 }
)
const consumer = await comfyPage.nodeOps.addNode(
autogrowCase.consumerType,
undefined,
{ x: 700, y: 200 }
)
await comfyPage.nextFrame()
const consumerId = String(consumer.id)
// The DOM baseline below is a one-shot census, so the Vue nodes
// must be MOUNTED first or it captures a mid-mount undercount and
// the +1 growth poll chases a wrong absolute target.
if (vueNodesEnabled) {
await comfyPage.vueNodes.waitForNodes(2)
// Input 0 exists for every autogrow case; one visible dot proves
// the slot rows mounted, so the census below reads settled DOM.
await expect(
comfyPage.vueNodes.getInputSlotConnectionDot(consumerId, 0),
`${context}: consumer slot dots mounted before baseline`
).toBeVisible()
}
const before = await consumerShape(comfyPage.page, consumerId)
expect(
before.inputCount,
`${context}: consumer instantiates with at least one input`
).toBeGreaterThan(0)
const lastIndex = before.inputCount - 1
const outIndex = await comfyPage.page.evaluate(
([producerId, slotName]) => {
const node = window.app!.graph.nodes.find(
(candidate) => String(candidate.id) === producerId
)!
return node.outputs.findIndex((slot) => slot.name === slotName)
},
[String(producer.id), autogrowCase.producerSlot] as const
)
expect(
outIndex,
`${context}: producer slot on instance`
).toBeGreaterThan(-1)
if (connectPath === 'drag') {
if (vueNodesEnabled) {
const outDot = comfyPage.vueNodes.getOutputSlotConnectionDot(
String(producer.id),
outIndex
)
const inDot = comfyPage.vueNodes.getInputSlotConnectionDot(
consumerId,
lastIndex
)
await outDot.dragTo(inDot)
} else {
await producer.connectOutput(outIndex, consumer, lastIndex)
}
} else {
await comfyPage.page.evaluate(
([producerId, consumerId, out, input]) => {
const byId = (id: string) =>
window.app!.graph.nodes.find(
(node) => String(node.id) === id
)!
byId(producerId).connect(
Number(out),
byId(consumerId),
Number(input)
)
},
[
String(producer.id),
consumerId,
String(outIndex),
String(lastIndex)
] as const
)
}
await comfyPage.nextFrame()
// The link itself must land on the LAST input: stricter than the
// handler needs (it grows on any connect), but a drag that falls
// back to an earlier slot is a hit-test regression this tier
// should surface, not silently absorb.
await expect
.poll(
() =>
comfyPage.page.evaluate(
([id, index]) => {
const node = window.app!.graph.nodes.find(
(candidate) => String(candidate.id) === id
)
return node?.inputs?.[Number(index)]?.link != null
},
[consumerId, String(lastIndex)] as const
),
{ message: `${context}: link lands on the last input` }
)
.toBe(true)
// The behavior under test: the pack's JS appends a fresh input.
await expect
.poll(
async () =>
(await consumerShape(comfyPage.page, consumerId)).inputCount,
{ message: `${context}: input count grows by one on connect` }
)
.toBe(before.inputCount + 1)
// Rendered growth: the new input must also EXIST as a slot row.
// Graph-side growth without a rendered row is the Vue reactivity
// gap the CombineRegionalPrompts incident exposed.
if (vueNodesEnabled)
await expect
.poll(
async () =>
(await consumerShape(comfyPage.page, consumerId)).domSlotDots,
{ message: `${context}: grown input renders a slot dot` }
)
.toBe(before.domSlotDots + 1)
await comfyPage.page.evaluate(
([id, index]) => {
const node = window.app!.graph.nodes.find(
(candidate) => String(candidate.id) === id
)!
node.disconnectInput(Number(index))
},
[consumerId, String(lastIndex)] as const
)
await comfyPage.nextFrame()
await expect
.poll(
async () =>
(await consumerShape(comfyPage.page, consumerId)).inputCount,
{
message: `${context}: trailing empty input removed on disconnect`
}
)
.toBe(before.inputCount)
// Symmetric rendered-shrink assert: the reactivity gap applies to
// slot removal too - a stale rendered row after disconnect would
// otherwise pass.
if (vueNodesEnabled)
await expect
.poll(
async () =>
(await consumerShape(comfyPage.page, consumerId)).domSlotDots,
{ message: `${context}: removed input's slot dot unrenders` }
)
.toBe(before.domSlotDots)
}
consoleErrors.stop()
expect(
consoleErrors.errors.filter(
(error) => !isForeignExecutionNoise(error)
),
`console errors with VueNodes=${vueNodesEnabled}`
).toEqual([])
for (const [surface, locator] of Object.entries(
errorSurfaces(comfyPage.page)
))
await expect(
locator,
`after VueNodes=${vueNodesEnabled} pass: ${surface}`
).toHaveCount(0)
}
})
})
}

View File

@@ -0,0 +1,101 @@
import {
comfyExpect as expect,
comfyPageFixture as test
} from '@e2e/fixtures/ComfyPage'
import type { CustomNodeManifestEntry } from '@e2e/fixtures/customNode/manifest'
import {
assertEntry,
loadManifest,
rendererPassesFor
} from '@e2e/fixtures/customNode/manifest'
function validEntry(): CustomNodeManifestEntry {
return {
pack: 'Example-Pack',
repo: 'https://github.com/example/Example-Pack',
pin: 'a1'.repeat(20),
tiers: ['load', 'connectivity', 'run'],
workflow: 'assets/customNodes/example_run.json',
expectedNodes: ['ExampleNode'],
expectedExtensions: ['Example.Extension'],
requiresGpu: false,
requiresModels: [],
timeoutMs: 60_000
}
}
test.describe('customNode manifest', () => {
test('loads entries with the shape the regression spec depends on', () => {
const entries = loadManifest()
expect(entries.length).toBeGreaterThan(0)
for (const entry of entries) {
expect(entry.pack).toBeTruthy()
expect(entry.expectedNodes.length).toBeGreaterThan(0)
expect(entry.tiers.length).toBeGreaterThan(0)
}
})
test('rendererPassesFor drops only the Vue pass, only on an explicit false', () => {
expect(rendererPassesFor({})).toEqual([false, true])
expect(rendererPassesFor({ vueNodesCompatible: true })).toEqual([
false,
true
])
expect(rendererPassesFor({ vueNodesCompatible: false })).toEqual([false])
})
test('pin must be a full commit SHA; only the canary override admits an empty one', () => {
// Deterministic regardless of ambient env (a canary environment sets
// the override): pin the var for the test, restore the prior value.
const prior = process.env.CUSTOM_NODES_ALLOW_UNPINNED
delete process.env.CUSTOM_NODES_ALLOW_UNPINNED
try {
expect(() => assertEntry(validEntry(), 0)).not.toThrow()
expect(() => assertEntry({ ...validEntry(), pin: '' }, 0)).toThrow(/pin/)
expect(() => assertEntry({ ...validEntry(), pin: 'abc123' }, 0)).toThrow(
/pin/
)
process.env.CUSTOM_NODES_ALLOW_UNPINNED = '1'
expect(() => assertEntry({ ...validEntry(), pin: '' }, 0)).not.toThrow()
// the override admits only EMPTY pins; a malformed pin still fails
expect(() => assertEntry({ ...validEntry(), pin: 'abc123' }, 0)).toThrow(
/pin/
)
} finally {
if (prior === undefined) delete process.env.CUSTOM_NODES_ALLOW_UNPINNED
else process.env.CUSTOM_NODES_ALLOW_UNPINNED = prior
}
})
test('expectedExtensions is required; empty only as an explicit no-frontend-JS declaration', () => {
// Omission must fail (a new pack row cannot silently opt out of the
// extension-loaded assert); an explicit [] is the deliberate opt-out.
const { expectedExtensions: _omitted, ...withoutField } = validEntry()
expect(() =>
assertEntry(withoutField as CustomNodeManifestEntry, 0)
).toThrow(/expectedExtensions/)
expect(() =>
assertEntry({ ...validEntry(), expectedExtensions: [] }, 0)
).not.toThrow()
expect(() =>
assertEntry({ ...validEntry(), expectedExtensions: [''] }, 0)
).toThrow(/expectedExtensions/)
expect(() =>
assertEntry(
{ ...validEntry(), expectedExtensions: [42 as unknown as string] },
0
)
).toThrow(/expectedExtensions/)
expect(() =>
assertEntry({ ...validEntry(), expectedExtensions: ['A', 'A'] }, 0)
).toThrow(/expectedExtensions/)
})
test('pack must be a plain path segment (it becomes the install dirname)', () => {
for (const bad of ['../escape', 'a/b', '.hidden', 'sp ace', ''])
expect(
() => assertEntry({ ...validEntry(), pack: bad }, 0),
`pack '${bad}' must be rejected`
).toThrow(/pack/)
})
})

View File

@@ -0,0 +1,22 @@
import {
comfyExpect as expect,
comfyPageFixture as test
} from '@e2e/fixtures/ComfyPage'
import type { ObjectInfo } from '@e2e/fixtures/customNode/objectInfoValidator'
import { missingExpectedNodes } from '@e2e/fixtures/customNode/objectInfoValidator'
const objectInfo: ObjectInfo = {
KSampler: { input: { required: { model: {}, seed: {} } } }
}
test.describe('objectInfoValidator', () => {
test('missingExpectedNodes returns only the names absent from object_info', () => {
expect(
missingExpectedNodes(objectInfo, ['KSampler', 'Missing (rgthree)'])
).toEqual(['Missing (rgthree)'])
})
test('missingExpectedNodes returns empty when every expected node is registered', () => {
expect(missingExpectedNodes(objectInfo, ['KSampler'])).toEqual([])
})
})

View File

@@ -0,0 +1,51 @@
import {
comfyExpect as expect,
comfyPageFixture as test
} from '@e2e/fixtures/ComfyPage'
import { summarizePromptError } from '@e2e/fixtures/customNode/ComfyTarget'
// The curated-run happy path never executes summarizePromptError (it only
// runs on a VALIDATION_FAIL), so these cases are what keep a T1 rejection
// naming the node+input instead of rotting back to `{}`.
test.describe('summarizePromptError', () => {
test('names the node class and the failing input from node_errors', () => {
const body = {
error: { type: 'prompt_outputs_failed_validation', message: 'failed' },
node_errors: {
'7': {
class_type: 'ImpactInt',
errors: [
{ type: 'value_not_in_list', message: 'msg', details: 'value' }
],
dependent_outputs: []
}
}
}
expect(summarizePromptError(body)).toBe('failed; ImpactInt: value')
})
test('accepts a string top-level error', () => {
expect(summarizePromptError({ error: 'bad request' })).toBe('bad request')
})
test('falls back to the node message when details is empty', () => {
const body = {
node_errors: {
'3': {
class_type: 'KSampler',
errors: [
{ type: 'x', message: 'required input missing', details: '' }
],
dependent_outputs: []
}
}
}
expect(summarizePromptError(body)).toBe('KSampler: required input missing')
})
test('returns undefined for an empty or non-object body', () => {
expect(summarizePromptError({})).toBeUndefined()
expect(summarizePromptError(null)).toBeUndefined()
expect(summarizePromptError('not an object')).toBeUndefined()
})
})

View File

@@ -0,0 +1,71 @@
import {
comfyExpect as expect,
comfyPageFixture as test
} from '@e2e/fixtures/ComfyPage'
import { classifyRun } from '@e2e/fixtures/customNode/runResult'
test.describe('classifyRun', () => {
test('PASS when every expected node appears in the executing stream', () => {
const result = classifyRun({
events: [
{ type: 'execution_start' },
{ type: 'executing', node: '1' },
{ type: 'executing', node: '2' },
{ type: 'executing', node: null },
{ type: 'execution_success' }
],
expectedNodeIds: ['1', '2']
})
expect(result.outcome).toBe('PASS')
expect(result.executedNodes).toEqual(['1', '2'])
})
test('PARTIAL when a succeeding run replays a cached node that never emitted executing', () => {
const result = classifyRun({
events: [{ type: 'executing', node: '1' }, { type: 'execution_success' }],
expectedNodeIds: ['1', '2']
})
expect(result.outcome).toBe('PARTIAL')
expect(result.executedNodes).toEqual(['1'])
})
test('EXECUTION_ERROR captures the failing node details', () => {
const result = classifyRun({
events: [
{ type: 'executing', node: '1' },
{
type: 'execution_error',
error: { exceptionType: 'ValueError', nodeId: '1' }
}
],
expectedNodeIds: ['1']
})
expect(result.outcome).toBe('EXECUTION_ERROR')
expect(result.error?.exceptionType).toBe('ValueError')
})
test('EXECUTION_ERROR when the run is interrupted', () => {
const result = classifyRun({
events: [
{ type: 'executing', node: '1' },
{ type: 'execution_interrupted' }
],
expectedNodeIds: ['1']
})
expect(result.outcome).toBe('EXECUTION_ERROR')
})
test('TIMEOUT when flagged or when no terminal event arrived', () => {
const flagged = classifyRun({
events: [{ type: 'executing', node: '1' }],
expectedNodeIds: ['1'],
timedOut: true
})
const noTerminal = classifyRun({
events: [{ type: 'executing', node: '1' }],
expectedNodeIds: ['1']
})
expect(flagged.outcome).toBe('TIMEOUT')
expect(noTerminal.outcome).toBe('TIMEOUT')
})
})

View File

@@ -0,0 +1,270 @@
import {
comfyExpect as expect,
comfyPageFixture as test
} from '@e2e/fixtures/ComfyPage'
import type { RawNodeDef } from '@e2e/fixtures/customNode/typePairing'
import {
isTypeCompatible,
normalizeNodeDefs,
packOf,
planPairs
} from '@e2e/fixtures/customNode/typePairing'
const DEFS: Record<string, RawNodeDef> = {
LatentSource: {
input: { required: {} },
output: ['LATENT'],
output_name: ['LATENT'],
python_module: 'nodes'
},
LatentSink: {
input: { required: { latent: ['LATENT', {}] } },
output: [],
python_module: 'custom_nodes.SomePack'
},
UnionSource: {
input: { required: {} },
output: ['STRING,INT'],
output_name: ['value'],
python_module: 'nodes'
},
IntSink: {
input: { required: { value: ['int', {}] } },
output: [],
python_module: 'nodes'
},
ComboNode: {
input: { required: { choice: [['a', 'b'], {}] } },
output: [],
python_module: 'nodes'
},
SocketlessNode: {
input: { required: { hidden: ['STRING', { socketless: true }] } },
output: [],
python_module: 'nodes'
},
WildcardNode: {
input: { required: { anything: ['*', {}] } },
output: ['*'],
output_name: ['out'],
python_module: 'nodes'
},
OrphanNode: {
input: { required: {} },
output: ['NOBODY_CONSUMES_THIS'],
output_name: ['orphan'],
python_module: 'custom_nodes.OrphanPack'
}
}
test.describe('typePairing', () => {
test('isTypeCompatible mirrors the real validator semantics', () => {
expect(isTypeCompatible('LATENT', 'LATENT')).toBe(true)
expect(isTypeCompatible('latent', 'LATENT')).toBe(true)
expect(isTypeCompatible('LATENT', 'IMAGE')).toBe(false)
expect(isTypeCompatible('STRING,INT', 'INT')).toBe(true)
expect(isTypeCompatible('STRING,INT', 'FLOAT')).toBe(false)
expect(isTypeCompatible('*', 'ANYTHING')).toBe(true)
expect(isTypeCompatible('', 'ANYTHING')).toBe(true)
})
test('packOf attributes core vs custom pack', () => {
expect(packOf('nodes')).toBe('core')
expect(packOf('comfy_extras.nodes_x')).toBe('core')
expect(packOf('custom_nodes.ComfyUI-Impact-Pack')).toBe(
'ComfyUI-Impact-Pack'
)
expect(packOf(undefined)).toBe('core')
})
test('normalize maps COMBO literals and drops socketless inputs', () => {
const nodes = normalizeNodeDefs(DEFS)
const combo = nodes.find((n) => n.type === 'ComboNode')!
expect(combo.inputs).toEqual([
{ name: 'choice', type: 'COMBO', comboOptions: ['a', 'b'] }
])
const socketless = nodes.find((n) => n.type === 'SocketlessNode')!
expect(socketless.inputs).toEqual([])
// socketless is a recognized shape deliberately left out of the matrix;
// it must never be recorded as an unknown slot.
expect(socketless.unknownSlots).toBeUndefined()
})
test('unrecognizable slot specs are recorded, never silently dropped', () => {
// A numeric input type and a numeric output type have no connectable
// socket type (slotTypeOf null): the slot leaves the corpus, but the
// drop must surface on the node and in the plan.
const nodes = normalizeNodeDefs({
WeirdNode: {
input: { required: { strange: [42, {}], ok: ['INT', {}] } },
output: [7, 'INT'],
python_module: 'custom_nodes.weird-pack'
}
})
const weird = nodes.find((n) => n.type === 'WeirdNode')!
expect(weird.unknownSlots).toEqual(['strange', 'output[0]'])
expect(weird.inputs.map((s) => s.name)).toEqual(['ok'])
const plan = planPairs(nodes, ['WeirdNode'])
expect(plan.unknownShapes).toEqual([
'WeirdNode.strange',
'WeirdNode.output[0]'
])
})
test('planPairs pairs exact and union types, deterministically', () => {
const nodes = normalizeNodeDefs(DEFS)
const plan = planPairs(nodes, ['LatentSink', 'IntSink'])
const keys = plan.pairs.map(
(p) =>
`${p.producer.nodeType}.${p.producer.slotName}->${p.consumer.nodeType}.${p.consumer.slotName}`
)
expect(keys).toContain('LatentSource.LATENT->LatentSink.latent')
expect(keys).toContain('UnionSource.value->IntSink.value')
const again = planPairs(nodes, ['LatentSink', 'IntSink'])
expect(again.pairs).toEqual(plan.pairs)
// The DEFS corpus is fully recognizable; unknownShapes stays empty.
expect(plan.unknownShapes).toEqual([])
})
test('COMBO slots with different vocabularies stay excluded', () => {
const nodes = normalizeNodeDefs({
ComboSource: {
input: { required: {} },
output: [['A', 'B', 'C']],
output_name: [['A', 'B', 'C'] as unknown as string],
python_module: 'nodes'
},
...DEFS
})
const source = nodes.find((n) => n.type === 'ComboSource')!
expect(source.outputs).toEqual([
{ name: 'COMBO', type: 'COMBO', comboOptions: ['A', 'B', 'C'] }
])
// ComboNode.choice offers [a, b] - not the same vocabulary as [A, B, C].
const plan = planPairs(nodes, ['ComboSource', 'ComboNode'])
expect(plan.pairs).toEqual([])
expect(plan.combos.map((s) => `${s.nodeType}.${s.slotName}`)).toEqual([
'ComboSource.COMBO',
'ComboNode.choice'
])
})
test('COMBO slots with an identical vocabulary pair up', () => {
const nodes = normalizeNodeDefs({
SamplerNameSource: {
input: { required: {} },
output: [['euler', 'ddim']],
output_name: [['euler', 'ddim'] as unknown as string],
python_module: 'nodes'
},
SamplerNameSink: {
input: { required: { sampler_name: [['euler', 'ddim'], {}] } },
output: [],
python_module: 'nodes'
},
...DEFS
})
const plan = planPairs(nodes, ['SamplerNameSource', 'SamplerNameSink'])
expect(
plan.pairs.map(
(p) =>
`${p.producer.nodeType}.${p.producer.slotName}->${p.consumer.nodeType}.${p.consumer.slotName}`
)
).toEqual(['SamplerNameSource.COMBO->SamplerNameSink.sampler_name'])
expect(plan.combos).toEqual([])
})
// Census-derived: transformed (V2-schema) defs carry combo inputs as the
// string 'COMBO' with options in the opts object. Same vocabulary must
// pair across forms, and a combo with no static options (remote/lazy)
// must never blind-match.
test('V2-form combos pair across forms by vocabulary; unknown options never pair', () => {
const nodes = normalizeNodeDefs({
ListFormSource: {
input: { required: {} },
output: [['x', 'y']],
output_name: [['x', 'y'] as unknown as string],
python_module: 'nodes'
},
V2FormSink: {
input: {
required: {
dim: ['COMBO', { multiselect: false, options: ['y', 'x'] }]
}
},
output: [],
python_module: 'nodes'
},
RemoteComboSink: {
input: {
required: {
image: ['COMBO', { remote: { route: '/internal/files/output' } }]
}
},
output: [],
python_module: 'nodes'
},
...DEFS
})
const plan = planPairs(nodes, [
'ListFormSource',
'V2FormSink',
'RemoteComboSink'
])
expect(
plan.pairs.map(
(p) =>
`${p.producer.nodeType}.${p.producer.slotName}->${p.consumer.nodeType}.${p.consumer.slotName}`
)
).toEqual(['ListFormSource.COMBO->V2FormSink.dim'])
expect(plan.combos.map((s) => `${s.nodeType}.${s.slotName}`)).toEqual([
'RemoteComboSink.image'
])
})
test('COMBO vocabulary matching ignores option order', () => {
// A wired input bypasses its own widget, so menu order and the
// options[0] default are not part of the wire contract - membership is.
const nodes = normalizeNodeDefs({
ShuffledSource: {
input: { required: {} },
output: [['ddim', 'euler']],
output_name: [['ddim', 'euler'] as unknown as string],
python_module: 'nodes'
},
SamplerNameSink: {
input: { required: { sampler_name: [['euler', 'ddim'], {}] } },
output: [],
python_module: 'nodes'
},
...DEFS
})
const plan = planPairs(nodes, ['ShuffledSource', 'SamplerNameSink'])
expect(
plan.pairs.map(
(p) =>
`${p.producer.nodeType}.${p.producer.slotName}->${p.consumer.nodeType}.${p.consumer.slotName}`
)
).toEqual(['ShuffledSource.COMBO->SamplerNameSink.sampler_name'])
expect(plan.combos).toEqual([])
})
test('wildcard slots are excluded, orphan types recorded not failed', () => {
const nodes = normalizeNodeDefs(DEFS)
const plan = planPairs(nodes, ['WildcardNode', 'OrphanNode'])
expect(plan.wildcards.map((w) => w.nodeType)).toEqual([
'WildcardNode',
'WildcardNode'
])
expect(plan.orphans).toEqual([
{
nodeType: 'OrphanNode',
pack: 'OrphanPack',
slotName: 'orphan',
slotType: 'NOBODY_CONSUMES_THIS',
dir: 'out'
}
])
expect(plan.pairs).toEqual([])
})
})

View File

@@ -205,27 +205,30 @@ test.describe('Credits tile (Plan & Credits)', { tag: '@cloud' }, () => {
await expect(content.getByText('Total credits')).toBeVisible()
await expect(content.getByText('12,660')).toBeVisible()
// Monthly usage bar header + used / left-of-total labels.
await expect(content.getByText('Monthly', { exact: true })).toBeVisible()
await expect(content.getByText('50% used')).toBeVisible()
await expect(content.getByText(/Refills Feb/)).toBeVisible()
await expect(content.getByText('10,550 used')).toBeVisible()
await expect(content.getByText('10,550 left of 21,100')).toBeVisible()
// Additional credits row + subtitle.
await expect(content.getByText('Additional credits')).toBeVisible()
await expect(content.getByText('2,110')).toBeVisible()
await expect(
content.getByText('Used after plan credits run out')
).toBeVisible()
await expect(content.getByText('Used after monthly runs out')).toBeVisible()
// Permission-gated add-credits action (personal owner can top up).
await expect(
content.getByRole('button', { name: 'Add credits' })
).toBeVisible()
// Narrow container (DES-247 responsive variants): drop the used/remaining
// labels and the breakdown subtitle, compact the monthly summary numbers.
await page.setViewportSize({ width: 360, height: 800 })
await expect(content.getByText('10,550 used')).toBeHidden()
await expect(content.getByText('remaining', { exact: true })).toBeHidden()
await expect(
content.getByText('Used after plan credits run out')
).toBeHidden()
await expect(content.getByText('50% used')).toBeVisible()
await expect(content.getByText('Used after monthly runs out')).toBeHidden()
await expect(content.getByText('10,550 left of 21,100')).toBeHidden()
await expect(content.getByText('11K left of 21K')).toBeVisible()
})
test('renders the depleted-credit empty states', async ({ page }) => {
@@ -237,17 +240,27 @@ test.describe('Credits tile (Plan & Credits)', { tag: '@cloud' }, () => {
const content = await openPlanAndCredits(page)
await expect(content.getByText('100% used')).toBeVisible()
await expect(content.getByText('In use')).toBeVisible()
// 0-monthly state: depletion notice + IN USE badge on additional credits.
await expect(
content.getByText('2,110', { exact: true }).last()
content.getByText('Monthly credits are used up. Refills Feb 20')
).toBeVisible()
await expect(
content.getByText("You're now spending additional credits.")
).toBeVisible()
await expect(content.getByText('In use')).toBeVisible()
await expect(content.getByText('0 left of 21,100')).toBeVisible()
// Drain the remaining additional credits and refresh the tile: the
// out-of-credits notice takes over and the badge drops.
await mockBalance(page, { amount: 0, monthly: 0, prepaid: 0 })
await content.getByRole('button', { name: 'Refresh credits' }).click()
await expect(content.getByText('0', { exact: true }).first()).toBeVisible()
await expect(content.getByText('100% used')).toBeVisible()
await expect(
content.getByText("You're out of credits. Credits refill Feb 20")
).toBeVisible()
await expect(
content.getByText('Add more credits to continue generating.')
).toBeVisible()
await expect(content.getByText('In use')).toBeHidden()
await expect(
content.getByRole('button', { name: 'Add credits' })

View File

@@ -22,7 +22,7 @@ import { CloudWorkspaceMockHelper } from '@e2e/fixtures/helpers/CloudWorkspaceMo
* The viewer is a promoted owner (not the workspace creator), so the spec can
* distinguish the creator guard from the self guard: the creator row and the
* viewer's own row hide the row menu, every other row exposes
* "Change role " (Admin / Member) plus "Remove member". Promoting a member
* "Change role " (Owner / Member) plus "Remove member". Promoting a member
* sends PATCH /api/workspace/members/:id {role}, flips the Role column,
* re-sorts the row under the creator, and the promoted owner stays demotable.
*/
@@ -44,15 +44,13 @@ async function openMembersTab(page: Page): Promise<Locator> {
const content = dialog.getByRole('main')
await content.getByRole('tab', { name: /Members/ }).click()
await expect(
content.getByRole('tabpanel', { name: 'Members (4)' }).getByRole('table')
).toBeVisible()
await expect(content.getByText('4 of 30 members')).toBeVisible()
return content
}
function memberRow(content: Locator, email: string): Locator {
return content
.getByRole('row')
.locator('div.grid')
.filter({ has: content.page().getByText(email, { exact: true }) })
}
@@ -68,7 +66,7 @@ async function openChangeRoleSubmenu(page: Page) {
await expect(trigger).toBeVisible()
await trigger.press('ArrowRight')
await expect(
page.getByRole('menuitemradio', { name: 'Admin', exact: true })
page.getByRole('menuitemradio', { name: 'Owner', exact: true })
).toBeVisible()
}
@@ -113,14 +111,14 @@ test.describe('Member role change (Members tab)', { tag: '@cloud' }, () => {
page.getByRole('menuitemradio', { name: 'Member', exact: true })
).toHaveAttribute('aria-checked', 'true')
await expect(
page.getByRole('menuitemradio', { name: 'Admin', exact: true })
page.getByRole('menuitemradio', { name: 'Owner', exact: true })
).toHaveAttribute('aria-checked', 'false')
await page
.getByRole('menuitemradio', { name: 'Member', exact: true })
.press('Enter')
.click()
await expect(page.getByRole('heading', { name: /an admin\?/ })).toHaveCount(
await expect(page.getByRole('heading', { name: /an owner\?/ })).toHaveCount(
0
)
expect(state.patches).toHaveLength(0)
@@ -136,11 +134,11 @@ test.describe('Member role change (Members tab)', { tag: '@cloud' }, () => {
await menuButton(janeRow).click()
await openChangeRoleSubmenu(page)
await page
.getByRole('menuitemradio', { name: 'Admin', exact: true })
.press('Enter')
.getByRole('menuitemradio', { name: 'Owner', exact: true })
.click()
await expect(
page.getByRole('heading', { name: 'Make Jane an admin?' })
page.getByRole('heading', { name: 'Make Jane an owner?' })
).toBeVisible()
await expect(page.getByText("They'll be able to:")).toBeVisible()
await expect(page.getByText('Add additional credits')).toBeVisible()
@@ -149,7 +147,7 @@ test.describe('Member role change (Members tab)', { tag: '@cloud' }, () => {
).toBeVisible()
await expect(
page.getByText(
'Promote and demote other admins (except the workspace creator).'
'Promote and demote other owners (except the workspace creator).'
)
).toBeVisible()
@@ -179,12 +177,12 @@ test.describe('Member role change (Members tab)', { tag: '@cloud' }, () => {
await menuButton(janeRow).click()
await openChangeRoleSubmenu(page)
await page
.getByRole('menuitemradio', { name: 'Admin', exact: true })
.press('Enter')
await page.getByRole('button', { name: 'Make admin' }).click()
.getByRole('menuitemradio', { name: 'Owner', exact: true })
.click()
await page.getByRole('button', { name: 'Make owner' }).click()
await expect(page.getByText('Role updated')).toBeVisible()
await expect(janeRow.getByText('Admin', { exact: true })).toBeVisible()
await expect(janeRow.getByText('Owner', { exact: true })).toBeVisible()
await expect(emails).toHaveText([
CREATOR.email,
VIEWER.email,
@@ -213,13 +211,13 @@ test.describe('Member role change (Members tab)', { tag: '@cloud' }, () => {
const content = await openMembersTab(page)
const janeRow = memberRow(content, MEMBER_JANE.email)
await expect(janeRow.getByText('Admin', { exact: true })).toBeVisible()
await expect(janeRow.getByText('Owner', { exact: true })).toBeVisible()
await menuButton(janeRow).click()
await openChangeRoleSubmenu(page)
await page
.getByRole('menuitemradio', { name: 'Member', exact: true })
.press('Enter')
.click()
await expect(
page.getByRole('heading', { name: 'Demote Jane to member?' })
).toBeVisible()
@@ -251,14 +249,14 @@ test.describe('Member role change (Members tab)', { tag: '@cloud' }, () => {
await menuButton(janeRow).click()
await openChangeRoleSubmenu(page)
await page
.getByRole('menuitemradio', { name: 'Admin', exact: true })
.press('Enter')
await page.getByRole('button', { name: 'Make admin' }).click()
.getByRole('menuitemradio', { name: 'Owner', exact: true })
.click()
await page.getByRole('button', { name: 'Make owner' }).click()
// US10 — error toast, dialog stays open, role unchanged.
await expect(page.getByText('Failed to update role')).toBeVisible()
await expect(
page.getByRole('heading', { name: 'Make Jane an admin?' })
page.getByRole('heading', { name: 'Make Jane an owner?' })
).toBeVisible()
await page.getByRole('button', { name: 'Cancel', exact: true }).click()
await expect(janeRow.getByText('Member', { exact: true })).toBeVisible()

Binary file not shown.

Before

Width:  |  Height:  |  Size: 21 KiB

After

Width:  |  Height:  |  Size: 21 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 53 KiB

After

Width:  |  Height:  |  Size: 53 KiB

View File

@@ -276,3 +276,255 @@ test.describe('FE-130 assets sidebar route mocks', () => {
)
})
})
test.describe('FE-910 marquee selection and select all', () => {
test.beforeEach(async ({ jobsRoutes, page, comfyPage }) => {
await jobsRoutes.mockJobsQueue([])
await jobsRoutes.mockJobsHistory(generatedJobs)
await mockInputFiles(page, ['imported.png'])
await mockViewFiles(page, viewFiles)
await comfyPage.setup()
await comfyPage.menu.assetsTab.open()
})
test('Ctrl/Cmd+A selects every asset while the panel is hovered', async ({
comfyPage
}) => {
const tab = comfyPage.menu.assetsTab
await expect(tab.assetCards).toHaveCount(2)
await tab.getAssetCardByName('alpha').hover()
await comfyPage.page.keyboard.press('ControlOrMeta+a')
await expect(tab.selectedCards).toHaveCount(2)
})
test('a marquee that begins in the panel header selects the cards', async ({
comfyPage
}) => {
const tab = comfyPage.menu.assetsTab
const { page } = comfyPage
await expect(tab.assetCards).toHaveCount(2)
await expect(tab.selectedCards).toHaveCount(0)
const header = await tab.panelHeader.boundingBox()
const beta = await tab.getAssetCardByName('beta').boundingBox()
if (!header || !beta) {
throw new Error('panel header or asset card has no layout box')
}
// Begin the rubber-band in the header (above the grid), then drag down
// across both cards.
await page.mouse.move(header.x + 24, header.y + 20)
await page.mouse.down()
await page.mouse.move(beta.x + 8, beta.y + beta.height - 8, { steps: 14 })
await page.mouse.up()
await expect(tab.selectedCards).toHaveCount(2)
await expect(tab.selectionFooter).toBeVisible()
})
test('Ctrl/Cmd+A leaves assets unselected while the canvas is hovered', async ({
comfyPage
}) => {
const tab = comfyPage.menu.assetsTab
const { page } = comfyPage
await expect(tab.assetCards).toHaveCount(2)
const viewport = page.viewportSize()
if (!viewport) throw new Error('viewport size is unavailable')
// Hover the canvas (not the panel); Ctrl/Cmd+A must yield to the canvas.
await page.mouse.move(viewport.width - 100, viewport.height / 2)
await page.keyboard.press('ControlOrMeta+a')
await expect(tab.selectedCards).toHaveCount(0)
})
test('a modifier-held marquee adds to the existing selection', async ({
comfyPage
}) => {
const tab = comfyPage.menu.assetsTab
const { page } = comfyPage
await expect(tab.assetCards).toHaveCount(2)
await tab.getAssetCardByName('alpha').click()
await expect(tab.selectedCards).toHaveCount(1)
const beta = await tab.getAssetCardByName('beta').boundingBox()
if (!beta) throw new Error('beta card has no layout box')
// Hold a modifier so the marquee is additive, then rubber-band over beta.
await page.keyboard.down('Control')
await page.mouse.move(beta.x + 12, beta.y + 12)
await page.mouse.down()
await page.mouse.move(beta.x + beta.width - 12, beta.y + beta.height - 12, {
steps: 12
})
await page.mouse.up()
await page.keyboard.up('Control')
await expect(tab.selectedCards).toHaveCount(2)
})
test('a Ctrl/Cmd+Shift marquee removes the covered cards from the selection', async ({
comfyPage
}) => {
const tab = comfyPage.menu.assetsTab
const { page } = comfyPage
await expect(tab.assetCards).toHaveCount(2)
await tab.getAssetCardByName('alpha').hover()
await page.keyboard.press('ControlOrMeta+a')
await expect(tab.selectedCards).toHaveCount(2)
const beta = await tab.getAssetCardByName('beta').boundingBox()
if (!beta) throw new Error('beta card has no layout box')
// Ctrl+Shift makes the marquee subtractive: rubber-band over beta only.
await page.keyboard.down('Control')
await page.keyboard.down('Shift')
await page.mouse.move(beta.x + 12, beta.y + 12)
await page.mouse.down()
await page.mouse.move(beta.x + beta.width - 12, beta.y + beta.height - 12, {
steps: 12
})
await page.mouse.up()
await page.keyboard.up('Shift')
await page.keyboard.up('Control')
await expect(tab.selectedCards).toHaveCount(1)
await expect(tab.getAssetCardByName('alpha')).toHaveAttribute(
'data-selected',
'true'
)
})
test('Ctrl/Cmd-dragging from an asset card starts a marquee selection', async ({
comfyPage
}) => {
const tab = comfyPage.menu.assetsTab
const { page } = comfyPage
await expect(tab.assetCards).toHaveCount(2)
await expect(tab.selectedCards).toHaveCount(0)
const alpha = await tab.getAssetCardByName('alpha').boundingBox()
const beta = await tab.getAssetCardByName('beta').boundingBox()
if (!alpha || !beta) throw new Error('asset cards have no layout box')
// Ctrl bypasses card drag, so a press that begins on a card rubber-bands.
await page.keyboard.down('Control')
await page.mouse.move(alpha.x + alpha.width / 2, alpha.y + alpha.height / 2)
await page.mouse.down()
await page.mouse.move(beta.x + beta.width - 6, beta.y + beta.height - 6, {
steps: 12
})
await page.mouse.up()
await page.keyboard.up('Control')
await expect(tab.selectedCards).toHaveCount(2)
await expect(tab.selectionFooter).toBeVisible()
})
test('Ctrl/Cmd-dragging within a single card selects only that card', async ({
comfyPage
}) => {
const tab = comfyPage.menu.assetsTab
const { page } = comfyPage
await expect(tab.assetCards).toHaveCount(2)
const alpha = tab.getAssetCardByName('alpha')
const box = await alpha.boundingBox()
if (!box) throw new Error('alpha card has no layout box')
const start = { x: box.x + box.width / 2, y: box.y + box.height / 2 }
await page.keyboard.down('Control')
await page.mouse.move(start.x, start.y)
await page.mouse.down()
await page.mouse.move(start.x + 12, start.y + 12, { steps: 4 })
await page.mouse.up()
await page.keyboard.up('Control')
await expect(tab.selectedCards).toHaveCount(1)
await expect(alpha).toHaveAttribute('data-selected', 'true')
})
test('Ctrl/Cmd+A in the focused search input does not select assets', async ({
comfyPage
}) => {
const tab = comfyPage.menu.assetsTab
const query = 'alpha'
await tab.searchInput.fill(query)
await expect(tab.assetCards).toHaveCount(1)
await tab.searchInput.focus()
await comfyPage.page.keyboard.press('ControlOrMeta+a')
await expect(tab.selectedCards).toHaveCount(0)
await expect
.poll(() =>
tab.searchInput.evaluate((el: HTMLInputElement) => {
return { start: el.selectionStart, end: el.selectionEnd }
})
)
.toEqual({ start: 0, end: query.length })
})
test('a drag starting in the search input does not marquee-select assets', async ({
comfyPage
}) => {
const tab = comfyPage.menu.assetsTab
const { page } = comfyPage
await expect(tab.assetCards).toHaveCount(2)
const search = await tab.searchInput.boundingBox()
const beta = await tab.getAssetCardByName('beta').boundingBox()
if (!search || !beta)
throw new Error('search box or card has no layout box')
await page.mouse.move(
search.x + search.width / 2,
search.y + search.height / 2
)
await page.mouse.down()
await page.mouse.move(beta.x + beta.width / 2, beta.y + beta.height / 2, {
steps: 12
})
await page.mouse.up()
await expect(tab.selectedCards).toHaveCount(0)
})
test('Ctrl/Cmd+A does not select assets while an aria-modal dialog is open', async ({
comfyPage
}) => {
const tab = comfyPage.menu.assetsTab
await expect(tab.assetCards).toHaveCount(2)
await comfyPage.page.evaluate(() => {
const dialog = document.createElement('div')
dialog.id = 'test-modal'
dialog.setAttribute('role', 'dialog')
dialog.setAttribute('aria-modal', 'true')
document.body.appendChild(dialog)
})
await tab.getAssetCardByName('alpha').hover()
await comfyPage.page.keyboard.press('ControlOrMeta+a')
await expect(tab.selectedCards).toHaveCount(0)
await comfyPage.page.evaluate(() => {
document.getElementById('test-modal')?.remove()
})
})
})

View File

@@ -0,0 +1,74 @@
# 12. Cloud Release Notes Use the ComfyUI Version
Date: 2026-07-13
## Status
Accepted
<!-- [Proposed | Accepted | Rejected | Deprecated | Superseded by [ADR-NNNN](NNNN-title.md)] -->
## Context
The release-note system (`releaseStore`) decides whether to surface new-release
UI — the desktop toast/red-dot and the "what's new" popup — by comparing the
version of the most recent entry in the `/releases` feed against the version the
user is currently running.
`currentVersion` sourced that "current version" differently per platform:
- on Cloud, from `system_stats.system.cloud_version`,
- everywhere else, from `system_stats.system.comfyui_version`.
The `/releases` feed, however, is authored in the docs repo and its entries are
keyed by **ComfyUI** version for every project, including `project: 'cloud'`.
There is no separate cloud-versioned feed, and the "learn more" link on every
release note points at <https://docs.comfy.org/changelog>, which only lists
ComfyUI versions.
This mismatch broke the feature on Cloud (tracked as **FE-1237**):
- Cloud runs a much higher `cloud_version` (e.g. `0.160.1`) than the ComfyUI
version the feed entries carry (e.g. `0.27.1`).
- The comparison therefore resolved as `0.27.1 < 0.160.1` → "already ahead of
the latest release" → the popup's `isLatestVersion` gate never passed and the
popup never showed.
- Analytics confirmed the regression: `release_note` clicks fell from 13.4% of
clicks over 90 days to 0% over 30 days, and `cloud_release_note` was
effectively never clicked.
Two directions could fix the mismatch:
1. Give Cloud its own cloud-versioned release feed and a cloud changelog page.
2. Compare against the ComfyUI version on Cloud too, so the running version and
the feed entries share the same version namespace.
Option 1 requires infrastructure that does not exist: no cloud changelog page,
and in current practice a single person maintains the changelog in the docs
repo using ComfyUI versions, updated after each Cloud deploy completes. A
cloud-versioned popup would deep-link users to a changelog page that has no
matching entry, which is more confusing than the version label itself.
## Decision
`currentVersion` always uses `comfyui_version`, on Cloud as well as everywhere
else. `cloud_version` is no longer consulted for release-note version
comparisons.
The `/releases` request still sends `project: 'cloud'` on Cloud, so Cloud can
receive a curated subset of release notes; only the version used for comparison
changes.
## Consequences
- Cloud shows a release note once the running ComfyUI version matches the latest
published feed entry — consistent with the practice of updating the changelog
after a Cloud deploy lands. Publishing a note for a version Cloud has not yet
deployed correctly withholds the popup until the deploy catches up.
- The popup and its "learn more" link now reference a ComfyUI version that
actually exists on the changelog page.
- `cloud_version` remains available in `system_stats` for other consumers; this
decision scopes only to release-note version comparison.
- If Cloud later wants release notes tied to its own versioning, it would need a
cloud-versioned feed **and** a cloud changelog page, at which point this ADR
should be revisited.

View File

@@ -21,6 +21,7 @@ An Architecture Decision Record captures an important architectural decision mad
| [0009](0009-subgraph-promoted-widgets-use-linked-inputs.md) | Subgraph Promoted Widgets Use Linked Inputs | Proposed | 2026-05-05 |
| [0010](0010-remove-nx-orchestration.md) | Remove Nx Orchestration | Accepted | 2026-05-19 |
| [0011](0011-derived-credential-lifecycle.md) | Derived Credential Lifecycle for Cloud Auth | Proposed | 2026-07-09 |
| [0012](0012-cloud-release-notes-use-comfyui-version.md) | Cloud Release Notes Use the ComfyUI Version | Accepted | 2026-07-13 |
## Creating a New ADR

View File

@@ -57,6 +57,9 @@ const config: KnipConfig = {
// Marketing media tooling — adopted by pages in a follow-up PR
'apps/website/src/components/common/SiteVideo.vue',
'apps/website/src/utils/marketingImage.ts',
// Pending integration: consumed by the useWorkspaceInvoices seam once
// #13591 (Plan & Credits tabs) lands — FE-1245
'src/composables/billing/useNextInvoice.ts',
// Agent review check config, not part of the build
'.agents/checks/eslint.strict.config.js',
// Devtools extensions, included dynamically

View File

@@ -1,6 +1,6 @@
{
"name": "@comfyorg/comfyui-frontend",
"version": "1.48.2",
"version": "1.48.3",
"private": true,
"description": "Official front-end implementation of ComfyUI",
"homepage": "https://comfy.org",
@@ -52,6 +52,16 @@
"test:browser": "pnpm exec playwright test",
"test:browser:coverage": "cross-env COLLECT_COVERAGE=true pnpm test:browser",
"test:browser:local": "cross-env PLAYWRIGHT_LOCAL=1 PLAYWRIGHT_TEST_URL=http://localhost:5173 pnpm test:browser",
"test:custom-nodes": "cross-env PLAYWRIGHT_TEST_URL=http://localhost:5173 pnpm exec playwright test browser_tests/tests/customNodes/ --config playwright.chrome.config.ts --workers=1",
"test:custom-nodes:ci": "cross-env PLAYWRIGHT_TEST_URL=http://localhost:8188 pnpm exec playwright test browser_tests/tests/customNodes/ --config playwright.chrome.config.ts --workers=1",
"test:custom-nodes:watch": "cross-env PLAYWRIGHT_TEST_URL=http://localhost:5173 PLAYWRIGHT_LOCAL=1 SLOW_MO=300 pnpm exec playwright test browser_tests/tests/customNodes/customNode.regression.spec.ts browser_tests/tests/customNodes/connectivity.spec.ts --config playwright.chrome.config.ts --workers=1 --headed",
"test:custom-nodes:debug": "cross-env PLAYWRIGHT_TEST_URL=http://localhost:5173 pnpm exec playwright test browser_tests/tests/customNodes/customNode.regression.spec.ts browser_tests/tests/customNodes/connectivity.spec.ts --config playwright.chrome.config.ts --workers=1 --debug",
"test:custom-nodes:impact-render": "pnpm test:custom-nodes:debug -g \"ComfyUI-Impact-Pack.*T0\"",
"test:custom-nodes:impact-run": "pnpm test:custom-nodes:debug -g \"ComfyUI-Impact-Pack.*T1\"",
"test:custom-nodes:vhs-render": "pnpm test:custom-nodes:debug -g \"VideoHelperSuite.*T0\"",
"test:custom-nodes:vhs-run": "pnpm test:custom-nodes:debug -g \"VideoHelperSuite.*T1\"",
"test:custom-nodes:connectivity": "pnpm test:custom-nodes:debug -g \"connectivity\"",
"test:custom-nodes:self-check": "pnpm test:custom-nodes:watch -g \"self-check\"",
"test:coverage": "vitest run --coverage",
"test:unit": "vitest run",
"typecheck": "vue-tsc --noEmit",

View File

@@ -0,0 +1,12 @@
import { defineConfig } from '@playwright/test'
import base from './playwright.config'
// Local runs against the system-installed Google Chrome (no bundled-chromium
// download). trace is kept on failure so a failed local run leaves a viewable
// Playwright trace (the primary reason to reach for this config); video stays
// off since the trace already carries screenshots + DOM snapshots and video is
// the heavier artifact.
export default defineConfig(base, {
use: { channel: 'chrome', video: 'off', trace: 'retain-on-failure' }
})

View File

@@ -16,6 +16,7 @@ const maybeLocalOptions: PlaywrightTestConfig = process.env.PLAYWRIGHT_LOCAL
}
: {
retries: process.env.CI ? 3 : 0,
workers: process.env.CI ? 2 : undefined,
use: {
trace: 'on-first-retry'
}
@@ -25,7 +26,7 @@ export default defineConfig({
testDir: './browser_tests',
fullyParallel: true,
forbidOnly: !!process.env.CI,
reporter: 'html',
reporter: process.env.PLAYWRIGHT_BLOB_OUTPUT_DIR ? 'blob' : 'html',
...maybeLocalOptions,
globalSetup: './browser_tests/globalSetup.ts',
@@ -36,7 +37,21 @@ export default defineConfig({
name: 'chromium',
use: { ...devices['Desktop Chrome'] },
timeout: 15000,
grepInvert: /@mobile|@perf|@audit|@cloud/
grepInvert: /@mobile|@perf|@audit|@cloud|@custom-nodes/
},
// The custom-node suite needs the manifest packs installed and exclusive
// backend-queue access (its afterEach drains the queue), so it runs in
// its own gating job (ci-tests-custom-nodes.yaml) with --workers=1, not
// alongside the parallel main e2e shards. Excluded from `chromium` above
// so the main job never collects it and its unscoped drain cannot
// interrupt a sibling worker's in-flight prompt.
{
name: 'custom-nodes',
use: { ...devices['Desktop Chrome'] },
timeout: 15000,
grep: /@custom-nodes/,
fullyParallel: false
},
{

View File

@@ -0,0 +1,120 @@
import fs from 'fs'
import os from 'os'
import path from 'path'
import { afterEach, beforeEach, describe, expect, it } from 'vitest'
import {
computeTargetVersion,
isValidSemver,
parseRequirementsVersion,
parseTargetBranchOverride
} from './resolve-comfyui-release'
describe('parseRequirementsVersion', () => {
let dir: string
beforeEach(() => {
dir = fs.mkdtempSync(path.join(os.tmpdir(), 'resolve-release-'))
})
afterEach(() => {
fs.rmSync(dir, { recursive: true, force: true })
})
function writeRequirements(content: string): string {
const filePath = path.join(dir, 'requirements.txt')
fs.writeFileSync(filePath, content)
return filePath
}
it('parses a pinned == version', () => {
const file = writeRequirements(
'torch\ncomfyui-frontend-package==1.45.20\nnumpy'
)
expect(parseRequirementsVersion(file)).toBe('1.45.20')
})
it('parses a >= constraint', () => {
const file = writeRequirements('comfyui-frontend-package>=2.0.3')
expect(parseRequirementsVersion(file)).toBe('2.0.3')
})
it('returns null when the package is absent', () => {
const file = writeRequirements('torch\nnumpy')
expect(parseRequirementsVersion(file)).toBeNull()
})
it('returns null when the file is missing', () => {
expect(parseRequirementsVersion(path.join(dir, 'nope.txt'))).toBeNull()
})
})
describe('isValidSemver', () => {
it('accepts a valid X.Y.Z', () => {
expect(isValidSemver('1.45.20')).toBe(true)
expect(isValidSemver('2.0.0')).toBe(true)
})
it('rejects non-three-part versions', () => {
expect(isValidSemver('1.45')).toBe(false)
expect(isValidSemver('1.45.20.1')).toBe(false)
})
it('rejects non-numeric or leading-zero-padded parts', () => {
expect(isValidSemver('1.x.0')).toBe(false)
expect(isValidSemver('v1.45.20')).toBe(false)
expect(isValidSemver('1.045.20')).toBe(false)
})
it('rejects empty / non-string input', () => {
expect(isValidSemver('')).toBe(false)
// @ts-expect-error exercising runtime guard
expect(isValidSemver(undefined)).toBe(false)
})
})
describe('parseTargetBranchOverride', () => {
it('parses core/1.47', () => {
expect(parseTargetBranchOverride('core/1.47')).toEqual({
major: 1,
minor: 47,
branch: 'core/1.47'
})
})
it('parses a major bump core/2.0', () => {
expect(parseTargetBranchOverride('core/2.0')).toEqual({
major: 2,
minor: 0,
branch: 'core/2.0'
})
})
it('rejects malformed overrides', () => {
expect(parseTargetBranchOverride('core/1')).toBeNull()
expect(parseTargetBranchOverride('1.47')).toBeNull()
expect(parseTargetBranchOverride('core/1.47.0')).toBeNull()
expect(parseTargetBranchOverride('release/1.47')).toBeNull()
expect(parseTargetBranchOverride('core/v1.47')).toBeNull()
expect(parseTargetBranchOverride('')).toBeNull()
})
})
describe('computeTargetVersion', () => {
it('bumps patch on a 2.x line when commits exist', () => {
expect(computeTargetVersion(2, 0, 'v2.0.3', true)).toBe('2.0.4')
})
it('keeps the tag version when no new commits exist', () => {
expect(computeTargetVersion(2, 0, 'v2.0.3', false)).toBe('2.0.3')
})
it('starts a fresh major.minor line at .0 when no tag exists', () => {
expect(computeTargetVersion(2, 0, null, true)).toBe('2.0.0')
expect(computeTargetVersion(1, 47, null, true)).toBe('1.47.0')
})
it('returns null for a malformed tag', () => {
expect(computeTargetVersion(1, 47, 'v1.47', true)).toBeNull()
})
})

View File

@@ -81,15 +81,72 @@ function isValidSemver(version: string): boolean {
}
/**
* Get the latest patch tag for a given minor version
* Parse a target branch override of the form `core/<major>.<minor>`.
* Returns the parsed major/minor and normalized branch, or null if malformed.
*/
function getLatestPatchTag(repoPath: string, minor: number): string | null {
function parseTargetBranchOverride(
branch: string
): { major: number; minor: number; branch: string } | null {
const match = branch.match(/^core\/(\d+)\.(\d+)$/)
if (!match) {
return null
}
return {
major: Number(match[1]),
minor: Number(match[2]),
branch
}
}
/**
* Compute the next release version for a target major.minor line.
*
* With no prior tag, the line starts at `.0`. With a prior tag, the patch is
* bumped when there are pending commits, otherwise the tagged version stands.
* Returns null if the tag is not valid semver.
*/
function computeTargetVersion(
targetMajor: number,
targetMinor: number,
latestPatchTag: string | null,
hasPendingCommits: boolean
): string | null {
if (!latestPatchTag) {
return `${targetMajor}.${targetMinor}.0`
}
const tagVersion = latestPatchTag.replace('v', '')
if (!isValidSemver(tagVersion)) {
return null
}
const existingPatch = Number(tagVersion.split('.')[2])
return hasPendingCommits
? `${targetMajor}.${targetMinor}.${existingPatch + 1}`
: tagVersion
}
/**
* Check whether a branch exists on origin in the given repo.
*/
function branchExists(branch: string, repoPath: string): boolean {
return Boolean(exec(`git rev-parse --verify origin/${branch}`, repoPath))
}
/**
* Get the latest patch tag for a given major.minor version
*/
function getLatestPatchTag(
repoPath: string,
major: number,
minor: number
): string | null {
// Fetch all tags
exec('git fetch --tags', repoPath)
// Use git's native version sorting to get the latest tag
const latestTag = exec(
`git tag -l 'v1.${minor}.*' --sort=-version:refname | head -n 1`,
`git tag -l 'v${major}.${minor}.*' --sort=-version:refname | head -n 1`,
repoPath
)
@@ -101,7 +158,7 @@ function getLatestPatchTag(repoPath: string, minor: number): string | null {
const validTagRegex = /^v\d+\.\d+\.\d+$/
if (!validTagRegex.test(latestTag)) {
console.error(
`Latest tag for minor version ${minor} is not valid semver: ${latestTag}`
`Latest tag for version ${major}.${minor} is not valid semver: ${latestTag}`
)
return null
}
@@ -132,85 +189,106 @@ function resolveRelease(
return null
}
const [major, currentMinor, patch] = currentVersion.split('.').map(Number)
const [currentMajor, currentMinor] = currentVersion.split('.').map(Number)
// Fetch all branches
exec('git fetch origin', frontendRepoPath)
// Determine target branch based on release type:
// 'patch' → target current minor (hotfix for production version)
// 'minor' → try next minor, fall back to current minor (bi-weekly cadence)
const releaseTypeInput =
process.env.RELEASE_TYPE?.trim().toLowerCase() || 'minor'
if (releaseTypeInput !== 'minor' && releaseTypeInput !== 'patch') {
console.error(
`Invalid RELEASE_TYPE: "${releaseTypeInput}". Expected "minor" or "patch"`
)
return null
}
const releaseType: 'minor' | 'patch' = releaseTypeInput
// Target major defaults to the current pin's major, but a TARGET_BRANCH
// override (below) can retarget both major and minor.
let targetMajor = currentMajor
let targetMinor: number
let targetBranch: string
if (releaseType === 'patch') {
targetMinor = currentMinor
targetBranch = `core/1.${targetMinor}`
const targetBranchOverride = process.env.TARGET_BRANCH?.trim()
const branchExists = exec(
`git rev-parse --verify origin/${targetBranch}`,
frontendRepoPath
)
if (!branchExists) {
if (targetBranchOverride) {
// Manual override takes precedence over RELEASE_TYPE / pin-derived selection.
const parsed = parseTargetBranchOverride(targetBranchOverride)
if (!parsed) {
console.error(
`Patch release requested but branch ${targetBranch} does not exist`
`Invalid TARGET_BRANCH: "${targetBranchOverride}". Expected format: core/<major>.<minor> (e.g. core/1.47 or core/2.0)`
)
return null
}
targetMajor = parsed.major
targetMinor = parsed.minor
targetBranch = parsed.branch
if (!branchExists(targetBranch, frontendRepoPath)) {
console.error(
`Manual override branch ${targetBranch} does not exist in frontend repo`
)
return null
}
console.error(
`Patch release: targeting current production branch ${targetBranch}`
`Manual override: targeting ${targetBranch} (ignoring release_type)`
)
} else {
// Try next minor first, fall back to current minor if not available
targetMinor = currentMinor + 1
targetBranch = `core/1.${targetMinor}`
const nextMinorExists = exec(
`git rev-parse --verify origin/${targetBranch}`,
frontendRepoPath
)
if (!nextMinorExists) {
// Fall back to current minor for minor release
targetMinor = currentMinor
targetBranch = `core/1.${targetMinor}`
const currentMinorExists = exec(
`git rev-parse --verify origin/${targetBranch}`,
frontendRepoPath
// Determine target branch based on release type:
// 'patch' → target current minor (hotfix for production version)
// 'minor' → try next minor, fall back to current minor (bi-weekly cadence)
const releaseTypeInput =
process.env.RELEASE_TYPE?.trim().toLowerCase() || 'minor'
if (releaseTypeInput !== 'minor' && releaseTypeInput !== 'patch') {
console.error(
`Invalid RELEASE_TYPE: "${releaseTypeInput}". Expected "minor" or "patch"`
)
return null
}
const releaseType: 'minor' | 'patch' = releaseTypeInput
if (!currentMinorExists) {
if (releaseType === 'patch') {
targetMinor = currentMinor
targetBranch = `core/${targetMajor}.${targetMinor}`
if (!branchExists(targetBranch, frontendRepoPath)) {
console.error(
`Neither core/1.${currentMinor + 1} nor core/1.${currentMinor} branches exist in frontend repo`
`Patch release requested but branch ${targetBranch} does not exist`
)
return null
}
console.error(
`Next minor branch core/1.${currentMinor + 1} not found, falling back to core/1.${currentMinor} for minor release`
`Patch release: targeting current production branch ${targetBranch}`
)
} else {
// Try next minor first, fall back to current minor if not available
targetMinor = currentMinor + 1
targetBranch = `core/${targetMajor}.${targetMinor}`
if (!branchExists(targetBranch, frontendRepoPath)) {
// Fall back to current minor for minor release
targetMinor = currentMinor
targetBranch = `core/${targetMajor}.${targetMinor}`
if (!branchExists(targetBranch, frontendRepoPath)) {
console.error(
`Neither core/${targetMajor}.${currentMinor + 1} nor core/${targetMajor}.${currentMinor} branches exist in frontend repo`
)
return null
}
console.error(
`Next minor branch core/${targetMajor}.${currentMinor + 1} not found, falling back to core/${targetMajor}.${currentMinor} for minor release`
)
}
}
}
// Get latest patch tag for target minor
const latestPatchTag = getLatestPatchTag(frontendRepoPath, targetMinor)
// Get latest patch tag for target major.minor
const latestPatchTag = getLatestPatchTag(
frontendRepoPath,
targetMajor,
targetMinor
)
let needsRelease = false
let branchHeadSha: string | null = null
let needsRelease: boolean
let branchHeadSha: string | null
let tagCommitSha: string | null = null
let targetVersion = currentVersion
let targetVersion: string
if (latestPatchTag) {
// Get commit SHA for the tag
@@ -231,34 +309,23 @@ function resolveRelease(
const commitCount = parseInt(commitsBetween, 10)
needsRelease = !isNaN(commitCount) && commitCount > 0
// Parse existing patch number and increment if needed
const tagVersion = latestPatchTag.replace('v', '')
// Validate tag version format
if (!isValidSemver(tagVersion)) {
const nextVersion = computeTargetVersion(
targetMajor,
targetMinor,
latestPatchTag,
needsRelease
)
if (!nextVersion) {
console.error(
`Invalid tag version format: ${tagVersion}. Expected format: X.Y.Z`
`Invalid tag version format: ${latestPatchTag}. Expected format: vX.Y.Z`
)
return null
}
const [, , existingPatch] = tagVersion.split('.').map(Number)
// Validate existingPatch is a valid number
if (!Number.isFinite(existingPatch) || existingPatch < 0) {
console.error(`Invalid patch number in tag: ${existingPatch}`)
return null
}
if (needsRelease) {
targetVersion = `1.${targetMinor}.${existingPatch + 1}`
} else {
targetVersion = tagVersion
}
targetVersion = nextVersion
} else {
// No tags exist for this minor version, need to create v1.{targetMinor}.0
// No tags exist for this major.minor version, need to create the .0 patch
needsRelease = true
targetVersion = `1.${targetMinor}.0`
targetVersion = `${targetMajor}.${targetMinor}.0`
branchHeadSha = exec(
`git rev-parse origin/${targetBranch}`,
frontendRepoPath
@@ -281,26 +348,41 @@ function resolveRelease(
}
}
// Main execution
const comfyuiRepoPath = process.argv[2]
const frontendRepoPath = process.argv[3] || process.cwd()
/**
* Main execution: parse args, resolve, and print the JSON result.
*/
function main(): void {
const comfyuiRepoPath = process.argv[2]
const frontendRepoPath = process.argv[3] || process.cwd()
if (!comfyuiRepoPath) {
console.error(
'Usage: resolve-comfyui-release.ts <comfyui-repo-path> [frontend-repo-path]'
)
process.exit(1)
if (!comfyuiRepoPath) {
console.error(
'Usage: resolve-comfyui-release.ts <comfyui-repo-path> [frontend-repo-path]'
)
process.exit(1)
}
const releaseInfo = resolveRelease(comfyuiRepoPath, frontendRepoPath)
if (!releaseInfo) {
console.error('Failed to resolve release information')
process.exit(1)
}
// Output as JSON for GitHub Actions
// oxlint-disable-next-line no-console -- stdout is captured by the workflow
console.log(JSON.stringify(releaseInfo, null, 2))
}
const releaseInfo = resolveRelease(comfyuiRepoPath, frontendRepoPath)
if (!releaseInfo) {
console.error('Failed to resolve release information')
process.exit(1)
// Only run when invoked directly, not when imported by tests.
if (process.argv[1] && import.meta.url === `file://${process.argv[1]}`) {
main()
}
// Output as JSON for GitHub Actions
// oxlint-disable-next-line no-console -- stdout is captured by the workflow
console.log(JSON.stringify(releaseInfo, null, 2))
export { resolveRelease }
export {
computeTargetVersion,
isValidSemver,
parseRequirementsVersion,
parseTargetBranchOverride,
resolveRelease
}

View File

@@ -7,14 +7,12 @@ import type {
JobListItem,
JobStatus
} from '@/platform/remote/comfyui/jobs/jobTypes'
import { useDisabledPartnerNodesStore } from '@/platform/workspace/stores/disabledPartnerNodesStore'
import { useCommandStore } from '@/stores/commandStore'
import {
TaskItemImpl,
useQueueSettingsStore,
useQueueStore
} from '@/stores/queueStore'
import { createNodeExecutionId } from '@/types/nodeIdentification'
import { render, screen } from '@testing-library/vue'
import userEvent from '@testing-library/user-event'
@@ -64,8 +62,7 @@ const i18n = createI18n({
stopRunInstantTooltip: 'Stop running',
runWorkflow: 'Run workflow',
runWorkflowFront: 'Run workflow front',
runWorkflowDisabled: 'Run workflow disabled',
runWorkflowDisabledNodes: 'Run workflow disabled nodes'
runWorkflowDisabled: 'Run workflow disabled'
}
}
}
@@ -185,32 +182,4 @@ describe('ComfyQueueButton', () => {
}
})
})
it('keeps instant mode idle while dispatching a disabled-node queue command', async () => {
const { user } = renderQueueButton()
const queueSettingsStore = useQueueSettingsStore()
const commandStore = useCommandStore()
const disabledPartnerNodesStore = useDisabledPartnerNodesStore()
disabledPartnerNodesStore.offenders = [
{
nodeId: createNodeExecutionId([1]),
displayName: 'Blocked Partner Node'
}
]
queueSettingsStore.mode = 'instant-idle'
await nextTick()
await user.click(screen.getByTestId('queue-button'))
await nextTick()
expect(queueSettingsStore.mode).toBe('instant-idle')
expect(disabledPartnerNodesStore.scanGraph).toHaveBeenCalledOnce()
expect(commandStore.execute).toHaveBeenCalledWith('Comfy.QueuePrompt', {
metadata: {
subscribe_to_run: false,
trigger_source: 'button'
}
})
})
})

View File

@@ -82,7 +82,6 @@ import { isCloud } from '@/platform/distribution/types'
import { useTelemetry } from '@/platform/telemetry'
import { app } from '@/scripts/app'
import { useCommandStore } from '@/stores/commandStore'
import { useDisabledPartnerNodesStore } from '@/platform/workspace/stores/disabledPartnerNodesStore'
import { useNodeDefStore } from '@/stores/nodeDefStore'
import {
isInstantMode,
@@ -100,10 +99,6 @@ const nodeDefStore = useNodeDefStore()
const hasMissingNodes = computed(() =>
graphHasMissingNodes(app.rootGraph, nodeDefStore.nodeDefsByName)
)
const disabledPartnerNodesStore = useDisabledPartnerNodesStore()
const hasDisabledNodes = computed(
() => disabledPartnerNodesStore.offenders.length > 0
)
const { t } = useI18n()
type QueueModeMenuKey = 'disabled' | 'change' | 'instant-idle'
@@ -195,7 +190,7 @@ const iconClass = computed(() => {
if (isStopInstantAction.value) {
return 'icon-[lucide--square]'
}
if (hasMissingNodes.value || hasDisabledNodes.value) {
if (hasMissingNodes.value) {
return 'icon-[lucide--triangle-alert]'
}
if (workspaceStore.shiftDown) {
@@ -220,9 +215,6 @@ const queueButtonTooltip = computed(() => {
if (hasMissingNodes.value) {
return t('menu.runWorkflowDisabled')
}
if (hasDisabledNodes.value) {
return t('menu.runWorkflowDisabledNodes')
}
if (workspaceStore.shiftDown) {
return t('menu.runWorkflowFront')
}
@@ -241,8 +233,7 @@ const queuePrompt = async (e: Event) => {
? 'Comfy.QueuePromptFront'
: 'Comfy.QueuePrompt'
disabledPartnerNodesStore.scanGraph()
if (!hasDisabledNodes.value && isInstantMode(queueMode.value)) {
if (isInstantMode(queueMode.value)) {
queueMode.value = 'instant-running'
}

View File

@@ -19,11 +19,7 @@ defineOptions({
inheritAttrs: false
})
const {
itemClass: itemProp,
contentClass: contentProp,
modal = true
} = defineProps<{
const { itemClass: itemProp, contentClass: contentProp } = defineProps<{
entries?: MenuItem[]
icon?: string
to?: string | HTMLElement
@@ -31,7 +27,6 @@ const {
contentClass?: string
buttonSize?: ButtonVariants['size']
buttonClass?: string
modal?: boolean
}>()
const itemClass = computed(() =>
@@ -53,7 +48,7 @@ const contentStyle = useModalLiftedZIndex(open)
</script>
<template>
<DropdownMenuRoot v-model:open="open" :modal>
<DropdownMenuRoot v-model:open="open">
<DropdownMenuTrigger as-child>
<slot name="button">
<Button :size="buttonSize ?? 'icon'" :class="buttonClass">

View File

@@ -1,43 +0,0 @@
<template>
<div class="relative mx-2">
<div
v-bind="$attrs"
class="absolute bottom-6 left-1/2 z-40 flex w-full max-w-78 -translate-x-1/2 items-center gap-2 rounded-lg bg-base-foreground p-2 text-base-background shadow-interface"
>
<Button
v-tooltip.top="{ value: deselectLabel, showDelay: 300 }"
variant="inverted"
size="icon-lg"
type="button"
:aria-label="deselectLabel"
class="rounded-lg hover:bg-base-background/10"
@click="emit('deselect')"
>
<i class="icon-[lucide--x] size-4" />
</Button>
<span class="pr-6 text-sm font-bold whitespace-nowrap tabular-nums">
{{ label }}
</span>
<div class="ml-auto flex shrink-0 items-center gap-1">
<slot />
</div>
</div>
</div>
</template>
<script setup lang="ts">
import Button from '@/components/ui/button/Button.vue'
defineOptions({ inheritAttrs: false })
defineProps<{
/** The "N selected" text; the caller formats it (pluralization, wording). */
label: string
/** Accessible label + tooltip for the deselect button. */
deselectLabel: string
}>()
const emit = defineEmits<{
deselect: []
}>()
</script>

View File

@@ -14,7 +14,7 @@
class="p-1 text-amber-400"
>
<template #icon>
<i class="icon-[lucide--coins]" />
<i class="icon-[lucide--component]" />
</template>
</Tag>
<div :class="textClass">

View File

@@ -404,18 +404,6 @@ describe('shouldPreventRekaDismiss', () => {
expect(event.defaultPrevented).toBe(false)
})
it('allows dismiss when target is an outside popup trigger', () => {
const trigger = document.createElement('button')
trigger.setAttribute('aria-haspopup', 'menu')
document.body.appendChild(trigger)
const event = makeEvent(trigger)
onRekaPointerDownOutside({ dismissableMask: undefined }, event)
expect(event.defaultPrevented).toBe(false)
trigger.remove()
})
it('prevents dismiss when the dialog is not the top-most (stacked)', () => {
// A backgrounded dialog must never dismiss on an outside pointer — the
// pointer belongs to the dialog stacked above it (e.g. Edit Keybinding

View File

@@ -86,7 +86,7 @@
@max-reached="showCeilingWarning = true"
>
<template #prefix>
<i class="icon-[lucide--coins] size-4 shrink-0 text-gold-500" />
<i class="icon-[lucide--component] size-4 shrink-0 text-gold-500" />
</template>
</FormattedNumberStepper>
</div>
@@ -98,7 +98,7 @@
v-if="isBelowMin"
class="m-0 flex items-center justify-center gap-1 px-8 pt-4 text-center text-sm text-red-500"
>
<i class="icon-[lucide--coins] size-4" />
<i class="icon-[lucide--component] size-4" />
{{
$t('credits.topUp.minRequired', {
credits: formatNumber(usdToCredits(MIN_AMOUNT))
@@ -109,7 +109,7 @@
v-if="showCeilingWarning"
class="m-0 flex items-center justify-center gap-1 px-8 pt-4 text-center text-sm text-gold-500"
>
<i class="icon-[lucide--coins] size-4" />
<i class="icon-[lucide--component] size-4" />
{{
$t('credits.topUp.maxAllowed', {
credits: formatNumber(usdToCredits(MAX_AMOUNT))

View File

@@ -39,6 +39,10 @@
<NodePropertiesPanel v-else />
</template>
<template #graph-canvas-panel>
<div
ref="canvasPanelBoundsRef"
class="pointer-events-none absolute inset-0"
/>
<GraphCanvasMenu
v-if="canvasMenuEnabled && !isBuilderMode"
class="pointer-events-auto"
@@ -89,7 +93,10 @@
/>
<!-- Selection rectangle overlay - rendered in DOM layer to appear above DOM widgets -->
<SelectionRectangle v-if="comfyAppReady" />
<SelectionRectangle
v-if="comfyAppReady"
:panel-el="canvasPanelBoundsRef ?? undefined"
/>
<NodeTooltip v-if="tooltipEnabled" />
<NodeSearchboxPopover ref="nodeSearchboxPopoverRef" />
@@ -116,6 +123,7 @@ import {
onUnmounted,
ref,
shallowRef,
useTemplateRef,
watch,
watchEffect
} from 'vue'
@@ -202,6 +210,7 @@ const emit = defineEmits<{
ready: []
}>()
const canvasRef = ref<HTMLCanvasElement | null>(null)
const canvasPanelBoundsRef = useTemplateRef('canvasPanelBoundsRef')
const nodeSearchboxPopoverRef = shallowRef<InstanceType<
typeof NodeSearchboxPopover
> | null>(null)

View File

@@ -0,0 +1,106 @@
import { fromPartial } from '@total-typescript/shoehorn'
import { render, screen } from '@testing-library/vue'
import { afterEach, describe, expect, it, vi } from 'vitest'
import { nextTick, ref } from 'vue'
import SelectionRectangle from './SelectionRectangle.vue'
const rafCallbacks: Array<() => void> = []
vi.mock('@vueuse/core', () => ({
useRafFn: (cb: () => void) => {
rafCallbacks.push(cb)
return { pause: vi.fn(), resume: vi.fn() }
}
}))
const mockCanvas = ref<unknown>(null)
vi.mock('@/renderer/core/canvas/canvasStore', () => ({
useCanvasStore: () => ({
get canvas() {
return mockCanvas.value
}
})
}))
function createPanelEl() {
const panel = document.createElement('div')
vi.spyOn(panel, 'getBoundingClientRect').mockReturnValue(
fromPartial<DOMRect>({ left: 300, top: 0, right: 1000, bottom: 800 })
)
return panel
}
function dragRectangle(eDown: [number, number], eMove: [number, number]) {
const canvasEl = document.createElement('canvas')
vi.spyOn(canvasEl, 'getBoundingClientRect').mockReturnValue(
fromPartial<DOMRect>({ left: 0, top: 0, right: 1000, bottom: 800 })
)
mockCanvas.value = {
canvas: canvasEl,
dragging_rectangle: true,
pointer: {
eDown: { safeOffsetX: eDown[0], safeOffsetY: eDown[1] },
eMove: { safeOffsetX: eMove[0], safeOffsetY: eMove[1] }
}
}
rafCallbacks[rafCallbacks.length - 1]()
}
describe('SelectionRectangle', () => {
afterEach(() => {
rafCallbacks.length = 0
mockCanvas.value = null
document.body.replaceChildren()
vi.restoreAllMocks()
})
it('clips the rectangle to the canvas panel when dragged over the sidebar', async () => {
render(SelectionRectangle, { props: { panelEl: createPanelEl() } })
dragRectangle([100, 100], [800, 400])
await nextTick()
const rect = screen.getByTestId('selection-rectangle')
expect(rect.style.left).toBe('300px')
expect(rect.style.top).toBe('100px')
expect(rect.style.width).toBe('500px')
expect(rect.style.height).toBe('300px')
})
it('leaves a rectangle within the panel unchanged', async () => {
render(SelectionRectangle, { props: { panelEl: createPanelEl() } })
dragRectangle([400, 100], [600, 300])
await nextTick()
const rect = screen.getByTestId('selection-rectangle')
expect(rect.style.left).toBe('400px')
expect(rect.style.top).toBe('100px')
expect(rect.style.width).toBe('200px')
expect(rect.style.height).toBe('200px')
})
it('normalizes and clips a rectangle dragged up-and-left', async () => {
render(SelectionRectangle, { props: { panelEl: createPanelEl() } })
dragRectangle([800, 400], [100, 100])
await nextTick()
const rect = screen.getByTestId('selection-rectangle')
expect(rect.style.left).toBe('300px')
expect(rect.style.top).toBe('100px')
expect(rect.style.width).toBe('500px')
expect(rect.style.height).toBe('300px')
})
it('renders unclamped edges when the canvas panel is absent', async () => {
render(SelectionRectangle)
dragRectangle([100, 100], [800, 400])
await nextTick()
const rect = screen.getByTestId('selection-rectangle')
expect(rect.style.left).toBe('100px')
expect(rect.style.width).toBe('700px')
})
})

View File

@@ -1,6 +1,7 @@
<template>
<div
v-show="isVisible"
data-testid="selection-rectangle"
class="pointer-events-none absolute z-9999 border border-blue-400 bg-blue-500/20"
:style="rectangleStyle"
/>
@@ -11,6 +12,13 @@ import { useRafFn } from '@vueuse/core'
import { computed, ref } from 'vue'
import { useCanvasStore } from '@/renderer/core/canvas/canvasStore'
import { clipRectToBounds } from '@/utils/mathUtil'
import type { RectEdges } from '@/utils/mathUtil'
const { panelEl } = defineProps<{
/** Clip surface owned by the caller; the rectangle renders unclipped when absent. */
panelEl?: HTMLElement
}>()
const canvasStore = useCanvasStore()
@@ -20,17 +28,18 @@ const selectionRect = ref<{
w: number
h: number
} | null>(null)
const panelBounds = ref<RectEdges>()
useRafFn(() => {
const canvas = canvasStore.canvas
if (!canvas) {
selectionRect.value = null
return
}
if (!canvas) return
const { pointer, dragging_rectangle } = canvas
if (dragging_rectangle && pointer.eDown && pointer.eMove) {
if (!selectionRect.value) {
panelBounds.value = getCanvasPanelBounds(canvas.canvas)
}
const x = pointer.eDown.safeOffsetX
const y = pointer.eDown.safeOffsetY
const w = pointer.eMove.safeOffsetX - x
@@ -39,25 +48,47 @@ useRafFn(() => {
selectionRect.value = { x, y, w, h }
} else {
selectionRect.value = null
panelBounds.value = undefined
}
})
const isVisible = computed(() => selectionRect.value !== null)
function getCanvasPanelBounds(
canvasEl: HTMLCanvasElement
): RectEdges | undefined {
if (!panelEl) return undefined
const panel = panelEl.getBoundingClientRect()
const canvas = canvasEl.getBoundingClientRect()
return {
left: panel.left - canvas.left,
top: panel.top - canvas.top,
right: panel.right - canvas.left,
bottom: panel.bottom - canvas.top
}
}
const rectangleStyle = computed(() => {
const rect = selectionRect.value
if (!rect) return {}
const left = rect.w >= 0 ? rect.x : rect.x + rect.w
const top = rect.h >= 0 ? rect.y : rect.y + rect.h
const width = Math.abs(rect.w)
const height = Math.abs(rect.h)
const edges: RectEdges = {
left: rect.w >= 0 ? rect.x : rect.x + rect.w,
top: rect.h >= 0 ? rect.y : rect.y + rect.h,
right: rect.w >= 0 ? rect.x + rect.w : rect.x,
bottom: rect.h >= 0 ? rect.y + rect.h : rect.y
}
const bounds = panelBounds.value
const { left, top, right, bottom } = bounds
? clipRectToBounds(edges, bounds)
: edges
return {
left: `${left}px`,
top: `${top}px`,
width: `${width}px`,
height: `${height}px`
width: `${right - left}px`,
height: `${bottom - top}px`
}
})
</script>

View File

@@ -7,7 +7,7 @@
)
"
>
<i class="icon-[lucide--coins] h-full bg-amber-400" />
<i class="icon-[lucide--component] h-full bg-amber-400" />
<span class="truncate" v-text="text" />
</span>
<span

View File

@@ -38,7 +38,6 @@ import {
} from './shared'
import SubgraphEditor from './subgraph/SubgraphEditor.vue'
import TabErrors from './errors/TabErrors.vue'
import { useDisabledPartnerNodesStore } from '@/platform/workspace/stores/disabledPartnerNodesStore'
const canvasStore = useCanvasStore()
const executionErrorStore = useExecutionErrorStore()
@@ -158,33 +157,14 @@ const hasMissingMediaSelected = computed(
)
)
const disabledPartnerNodesStore = useDisabledPartnerNodesStore()
const activeDisabledGraphNodeIds = computed<Set<string>>(() => {
if (!app.isGraphReady) return new Set()
return getActiveGraphNodeIds(
app.rootGraph,
canvasStore.currentGraph ?? app.rootGraph,
disabledPartnerNodesStore.disabledAncestorExecutionIds
)
})
const hasDisabledNodeSelected = computed(
() =>
hasSelection.value &&
selectedNodes.value.some((node) =>
activeDisabledGraphNodeIds.value.has(String(node.id))
)
)
const hasRelevantErrors = computed(() => {
if (!hasSelection.value)
return hasAnyError.value || disabledPartnerNodesStore.offenders.length > 0
if (!hasSelection.value) return hasAnyError.value
return (
hasDirectNodeError.value ||
hasContainerInternalError.value ||
hasMissingNodeSelected.value ||
hasMissingModelSelected.value ||
hasMissingMediaSelected.value ||
hasDisabledNodeSelected.value
hasMissingMediaSelected.value
)
})

View File

@@ -309,11 +309,6 @@
:highlighted-node-ids="selectionMatchedAssetNodeIds"
@locate-node="handleLocateAssetNode"
/>
<DisabledNodesCard
v-if="group.type === 'disabled_node'"
:offenders="disabledPartnerNodesStore.offenders"
@locate-node="handleLocateAssetNode"
/>
</ErrorCardSection>
</TransitionGroup>
</div>
@@ -341,12 +336,10 @@ import MissingNodeCard from './MissingNodeCard.vue'
import SwapNodesCard from '@/platform/nodeReplacement/components/SwapNodesCard.vue'
import MissingModelCard from '@/platform/missingModel/components/MissingModelCard.vue'
import MissingMediaCard from '@/platform/missingMedia/components/MissingMediaCard.vue'
import DisabledNodesCard from '@/platform/workspace/components/errors/DisabledNodesCard.vue'
import { isCloud } from '@/platform/distribution/types'
import Button from '@/components/ui/button/Button.vue'
import DotSpinner from '@/components/common/DotSpinner.vue'
import { useMissingModelStore } from '@/platform/missingModel/missingModelStore'
import { useDisabledPartnerNodesStore } from '@/platform/workspace/stores/disabledPartnerNodesStore'
import { usePackInstall } from '@/workbench/extensions/manager/composables/nodePack/usePackInstall'
import { useMissingNodes } from '@/workbench/extensions/manager/composables/nodePack/useMissingNodes'
import { useErrorGroups } from './useErrorGroups'
@@ -369,7 +362,6 @@ const { copyToClipboard } = useCopyToClipboard()
const { focusNode } = useFocusNode()
const rightSidePanelStore = useRightSidePanelStore()
const missingModelStore = useMissingModelStore()
const disabledPartnerNodesStore = useDisabledPartnerNodesStore()
const { shouldShowManagerButtons, shouldShowInstallButton, openManager } =
useManagerState()
const { missingNodePacks } = useMissingNodes()

View File

@@ -45,6 +45,3 @@ export type ErrorGroup =
| (ErrorGroupBase & {
type: 'missing_media'
})
| (ErrorGroupBase & {
type: 'disabled_node'
})

View File

@@ -128,7 +128,6 @@ vi.mock(
import { useCanvasStore } from '@/renderer/core/canvas/canvasStore'
import { useExecutionErrorStore } from '@/stores/executionErrorStore'
import { useMissingNodesErrorStore } from '@/platform/nodeReplacement/missingNodesErrorStore'
import { useDisabledPartnerNodesStore } from '@/platform/workspace/stores/disabledPartnerNodesStore'
import { isLGraphNode } from '@/utils/litegraphUtil'
import { nodeError, validationError } from '@/utils/__tests__/nodeErrorHelpers'
import { createBoundaryLinkedSubgraph } from '@/lib/litegraph/src/subgraph/__fixtures__/subgraphHelpers'
@@ -330,39 +329,6 @@ describe('useErrorGroups', () => {
expect(groups.allErrorGroups.value).toEqual([])
})
it('includes disabled nodes in the group and node summary', async () => {
const { groups } = createErrorGroups()
const canvasStore = useCanvasStore()
vi.mocked(isLGraphNode).mockReturnValue(true)
vi.mocked(getNodeByExecutionId).mockImplementation((_graph, nodeId) =>
fromAny<LGraphNode, unknown>({ id: nodeId })
)
canvasStore.selectedItems = fromAny<
typeof canvasStore.selectedItems,
unknown
>([{ id: '7' }])
useDisabledPartnerNodesStore().offenders = [
{
nodeId: fromAny<NodeExecutionId, unknown>('7'),
displayName: 'Selected disabled partner node'
},
{
nodeId: fromAny<NodeExecutionId, unknown>('8'),
displayName: 'Other disabled partner node'
}
]
await nextTick()
expect(groups.allErrorGroups.value).toEqual([
expect.objectContaining({ type: 'disabled_node', count: 2 })
])
expect(groups.errorNodeCount.value).toBe(2)
expect(groups.selectionMatchedGroupKeys.value).toEqual(
new Set(['disabled_node'])
)
expect(groups.selectionErrorCount.value).toBe(1)
})
it('includes missing_node group when missing nodes exist', async () => {
const { groups } = createErrorGroups()
const missingNodesStore = useMissingNodesErrorStore()

View File

@@ -5,7 +5,6 @@ import type { IFuseOptions } from 'fuse.js'
import { useMissingModelStore } from '@/platform/missingModel/missingModelStore'
import { useMissingMediaStore } from '@/platform/missingMedia/missingMediaStore'
import { useDisabledPartnerNodesStore } from '@/platform/workspace/stores/disabledPartnerNodesStore'
import { useExecutionErrorStore } from '@/stores/executionErrorStore'
import { useMissingNodesErrorStore } from '@/platform/nodeReplacement/missingNodesErrorStore'
import { useComfyRegistryStore } from '@/stores/comfyRegistryStore'
@@ -21,7 +20,7 @@ import {
} from '@/utils/graphTraversalUtil'
import { resolveNodeDisplayName } from '@/utils/nodeTitleUtil'
import { isLGraphNode } from '@/utils/litegraphUtil'
import { st, t } from '@/i18n'
import { st } from '@/i18n'
import type { MissingNodeType } from '@/types/comfy'
import type { ErrorCardData, ErrorGroup, ErrorItem } from './types'
import { shouldRenderExecutionItemList } from './executionItemList'
@@ -237,7 +236,6 @@ export function useErrorGroups(searchQuery: MaybeRefOrGetter<string>) {
const missingNodesStore = useMissingNodesErrorStore()
const missingModelStore = useMissingModelStore()
const missingMediaStore = useMissingMediaStore()
const disabledPartnerNodesStore = useDisabledPartnerNodesStore()
const canvasStore = useCanvasStore()
const { inferPackFromNodeName } = useComfyRegistryStore()
const collapseState = reactive<Record<string, boolean>>({})
@@ -649,31 +647,6 @@ export function useErrorGroups(searchQuery: MaybeRefOrGetter<string>) {
return groups.sort((a, b) => a.priority - b.priority)
}
const filteredDisabledNodes = computed(() => {
const all = disabledPartnerNodesStore.offenders
if (!selectedNodeInfo.value.nodeIds) return all
return all.filter((offender) => isAssetErrorInSelection(offender.nodeId))
})
function buildDisabledNodeGroups(
offenders: typeof disabledPartnerNodesStore.offenders
): ErrorGroup[] {
if (!offenders.length) return []
return [
{
type: 'disabled_node' as const,
groupKey: 'disabled_node',
count: offenders.length,
priority: 0,
displayTitle: t('rightSidePanel.disabledNodes.title', offenders.length),
displayMessage: t(
'rightSidePanel.disabledNodes.message',
offenders.length
)
}
]
}
const missingModelGroups = computed<MissingModelGroup[]>(() => {
return groupMissingModelCandidates(
missingModelStore.missingModelCandidates,
@@ -824,7 +797,6 @@ export function useErrorGroups(searchQuery: MaybeRefOrGetter<string>) {
processExecutionError(groupsMap)
return [
...buildDisabledNodeGroups(disabledPartnerNodesStore.offenders),
...buildMissingNodeGroups(),
...buildMissingModelGroups(),
...buildMissingMediaGroups(),
@@ -847,7 +819,6 @@ export function useErrorGroups(searchQuery: MaybeRefOrGetter<string>) {
processExecutionError(groupsMap, true)
return [
...buildDisabledNodeGroups(filteredDisabledNodes.value),
...buildMissingNodeGroups((nodeTypes) =>
someNodeTypeInSelection(nodeTypes, selectionMatchedAssetNodeIds.value)
),
@@ -915,14 +886,7 @@ export function useErrorGroups(searchQuery: MaybeRefOrGetter<string>) {
.flatMap((group) => (group.type === 'execution' ? group.cards : []))
.map((card) => card.nodeId)
.filter((nodeId) => nodeId != null)
const disabledNodeIds = disabledPartnerNodesStore.offenders.map(
(offender) => offender.nodeId
)
return new Set([
...executionNodeIds,
...assetNodeIdsWithError.value,
...disabledNodeIds
]).size
return new Set([...executionNodeIds, ...assetNodeIdsWithError.value]).size
})
const filteredGroups = computed<ErrorGroup[]>(() => {

View File

@@ -2,16 +2,6 @@ import { render, screen, waitFor } from '@testing-library/vue'
import userEvent from '@testing-library/user-event'
import { beforeEach, describe, expect, it, vi } from 'vitest'
const mockIsNodeDefDisabled = vi.hoisted(() =>
vi.fn<(nodeDef: ComfyNodeDefImpl) => boolean>(() => false)
)
vi.mock('@/platform/workspace/stores/disabledPartnerNodesStore', () => ({
useDisabledPartnerNodesStore: () => ({
isNodeDefDisabled: mockIsNodeDefDisabled
})
}))
import NodeSearchContent from '@/components/searchbox/v2/NodeSearchContent.vue'
import {
createMockNodeDef,
@@ -34,8 +24,6 @@ describe('NodeSearchContent', () => {
beforeEach(() => {
setupTestPinia()
vi.restoreAllMocks()
mockIsNodeDefDisabled.mockReset()
mockIsNodeDefDisabled.mockReturnValue(false)
setViewport(DESKTOP_VIEWPORT)
const settings = useSettingStore()
settings.settingValues['Comfy.NodeLibrary.Bookmarks.V2'] = []
@@ -327,93 +315,6 @@ describe('NodeSearchContent', () => {
})
describe('search and category interaction', () => {
it('does not report disabled matches in the default empty state', async () => {
const nodeDefStore = useNodeDefStore()
nodeDefStore.updateNodeDefs([
createMockNodeDef({
name: 'BlockedPartnerNode',
display_name: 'Blocked Partner Node',
api_node: true
})
])
mockIsNodeDefDisabled.mockReturnValue(true)
nodeDefStore.registerNodeDefFilter({
id: 'test.disabled-partner-nodes',
name: 'Disabled partner nodes',
predicate: (nodeDef) => !mockIsNodeDefDisabled(nodeDef)
})
renderComponent()
expect(await screen.findByText('No Results')).toBeInTheDocument()
expect(
screen.queryByText('This node has been disabled by your team admin.')
).not.toBeInTheDocument()
})
it('explains when a query only matches an admin-disabled node', async () => {
const nodeDefStore = useNodeDefStore()
nodeDefStore.updateNodeDefs([
createMockNodeDef({
name: 'BlockedPartnerNode',
display_name: 'Blocked Partner Node',
api_node: true
})
])
mockIsNodeDefDisabled.mockImplementation(
(nodeDef: ComfyNodeDefImpl) => nodeDef.name === 'BlockedPartnerNode'
)
nodeDefStore.registerNodeDefFilter({
id: 'test.disabled-partner-nodes',
name: 'Disabled partner nodes',
predicate: (nodeDef) => !mockIsNodeDefDisabled(nodeDef)
})
const { user } = renderComponent()
await user.type(screen.getByRole('combobox'), 'Blocked Partner')
expect(
await screen.findByText(
'This node has been disabled by your team admin.'
)
).toBeInTheDocument()
expect(screen.queryByRole('option')).not.toBeInTheDocument()
})
it('does not report a disabled match outside the selected category', async () => {
const nodeDefStore = useNodeDefStore()
nodeDefStore.updateNodeDefs([
createMockNodeDef({
name: 'BlockedPartnerNode',
display_name: 'Blocked Partner Node',
category: 'loaders',
api_node: true
}),
createMockNodeDef({
name: 'SamplerNode',
display_name: 'Sampler Node',
category: 'sampling'
})
])
mockIsNodeDefDisabled.mockImplementation(
(nodeDef: ComfyNodeDefImpl) => nodeDef.name === 'BlockedPartnerNode'
)
nodeDefStore.registerNodeDefFilter({
id: 'test.disabled-partner-nodes',
name: 'Disabled partner nodes',
predicate: (nodeDef) => !mockIsNodeDefDisabled(nodeDef)
})
const { user } = renderComponent()
await user.click(await screen.findByTestId('category-sampling'))
await user.type(screen.getByRole('combobox'), 'Blocked Partner')
expect(await screen.findByText('No Results')).toBeInTheDocument()
expect(
screen.queryByText('This node has been disabled by your team admin.')
).not.toBeInTheDocument()
})
it('should search within selected category', async () => {
useNodeDefStore().updateNodeDefs([
createMockNodeDef({
@@ -856,82 +757,6 @@ describe('NodeSearchContent', () => {
})
describe('rootFilter + category + search combination', () => {
it('counts disabled nodes only in the selected category without a query', async () => {
const nodeDefStore = useNodeDefStore()
const nodeDefs = [
createMockNodeDef({
name: 'CustomSampler',
display_name: 'Custom Sampler',
category: 'sampling',
python_module: 'custom_nodes.my_extension'
}),
createMockNodeDef({
name: 'CustomLoader',
display_name: 'Custom Loader',
category: 'loaders',
python_module: 'custom_nodes.my_extension'
})
]
nodeDefStore.updateNodeDefs(nodeDefs)
const { user } = renderComponent()
await clickFilterBarButton(user, 'Extensions')
await user.click(await screen.findByTestId('category-custom/sampling'))
mockIsNodeDefDisabled.mockReturnValue(true)
nodeDefStore.registerNodeDefFilter({
id: 'test.disabled-partner-nodes',
name: 'Disabled partner nodes',
predicate: (nodeDef) => !mockIsNodeDefDisabled(nodeDef)
})
nodeDefStore.updateNodeDefs(nodeDefs)
expect(
await screen.findByText(
'This node has been disabled by your team admin.'
)
).toBeInTheDocument()
})
it('ignores disabled matches outside the selected category', async () => {
const nodeDefStore = useNodeDefStore()
const nodeDefs = [
createMockNodeDef({
name: 'CustomSampler',
display_name: 'Custom Sampler',
category: 'sampling',
python_module: 'custom_nodes.my_extension'
}),
createMockNodeDef({
name: 'CustomLoader',
display_name: 'Custom Loader',
category: 'loaders',
python_module: 'custom_nodes.my_extension'
})
]
nodeDefStore.updateNodeDefs(nodeDefs)
const { user } = renderComponent()
await clickFilterBarButton(user, 'Extensions')
await user.click(await screen.findByTestId('category-custom/sampling'))
mockIsNodeDefDisabled.mockImplementation(
(nodeDef) => nodeDef.name === 'CustomLoader'
)
nodeDefStore.registerNodeDefFilter({
id: 'test.disabled-partner-nodes',
name: 'Disabled partner nodes',
predicate: (nodeDef) => !mockIsNodeDefDisabled(nodeDef)
})
nodeDefStore.updateNodeDefs(nodeDefs)
await user.type(screen.getByRole('combobox'), 'Loader')
expect(await screen.findByText('No Results')).toBeInTheDocument()
expect(
screen.queryByText('This node has been disabled by your team admin.')
).not.toBeInTheDocument()
})
it('should intersect rootFilter, selected category, and search query', async () => {
useNodeDefStore().updateNodeDefs([
createMockNodeDef({

View File

@@ -99,11 +99,7 @@
data-testid="no-results"
class="px-4 py-8 text-center text-muted-foreground"
>
{{
disabledMatchCount > 0
? $t('nodeSearch.disabledByTeamAdmin', disabledMatchCount)
: $t('g.noResults')
}}
{{ $t('g.noResults') }}
</div>
</div>
</div>
@@ -125,12 +121,11 @@ import NodeSearchInput from '@/components/searchbox/v2/NodeSearchInput.vue'
import NodeSearchListItem from '@/components/searchbox/v2/NodeSearchListItem.vue'
import { RootCategory } from '@/components/searchbox/v2/rootCategories'
import type { RootCategoryId } from '@/components/searchbox/v2/rootCategories'
import { useDisabledNodeSearch } from '@/composables/node/useDisabledNodeSearch'
import { useFeatureFlags } from '@/composables/useFeatureFlags'
import { useSearchQueryTracking } from '@/platform/telemetry/searchQuery/useSearchQueryTracking'
import { useNodeBookmarkStore } from '@/stores/nodeBookmarkStore'
import type { ComfyNodeDefImpl } from '@/stores/nodeDefStore'
import { useNodeDefStore, useNodeFrequencyStore } from '@/stores/nodeDefStore'
import { useFeatureFlags } from '@/composables/useFeatureFlags'
import {
BLUEPRINT_CATEGORY,
isCustomNode,
@@ -163,7 +158,6 @@ const { flags } = useFeatureFlags()
const nodeDefStore = useNodeDefStore()
const nodeFrequencyStore = useNodeFrequencyStore()
const nodeBookmarkStore = useNodeBookmarkStore()
const { disabledNodeDefs, disabledSearchService } = useDisabledNodeSearch()
const nodeAvailability = computed(() => {
let essential = false
@@ -222,28 +216,21 @@ const rootFilterLabel = computed(() => {
}
})
function rootFilterPredicate(
root: RootCategoryId
): (n: ComfyNodeDefImpl) => boolean {
const sourceFilter = sourceCategoryFilters[root]
if (sourceFilter) return sourceFilter
switch (root) {
case RootCategory.Favorites:
return (n) => nodeBookmarkStore.isBookmarked(n)
case RootCategory.Blueprint:
return (n) => n.category.startsWith(BLUEPRINT_CATEGORY)
case RootCategory.PartnerNodes:
return (n) => n.api_node
default:
return () => true
}
}
const rootFilteredNodeDefs = computed(() => {
if (!rootFilter.value) return nodeDefStore.visibleNodeDefs
return nodeDefStore.visibleNodeDefs.filter(
rootFilterPredicate(rootFilter.value)
)
const allNodes = nodeDefStore.visibleNodeDefs
const sourceFilter = sourceCategoryFilters[rootFilter.value]
if (sourceFilter) return allNodes.filter(sourceFilter)
switch (rootFilter.value) {
case RootCategory.Favorites:
return allNodes.filter((n) => nodeBookmarkStore.isBookmarked(n))
case RootCategory.Blueprint:
return allNodes.filter((n) => n.category.startsWith(BLUEPRINT_CATEGORY))
case RootCategory.PartnerNodes:
return allNodes.filter((n) => n.api_node)
default:
return allNodes
}
})
function onToggleFilter(
@@ -324,15 +311,6 @@ function getCategoryResults(baseNodes: ComfyNodeDefImpl[], category: string) {
})
}
function filterBySelectedCategory(baseNodes: ComfyNodeDefImpl[]) {
const category = selectedCategory.value
if (category === DEFAULT_CATEGORY) return baseNodes
const sourceFilter = sourceCategoryFilters[category]
return sourceFilter
? baseNodes.filter(sourceFilter)
: getCategoryResults(baseNodes, category)
}
const displayedResults = computed<ComfyNodeDefImpl[]>(() => {
const baseNodes = rootFilteredNodeDefs.value
const category = selectedCategory.value
@@ -352,31 +330,10 @@ const displayedResults = computed<ComfyNodeDefImpl[]>(() => {
} else {
source = baseNodes
}
return filterBySelectedCategory(source)
})
const disabledMatchCount = computed(() => {
if (displayedResults.value.length > 0) return 0
if (disabledNodeDefs.value.length === 0) return 0
const inRoot = rootFilter.value
? disabledNodeDefs.value.filter(rootFilterPredicate(rootFilter.value))
: disabledNodeDefs.value
if (!searchQuery.value && filters.length === 0) {
if (!rootFilter.value && selectedCategory.value === DEFAULT_CATEGORY) {
return 0
}
return filterBySelectedCategory(inRoot).length
}
const matched = disabledSearchService.value.searchNode(
searchQuery.value,
filters,
{ limit: 64 }
)
if (!rootFilter.value) return filterBySelectedCategory(matched).length
const inRootNames = new Set(inRoot.map((n) => n.name))
return filterBySelectedCategory(
matched.filter((n) => inRootNames.has(n.name))
).length
const sourceFilter = sourceCategoryFilters[category]
if (sourceFilter) return source.filter(sourceFilter)
return getCategoryResults(source, category)
})
const hoveredNodeDef = computed(

View File

@@ -51,7 +51,7 @@
>
<i
aria-hidden="true"
class="icon-[lucide--coins] size-3 text-amber-400"
class="icon-[lucide--component] size-3 text-amber-400"
/>
<i
aria-hidden="true"

View File

@@ -1,5 +1,6 @@
<template>
<SidebarTabTemplate
ref="panelRef"
:title="isInFolderView ? '' : $t('sideToolbar.mediaAssets.title')"
v-bind="$attrs"
>
@@ -100,18 +101,19 @@
@context-menu="handleAssetContextMenu"
@approach-end="handleApproachEnd"
/>
<AssetsSidebarGridView
v-else
:assets="displayAssets"
:is-selected="isSelected"
:show-output-count="shouldShowOutputCount"
:get-output-count="getOutputCount"
@select-asset="handleAssetSelect"
@context-menu="handleAssetContextMenu"
@approach-end="handleApproachEnd"
@zoom="handleZoomClick"
@output-count-click="enterFolderView"
/>
<div v-else class="size-full">
<AssetsSidebarGridView
:assets="displayAssets"
:is-selected
:show-output-count
:get-output-count
@select-asset="handleAssetSelect"
@context-menu="handleAssetContextMenu"
@approach-end="handleApproachEnd"
@zoom="handleZoomClick"
@output-count-click="enterFolderView"
/>
</div>
</div>
</template>
<template #footer>
@@ -125,6 +127,13 @@
/>
</template>
</SidebarTabTemplate>
<Teleport to="body">
<div
v-if="marqueeStyle"
class="pointer-events-none fixed z-9999 border border-primary-background bg-primary-background/20"
:style="marqueeStyle"
/>
</Teleport>
<MediaLightbox
v-model:active-index="galleryActiveIndex"
:all-gallery-items="galleryItems"
@@ -151,6 +160,7 @@
<script setup lang="ts">
import {
unrefElement,
useAsyncState,
useDebounceFn,
useStorage,
@@ -164,6 +174,7 @@ import {
onMounted,
onUnmounted,
ref,
useTemplateRef,
watch
} from 'vue'
import { useI18n } from 'vue-i18n'
@@ -182,6 +193,7 @@ import MediaAssetFilterBar from '@/platform/assets/components/MediaAssetFilterBa
import MediaAssetSelectionBar from '@/platform/assets/components/MediaAssetSelectionBar.vue'
import { getAssetType } from '@/platform/assets/composables/media/assetMappers'
import { useAssetsApi } from '@/platform/assets/composables/media/useAssetsApi'
import { useAssetGridSelection } from '@/platform/assets/composables/useAssetGridSelection'
import { useAssetSelection } from '@/platform/assets/composables/useAssetSelection'
import { useMediaAssetActions } from '@/platform/assets/composables/useMediaAssetActions'
import { useMediaAssetFiltering } from '@/platform/assets/composables/useMediaAssetFiltering'
@@ -239,7 +251,7 @@ const contextMenuFileKind = computed<MediaKind>(() =>
getMediaTypeFromFilename(contextMenuAsset.value?.name ?? '')
)
const shouldShowOutputCount = (item: AssetItem): boolean => {
const showOutputCount = (item: AssetItem): boolean => {
if (activeTab.value !== 'output' || isInFolderView.value) {
return false
}
@@ -259,7 +271,10 @@ const outputAssets = useAssetsApi('output')
// Asset selection
const {
isSelected,
selectedIds,
handleAssetClick,
selectAll,
setSelectedIds,
hasSelection,
clearSelection,
getSelectedAssets,
@@ -270,6 +285,12 @@ const {
deactivate: deactivateSelection
} = useAssetSelection()
const panelRef = useTemplateRef('panelRef')
const marqueePanelRef = computed(() => {
const el = unrefElement(panelRef)
return el instanceof HTMLElement ? el : undefined
})
const {
downloadAssets,
deleteAssets,
@@ -337,6 +358,16 @@ const visibleAssets = computed(() => {
return listViewSelectableAssets.value
})
const { marqueeStyle } = useAssetGridSelection({
marqueeContainerRef: marqueePanelRef,
hoverTargetRef: marqueePanelRef,
getAssets: () => visibleAssets.value,
getSelectedIds: () => [...selectedIds.value],
setSelectedIds,
selectAll,
isEnabled: () => !isListView.value
})
const previewableVisibleAssets = computed(() =>
visibleAssets.value.filter((asset) =>
isPreviewableMediaType(getMediaTypeFromFilename(asset.name))
@@ -575,7 +606,7 @@ const handleDeselectAll = () => {
}
const handleEmptySpaceClick = () => {
if (hasSelection) {
if (hasSelection.value) {
clearSelection()
}
}

View File

@@ -96,11 +96,9 @@
class="flex min-h-0 flex-1 items-center justify-center px-6 py-8 text-center text-sm text-muted-foreground"
>
{{
disabledMatchCount > 0
? $t('nodeSearch.disabledByTeamAdmin', disabledMatchCount)
: $t('sideToolbar.nodeLibraryTab.noMatchingNodes', {
query: searchQuery
})
$t('sideToolbar.nodeLibraryTab.noMatchingNodes', {
query: searchQuery
})
}}
</div>
<AllNodesPanel
@@ -141,7 +139,6 @@ import TabPanel from '@/components/tab/TabPanel.vue'
import SearchInput from '@/components/ui/search-input/SearchInput.vue'
import Button from '@/components/ui/button/Button.vue'
import { useFeatureFlags } from '@/composables/useFeatureFlags'
import { useDisabledNodeSearch } from '@/composables/node/useDisabledNodeSearch'
import { useNodeDragToCanvas } from '@/composables/node/useNodeDragToCanvas'
import { usePerTabState } from '@/composables/usePerTabState'
import { ESSENTIAL_SECTIONS } from '@/constants/essentialsNodes'
@@ -280,17 +277,6 @@ const hasNoMatches = computed(
() => searchQuery.value.length > 0 && filteredNodeDefs.value.length === 0
)
const { disabledNodeDefs, disabledSearchService } = useDisabledNodeSearch()
const disabledMatchCount = computed(() => {
if (!hasNoMatches.value || disabledNodeDefs.value.length === 0) return 0
return disabledSearchService.value.searchNode(
searchQuery.value,
[],
{ limit: 64 },
{ matchWildcards: false }
).length
})
const sections = computed(() => {
return nodeOrganizationService.organizeNodesTab(activeNodes.value)
})

View File

@@ -1,27 +1,5 @@
<template>
<Toast />
<Toast group="disabled-nodes" position="top-right">
<template #message="slotProps">
<div class="flex min-w-0 flex-1 flex-col gap-2">
<span class="text-sm font-semibold">
{{ slotProps.message.summary }}
</span>
<span class="text-sm text-muted-foreground">
{{ slotProps.message.detail }}
</span>
<div class="flex justify-end">
<Button
v-if="canViewErrors"
size="sm"
variant="secondary"
@click="viewDisabledNodeDetails(slotProps.message)"
>
{{ $t('rightSidePanel.disabledNodes.viewDetails') }}
</Button>
</div>
</div>
</template>
</Toast>
<Toast group="billing-operation" position="top-right">
<template #message="slotProps">
<div class="flex items-center gap-2">
@@ -34,28 +12,15 @@
<script setup lang="ts">
import Toast from 'primevue/toast'
import type { ToastMessageOptions } from 'primevue/toast'
import { useToast } from 'primevue/usetoast'
import { computed, nextTick, watch } from 'vue'
import { nextTick, watch } from 'vue'
import Button from '@/components/ui/button/Button.vue'
import { useSettingStore } from '@/platform/settings/settingStore'
import { useToastStore } from '@/platform/updates/common/toastStore'
import { useRightSidePanelStore } from '@/stores/workspace/rightSidePanelStore'
const toast = useToast()
const toastStore = useToastStore()
const settingStore = useSettingStore()
const canViewErrors = computed(
() =>
settingStore.get('Comfy.UseNewMenu') !== 'Disabled' &&
settingStore.get('Comfy.RightSidePanel.ShowErrorsTab')
)
function viewDisabledNodeDetails(message: ToastMessageOptions) {
useRightSidePanelStore().openPanel('errors')
toast.remove(message)
}
watch(
() => toastStore.messagesToAdd,

View File

@@ -31,7 +31,7 @@
<!-- Credits Section -->
<div v-if="isActiveSubscription" class="flex items-center gap-2 px-4 py-2">
<i class="icon-[lucide--coins] size-4 text-amber-400" />
<i class="icon-[lucide--component] text-sm text-amber-400" />
<Skeleton v-if="isLoading" width="4rem" height="1.25rem" class="w-full" />
<span v-else class="text-base font-semibold text-base-foreground">{{
formattedBalance

View File

@@ -1,38 +0,0 @@
<template>
<CheckboxRoot
v-bind="forwardedProps"
v-model="checked"
:class="
cn(
'peer flex size-4 shrink-0 cursor-pointer items-center justify-center rounded-[4px] border border-interface-stroke bg-transparent transition-colors focus-visible:ring-2 focus-visible:ring-primary/50 focus-visible:outline-none data-[state=checked]:border-primary data-[state=checked]:bg-primary data-[state=checked]:text-white data-[state=indeterminate]:border-primary data-[state=indeterminate]:bg-primary data-[state=indeterminate]:text-white',
className
)
"
>
<CheckboxIndicator class="flex items-center justify-center">
<i
:class="
checked === 'indeterminate'
? 'icon-[lucide--minus] size-3'
: 'icon-[lucide--check] size-3'
"
/>
</CheckboxIndicator>
</CheckboxRoot>
</template>
<script setup lang="ts">
import type { CheckboxRootProps } from 'reka-ui'
import { CheckboxIndicator, CheckboxRoot, useForwardProps } from 'reka-ui'
import type { HTMLAttributes } from 'vue'
import { cn } from '@comfyorg/tailwind-utils'
type Props = Omit<CheckboxRootProps, 'defaultValue' | 'modelValue'> & {
class?: HTMLAttributes['class']
}
const { class: className, ...restProps } = defineProps<Props>()
const forwardedProps = useForwardProps(restProps)
const checked = defineModel<boolean | 'indeterminate'>({ default: false })
</script>

View File

@@ -1,30 +0,0 @@
<template>
<SwitchRoot
v-model="checked"
:disabled
:class="
cn(
'inline-flex h-5 w-9 shrink-0 cursor-pointer items-center rounded-full border border-transparent px-0.5 transition-colors focus-visible:ring-2 focus-visible:ring-primary/50 focus-visible:outline-none disabled:cursor-not-allowed disabled:opacity-50',
checked ? 'bg-primary' : 'bg-interface-stroke'
)
"
>
<SwitchThumb
:class="
cn(
'pointer-events-none block size-4 rounded-full bg-white shadow-sm transition-transform',
checked ? 'translate-x-3.5' : 'translate-x-0'
)
"
/>
</SwitchRoot>
</template>
<script setup lang="ts">
import { SwitchRoot, SwitchThumb } from 'reka-ui'
import { cn } from '@comfyorg/tailwind-utils'
const { disabled = false } = defineProps<{ disabled?: boolean }>()
const checked = defineModel<boolean>({ default: false })
</script>

View File

@@ -1,17 +0,0 @@
<template>
<div :class="cn('relative w-full overflow-auto', className)">
<table
class="w-full caption-bottom border-separate border-spacing-0 text-sm"
>
<slot />
</table>
</div>
</template>
<script setup lang="ts">
import type { HTMLAttributes } from 'vue'
import { cn } from '@comfyorg/tailwind-utils'
const { class: className } = defineProps<{ class?: HTMLAttributes['class'] }>()
</script>

View File

@@ -1,13 +0,0 @@
<template>
<tbody :class="cn('[&_tr:last-child]:border-0', className)">
<slot />
</tbody>
</template>
<script setup lang="ts">
import type { HTMLAttributes } from 'vue'
import { cn } from '@comfyorg/tailwind-utils'
const { class: className } = defineProps<{ class?: HTMLAttributes['class'] }>()
</script>

View File

@@ -1,13 +0,0 @@
<template>
<td :class="cn('px-2 py-2.5 align-middle whitespace-nowrap', className)">
<slot />
</td>
</template>
<script setup lang="ts">
import type { HTMLAttributes } from 'vue'
import { cn } from '@comfyorg/tailwind-utils'
const { class: className } = defineProps<{ class?: HTMLAttributes['class'] }>()
</script>

View File

@@ -1,21 +0,0 @@
<template>
<th
scope="col"
:class="
cn(
'h-10 px-2 text-left align-middle text-sm font-normal whitespace-nowrap text-muted-foreground',
className
)
"
>
<slot />
</th>
</template>
<script setup lang="ts">
import type { HTMLAttributes } from 'vue'
import { cn } from '@comfyorg/tailwind-utils'
const { class: className } = defineProps<{ class?: HTMLAttributes['class'] }>()
</script>

View File

@@ -1,15 +0,0 @@
<template>
<thead
:class="cn('[&_tr]:border-b [&_tr]:border-interface-stroke/60', className)"
>
<slot />
</thead>
</template>
<script setup lang="ts">
import type { HTMLAttributes } from 'vue'
import { cn } from '@comfyorg/tailwind-utils'
const { class: className } = defineProps<{ class?: HTMLAttributes['class'] }>()
</script>

View File

@@ -1,20 +0,0 @@
<template>
<tr
:class="
cn(
'border-b border-interface-stroke/60 transition-colors hover:bg-secondary-background/50 data-[state=selected]:bg-secondary-background/50',
className
)
"
>
<slot />
</tr>
</template>
<script setup lang="ts">
import type { HTMLAttributes } from 'vue'
import { cn } from '@comfyorg/tailwind-utils'
const { class: className } = defineProps<{ class?: HTMLAttributes['class'] }>()
</script>

View File

@@ -14,12 +14,7 @@
>
<header
data-component-id="LeftPanelHeader"
:class="
cn(
'flex h-18 w-full shrink-0 items-center-safe gap-2 pr-3 pl-6',
headerHeightClass
)
"
class="flex h-18 w-full shrink-0 items-center-safe gap-2 pr-3 pl-6"
>
<slot name="leftPanelHeaderTitle" />
<Button
@@ -38,12 +33,7 @@
<div class="flex flex-col overflow-hidden bg-base-background">
<header
v-if="$slots.header"
:class="
cn(
'flex h-18 w-full items-center justify-between gap-2 px-6',
headerHeightClass
)
"
class="flex h-18 w-full items-center justify-between gap-2 px-6"
>
<div class="flex min-w-0 flex-1 gap-2">
<Button
@@ -161,22 +151,20 @@ const SIZE_CLASSES = {
} as const
type ModalSize = keyof typeof SIZE_CLASSES
type ContentPadding = 'default' | 'compact' | 'none' | 'flush'
type ContentPadding = 'default' | 'compact' | 'none'
const {
contentTitle,
rightPanelTitle,
size = 'lg',
leftPanelWidth = '14rem',
contentPadding = 'default',
headerHeightClass = 'h-18'
contentPadding = 'default'
} = defineProps<{
contentTitle: string
rightPanelTitle?: string
size?: ModalSize
leftPanelWidth?: string
contentPadding?: ContentPadding
headerHeightClass?: string
}>()
const sizeClasses = computed(() => SIZE_CLASSES[size])
@@ -216,10 +204,7 @@ const contentContainerClass = computed(() =>
cn(
'flex scrollbar-custom min-h-0 flex-1 flex-col overflow-y-auto',
contentPadding === 'default' && 'px-6 pt-0 pb-10',
contentPadding === 'compact' && 'px-6 pt-0 pb-2',
// Keep the horizontal inset but let content run to the bottom edge (it
// clips there instead of ending above a padding gap).
contentPadding === 'flush' && 'px-6 pt-0'
contentPadding === 'compact' && 'px-6 pt-0 pb-2'
)
)

View File

@@ -140,6 +140,7 @@ describe('loadTurnstile', () => {
const promise = loadTurnstile()
scriptEl()!.dispatchEvent(new Event('load'))
// global never published; deadline elapses
// oxlint-disable-next-line vitest/valid-expect -- deliberately awaited after the timer advance below; awaiting here would deadlock fake timers
const assertion = expect(promise).rejects.toThrow(/timed out/i)
await vi.advanceTimersByTimeAsync(10_000)
@@ -177,6 +178,7 @@ describe('loadTurnstile', () => {
const loadTurnstile = await freshLoadTurnstile()
const promise = loadTurnstile()
// oxlint-disable-next-line vitest/valid-expect -- deliberately awaited after the timer advance below; awaiting here would deadlock fake timers
const assertion = expect(promise).rejects.toThrow(/timed out/i)
vi.advanceTimersByTime(10_000)
@@ -216,6 +218,7 @@ describe('loadTurnstile', () => {
const loadTurnstile = await freshLoadTurnstile()
const promise = loadTurnstile()
// oxlint-disable-next-line vitest/valid-expect -- deliberately awaited after the timer advance below; awaiting here would deadlock fake timers
const assertion = expect(promise).rejects.toThrow(/timed out/i)
await vi.advanceTimersByTimeAsync(10_000)

View File

@@ -107,8 +107,6 @@ export interface BillingState {
export interface BillingContext extends BillingState, BillingActions {
type: ComputedRef<BillingType>
/** Subscription paused on a failed payment (`subscriptionStatus === 'paused'`). */
isPaused: ComputedRef<boolean>
/**
* True when the active team workspace is still on a pre-credit-slider
* (legacy) per-member tier plan, which keeps the old team pricing table.

View File

@@ -147,7 +147,6 @@ function useBillingContextInternal(): BillingContext {
const subscriptionStatus = computed(() =>
toValue(activeContext.value.subscriptionStatus)
)
const isPaused = computed(() => subscriptionStatus.value === 'paused')
const tier = computed(() => toValue(activeContext.value.tier))
const renewalDate = computed(() => toValue(activeContext.value.renewalDate))
@@ -302,7 +301,6 @@ function useBillingContextInternal(): BillingContext {
isLegacyTeamPlan,
billingStatus,
subscriptionStatus,
isPaused,
tier,
renewalDate,
getMaxSeats,

View File

@@ -0,0 +1,190 @@
import { describe, expect, it } from 'vitest'
import type { SubscriptionInfo } from '@/composables/billing/types'
import type {
Plan,
TeamCreditStops
} from '@/platform/workspace/api/workspaceApi'
import type { NextInvoiceInputs } from './useNextInvoice'
import { deriveNextInvoice } from './useNextInvoice'
function makeSubscription(
overrides: Partial<SubscriptionInfo> = {}
): SubscriptionInfo {
return {
isActive: true,
tier: 'STANDARD',
duration: 'MONTHLY',
planSlug: 'standard-monthly',
renewalDate: '2026-08-01T00:00:00Z',
endDate: null,
isCancelled: false,
hasFunds: true,
...overrides
}
}
function makePlan(overrides: Partial<Plan> = {}): Plan {
return {
slug: 'standard-monthly',
tier: 'STANDARD',
duration: 'MONTHLY',
price_cents: 2000,
credits_cents: 2000,
max_seats: 1,
availability: { available: true },
seat_summary: {
seat_count: 1,
total_cost_cents: 2000,
total_credits_cents: 2000
},
...overrides
}
}
// Both stop prices are per-month figures; price_cents is the discounted
// figure, kept distinct from list_price_cents and credits so a regression to
// either fails the amount assertions.
const teamCreditStops: TeamCreditStops = {
default_stop_index: 0,
stops: [
{
id: 'stop-320',
credits: 67520,
monthly: { list_price_cents: 32000, price_cents: 30400 },
yearly: { list_price_cents: 32000, price_cents: 28800 }
},
{
id: 'stop-640',
credits: 135040,
monthly: { list_price_cents: 64000, price_cents: 60800 },
yearly: { list_price_cents: 64000, price_cents: 57600 }
}
]
}
function makeInputs(
overrides: Partial<NextInvoiceInputs> = {}
): NextInvoiceInputs {
return {
subscription: makeSubscription(),
planSlug: 'standard-monthly',
plans: [makePlan()],
teamCreditStops: null,
currentTeamCreditStop: null,
...overrides
}
}
describe(deriveNextInvoice, () => {
it('resolves a monthly invoice from the current plan price by slug', () => {
expect(deriveNextInvoice(makeInputs())).toEqual({
amountCents: 2000,
renewalDate: '2026-08-01T00:00:00Z',
duration: 'MONTHLY'
})
})
it('prefers the subscribed team credit stop over the plan price', () => {
const inputs = makeInputs({
subscription: makeSubscription({ planSlug: 'team-pro-monthly' }),
planSlug: 'team-pro-monthly',
plans: [makePlan({ slug: 'team-pro-monthly', price_cents: 9999 })],
teamCreditStops,
currentTeamCreditStop: {
id: 'stop-320',
credits_monthly: 32000,
stop_usd: 320
}
})
expect(deriveNextInvoice(inputs)?.amountCents).toBe(30400)
})
it('multiplies the per-month yearly stop price by 12 for annual subs', () => {
const inputs = makeInputs({
subscription: makeSubscription({ duration: 'ANNUAL' }),
teamCreditStops,
currentTeamCreditStop: {
id: 'stop-640',
credits_monthly: 64000,
stop_usd: 640
}
})
expect(deriveNextInvoice(inputs)).toEqual({
amountCents: 57600 * 12,
renewalDate: '2026-08-01T00:00:00Z',
duration: 'ANNUAL'
})
})
it('uses the annual plan price_cents as the yearly total, unscaled', () => {
const inputs = makeInputs({
subscription: makeSubscription({
duration: 'ANNUAL',
planSlug: 'standard-yearly'
}),
planSlug: 'standard-yearly',
plans: [
makePlan({
slug: 'standard-yearly',
duration: 'ANNUAL',
price_cents: 21600
})
]
})
expect(deriveNextInvoice(inputs)).toEqual({
amountCents: 21600,
renewalDate: '2026-08-01T00:00:00Z',
duration: 'ANNUAL'
})
})
it('passes a null renewalDate through (scheduled-cancellation window)', () => {
const inputs = makeInputs({
subscription: makeSubscription({ renewalDate: null })
})
expect(deriveNextInvoice(inputs)?.renewalDate).toBeNull()
})
it('falls back to the plan price when the stop is not in the ladder', () => {
const inputs = makeInputs({
teamCreditStops,
currentTeamCreditStop: {
id: 'stop-unknown',
credits_monthly: 1000,
stop_usd: 10
}
})
expect(deriveNextInvoice(inputs)?.amountCents).toBe(2000)
})
it.for([
['no subscription', { subscription: null }],
[
'inactive subscription',
{ subscription: makeSubscription({ isActive: false }) }
],
[
'cancelled subscription',
{ subscription: makeSubscription({ isCancelled: true }) }
],
['unresolvable plan slug', { planSlug: 'unknown-plan' }],
[
'annual sub whose slug resolves only to a monthly plan',
{ subscription: makeSubscription({ duration: 'ANNUAL' }) }
],
['empty plan list (legacy billing)', { plans: [] }],
['zero-price plan (free tier)', { plans: [makePlan({ price_cents: 0 })] }]
] satisfies [string, Partial<NextInvoiceInputs>][])(
'returns null for %s',
([, overrides]) => {
expect(deriveNextInvoice(makeInputs(overrides))).toBeNull()
}
)
})

View File

@@ -0,0 +1,96 @@
import { computed } from 'vue'
import type { SubscriptionInfo } from '@/composables/billing/types'
import { useBillingContext } from '@/composables/billing/useBillingContext'
import type {
CurrentTeamCreditStop,
Plan,
SubscriptionDuration,
TeamCreditStops
} from '@/platform/workspace/api/workspaceApi'
export interface NextInvoiceInputs {
subscription: SubscriptionInfo | null
planSlug: string | null
plans: Plan[]
teamCreditStops: TeamCreditStops | null
currentTeamCreditStop: CurrentTeamCreditStop | null
}
export interface NextInvoice {
amountCents: number
renewalDate: string | null
duration: SubscriptionDuration
}
/**
* Next invoice for the Settings > Invoices banner; annual subscriptions show
* their yearly total and renewal date. Unit semantics: credit-stop
* `yearly.price_cents` is a per-month figure (x12 for the invoice total)
* while an ANNUAL plan's `price_cents` is already the yearly total.
* `renewalDate` is BE-computed and passed through untouched — backends own
* period math including month-end bias — and goes null once a cancellation
* is scheduled. Cancelled/inactive return null because the cancelled Toast
* owns that state. A non-positive resolved amount also returns null (free
* tier can look like an active subscription with no real invoice).
* Intentionally limited to the subscription price: usage/overage pending
* charges are excluded until the backend exposes an authoritative
* upcoming-invoice amount.
*/
export function deriveNextInvoice({
subscription,
planSlug,
plans,
teamCreditStops,
currentTeamCreditStop
}: NextInvoiceInputs): NextInvoice | null {
if (!subscription?.isActive || subscription.isCancelled) return null
const duration = subscription.duration === 'ANNUAL' ? 'ANNUAL' : 'MONTHLY'
const stop = teamCreditStops?.stops.find(
({ id }) => id === currentTeamCreditStop?.id
)
const plan = plans.find(
(candidate) =>
candidate.slug === planSlug && candidate.duration === duration
)
const amountCents = stop
? duration === 'ANNUAL'
? stop.yearly.price_cents * 12
: stop.monthly.price_cents
: plan?.price_cents
if (!amountCents || amountCents <= 0) return null
return {
amountCents,
renewalDate: subscription.renewalDate,
duration
}
}
/**
* Callers own billing-context initialization; a null invoice hides the
* banner.
*/
export function useNextInvoice() {
const {
subscription,
currentPlanSlug,
plans,
teamCreditStops,
currentTeamCreditStop
} = useBillingContext()
const nextInvoice = computed(() =>
deriveNextInvoice({
subscription: subscription.value,
planSlug: currentPlanSlug.value,
plans: plans.value,
teamCreditStops: teamCreditStops.value,
currentTeamCreditStop: currentTeamCreditStop.value
})
)
return { nextInvoice }
}

View File

@@ -4,7 +4,6 @@ import { computed, watch } from 'vue'
import type { LGraph, LGraphNode } from '@/lib/litegraph/src/litegraph'
import type { useMissingModelStore } from '@/platform/missingModel/missingModelStore'
import type { useMissingMediaStore } from '@/platform/missingMedia/missingMediaStore'
import type { useDisabledPartnerNodesStore } from '@/platform/workspace/stores/disabledPartnerNodesStore'
import { useSettingStore } from '@/platform/settings/settingStore'
import { app } from '@/scripts/app'
import type { NodeError } from '@/schemas/apiSchema'
@@ -35,8 +34,7 @@ function reconcileNodeErrorFlags(
rootGraph: LGraph,
nodeErrors: Record<string, NodeError> | null,
missingModelExecIds: Set<string>,
missingMediaExecIds: Set<string> = new Set(),
disabledNodeExecIds: Set<string> = new Set()
missingMediaExecIds: Set<string> = new Set()
): void {
// Collect nodes and slot info that should be flagged
// Includes both error-owning nodes and their ancestor containers
@@ -73,11 +71,6 @@ function reconcileNodeErrorFlags(
if (node) flaggedNodes.add(node)
}
for (const execId of disabledNodeExecIds) {
const node = getNodeByExecutionId(rootGraph, execId)
if (node) flaggedNodes.add(node)
}
forEachNode(rootGraph, (node) => {
setNodeHasErrors(node, flaggedNodes.has(node))
@@ -93,8 +86,7 @@ function reconcileNodeErrorFlags(
export function useNodeErrorFlagSync(
nodeErrors: Ref<Record<string, NodeError> | null>,
missingModelStore: ReturnType<typeof useMissingModelStore>,
missingMediaStore: ReturnType<typeof useMissingMediaStore>,
disabledPartnerNodesStore: ReturnType<typeof useDisabledPartnerNodesStore>
missingMediaStore: ReturnType<typeof useMissingMediaStore>
): () => void {
const settingStore = useSettingStore()
const showErrorsTab = computed(() =>
@@ -106,7 +98,6 @@ export function useNodeErrorFlagSync(
nodeErrors,
() => missingModelStore.missingModelNodeIds,
() => missingMediaStore.missingMediaNodeIds,
() => disabledPartnerNodesStore.disabledAncestorExecutionIds,
showErrorsTab
],
() => {
@@ -123,9 +114,6 @@ export function useNodeErrorFlagSync(
: new Set(),
showErrorsTab.value
? missingMediaStore.missingMediaAncestorExecutionIds
: new Set(),
showErrorsTab.value
? disabledPartnerNodesStore.disabledAncestorExecutionIds
: new Set()
)
},

View File

@@ -1,20 +0,0 @@
import { computed } from 'vue'
import { useDisabledPartnerNodesStore } from '@/platform/workspace/stores/disabledPartnerNodesStore'
import { NodeSearchService } from '@/services/nodeSearchService'
import { useNodeDefStore } from '@/stores/nodeDefStore'
export function useDisabledNodeSearch() {
const nodeDefStore = useNodeDefStore()
const disabledPartnerNodesStore = useDisabledPartnerNodesStore()
const disabledNodeDefs = computed(() =>
Object.values(nodeDefStore.nodeDefsByName).filter((nodeDef) =>
disabledPartnerNodesStore.isNodeDefDisabled(nodeDef)
)
)
const disabledSearchService = computed(
() => new NodeSearchService(disabledNodeDefs.value)
)
return { disabledNodeDefs, disabledSearchService }
}

View File

@@ -90,9 +90,7 @@ export function useExternalLink() {
githubFrontend: 'https://github.com/Comfy-Org/ComfyUI_frontend',
githubElectron: 'https://github.com/Comfy-Org/electron',
forum: 'https://forum.comfy.org/',
comfyOrg: 'https://www.comfy.org/',
teamPlanRequests:
'https://comfy-org.portal.usepylon.com/forms/team-plan-requests'
comfyOrg: 'https://www.comfy.org/'
}
/** Common doc paths for use with buildDocsUrl */

View File

@@ -24,7 +24,6 @@ export enum ServerFeatureFlag {
ONBOARDING_SURVEY_ENABLED = 'onboarding_survey_enabled',
LINEAR_TOGGLE_ENABLED = 'linear_toggle_enabled',
TEAM_WORKSPACES_ENABLED = 'team_workspaces_enabled',
PARTNER_NODE_GOVERNANCE_ENABLED = 'partner_node_governance_enabled',
USER_SECRETS_ENABLED = 'user_secrets_enabled',
NODE_REPLACEMENTS = 'node_replacements',
NODE_LIBRARY_ESSENTIALS_ENABLED = 'node_library_essentials_enabled',
@@ -134,13 +133,6 @@ export function useFeatureFlags() {
cachedTeamWorkspacesEnabled
)
},
get partnerNodeGovernanceEnabled() {
return resolveFlag(
ServerFeatureFlag.PARTNER_NODE_GOVERNANCE_ENABLED,
remoteConfig.value.partner_node_governance_enabled,
false
)
},
get userSecretsEnabled() {
return resolveFlag(
ServerFeatureFlag.USER_SECRETS_ENABLED,

Some files were not shown because too many files have changed in this diff Show More