[PR #34] [MERGED] fix: keep latest container resolution current #33

Closed
opened 2026-10-26 22:23:07 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfyui-ci-container/pull/34
Author: @DrJKL
Created: 9/29/2026
Status: ✅ Merged
Merged: 9/29/2026
Merged by: @DrJKL

Base: main ← Head: amp/fix-latest-container-resolution


📝 Commits (1)

  • eab4676 fix: keep latest container resolution current

📊 Changes

1 file changed (+90 additions, -69 deletions)

View changed files

📝 .github/workflows/update-frontend-container-ref.yml (+90 -69)

📄 Description

Summary

Follow-up to #33 addressing both CodeRabbit findings:

  • fail immediately when the latest main commit skips push workflows instead of waiting for the timeout
  • recheck main after the image manifest appears and resolve the newer release if main advanced
  • keep explicit-version behavior unchanged

Verification

  • actionlint
  • pinact run --check
  • skipped-commit simulation exits with an explicit override message
  • advancing-main simulation discards 0.0.25 and resolves 0.0.26
  • explicit v0.0.24 simulation still resolves without querying Actions

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfyui-ci-container/pull/34 **Author:** [@DrJKL](https://github.com/DrJKL) **Created:** 9/29/2026 **Status:** ✅ Merged **Merged:** 9/29/2026 **Merged by:** [@DrJKL](https://github.com/DrJKL) **Base:** `main` ← **Head:** `amp/fix-latest-container-resolution` --- ### 📝 Commits (1) - [`eab4676`](https://github.com/Comfy-Org/comfyui-ci-container/commit/eab4676aa0537357a7dc3551882cd9f0d0d3b697) fix: keep latest container resolution current ### 📊 Changes **1 file changed** (+90 additions, -69 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/update-frontend-container-ref.yml` (+90 -69) </details> ### 📄 Description ## Summary Follow-up to #33 addressing both CodeRabbit findings: - fail immediately when the latest `main` commit skips push workflows instead of waiting for the timeout - recheck `main` after the image manifest appears and resolve the newer release if `main` advanced - keep explicit-version behavior unchanged ## Verification - `actionlint` - `pinact run --check` - skipped-commit simulation exits with an explicit override message - advancing-main simulation discards `0.0.25` and resolves `0.0.26` - explicit `v0.0.24` simulation still resolves without querying Actions --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-26 22:23:07 +00:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/comfyui-ci-container#33
No description provided.