[PR #175] [MERGED] fix(scripts): improve TLS diagnostics before API integration tests #175

New issue

Closed

opened 2026-10-13 19:48:21 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-13 19:48:21 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Glitchy-Sheep/boosty-downloader/pull/175
Author: @botbikamordehai2-sketch
Created: 9/2/2026
Status: ✅ Merged
Merged: 10/5/2026
Merged by: @Glitchy-Sheep

Base: main ← Head: fix/issue-174-1788354876

📝 Commits (2)

17f6227 fix: add SSL certificate diagnostic to preflight (closes #174)
17a5dfa fix(scripts): handle TLS verification failures in API preflight

📊 Changes

2 files changed (+221 additions, -2 deletions)

View changed files

📝 scripts/api_preflight.py (+48 -2)
➕ test/unit/scripts/api_preflight_test.py (+173 -0)

📄 Description

Summary

Improve TLS diagnostics in the preflight script run by task test:api before the live API integration tests.

Verify TLS before sending the API credential-check request.
On success, display the server certificate's expiry in UTC.
On certificate verification failure, show the verification error and suggest checking the system date/time and trusted CA certificates. The error may concern the server certificate or a CA in its chain.
Report other connection failures with a network troubleshooting hint.

This change affects integration-test tooling only. The regular downloader's behavior is unchanged.

Related to #174. This PR adds test-preflight diagnostics; it does not resolve the download failure reported in that issue.

Checklist

Focused tests pass: uv run pytest test/unit/scripts/api_preflight_test.py (8 tests covering UTC output, certificate and connection failures, and request order).
CI checks passed for 17a5dfac0dd6ca65eb2947aebdde1292a6923075.
ci/skip-changelog label applied because the change is limited to test tooling.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Glitchy-Sheep/boosty-downloader/pull/175 **Author:** [@botbikamordehai2-sketch](https://github.com/botbikamordehai2-sketch) **Created:** 9/2/2026 **Status:** ✅ Merged **Merged:** 10/5/2026 **Merged by:** [@Glitchy-Sheep](https://github.com/Glitchy-Sheep) **Base:** `main` ← **Head:** `fix/issue-174-1788354876` --- ### 📝 Commits (2) - [`17f6227`](https://github.com/Glitchy-Sheep/boosty-downloader/commit/17f622713bd739aa78920b7317ecf6b59cf4dd5d) fix: add SSL certificate diagnostic to preflight (closes #174) - [`17a5dfa`](https://github.com/Glitchy-Sheep/boosty-downloader/commit/17a5dfac0dd6ca65eb2947aebdde1292a6923075) fix(scripts): handle TLS verification failures in API preflight ### 📊 Changes **2 files changed** (+221 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `scripts/api_preflight.py` (+48 -2) ➕ `test/unit/scripts/api_preflight_test.py` (+173 -0) </details> ### 📄 Description ## Summary Improve TLS diagnostics in the preflight script run by `task test:api` before the live API integration tests. - Verify TLS before sending the API credential-check request. - On success, display the server certificate's expiry in UTC. - On certificate verification failure, show the verification error and suggest checking the system date/time and trusted CA certificates. The error may concern the server certificate or a CA in its chain. - Report other connection failures with a network troubleshooting hint. This change affects integration-test tooling only. The regular downloader's behavior is unchanged. ## Related Issue Related to #174. This PR adds test-preflight diagnostics; it does not resolve the download failure reported in that issue. ## Checklist - [x] Focused tests pass: `uv run pytest test/unit/scripts/api_preflight_test.py` (8 tests covering UTC output, certificate and connection failures, and request order). - [x] CI checks passed for `17a5dfac0dd6ca65eb2947aebdde1292a6923075`. - [x] `ci/skip-changelog` label applied because the change is limited to test tooling. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-13 19:48:21 +00:00