NVIDIA/nvbench
1
0
Fork 0
mirror of https://github.com/NVIDIA/nvbench.git synced 2026-03-14 20:27:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #138 from andmax/fix/am/do_clone_warnings

Browse Source 
fix: add final mark in do_clone methods to avoid warnings
This commit is contained in:
Allison Vacanti
2023-11-20 11:10:38 -05:00
committed by GitHub
parent 978d81a0cb e7a4ce70dc
commit 7521229872
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
nvbench/float64_axis.cuh
View File

@@ -40,7 +40,7 @@ struct float64_axis final : public axis_base
[[nodiscard]] nvbench::float64_t get_value(std::size_t i) const { return m_values[i]; }
private:
std::unique_ptr<axis_base> do_clone() const { return std::make_unique<float64_axis>(*this); }
std::unique_ptr<axis_base> do_clone() const final { return std::make_unique<float64_axis>(*this); }
std::size_t do_get_size() const final { return m_values.size(); }
std::string do_get_input_string(std::size_t i) const final;
std::string do_get_description(std::size_t i) const final;

2
nvbench/int64_axis.cuh
View File

@@ -88,7 +88,7 @@ struct int64_axis final : public axis_base
};
private:
std::unique_ptr<axis_base> do_clone() const { return std::make_unique<int64_axis>(*this); }
std::unique_ptr<axis_base> do_clone() const final { return std::make_unique<int64_axis>(*this); }
std::size_t do_get_size() const final { return m_inputs.size(); }
std::string do_get_input_string(std::size_t) const final;
std::string do_get_description(std::size_t) const final;

2
nvbench/string_axis.cuh
View File

@@ -40,7 +40,7 @@ struct string_axis final : public axis_base
[[nodiscard]] const std::string &get_value(std::size_t i) const { return m_values[i]; }
private:
std::unique_ptr<axis_base> do_clone() const { return std::make_unique<string_axis>(*this); }
std::unique_ptr<axis_base> do_clone() const final { return std::make_unique<string_axis>(*this); }
std::size_t do_get_size() const final { return m_values.size(); }
std::string do_get_input_string(std::size_t i) const final { return m_values[i]; }
std::string do_get_description(std::size_t) const final { return {}; }

2
nvbench/type_axis.cuh
View File

@@ -60,7 +60,7 @@ struct type_axis final : public axis_base
[[nodiscard]] std::size_t get_type_index(const std::string &input_string) const;
private:
std::unique_ptr<axis_base> do_clone() const { return std::make_unique<type_axis>(*this); }
std::unique_ptr<axis_base> do_clone() const final { return std::make_unique<type_axis>(*this); }
std::size_t do_get_size() const final { return m_input_strings.size(); }
std::string do_get_input_string(std::size_t i) const final { return m_input_strings[i]; }
std::string do_get_description(std::size_t i) const final { return m_descriptions[i]; }