Luke Mino-Altherr
e708054f7d
chore: remove unused Asset import from manager.py
...
Amp-Thread-ID: https://ampcode.com/threads/T-019c24bb-475b-7442-9ff9-8288edea3345
Co-authored-by: Amp <amp@ampcode.com >
2026-02-11 17:41:37 -08:00
Luke Mino-Altherr
e46c602c18
refactor(assets): split queries.py into modular query modules
...
Split the ~1000 line app/assets/database/queries.py into focused modules:
- queries/asset.py - Asset entity queries (asset_exists_by_hash, get_asset_by_hash)
- queries/asset_info.py - AssetInfo queries (~15 functions)
- queries/cache_state.py - AssetCacheState queries (list_cache_states_by_asset_id,
pick_best_live_path, prune_orphaned_assets, fast_db_consistency_pass)
- queries/tags.py - Tag queries (8 functions including ensure_tags_exist,
add/remove tag functions, list_tags_with_usage)
- queries/__init__.py - Re-exports all public functions for backward compatibility
Also adds comprehensive unit tests using in-memory SQLite:
- tests-unit/assets_test/queries/conftest.py - Session fixture
- tests-unit/assets_test/queries/test_asset.py - 5 tests
- tests-unit/assets_test/queries/test_asset_info.py - 23 tests
- tests-unit/assets_test/queries/test_cache_state.py - 8 tests
- tests-unit/assets_test/queries/test_metadata.py - 12 tests for _apply_metadata_filter
- tests-unit/assets_test/queries/test_tags.py - 23 tests
All 71 unit tests pass. Existing integration tests unaffected.
Amp-Thread-ID: https://ampcode.com/threads/T-019c24bb-475b-7442-9ff9-8288edea3345
Co-authored-by: Amp <amp@ampcode.com >
2026-02-11 17:41:37 -08:00
askmyteapot
e5ae670a40
Update ace15.py to allow min_p sampling ( #12373 )
2026-02-11 20:28:48 -05:00
rattus
3fe61cedda
model_patcher: guard against none model_dtype ( #12410 )
...
Handle the case where the _model_dtype exists but is none with the
intended fallback.
2026-02-11 14:54:02 -05:00
rattus
2a4328d639
ace15: Use dynamic_vram friendly trange ( #12409 )
...
Factor out the ksampler trange and use it in ACE LLM to prevent the
silent stall at 0 and rate distortion due to first-step model load.
2026-02-11 14:53:42 -05:00
rattus
d297a749a2
dynamic_vram: Fix windows Aimdo crash + Fix LLM performance ( #12408 )
...
* model_management: lazy-cache aimdo_tensor
These tensors cosntructed from aimdo-allocations are CPU expensive to
make on the pytorch side. Add a cache version that will be valid with
signature match to fast path past whatever torch is doing.
* dynamic_vram: Minimize fast path CPU work
Move as much as possible inside the not resident if block and cache
the formed weight and bias rather than the flat intermediates. In
extreme layer weight rates this adds up.
2026-02-11 14:50:16 -05:00
Alexander Piskun
2b7cc7e3b6
[API Nodes] enable Magnific Upscalers ( #12179 )
...
* feat(api-nodes): enable Magnific Upscalers
* update price badges
---------
Co-authored-by: Jedrzej Kosinski <kosinkadink1@gmail.com >
2026-02-11 11:30:19 -08:00
Benjamin Lu
4993411fd9
Dispatch desktop auto-bump when a ComfyUI release is published ( #12398 )
...
* Dispatch desktop auto-bump on ComfyUI release publish
* Fix release webhook secret checks in step conditions
* Require desktop dispatch token in release webhook
* Apply suggestion from @Copilot
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
---------
Co-authored-by: Luke Mino-Altherr <lminoaltherr@gmail.com >
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Jedrzej Kosinski <kosinkadink1@gmail.com >
2026-02-11 11:15:13 -08:00
Alexander Piskun
2c7cef4a23
fix(api-nodes): retry on connection errors during polling instead of aborting ( #12393 )
2026-02-11 10:51:49 -08:00
comfyanonymous
76a7fa96db
Make built in lora training work on anima. ( #12402 )
2026-02-10 22:04:32 -05:00
Kohaku-Blueleaf
cdcf4119b3
[Trainer] training with proper offloading ( #12189 )
...
* Fix bypass dtype/device moving
* Force offloading mode for training
* training context var
* offloading implementation in training node
* fix wrong input type
* Support bypass load lora model, correct adapter/offloading handling
2026-02-10 21:45:19 -05:00
AustinMroz
dbe70b6821
Add a VideoSlice node ( #12107 )
...
* Base TrimVideo implementation
* Raise error if as_trimmed call fails
* Bigger max start_time, tooltips, and formatting
* Count packets unless codec has subframes
* Remove incorrect nested decode
* Add null check for audio streams
* Support non-strict duration
* Added strict_duration bool to node definition
* Empty commit for approval
* Fix duration
* Support 5.1 audio layout on save
---------
Co-authored-by: Jedrzej Kosinski <kosinkadink1@gmail.com >
2026-02-10 14:42:21 -08:00
guill
00fff6019e
feat(jobs): add 3d to PREVIEWABLE_MEDIA_TYPES for first-class 3D output support ( #12381 )
...
Co-authored-by: Jedrzej Kosinski <kosinkadink1@gmail.com >
2026-02-10 14:37:14 -08:00
rattus
123a7874a9
ops: Fix vanilla-fp8 loaded lora quality ( #12390 )
...
This was missing the stochastic rounding required for fp8 downcast
to be consistent with model_patcher.patch_weight_to_device.
Missed in testing as I spend too much time with quantized tensors
and overlooked the simpler ones.
2026-02-10 13:38:28 -05:00
rattus
f719f9c062
sd: delay VAE dtype archive until after override ( #12388 )
...
VAEs have host specific dtype logic that should override the dynamic
_model_dtype. Defer the archiving of model dtypes until after.
2026-02-10 13:37:46 -05:00
rattus
fe053ba5eb
mp: dont deep-clone objects from model_options ( #12382 )
...
If there are non-trivial python objects nested in the model_options, this
causes all sorts of issues. Traverse lists and dicts so clones can safely
overide settings and BYO objects but stop there on the deepclone.
2026-02-10 13:37:17 -05:00
comfyanonymous
6648ab68bc
ComfyUI v0.13.0
v0.13.0
2026-02-10 13:26:29 -05:00
ComfyUI Wiki
6615db925c
chore: update workflow templates to v0.8.38 ( #12394 )
2026-02-10 13:24:56 -05:00
Alexander Piskun
8ca842a8ed
feat(api-nodes-Kling): add new models (V3, O3) ( #12389 )
...
* feat(api-nodes-Kling): add new models (V3, O3)
* remove storyboard from VideoToVideo node
* added check for total duration of storyboards
* fixed other small things
* updated display name for nodes
* added "fake" seed
2026-02-10 09:34:54 -08:00
Alexander Piskun
c1b63a7e78
fix(Moonvalley-API-Nodes): adjust "steps" parameter to not raise exception ( #12370 )
2026-02-09 21:58:27 -05:00
ComfyUI Wiki
349a636a2b
chore: update workflow templates to v0.8.37 ( #12377 )
2026-02-09 21:25:34 -05:00
comfyanonymous
a4be04c5d7
Ace step prompts match now. ( #12376 )
2026-02-09 19:45:56 -05:00
blepping
baf8c87455
Iimprovements to ACE-Steps 1.5 text encoding (part 2) ( #12350 )
2026-02-09 19:41:49 -05:00
rattus
62315fbb15
Dynamic VRAM fixes - Ace 1.5 performance + a VRAM leak ( #12368 )
...
* revert threaded model loader change
This change was only needed to get around the pytorch 2.7 mempool bugs,
and should have been reverted along with #12260 . This fixes a different
memory leak where pytorch gets confused about cache emptying.
* load non comfy weights
* MPDynamic: Pre-generate the tensors for vbars
Apparently this is an expensive operation that slows down things.
* bump to aimdo 1.8
New features:
watermark limit feature
logging enhancements
-O2 build on linux
2026-02-09 16:16:08 -05:00
comfyanonymous
a0302cc6a8
Make tonemap latent work on any dim latents. ( #12363 )
2026-02-08 21:16:40 -05:00
comfyanonymous
f350a84261
Disable prompt weights for ltxv2. ( #12354 )
2026-02-07 19:16:28 -05:00
ComfyUI Wiki
3760d74005
chore: update embedded docs to v0.4.1 ( #12346 )
2026-02-07 18:34:52 -05:00
chaObserv
9bf5aa54db
Add search_aliases to sa-solver and seeds-2 node ( #12327 )
2026-02-07 17:38:51 -05:00
Jukka Seppänen
5ff4fdedba
Fix LazyCache ( #12344 )
2026-02-07 11:25:30 -08:00
comfyanonymous
17e7df43d1
Pad ace step 1.5 ref audio if not long enough. ( #12341 )
2026-02-07 00:02:11 -05:00
comfyanonymous
039955c527
Some fixes to previous pr. ( #12339 )
2026-02-06 20:14:52 -05:00
tdrussell
6a26328842
Support fp16 for Cosmos-Predict2 and Anima ( #12249 )
2026-02-06 20:12:15 -05:00
comfyanonymous
204e65b8dc
Fix bug with last pr ( #12338 )
2026-02-06 19:48:20 -05:00
asagi4
a831c19b70
Fix return_word_ids=True with Anima tokenizer ( #12328 )
2026-02-06 19:38:04 -05:00
comfyanonymous
eba6c940fd
Make ace step 1.5 base model work properly with default workflow. ( #12337 )
2026-02-06 19:14:56 -05:00
Jukka Seppänen
a1c101f861
EasyCache: Support LTX2 ( #12231 )
2026-02-06 00:43:09 -05:00
comfyanonymous
c2d7f07dbf
Fix issue when using disable_unet_model_creation ( #12315 )
2026-02-05 19:24:09 -05:00
comfyanonymous
458292fef0
Fix some lowvram stuff with ace step 1.5 ( #12312 )
2026-02-05 19:15:04 -05:00
comfyanonymous
6555dc65b8
Make ace step 1.5 work without the llm. ( #12311 )
2026-02-05 16:43:45 -05:00
AustinMroz
2b70ab9ad0
Add a Create List node ( #12173 )
2026-02-05 01:18:21 -05:00
Comfy Org PR Bot
00efcc6cd0
Bump comfyui-frontend-package to 1.38.13 ( #12238 )
2026-02-05 01:17:37 -05:00
comfyanonymous
cb459573c8
ComfyUI v0.12.3
v0.12.3
2026-02-05 01:13:35 -05:00
comfyanonymous
35183543e0
Add VAE tiled decode node for audio. ( #12299 )
2026-02-05 01:12:04 -05:00
blepping
a246cc02b2
Improvements to ACE-Steps 1.5 text encoding ( #12283 )
2026-02-05 00:17:37 -05:00
comfyanonymous
a50c32d63f
Disable sage attention on ace step 1.5 ( #12297 )
2026-02-04 22:15:30 -05:00
comfyanonymous
6125b80979
Add llm sampling options and make reference audio work on ace step 1.5 ( #12295 )
2026-02-04 21:29:22 -05:00
comfyanonymous
c8fcbd66ee
Try to fix ace text encoder slowness on some configs. ( #12290 )
2026-02-04 19:37:05 -05:00
comfyanonymous
26dd7eb421
Fix ace step nan issue on some hardware/pytorch configs. ( #12289 )
2026-02-04 18:25:06 -05:00
Alexander Piskun
e77b34dfea
add File3DAny output to Load3D node; extend SaveGLB to accept File3DAny as input ( #12276 )
...
* add File3DAny output to Load3D node; extend SaveGLB node to accept File3DAny as input
* fix(grammar): capitalize letter
2026-02-04 11:35:38 -08:00
rattus
ef73070ea4
mp: Fix checkpoint saving ( #12268 )
...
Fix regression in the recent model saving refactor. Pass the non unet
pieces down the layers so that checkpoints are complete.
2026-02-04 02:08:45 -05:00