[PR #62] [CLOSED] gofmt pkg/api/v1alpha1/user.go #62

Closed
opened 2026-10-15 12:47:05 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/fenrir/pull/62
Author: @xerhab
Created: 10/1/2026
Status: ❌ Closed

Base: main ← Head: gofmt-user-go


📝 Commits (10+)

📊 Changes

136 files changed (+17238 additions, -1579 deletions)

View changed files

➕ .claude/rules/catalogue.md (+69 -0)
➕ .claude/rules/client-ip.md (+18 -0)
➕ .claude/rules/informer-cache.md (+17 -0)
➕ .claude/rules/input-hotplug.md (+41 -0)
➕ .claude/rules/library.md (+33 -0)
➕ .claude/rules/moonlight-proxy.md (+37 -0)
➕ .claude/rules/romm.md (+37 -0)
📝 .github/workflows/build.yml (+43 -2)
📝 .github/workflows/builder.yml (+41 -8)
📝 .github/workflows/golangci-lint.yml (+6 -1)
➕ .github/workflows/instruction-size.yml (+34 -0)
📝 .gitignore (+10 -1)
➕ CLAUDE.md (+113 -0)
📝 Dockerfile (+2 -2)
📝 README.md (+74 -22)
📝 charts/direwolf-operator/values.yaml (+97 -8)
📝 cmd/moonlight-proxy/main.go (+67 -11)
➕ cmd/nri-input/main.go (+144 -0)
➕ cmd/nri-input/main_test.go (+111 -0)
📝 cmd/operator/main.go (+186 -12)

...and 80 more files

📄 Description

gofmt reports pkg/api/v1alpha1/user.go on main: a //TODO comment sits directly under a closing brace. This adds the blank line and the space gofmt wants. Comment-only.

The generated applyconfig (pkg/generated/applyconfiguration/api/v1alpha1/sidecarpolicy.go) already renders the comment as // TODO, so codegen output does not change.

Verified: gofmt -l ./pkg ./cmd is now empty and go build ./... passes. No runtime surface, so no QA pass. Found while working on XERK-1367.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/fenrir/pull/62 **Author:** [@xerhab](https://github.com/xerhab) **Created:** 10/1/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `gofmt-user-go` --- ### 📝 Commits (10+) - [`2828835`](https://github.com/games-on-whales/fenrir/commit/28288350ce85f16a2e95eee302d9ab58f623927d) [moonlight-proxy] raise launch wait from 25s to 120s - [`8400e83`](https://github.com/games-on-whales/fenrir/commit/8400e83ab0336fc2b055191c34bfe1cce6909db3) [operator] retry stream reconciliation and fix stale session tracking - [`b621069`](https://github.com/games-on-whales/fenrir/commit/b6210699c2e1439a46f21fb0818d1289ee463dd3) [wolf-agent] act as fake-udev for hotplugged input devices - [`021da17`](https://github.com/games-on-whales/fenrir/commit/021da17e54880bd73e937c5872a5842141f8e929) [moonlight-proxy] make launch timeout configurable - [`48c1b41`](https://github.com/games-on-whales/fenrir/commit/48c1b413d39cc372101db44ef2effa11095ed1ab) Merge upstream games-on-whales/fenrir#8 - [`fbadbc1`](https://github.com/games-on-whales/fenrir/commit/fbadbc1b72fc74e2841b957ef5fd44294fbe94ee) Merge upstream games-on-whales/fenrir#52 - [`48876e8`](https://github.com/games-on-whales/fenrir/commit/48876e89abdfb4df1edd9cd8a499251499642158) Merge upstream games-on-whales/fenrir#10 - [`188ea80`](https://github.com/games-on-whales/fenrir/commit/188ea80ce2631468cb5b2b8d03ebdbb3ac6658e7) go mod tidy: golang.org/x/sys is a direct dependency since #10 - [`be022ea`](https://github.com/games-on-whales/fenrir/commit/be022eaf0b0d4c13ba2c7e12e5b108ef4af19318) Merge pull request #1 from xerktech/merge-upstream-prs - [`8b4644c`](https://github.com/games-on-whales/fenrir/commit/8b4644c1ed0f5d9605ba74d07b185984ab223f85) Build with Go 1.26 and current golang.org/x modules so govulncheck passes ### 📊 Changes **136 files changed** (+17238 additions, -1579 deletions) <details> <summary>View changed files</summary> ➕ `.claude/rules/catalogue.md` (+69 -0) ➕ `.claude/rules/client-ip.md` (+18 -0) ➕ `.claude/rules/informer-cache.md` (+17 -0) ➕ `.claude/rules/input-hotplug.md` (+41 -0) ➕ `.claude/rules/library.md` (+33 -0) ➕ `.claude/rules/moonlight-proxy.md` (+37 -0) ➕ `.claude/rules/romm.md` (+37 -0) 📝 `.github/workflows/build.yml` (+43 -2) 📝 `.github/workflows/builder.yml` (+41 -8) 📝 `.github/workflows/golangci-lint.yml` (+6 -1) ➕ `.github/workflows/instruction-size.yml` (+34 -0) 📝 `.gitignore` (+10 -1) ➕ `CLAUDE.md` (+113 -0) 📝 `Dockerfile` (+2 -2) 📝 `README.md` (+74 -22) 📝 `charts/direwolf-operator/values.yaml` (+97 -8) 📝 `cmd/moonlight-proxy/main.go` (+67 -11) ➕ `cmd/nri-input/main.go` (+144 -0) ➕ `cmd/nri-input/main_test.go` (+111 -0) 📝 `cmd/operator/main.go` (+186 -12) _...and 80 more files_ </details> ### 📄 Description gofmt reports `pkg/api/v1alpha1/user.go` on main: a `//TODO` comment sits directly under a closing brace. This adds the blank line and the space gofmt wants. Comment-only. The generated applyconfig (`pkg/generated/applyconfiguration/api/v1alpha1/sidecarpolicy.go`) already renders the comment as `// TODO`, so codegen output does not change. Verified: `gofmt -l ./pkg ./cmd` is now empty and `go build ./...` passes. No runtime surface, so no QA pass. Found while working on XERK-1367. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-15 12:47:05 +00:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
games-on-whales/fenrir#62
No description provided.