[PR #1915] [MERGED] fix(javascript): report available parent result budget in coverage limits #4905

New issue

Closed

opened 2026-10-31 00:56:37 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 00:56:37 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1915
Author: @kaoru0822-kitauji
Created: 10/11/2026
Status: ✅ Merged
Merged: 10/11/2026
Merged by: @morluto

Base: main ← Head: fix/javascript-parent-static-reserve

📝 Commits (6)

24bf9df fix(javascript): size the future static reserve by remaining sources
fb43cfc fix(javascript): make parent budget remediation and its test runtime-aware
5b7f43a Merge remote-tracking branch 'origin/main' into fix/javascript-parent-static-reserve
74472da fix(javascript): suggest a concrete parent heap size in remediation
34e5540 fix(javascript): let parent budget rejections state their retained facts
f18c65a Merge remote-tracking branch 'origin/main' into fix/javascript-parent-static-reserve

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 src/domain/javascript/javascriptAnalysisResourceControls.ts (+1 -0)

📄 Description

Summary

Follow-up to #1921, which fixed #1911.

This PR began as a separate fix for #1911. #1921 merged in the meantime with a more complete fix for the same code, so I resolved the merge conflict by taking main's JavaScriptAnalysisWorker. I also dropped my CLI regression test, because #1921's tests/acceptance/applications/javascriptCheckpointReserveCli.test.ts covers the same one-remaining-source case.

What remains is a small gap in #1921. Parent-budget rejections now report parent_available_result_budget_bytes, but javaScriptAnalysisCoverageLimits only projects allowlisted limit keys. So the effective available budget appeared in the error details but never in the application coverage limits. This adds it as javascript_analysis_parent_available_result_budget_bytes, next to the existing total parent_result_budget_bytes.

Validation

I reran a parent-budget rejection through the real CLI: an enlarged single-module input with a 448 MiB parent heap. Coverage limits now include javascript_analysis_parent_available_result_budget_bytes.
#1921's javascriptCheckpointReserveCli.test.ts passes on this branch (3 tests).
npm run check:fast passes.

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1915 **Author:** [@kaoru0822-kitauji](https://github.com/kaoru0822-kitauji) **Created:** 10/11/2026 **Status:** ✅ Merged **Merged:** 10/11/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/javascript-parent-static-reserve` --- ### 📝 Commits (6) - [`24bf9df`](https://github.com/morluto/rea/commit/24bf9dfeacdeb00ad4600fa3800cf0807fb6d0bb) fix(javascript): size the future static reserve by remaining sources - [`fb43cfc`](https://github.com/morluto/rea/commit/fb43cfc2aee1287813948cee0dc0c15c691d8924) fix(javascript): make parent budget remediation and its test runtime-aware - [`5b7f43a`](https://github.com/morluto/rea/commit/5b7f43afaa02fc895a3b77fcb6f89ccab39dc9a0) Merge remote-tracking branch 'origin/main' into fix/javascript-parent-static-reserve - [`74472da`](https://github.com/morluto/rea/commit/74472dacba8503abae796836c719d06ecea212f4) fix(javascript): suggest a concrete parent heap size in remediation - [`34e5540`](https://github.com/morluto/rea/commit/34e55403d3e3c04c017555688101c2b2c08ea05c) fix(javascript): let parent budget rejections state their retained facts - [`f18c65a`](https://github.com/morluto/rea/commit/f18c65a3a3c6c54c790d89b70268ad5bb7d8c614) Merge remote-tracking branch 'origin/main' into fix/javascript-parent-static-reserve ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/javascript/javascriptAnalysisResourceControls.ts` (+1 -0) </details> ### 📄 Description ## Summary Follow-up to #1921, which fixed #1911. This PR began as a separate fix for #1911. #1921 merged in the meantime with a more complete fix for the same code, so I resolved the merge conflict by taking `main`'s `JavaScriptAnalysisWorker`. I also dropped my CLI regression test, because #1921's `tests/acceptance/applications/javascriptCheckpointReserveCli.test.ts` covers the same one-remaining-source case. What remains is a small gap in #1921. Parent-budget rejections now report `parent_available_result_budget_bytes`, but `javaScriptAnalysisCoverageLimits` only projects allowlisted limit keys. So the effective available budget appeared in the error details but never in the application coverage limits. This adds it as `javascript_analysis_parent_available_result_budget_bytes`, next to the existing total `parent_result_budget_bytes`. ## Validation - I reran a parent-budget rejection through the real CLI: an enlarged single-module input with a 448 MiB parent heap. Coverage limits now include `javascript_analysis_parent_available_result_budget_bytes`. - #1921's `javascriptCheckpointReserveCli.test.ts` passes on this branch (3 tests). - `npm run check:fast` passes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 00:56:37 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#4905

No description provided.

Rows
Columns