morluto/rea

Fork

You've already forked rea

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

Code Issues 1.3k Projects Packages Wiki Activity

[PR #2880] [CLOSED] fix(ida): stop legacy string paging against fake-paginated upstream #5464

New issue

Closed

opened 2026-10-31 01:06:51 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:06:51 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2880
Author: @sugeladi2450
Created: 10/13/2026
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (4)

ef9353d fix(ida): stop legacy string paging against fake-paginated upstream
b46578c fix(ida): bound large stdio string replies
bf6e182 fix(ida): bound large legacy string replies
60bd43c fix(ida): attribute oversized MCP replies

📊 Changes

4 files changed (+141 additions, -18 deletions)

View changed files

📝 src/ida/IdaMcpConnection.ts (+35 -11)
📝 src/ida/IdaOperationRunner.ts (+5 -7)
📝 src/ida/IdaSessionClient.test.ts (+62 -0)
📝 tests/boundary/mcp/idaTransport.test.ts (+39 -0)

📄 Description

Summary

Fixes IDA GUI hangs in legacy attached mode when running rea search <binary> <pattern> --json
or rea list strings against the ida-pro-mcp 1.4.0 server. Fixes #2786.

Problem and expected behavior

Smallest trigger: rea search test.exe hello --json against ida-pro-mcp 1.4.0 with a binary
containing a large number of strings. REA's legacy strings() loops over list_strings with
count: 100 until next_offset is null. Upstream 1.4.0's list_strings is only apparently
paginated: every call re-enumerates the whole database (for item in idautils.Strings()) and
then slices, so the paging loop forces O(N²/100) upstream enumeration work and IDA's GUI hangs
inside the "Generating strings" loop.

Expected behavior: listing and searching strings complete in one upstream round trip with the
same result set as before.

Change and scope

The upstream paginate helper documents count == 0 as "0 means remainder": it returns the
full remainder in one page and sets next_offset to null. Passing count: 0 in the legacy
branch of strings() turns the paging loop into a single call (O(N)) with the same page shape
and no server-side contract change. The existing "pagination did not advance" guard is kept.

Two additional adjustments are included in the same change:

The legacy branch appends mapped items with a for...of loop instead of a spread
(result.push(...page.data.map(...))). With a single full-size page, a spread would exceed
the JavaScript call argument limit (~65535) and throw RangeError on large binaries.
The regression test now asserts concrete values (hello-0/0x3000, hello-249/0x30f9,
and the literal-search head/tail) in addition to result lengths, so wrong upstream data
cannot pass the test.

Contribution scope fit: ordinary fix within existing boundaries — "not applicable" for a
maintainer scope decision (no new provider, no target execution/injection/mutation).

Contract and boundary impact

Semantic owner and earliest changed stage: legacy attached-mode string inventory read.
Contribution scope fit and linked maintainer decision: not applicable (existing boundary).
CLI and MCP/tool-catalog contract: none. count: 0 is documented upstream semantics;
no tool added, removed, or renamed.
Provider, bridge, target-format, or platform compatibility: unchanged for native/headless
modes; legacy mode result set unchanged.
Evidence, artifact, provenance, or reconstruction contract: none.
Target selection, authority, upstream behavior, and cleanup details: not applicable.
Generated metadata / package / installation impact: none.

Expected effects:

Read existing files or captured data. (reads upstream string pages; no new interaction)
Launch or attach to a process.
Inject instrumentation or run scripts/code.
Change process memory, registers, files, or configuration.
Contact network services.
Recover protected code or work around protections.
Documentation or usability only; no target interaction.
Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

Tests added or updated: src/ida/IdaSessionClient.test.ts — new
"attached IDA legacy string inventory" case (fake-paginated upstream, 250 strings), asserting
call counts, count: 0, and concrete address/value pairs at the head and tail of results.
Base reproduction or other evidence: temporary repro harness with N=2500 fake-paginated
upstream, run against the upstream base revision and against this change:
list_strings calls 25 (all count: 100) → 1 (count: 0); literal search_strings total
calls 50 → 2. Result length identical (1111) both ways. A second harness with 200,000 strings
confirmed no RangeError from the append path.
User-visible CLI/MCP output: none changed; output shape is identical.

For evidence-bearing changes:

Observed, derived, and inferred claims remain distinguishable.
Artifact identity, source provenance, and failed attempts remain preserved.
Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

npx vitest run src/ida/IdaSessionClient.test.ts -t "single upstream calls" — 1 passed.
Repro harness (temporary, N=2500): base 25/50 calls → fixed 1/2 calls, same results.
Large-inventory harness (temporary, N=200000): no RangeError, full result returned.
npx tsc --noEmit — passes (0 errors) at the verification baseline.
npx oxlint src/ida/IdaOperationRunner.ts src/ida/IdaSessionClient.test.ts — 0 errors.
npx oxfmt --check on the changed files — passes.

Compatibility, safety, and release

Breaking changes or migration steps: none. No call or configuration becomes invalid;
count: 0 was already valid upstream input.
Real Hopper/Ghidra, browser, or OS coverage: not applicable (IDA legacy path only).
Package or release metadata impact: none.
Security, privacy, process, or containment review: none; no new target interaction.

Before merge

This PR addresses a concrete problem or an agreed enhancement.
Material scope and authority questions are resolved; maintainer scope decision
covers the final diff (declared not applicable).
The PR has one focused outcome and the title follows type(scope): outcome.
Related issue is linked (Fixes #2786).
Tests cover changed observable behavior and meaningful failure paths.
Owning docs, contracts, and generated metadata are updated where needed
(none needed; no contract text changed).
User-visible CLI/MCP changes include representative output
(no output shape change).
I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2880 **Author:** [@sugeladi2450](https://github.com/sugeladi2450) **Created:** 10/13/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (4) - [`ef9353d`](https://github.com/morluto/rea/commit/ef9353da00c05fa444b20a91b0e1d9ae1ee54092) fix(ida): stop legacy string paging against fake-paginated upstream - [`b46578c`](https://github.com/morluto/rea/commit/b46578c6d3cd7a20942390fa1a36b48ffd73cfbb) fix(ida): bound large stdio string replies - [`bf6e182`](https://github.com/morluto/rea/commit/bf6e182b1935bc36cbe50355e3e6a912b91aa73e) fix(ida): bound large legacy string replies - [`60bd43c`](https://github.com/morluto/rea/commit/60bd43cfbc283540f6b41d1a6f34492e408b10cc) fix(ida): attribute oversized MCP replies ### 📊 Changes **4 files changed** (+141 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/ida/IdaMcpConnection.ts` (+35 -11) 📝 `src/ida/IdaOperationRunner.ts` (+5 -7) 📝 `src/ida/IdaSessionClient.test.ts` (+62 -0) 📝 `tests/boundary/mcp/idaTransport.test.ts` (+39 -0) </details> ### 📄 Description ## Summary Fixes IDA GUI hangs in legacy attached mode when running `rea search <binary> <pattern> --json` or `rea list strings` against the ida-pro-mcp 1.4.0 server. Fixes #2786. ## Problem and expected behavior Smallest trigger: `rea search test.exe hello --json` against ida-pro-mcp 1.4.0 with a binary containing a large number of strings. REA's legacy `strings()` loops over `list_strings` with `count: 100` until `next_offset` is null. Upstream 1.4.0's `list_strings` is only apparently paginated: every call re-enumerates the whole database (`for item in idautils.Strings()`) and then slices, so the paging loop forces O(N²/100) upstream enumeration work and IDA's GUI hangs inside the "Generating strings" loop. Expected behavior: listing and searching strings complete in one upstream round trip with the same result set as before. ## Change and scope The upstream `paginate` helper documents `count == 0` as "0 means remainder": it returns the full remainder in one page and sets `next_offset` to null. Passing `count: 0` in the legacy branch of `strings()` turns the paging loop into a single call (O(N)) with the same page shape and no server-side contract change. The existing "pagination did not advance" guard is kept. Two additional adjustments are included in the same change: - The legacy branch appends mapped items with a `for...of` loop instead of a spread (`result.push(...page.data.map(...))`). With a single full-size page, a spread would exceed the JavaScript call argument limit (~65535) and throw `RangeError` on large binaries. - The regression test now asserts concrete values (`hello-0`/`0x3000`, `hello-249`/`0x30f9`, and the literal-search head/tail) in addition to result lengths, so wrong upstream data cannot pass the test. Contribution scope fit: ordinary fix within existing boundaries — "not applicable" for a maintainer scope decision (no new provider, no target execution/injection/mutation). ## Contract and boundary impact - Semantic owner and earliest changed stage: legacy attached-mode string inventory read. - Contribution scope fit and linked maintainer decision: not applicable (existing boundary). - CLI and MCP/tool-catalog contract: none. `count: 0` is documented upstream semantics; no tool added, removed, or renamed. - Provider, bridge, target-format, or platform compatibility: unchanged for native/headless modes; legacy mode result set unchanged. - Evidence, artifact, provenance, or reconstruction contract: none. - Target selection, authority, upstream behavior, and cleanup details: not applicable. - Generated metadata / package / installation impact: none. Expected effects: - [x] Read existing files or captured data. (reads upstream string pages; no new interaction) - [ ] Launch or attach to a process. - [ ] Inject instrumentation or run scripts/code. - [ ] Change process memory, registers, files, or configuration. - [ ] Contact network services. - [ ] Recover protected code or work around protections. - [ ] Documentation or usability only; no target interaction. - [ ] Not sure yet; investigation or maintainer guidance needed. ## Evidence and regression coverage - Tests added or updated: `src/ida/IdaSessionClient.test.ts` — new "attached IDA legacy string inventory" case (fake-paginated upstream, 250 strings), asserting call counts, `count: 0`, and concrete address/value pairs at the head and tail of results. - Base reproduction or other evidence: temporary repro harness with N=2500 fake-paginated upstream, run against the upstream base revision and against this change: `list_strings` calls 25 (all `count: 100`) → 1 (`count: 0`); literal `search_strings` total calls 50 → 2. Result length identical (1111) both ways. A second harness with 200,000 strings confirmed no `RangeError` from the append path. - User-visible CLI/MCP output: none changed; output shape is identical. For evidence-bearing changes: - [x] Observed, derived, and inferred claims remain distinguishable. - [x] Artifact identity, source provenance, and failed attempts remain preserved. - [x] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed - `npx vitest run src/ida/IdaSessionClient.test.ts -t "single upstream calls"` — 1 passed. - Repro harness (temporary, N=2500): base 25/50 calls → fixed 1/2 calls, same results. - Large-inventory harness (temporary, N=200000): no `RangeError`, full result returned. - `npx tsc --noEmit` — passes (0 errors) at the verification baseline. - `npx oxlint src/ida/IdaOperationRunner.ts src/ida/IdaSessionClient.test.ts` — 0 errors. - `npx oxfmt --check` on the changed files — passes. ## Compatibility, safety, and release - Breaking changes or migration steps: none. No call or configuration becomes invalid; `count: 0` was already valid upstream input. - Real Hopper/Ghidra, browser, or OS coverage: not applicable (IDA legacy path only). - Package or release metadata impact: none. - Security, privacy, process, or containment review: none; no new target interaction. ## Before merge - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved; maintainer scope decision covers the final diff (declared not applicable). - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked (Fixes #2786). - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed (none needed; no contract text changed). - [x] User-visible CLI/MCP changes include representative output (no output shape change). - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:06:51 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:44:42 +00:00

[PR #5651] [MERGED] fix(javascript): preserve path reasons, module coverage, and property provenance #7014

No Branch/Tag specified

main

codex/procedure-reference-stacked

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels

Mirrored from GitHub Pull Request

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5464

Reference in a new issue

Repository

morluto/rea

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns