mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #5651] [MERGED] fix(javascript): preserve path reasons, module coverage, and property provenance #7014
Closed
opened 2026-11-01 21:44:42 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#7014
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/5651
Author: @morluto
Created: 10/20/2026
Status: ✅ Merged
Merged: 10/20/2026
Merged by: @morluto
Base:
main← Head:cursor/js-analysis-evidence-2cbb📝 Commits (9)
dc7adddfix(javascript): preserve selected path host resolution reasons6c66ffbfix(javascript): count summary coverage in module unitsc7170bdfix(javascript): connect direct property reads to return and argument flow36a8eb3fix(javascript): count return wrappers against expression depthe77f8a8fix(javascript): describe ELOOP as unresolved symlink traversalffba34atest(javascript): skip symlink traversal fixtures on Windowsefb47d4fix(javascript): describe ENAMETOOLONG as a path or component limit568f7afstyle(javascript): format return-depth and object-read changes2265265test(ida): expect unchanged invalid requests to be nonretryable📊 Changes
13 files changed (+319 additions, -10 deletions)
View changed files
📝
src/application/javascript/JavaScriptArtifactReconstruction.ts(+19 -2)📝
src/application/javascript/JavaScriptSemanticGraphBuilder.test.ts(+50 -0)📝
src/application/javascript/JavaScriptSemanticGraphBuilder.ts(+10 -0)📝
src/application/javascript/JavaScriptSemanticGraphFlowProjection.ts(+61 -0)📝
src/domain/analysisView/analysisView.test.ts(+48 -0)📝
src/domain/analysisView/javascriptApplicationView.ts(+3 -1)📝
src/domain/javascript/javascriptSemanticAnalysis.unions.test.ts(+31 -0)📝
src/domain/javascript/javascriptSemanticCalls.ts(+9 -1)📝
src/domain/javascript/javascriptSemanticIr.ts(+7 -0)📝
src/domain/javascript/javascriptSemanticReturns.ts(+7 -2)📝
src/ida/IdaOperationFailures.test.ts(+4 -3)📝
src/javascript/analysis/JavaScriptAnalysisWorkerSchemas.ts(+1 -0)📝
tests/boundary/filesystem/javascriptApplicationInputSelection.test.ts(+69 -1)📄 Description
Summary
JavaScript application analysis dropped selected-path host reasons, mixed module and graph-node counts in summary coverage, and lost a directly returned or passed property in backward provenance.
Fixes #5623, #5585, #5464, #5648.
#5469, #5466, and #5377 were rechecked on current
mainand already have producing-boundary fixes there (a4dbb36d8,2b2e362a0, and the call resolver's definite-initializer gate). This diff does not change them. Their issues stay open.Problem and expected behavior
resolveSelectedInputclassifiedENOENTandENOTDIRas invalid input andEACCES/EPERMas access denied.ELOOPandENAMETOOLONGfell through to a later filesystem catch and becameArtifactOperationErrorreasoniowith no selected path. Both are caller/host-resolution failures and should stayinvalid_requestwithinput_pathand the host code.ELOOPcovers a cycle and a chain past the host traversal limit, so the message must not assert that a cycle exists.ENAMETOOLONGcovers a long component and a long full path, so the message must not claim only a filename was too long.Summary coverage used
completeCoverage(moduleCount, graph.nodes.length). Examined and total must be the same module population. Non-module nodes stay insummary.coverage.application.return settings.indexandtake(settings.index)already evaluated the literal, but graph projection only aliased identifier references inside the return or argument range. The member read is a separate occurrence owned by object projection. Backward provenance must reach that literal.return settings.index + "!"must not gain a"products"edge. Query status may stay ambiguous because the receiver identifier remains a candidate alias.Erased TypeScript and Flow wrappers still count toward the expression-depth budget. Unwrapping a return before evaluation restarted that budget at zero.
Change and scope
Host path classification happens in
resolveSelectedInput, next to the existing missing-path and permission cases. Later uncategorized filesystem IO during analysis still uses the serviceioreason. TheELOOPmessage names a loop or a traversal past the host limit. TheENAMETOOLONGmessage names a host path or component length limit.Summary coverage counts modules for both examined and total. An empty module set stays
complete-within-viewat 0/0.Return sites and call arguments record the unwrapped value expression. Return and argument flow alias the object-read occurrence at that range. Evaluation still receives the original return expression, so wrapper depth stays inside the existing budget. The occurrence lookup is owned by the object projection and indexed once per IR and graph state. Parentheses and arrow expression bodies use the same unwrapped range. Concatenation and other wider expressions do not match the member-read range.
The IDA procedure-lookup test now expects
invalid_requestto be non-retryable, matching the projector change already on this branch's base. No IDA behavior change.Follow the contribution scope.
Ordinary evidence and diagnostic fixes inside existing JavaScript analysis boundaries. No new provider, target execution, injection, mutation, or protection recovery. Maintainer scope decision: not applicable.
Contract and boundary impact
JavaScriptArtifactReconstruction; summary projection inprojectJavaScriptApplicationView; value-expression ranges on the semantic IR, consumed by return and argument graph flow. Expression-depth accounting stays inevaluateSemanticExpression.invalid_requestreplaces a path-lessiofailure forELOOPandENAMETOOLONG. Summarycoverage.examinedandcoverage.totalare both module counts. Backward provenance can include the literal behind a direct property read or argument. Worker callable return sites gainvalueExpressionLocation.realpathdoes not reportELOOPfor these cases. The overlong-name case still runs there.aliasesedge from that occurrence to the return or argument node. Concatenated returns do not inherit the property literal. A return past the wrapper-depth budget staysexpression-depthunknown.docs/public/product-catalog.json), package, or installation impact (CI generates and validates ignored catalogs andskills/; edit authored instructions in.agents/skills/reverse-engineer-anything/and never commit build outputs): none.Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.
Evidence and regression coverage
ENAMETOOLONGon every platform; a two-link cycle and a 60-link acyclic chain skipped on Windows; JavaScript summary coverage with one extra non-module node; backward provenance for a local copy, a direct return, parentheses, an arrow expression body, direct and parenthesized arguments, an identifier argument, and a concatenated return that must not reach"products"; a return wrapped in 300asexpressions staysexpression-depthunknown and keeps the inner literal range. The IDA missing-procedure cases now expectretryable: false.viaMember, parenthesized member returns, arrow expression bodies, and direct member arguments did not reach the"products"literal with candidates on or off. The return-site value was already the literal. Source-map mapping tests and the nestedvarcallback test still pass.invalid_requestissue, including the selected path.inspect-artifactalready retained these host reasons and was not changed.iofailure. #5302 was not verified.soleWriteReachesReadstill treats a stable initializer as a reaching write and was not confirmed as a user-visible bug. WindowsELOOPbehavior was not executed here. A full path atPATH_MAXwas not executed; the message covers that host code without a separate fixture. The Electron IPC CLI failure wasspawn E2BIGand was not reproduced locally.For evidence-bearing changes:
Validation performed
On
226526532, before this push:npx oxfmt --checkon the flow projection, the unions test, and the IDA failure test — formatted.npm run check:fast— typecheck and lint, 2 successful, 24.923s.npm run test:local -- src/ida/IdaOperationFailures.test.ts src/domain/javascript/javascriptSemanticAnalysis.unions.test.ts— 2 files, 61 tests passed.CI on
efb47d44bfailedoxfmtfor the unions test and object-read projection, and eight IDA lookup cases still expectedinvalid_requestto be retryable. That retryable bit was removed on the base commit. The Electron IPC CLI shard failed withspawn E2BIGbefore an assertion.On
efb47d44b:npm run check:fastpassed and the input-selection boundary file passed with 7 tests. One77f8a8f7: unions source tests, 28 passed, including the 300-wrapper return. Onc7170bd06: graph, analysis view, worker schema, and call-resolution source tests were 135 passed, and source-map mapping boundary tests were 6 passed.Not run:
npm run check:pr, public CLI/MCP replay, Windows, aPATH_MAXfixture, or a Flameox profile.Compatibility, safety, and release
ELOOPorENAMETOOLONGas artifactio, or that compared summary examined/total against all graph nodes, will seeinvalid_requestand module-unit coverage. Worker consumers of callable return sites must acceptvalueExpressionLocation.Author readiness
Human owner: @morluto
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.