mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #6392] fix(ghidra): thin the selected universal Mach-O slice into the private import #7332
Open
opened 2026-11-01 21:47:07 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#7332
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/6392
Author: @cpruijsen
Created: 10/22/2026
Status: 🔄 Open
Base:
main← Head:fix/ghidra-thin-universal-slice📝 Commits (4)
719823ffix(ghidra): thin the selected universal Mach-O slice into the private import2bf9696fix(ghidra): report universal-file offsets for a thinned slice6d1ce95Merge branch 'main' into fix/ghidra-thin-universal-slice124f354test(ghidra): thin a slice spanning several 64 KiB read chunks📊 Changes
9 files changed (+336 additions, -28 deletions)
View changed files
📝
bridge/ghidra/ReaGhidraBridge.java(+27 -4)📝
src/ghidra/GhidraClient.ts(+13 -2)📝
src/ghidra/GhidraClientTypes.ts(+3 -0)📝
src/ghidra/GhidraLauncher.ts(+5 -0)📝
src/ghidra/GhidraProvider.behavior.test.ts(+22 -15)📝
src/ghidra/GhidraProvider.ts(+6 -2)📝
src/ghidra/GhidraProviderClient.ts(+8 -0)📝
src/ghidra/GhidraTargetSnapshot.ts(+41 -5)➕
src/ghidra/GhidraTargetSnapshotThinning.test.ts(+211 -0)📄 Description
Summary
The Ghidra provider refused every universal (FAT) Mach-O since
6582b2433, with "analyze a thinned Mach-O slice instead". REA offers no tool that thins a slice, so there was no way to get Ghidra analysis of a typical macOS app through REA. Most macOS apps ship as universal binaries.This change makes Ghidra import only the selected slice, with the approach #2201 merged for IDA: the private, per-session copy that Ghidra already imports now holds just the admitted slice. Evidence still names the original universal file and its digest, and every file offset in Ghidra results and
file-offset:selectors is an offset in that universal file.No issue is linked. I hit the refusal analyzing a universal macOS app (Elgato Control Center,
x86_64 arm64) through REA with Ghidra 12.1.4.Problem and expected behavior
rea search "<universal Mach-O>" elgato --provider ghidrafails with "Ghidra v1 cannot enforce the selected architecture when importing a universal Mach-O; analyze a thinned Mach-O slice instead."BinaryTarget.universalSlice), as the IDA provider does, and its file coordinates refer to the same universal file that Evidence names.Change and scope
GhidraTargetSnapshot.ts: the existing private copy step copies only[slice.offset, slice.offset + slice.size)for universal targets. The whole-file digest is still checked against the admitted target, and the copy fails closed if the source changed or the slice leaves the file.GhidraClient.ts,GhidraClientTypes.ts: the bridge handshake expects the digest of the slice that Ghidra imports.GhidraProvider.ts: universal targets with an admitted slice are accepted. A universal target whose selected architecture is not one of its slices, and a non-universal Mach-O that declares more than one architecture, are still refused.GhidraLauncher.ts,bridge/ghidra/ReaGhidraBridge.java: the session descriptor carries the slice's universal-file offset (target_file_offset_base, optional, validated, absent for every other target). The bridge adds it to every target file offset it reports (address_to_file_offset, byte-search matches, decompile selections) and subtracts it fromfile-offset:selectors before it maps them, so an offset outside the slice does not resolve.GhidraProviderClient.ts: a session limitation for universal targets that names the imported slice, its offset and size, and the coordinate rule.What I chose and the alternative (from baron's review): I normalized the coordinates once, in the bridge, which is where Ghidra's
FileBytescoordinates become REA JSON. The other option was to make the slice its own Evidence subject with a container relation. I did not take it because REA already reports universal-file offsets for universal targets elsewhere (for exampleMachoSliceSelection.ts), so one subject with one coordinate system keeps Evidence uniform.inspect_native_load_imagemappings stay raw: eachfile_offsetthere is relative to the source file named bysource_file_index, and that entry carries the slice digest, so the raw provider fact and its identity stay together.Not included: choosing a slice other than the one admission selects (it follows the host CPU, as for IDA), and the startup deadline default.
Follow the contribution scope.
Unresolved scope, authority, side effects, or required verification block
integration. Link the required maintainer scope decision for new providers or
capabilities involving target execution, injection, mutation, or protection
recovery; ordinary fixes within existing boundaries may state "not applicable".
Draft PRs may leave the scope decision pending and the readiness and merge checklists
unchecked. Maintainers can help resolve open questions.
Scope decision: not applicable. This is an ordinary fix inside the existing Ghidra provider boundary.
Contract and boundary impact
6582b2433).--provider ghidrainstead of failing. No tool catalog changes.file-offset:selectors are universal-file offsets. Native load-image mappings stay relative to the source file they name.docs/public/product-catalog.json), package, or installation impact (CI generates and validates ignored catalogs andskills/; edit authored instructions in.agents/skills/reverse-engineer-anything/and never commit build outputs): none.Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.
Evidence and regression coverage
Tests added or updated:
src/ghidra/GhidraTargetSnapshotThinning.test.ts(new): the private copy equals the selected slice for universal fixtures, the launch session carries the slice offset astargetFileOffsetBase, and a changed source or an out-of-range slice fails closed.GhidraProvider.behavior.test.ts: the old refusal test now checks that universal targets with an admitted slice are accepted and that the remaining ambiguous cases are refused. The existing snapshot boundary suite (tests/boundary/providers/ghidra/ghidraTargetSnapshot.test.ts) covers the unchanged non-universal copy.Base reproduction or other evidence: with every source change reverted to
main, 6 of the 172 tests in the two changed test files fail. With the change, 172 of 172 pass.Real Ghidra 12.1.4 (macOS arm64, JDK 21), coordinate round trip on a small universal binary (
clang -arch x86_64 -arch arm64; x86_64 slice at 4096, arm64 slice at 16384, size 33456). The marker string is at universal offset 17576, and_marker_fn(0x100000460) at universal offset 17504:e13f16a2f)address-to-file-offset <bin> 0x1000004a8file_offset1192 (slice-local)file_offset17576address-to-file-offset <bin> 0x100000460file_offset1120 (slice-local)file_offset17504decompile <bin> --file-offset 0x44600x100004460, no procedure there_marker_fn, locationfile-offset17504decompile <bin> --file-offset 0x460(inside the x86_64 region)_marker_fnnot_found: "File offset 0x460 has no loaded source mapping for the admitted target file"Real Ghidra 12.1.4 on the universal Elgato Control Center binary: base gives the refusal above. With the thinning, Ghidra imported the private arm64 slice (
AARCH64:LE:64:AppleSilicon:swift), andsearch ... elgato --provider ghidrareturned 331 matches, for examplehttps://lspro.elgato.comat0x10065b7e0. The private copy was byte-identical tolipo -thin arm64. The app's digest in the Evidence equals the digest measured before the run.User-visible CLI/MCP output (if applicable):
address-to-file-offseton the arm64 slice of the test binary above (normalized_result). Session limitation: "Ghidra imported only the arm64 slice of this universal Mach-O, copied from container offset 16384 (33456 bytes). File offsets in results and file-offset selectors are universal-file offsets; native load-image mappings stay relative to the imported slice source file."Remaining proof gaps: Ghidra's own analysis of the 9.7 MB Elgato slice took 373 s, above the 330 s default startup deadline, so that run used
REA_GHIDRA_STARTUP_TIMEOUT_MS=1800000. One earlier run died in a JVM SIGBUS inside Ghidra's analyzer (SymbolicPropogator.getInstructionAt) before the REA bridge started, so it is upstream of this change.For evidence-bearing changes:
Validation performed
main: 6 failed.src/ghidra/*.test.ts,tests/boundary/providers/ghidra/*.test.ts,tests/boundary/filesystem/ghidra*.test.ts): 48 files, 1143 passed, 3 skipped.npm run check:fast: passed.npm run verify:test-discovery: passed (2341 files).npm run docs:check: passed.mainat4a041ae75, macOS arm64, Node 26.Compatibility, safety, and release
Author readiness
Human owner: @cpruijsen
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.