[PR #90] [MERGED] fix(examples): say which compiler is missing instead of call "" #114

New issue

Closed

opened 2026-10-15 20:53:30 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 20:53:30 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rehan-remade/universal-modder/pull/90
Author: @rehan-remade
Created: 10/5/2026
Status: ✅ Merged
Merged: 10/5/2026
Merged by: @rehan-remade

Base: main ← Head: fix/gta-build-vcvars

📝 Commits (1)

ad4462b fix(examples): say which compiler is missing instead of call ""

📊 Changes

2 files changed (+2 additions, -0 deletions)

View changed files

📝 examples/minecraft-gta5-passthrough/gta/build.bat (+1 -0)
📝 examples/minecraft-gta5-passthrough/gta/tests/build_fakegta.bat (+1 -0)

📄 Description

What: a clear error for #88.

Without Visual Studio's C++ x64 tools, vswhere finds nothing, VCVARS stays empty, and build.bat ran call "". cmd reports that as '""' is not recognized as an internal or external command. Both gta/build.bat and gta/tests/build_fakegta.bat now stop with:

No Visual Studio with the C++ x64 tools was found. Install "Desktop development with C++" (Visual Studio 2022 or its Build Tools), or set VCVARS to your vcvars64.bat

Tested in Windows cmd.exe: a missing VCVARS path and an empty one both print the message and exit 1, and a real file passes through. The line endings stay CRLF.

Checklist

uv run --with pytest pytest -q tests passes; um kb check --index and um publish check . pass
authored by: Claude Code (Opus 5.5) with @rehan-remade

Closes #88

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rehan-remade/universal-modder/pull/90 **Author:** [@rehan-remade](https://github.com/rehan-remade) **Created:** 10/5/2026 **Status:** ✅ Merged **Merged:** 10/5/2026 **Merged by:** [@rehan-remade](https://github.com/rehan-remade) **Base:** `main` ← **Head:** `fix/gta-build-vcvars` --- ### 📝 Commits (1) - [`ad4462b`](https://github.com/rehan-remade/universal-modder/commit/ad4462b3f0ced6b61809a6b10deb9b0b2a4ba158) fix(examples): say which compiler is missing instead of call "" ### 📊 Changes **2 files changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `examples/minecraft-gta5-passthrough/gta/build.bat` (+1 -0) 📝 `examples/minecraft-gta5-passthrough/gta/tests/build_fakegta.bat` (+1 -0) </details> ### 📄 Description **What:** a clear error for #88. Without Visual Studio's C++ x64 tools, `vswhere` finds nothing, `VCVARS` stays empty, and `build.bat` ran `call ""`. cmd reports that as `'""' is not recognized as an internal or external command`. Both `gta/build.bat` and `gta/tests/build_fakegta.bat` now stop with: > No Visual Studio with the C++ x64 tools was found. Install "Desktop development with C++" (Visual Studio 2022 or its Build Tools), or set VCVARS to your vcvars64.bat **Tested** in Windows `cmd.exe`: a missing `VCVARS` path and an empty one both print the message and exit 1, and a real file passes through. The line endings stay CRLF. **Checklist** - [x] `uv run --with pytest pytest -q tests` passes; `um kb check --index` and `um publish check .` pass - [x] authored by: Claude Code (Opus 5.5) with @rehan-remade Closes #88 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 20:53:30 +00:00